Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Rename to "Operation" from "ComputeOperation" #3179

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Jun 4, 2018

Cleaning up a set of names that were copy-and-pasted from the Compute package. Not the end of the world, but it would be great if this could be merged before this new API is published in the Python SDK.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 4, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2186

@AutorestCI
Copy link

AutorestCI commented Jun 4, 2018

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#174

@AutorestCI
Copy link

AutorestCI commented Jun 4, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2848

@AutorestCI
Copy link

AutorestCI commented Jun 4, 2018

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpwiau93kn/rest/specification/containerservices/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpwiau93kn/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.100', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.100->2.1.100)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-09"} .
FATAL: swagger-document/compose - FAILED
FATAL: Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
).
Process() cancelled due to exception : '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
).
Failure during batch task - {"tag":"package-2017-09"} -- Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
)..
  Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
).

@AutorestCI
Copy link

AutorestCI commented Jun 4, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@mboersma mboersma changed the title Rename to "Operation" from "ComputeOperation" [AKS] Rename to "Operation" from "ComputeOperation" Jun 4, 2018
"properties": {
"value": {
"type": "array",
"readOnly": true,
"items": {
"$ref": "#/definitions/ComputeOperationValue"
"$ref": "#/definitions/OperationValue"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please acknowledge that this could be a breaking change to the generated sdk.

Copy link
Member Author

@mboersma mboersma Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change isn't backward-compatible. If we think that's problematic, this isn't crucial to merge.

But I don't think the 4.0.0 ACS SDK in #3131 has merged any of the generated PRs yet, so I'm hoping we can sneak this fix in without breaking anything.

@dsgouda dsgouda merged commit 5929767 into Azure:master Jun 4, 2018
@sarangan12 sarangan12 removed the review label Jun 4, 2018
@mboersma mboersma deleted the rename-aks-operations-classes branch June 4, 2018 18:33
sjiherzig added a commit that referenced this pull request Dec 28, 2021
* Add SDK Generation Options for new API Version (#3179)

* Add SDK generation for 2021-06-30-preview

* The following fixes were done:
 * Fixed schema location: preview instead of stable
 * Updated go SDK generation to point to preview namespace

* Remove Ruby support

* add SystemData and update instance and endpoints definitions

* added systemdata to all examples

* fix typo

* fix prettier issues

* added experimental operations fix

* fixed some errors

* addressed lint and model errors

* fixed type issues with endpoints examples

* Fixed autorest error

* removed unnecessary _allOf_s

* Add Time Series Database Connection Resource and CRUD API Endpoints (#3180)

* Added basic time series integration resource CRUD and resource description

* Add list call for TSDB integration resources

* Modify naming for adx endpoint

* Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations)

* Update operation names

* Resolve review comments

* Add examples for time series database connection CRUD

* Add example for missing status code 200 to DELETE

* Run prettier and fix formatting issues

* Align tags, solve issue in Python SDK generation

* Align python readme

* Fix linter error

* Fix linter error 2

* Fix linter error

* Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (#3358)

* Address major lintdiff warnings

* Fix more linter warnings

* Address remaining lintdiff warnings and errors

* Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location

* Address lintdiff error

* Add systemData property to private endpoint connection resource

* Address breaking change warnings

* Fix inheritance

* Update suppressions to point to new locations in document

* Updated TSDB connection parameter set

* Fix issue in property set

* Revert readOnly=true from private endpoint connections property

* Revert change to TopicEndpoint

* Back to camelcase...

* Revert change in old API version

* Revert TopicEndpoint back to camelCase

* Revert allOf addition

* Change capitalization of TopicEndpoint back to original from previous version

* Add approved suppression

* Fix $.definitions path in suppression rules

Co-authored-by: Nate Lehman <nalehman@microsoft.com>
Co-authored-by: Nate Lehman <njlehman1@gmail.com>
akning-ms pushed a commit that referenced this pull request Feb 1, 2022
…italTwins-2021-06-30-preview-merge-with-main' (#17186)

* Adds base for updating Microsoft.DigitalTwins from version stable/2020-12-01 to version 2021-06-30-preview

* Updates readme

* Updates API version in new specs and examples

* Add RM API Version Microsoft.DigitalTwins 2021-06-30-preview (#3404)

* Add SDK Generation Options for new API Version (#3179)

* Add SDK generation for 2021-06-30-preview

* The following fixes were done:
 * Fixed schema location: preview instead of stable
 * Updated go SDK generation to point to preview namespace

* Remove Ruby support

* add SystemData and update instance and endpoints definitions

* added systemdata to all examples

* fix typo

* fix prettier issues

* added experimental operations fix

* fixed some errors

* addressed lint and model errors

* fixed type issues with endpoints examples

* Fixed autorest error

* removed unnecessary _allOf_s

* Add Time Series Database Connection Resource and CRUD API Endpoints (#3180)

* Added basic time series integration resource CRUD and resource description

* Add list call for TSDB integration resources

* Modify naming for adx endpoint

* Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations)

* Update operation names

* Resolve review comments

* Add examples for time series database connection CRUD

* Add example for missing status code 200 to DELETE

* Run prettier and fix formatting issues

* Align tags, solve issue in Python SDK generation

* Align python readme

* Fix linter error

* Fix linter error 2

* Fix linter error

* Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (#3358)

* Address major lintdiff warnings

* Fix more linter warnings

* Address remaining lintdiff warnings and errors

* Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location

* Address lintdiff error

* Add systemData property to private endpoint connection resource

* Address breaking change warnings

* Fix inheritance

* Update suppressions to point to new locations in document

* Updated TSDB connection parameter set

* Fix issue in property set

* Revert readOnly=true from private endpoint connections property

* Revert change to TopicEndpoint

* Back to camelcase...

* Revert change in old API version

* Revert TopicEndpoint back to camelCase

* Revert allOf addition

* Change capitalization of TopicEndpoint back to original from previous version

* Add approved suppression

* Fix $.definitions path in suppression rules

Co-authored-by: Nate Lehman <nalehman@microsoft.com>
Co-authored-by: Nate Lehman <njlehman1@gmail.com>

* Align with repo (#5658)

Co-authored-by: Nate Lehman <nalehman@microsoft.com>
Co-authored-by: Nate Lehman <njlehman1@gmail.com>
mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
…italTwins-2021-06-30-preview-merge-with-main' (Azure#17186)

* Adds base for updating Microsoft.DigitalTwins from version stable/2020-12-01 to version 2021-06-30-preview

* Updates readme

* Updates API version in new specs and examples

* Add RM API Version Microsoft.DigitalTwins 2021-06-30-preview (Azure#3404)

* Add SDK Generation Options for new API Version (Azure#3179)

* Add SDK generation for 2021-06-30-preview

* The following fixes were done:
 * Fixed schema location: preview instead of stable
 * Updated go SDK generation to point to preview namespace

* Remove Ruby support

* add SystemData and update instance and endpoints definitions

* added systemdata to all examples

* fix typo

* fix prettier issues

* added experimental operations fix

* fixed some errors

* addressed lint and model errors

* fixed type issues with endpoints examples

* Fixed autorest error

* removed unnecessary _allOf_s

* Add Time Series Database Connection Resource and CRUD API Endpoints (Azure#3180)

* Added basic time series integration resource CRUD and resource description

* Add list call for TSDB integration resources

* Modify naming for adx endpoint

* Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations)

* Update operation names

* Resolve review comments

* Add examples for time series database connection CRUD

* Add example for missing status code 200 to DELETE

* Run prettier and fix formatting issues

* Align tags, solve issue in Python SDK generation

* Align python readme

* Fix linter error

* Fix linter error 2

* Fix linter error

* Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (Azure#3358)

* Address major lintdiff warnings

* Fix more linter warnings

* Address remaining lintdiff warnings and errors

* Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location

* Address lintdiff error

* Add systemData property to private endpoint connection resource

* Address breaking change warnings

* Fix inheritance

* Update suppressions to point to new locations in document

* Updated TSDB connection parameter set

* Fix issue in property set

* Revert readOnly=true from private endpoint connections property

* Revert change to TopicEndpoint

* Back to camelcase...

* Revert change in old API version

* Revert TopicEndpoint back to camelCase

* Revert allOf addition

* Change capitalization of TopicEndpoint back to original from previous version

* Add approved suppression

* Fix $.definitions path in suppression rules

Co-authored-by: Nate Lehman <nalehman@microsoft.com>
Co-authored-by: Nate Lehman <njlehman1@gmail.com>

* Align with repo (Azure#5658)

Co-authored-by: Nate Lehman <nalehman@microsoft.com>
Co-authored-by: Nate Lehman <njlehman1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants