Adding June Swagger Update - Azure Container Instance #3170

samkreter · 2018-05-31T23:06:20Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-05-31T23:08:06Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2618

AutorestCI · 2018-05-31T23:08:35Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#37

AutorestCI · 2018-05-31T23:11:55Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1353

AutorestCI · 2018-05-31T23:32:22Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2320

AutorestCI · 2018-06-01T00:19:44Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1990

lmazuel · 2018-06-01T17:21:39Z

Hi @samkreter !
Please update the Readme to add a new tag and change "Basic Information" to point to this new tag. Then the bot generation will be meaningfull. Thanks!

marstr

Mind updating the Golang config in the README as well? https://github.com/Azure/azure-rest-api-specs/pull/3170/files#diff-5c3d140eca9525738ed2ab683fb322afR155

…rest-api-specs into sakreter-JuneAPISwagger

marstr

Now we're just waiting for @ravbhatnagar

marstr · 2018-06-05T23:05:38Z

...stance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json

+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerInstance/containerGroups/{containerGroupName}/containers/{containerName}/logs": {
+      "get": {
+        "operationId": "ContainerLogs_List",


There are some semantics that we introduce to OperationIDs in AutoRest. Chiefly, we use the prefix here to denote an "operation group". For some languages, each operation group gets is own Client type.

For that reason, I'd recommend having fewer Operation Groups:

ContainerGroupUsage_List -> ContainerGroups_ListUsage
ContainerLogs_List -> Container_ListLogs
StartContainer_LaunchExec -> Container_StartExecLaunch

I took another look and found another thing we may want to tweak, not necessary to fix it though! Just acknowledge if you don't want to fix it. :)

@marstr I would rather save those for the next PR so we can get this June release out. I can update those changes quickly for another PR.

It'd be a breaking change in the future, so we should do it now or never. Your choice though. :)

marstr

~~When comparing the two API Versions against one another, this is actually a relatively small change. Nothing troublesome jumped out to me.~~

edit: wrong window, though the approval counts.

sakreter added 2 commits May 31, 2018 14:54

Adding June API

aadc8b1

updating api version

dd1d82c

sarangan12 added the review label May 31, 2018

azuresdkci assigned marstr May 31, 2018

azuresdkci requested a review from marstr May 31, 2018 23:07

AutorestCI mentioned this pull request May 31, 2018

[AutoPR containerinstance/resource-manager] Adding June Swagger Update - Azure Container Instance Azure/azure-sdk-for-node#2934

Merged

AutorestCI mentioned this pull request May 31, 2018

[AutoPR containerinstance/resource-manager] Adding June Swagger Update - Azure Container Instance AutorestCI/azure-libraries-for-java#219

Merged

AutorestCI mentioned this pull request May 31, 2018

[AutoPR containerinstance/resource-manager] Adding June Swagger Update - Azure Container Instance Azure/azure-sdk-for-ruby#1341

Merged

AutorestCI mentioned this pull request May 31, 2018

[AutoPR containerinstance/resource-manager] Adding June Swagger Update - Azure Container Instance Azure/azure-sdk-for-python#2676

Merged

samkreter and others added 2 commits June 1, 2018 11:53

updating basic information to point at correct tag

2988a6e

updating api version in the examples

cdf838f

marstr requested a review from ravbhatnagar June 4, 2018 20:36

marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 4, 2018

marstr requested changes Jun 4, 2018

View reviewed changes

samkreter added 2 commits June 5, 2018 10:56

updating GO tags in README

6b36cf8

Merge branch 'sakreter-JuneAPISwagger' of github.com:samkreter/azure-…

de5b92a

…rest-api-specs into sakreter-JuneAPISwagger

AutorestCI mentioned this pull request Jun 5, 2018

[AutoPR containerinstance/resource-manager] Adding June Swagger Update - Azure Container Instance Azure/azure-sdk-for-go#1967

Merged

marstr approved these changes Jun 5, 2018

View reviewed changes

marstr requested changes Jun 5, 2018

View reviewed changes

marstr approved these changes Jun 5, 2018

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 6, 2018

marstr merged commit 709ef95 into Azure:master Jun 7, 2018

bsiegel removed the review label Jun 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding June Swagger Update - Azure Container Instance #3170

Adding June Swagger Update - Azure Container Instance #3170

samkreter commented May 31, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 31, 2018 •

edited

Loading

AutorestCI commented May 31, 2018 •

edited

Loading

AutorestCI commented May 31, 2018 •

edited

Loading

AutorestCI commented May 31, 2018 •

edited

Loading

AutorestCI commented Jun 1, 2018 •

edited

Loading

lmazuel commented Jun 1, 2018

marstr left a comment

marstr left a comment

marstr Jun 5, 2018

marstr Jun 5, 2018

samkreter Jun 5, 2018

marstr Jun 5, 2018

marstr left a comment •

edited

Loading

Adding June Swagger Update - Azure Container Instance #3170

Adding June Swagger Update - Azure Container Instance #3170

Conversation

samkreter commented May 31, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented May 31, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 31, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented May 31, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented May 31, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 1, 2018 • edited Loading

Automation for azure-sdk-for-go

lmazuel commented Jun 1, 2018

marstr left a comment

Choose a reason for hiding this comment

marstr left a comment

Choose a reason for hiding this comment

marstr Jun 5, 2018

Choose a reason for hiding this comment

marstr Jun 5, 2018

Choose a reason for hiding this comment

samkreter Jun 5, 2018

Choose a reason for hiding this comment

marstr Jun 5, 2018

Choose a reason for hiding this comment

marstr left a comment • edited Loading

Choose a reason for hiding this comment

samkreter commented May 31, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 31, 2018 •

edited

Loading

AutorestCI commented May 31, 2018 •

edited

Loading

AutorestCI commented May 31, 2018 •

edited

Loading

AutorestCI commented May 31, 2018 •

edited

Loading

AutorestCI commented Jun 1, 2018 •

edited

Loading

marstr left a comment •

edited

Loading