Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the swagger file for the new service Gallery. #3080

Merged
merged 33 commits into from
May 23, 2018
Merged

Added the swagger file for the new service Gallery. #3080

merged 33 commits into from
May 23, 2018

Conversation

vanbasten2323
Copy link
Contributor

@vanbasten2323 vanbasten2323 commented May 15, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • [y] The title of the PR is clear and informative.
  • [y] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • [y] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • [y] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from lmazuel May 15, 2018 21:36
@AutorestCI AutorestCI mentioned this pull request May 15, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 15, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2710

@AutorestCI AutorestCI mentioned this pull request May 15, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 15, 2018 •
edited
Loading

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#2

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️10 new Warnings.(64 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'images' with immediate parent 'Gallery', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'versions' with immediate parent 'GalleryImage', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'extensions' with immediate parent 'VirtualMachine', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'extensions' with immediate parent 'VirtualMachineScaleSet', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'virtualmachines' with immediate parent 'VirtualMachineScaleSet', must have a list by immediate parent operation.
TrackedResourceListByResourceGroup R3027 Link The tracked resource, 'Gallery', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
TrackedResourceListByResourceGroup R3027 Link The tracked resource, 'GalleryImage', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
TrackedResourceListBySubscription R3028 Link The tracked resource, 'Gallery', must have a list by subscriptions operation.
TrackedResourceListBySubscription R3028 Link The tracked resource, 'GalleryImage', must have a list by subscriptions operation.
EnumInsteadOfBoolean R3018 Link Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: excludeFromLatest
❌4 new Errors.(15 total)
Code Id Source Message
XmsExamplesRequired D5001 Link Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
RequiredPropertiesMissingInResourceModel R2020 Link Model definition 'GalleryImageVersion' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
TrackedResourcePatchOperation R3026 Link Tracked resource 'Gallery' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.
TrackedResourcePatchOperation R3026 Link Tracked resource 'GalleryImage' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️52 new Warnings.(123 total)
Code Id Source Message
PageableOperation R2029 Link Based on the response model schema, operation 'Gallery_ListGalleriesInResourceGroup' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'Gallery_ListGalleriesInSubscription' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'GalleryImage_ListGalleryImagesInGallery' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'GalleryImageVersion_ListGalleryImageVersionsInGalleryImage' might be pageable. Consider adding the x-ms-pageable extension.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'GalleryImageVersion_Delete' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'GalleryImage' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'GalleryImageVersion' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
DescriptionAndTitleMissing R4000 Link 'GalleryIdentifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'VirtualMachineImageResource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'VirtualMachineImageResource'
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'identifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'identifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recommended' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'disallowed' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'purchasePlan' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'vCPUs' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'memory' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'publishingProfile' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'storageProfile' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'replicationStatus' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'managedImage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'osDiskImage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
❌1 new Errors.(1 total)
Code Id Source Message
XmsParameterLocation R4001 Link The parameter 'resourceGroupName' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension "x-ms-parameter-location": "client". Else, apply the extension "x-ms-parameter-location": "method".

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI AutorestCI mentioned this pull request May 15, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 15, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2487

@AutorestCI AutorestCI mentioned this pull request May 15, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 15, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1853

@vanbasten2323
Copy link
Contributor Author

vanbasten2323 commented May 15, 2018 •
edited
Loading

Hi @lmazuel I saw some errors and warnings during the swagger validation. Which one should I fix?

lmazuel
lmazuel requested changes May 15, 2018
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

specification/compute/resource-manager/Microsoft.Compute/preview/2018-06-01/gallery.json Outdated
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add:

"x-ms-parameter-location": "method"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added.

@lmazuel lmazuel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 15, 2018
lmazuel
lmazuel reviewed May 15, 2018
View reviewed changes
specification/compute/resource-manager/readme.md Outdated
@@ -151,6 +151,21 @@ directive:
- TrackedResourceGetOperation

```

### Tag: package-2018-06
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a package-gallery-2018-06 with only gallery. Tag with consistent ApiVersion are required for Go, Python and Ruby

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I modified it correctly. Would you mind taking a look?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did it correctly, thanks :)

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️12 new Warnings.(66 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'images' with immediate parent 'Gallery', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'versions' with immediate parent 'GalleryImage', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'extensions' with immediate parent 'VirtualMachine', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'extensions' with immediate parent 'VirtualMachineScaleSet', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'virtualmachines' with immediate parent 'VirtualMachineScaleSet', must have a list by immediate parent operation.
TrackedResourceListByResourceGroup R3027 Link The tracked resource, 'Gallery', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
TrackedResourceListByResourceGroup R3027 Link The tracked resource, 'GalleryImage', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
TrackedResourceListByResourceGroup R3027 Link The tracked resource, 'GalleryImageVersion', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
TrackedResourceListBySubscription R3028 Link The tracked resource, 'Gallery', must have a list by subscriptions operation.
TrackedResourceListBySubscription R3028 Link The tracked resource, 'GalleryImage', must have a list by subscriptions operation.
TrackedResourceListBySubscription R3028 Link The tracked resource, 'GalleryImageVersion', must have a list by subscriptions operation.
EnumInsteadOfBoolean R3018 Link Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: excludeFromLatest
❌4 new Errors.(15 total)
Code Id Source Message
XmsExamplesRequired D5001 Link Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
TrackedResourcePatchOperation R3026 Link Tracked resource 'Gallery' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.
TrackedResourcePatchOperation R3026 Link Tracked resource 'GalleryImage' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.
TrackedResourcePatchOperation R3026 Link Tracked resource 'GalleryImageVersion' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️53 new Warnings.(124 total)
Code Id Source Message
PageableOperation R2029 Link Based on the response model schema, operation 'Gallery_ListGalleriesInResourceGroup' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'Gallery_ListGalleriesInSubscription' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'GalleryImage_ListGalleryImagesInGallery' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'GalleryImageVersion_ListGalleryImageVersionsInGalleryImage' might be pageable. Consider adding the x-ms-pageable extension.
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'GalleryImageVersion_Delete' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'GalleryImage' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'GalleryImageVersion' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
DescriptionAndTitleMissing R4000 Link 'GalleryIdentifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'VirtualMachineImageResource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'VirtualMachineImageResource'
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'identifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'identifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recommended' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'disallowed' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'purchasePlan' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'vCPUs' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'memory' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'publishingProfile' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'storageProfile' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'replicationStatus' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'managedImage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'osDiskImage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️12 new Warnings.(66 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'images' with immediate parent 'Gallery', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'versions' with immediate parent 'GalleryImage', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'extensions' with immediate parent 'VirtualMachine', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'extensions' with immediate parent 'VirtualMachineScaleSet', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'virtualmachines' with immediate parent 'VirtualMachineScaleSet', must have a list by immediate parent operation.
TrackedResourceListByResourceGroup R3027 Link The tracked resource, 'Gallery', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
TrackedResourceListByResourceGroup R3027 Link The tracked resource, 'GalleryImage', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
TrackedResourceListByResourceGroup R3027 Link The tracked resource, 'GalleryImageVersion', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
TrackedResourceListBySubscription R3028 Link The tracked resource, 'Gallery', must have a list by subscriptions operation.
TrackedResourceListBySubscription R3028 Link The tracked resource, 'GalleryImage', must have a list by subscriptions operation.
TrackedResourceListBySubscription R3028 Link The tracked resource, 'GalleryImageVersion', must have a list by subscriptions operation.
EnumInsteadOfBoolean R3018 Link Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: excludeFromLatest
❌4 new Errors.(15 total)
Code Id Source Message
XmsExamplesRequired D5001 Link Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
TrackedResourcePatchOperation R3026 Link Tracked resource 'Gallery' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.
TrackedResourcePatchOperation R3026 Link Tracked resource 'GalleryImage' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.
TrackedResourcePatchOperation R3026 Link Tracked resource 'GalleryImageVersion' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️53 new Warnings.(124 total)
Code Id Source Message
PageableOperation R2029 Link Based on the response model schema, operation 'Gallery_ListGalleriesInResourceGroup' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'Gallery_ListGalleriesInSubscription' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'GalleryImage_ListGalleryImagesInGallery' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'GalleryImageVersion_ListGalleryImageVersionsInGalleryImage' might be pageable. Consider adding the x-ms-pageable extension.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'GalleryImageVersion_Delete' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'GalleryImage' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'GalleryImageVersion' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
DescriptionAndTitleMissing R4000 Link 'GalleryIdentifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'VirtualMachineImageResource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'VirtualMachineImageResource'
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'identifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'identifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recommended' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'disallowed' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'purchasePlan' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'vCPUs' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'memory' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'publishingProfile' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'storageProfile' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'replicationStatus' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'managedImage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'osDiskImage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@Azure Azure deleted a comment from AutorestCI May 16, 2018
@Azure Azure deleted a comment from AutorestCI May 16, 2018
@Azure Azure deleted a comment from AutorestCI May 16, 2018
@Azure Azure deleted a comment from AutorestCI May 16, 2018
@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️12 new Warnings.(66 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'images' with immediate parent 'Gallery', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'versions' with immediate parent 'GalleryImage', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'extensions' with immediate parent 'VirtualMachine', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'extensions' with immediate parent 'VirtualMachineScaleSet', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'virtualmachines' with immediate parent 'VirtualMachineScaleSet', must have a list by immediate parent operation.
TrackedResourceListByResourceGroup R3027 Link The tracked resource, 'Gallery', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
TrackedResourceListByResourceGroup R3027 Link The tracked resource, 'GalleryImage', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
TrackedResourceListByResourceGroup R3027 Link The tracked resource, 'GalleryImageVersion', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
TrackedResourceListBySubscription R3028 Link The tracked resource, 'Gallery', must have a list by subscriptions operation.
TrackedResourceListBySubscription R3028 Link The tracked resource, 'GalleryImage', must have a list by subscriptions operation.
TrackedResourceListBySubscription R3028 Link The tracked resource, 'GalleryImageVersion', must have a list by subscriptions operation.
EnumInsteadOfBoolean R3018 Link Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: excludeFromLatest
❌4 new Errors.(15 total)
Code Id Source Message
XmsExamplesRequired D5001 Link Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
TrackedResourcePatchOperation R3026 Link Tracked resource 'Gallery' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.
TrackedResourcePatchOperation R3026 Link Tracked resource 'GalleryImage' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.
TrackedResourcePatchOperation R3026 Link Tracked resource 'GalleryImageVersion' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️53 new Warnings.(124 total)
Code Id Source Message
PageableOperation R2029 Link Based on the response model schema, operation 'Gallery_ListGalleriesInResourceGroup' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'Gallery_ListGalleriesInSubscription' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'GalleryImage_ListGalleryImagesInGallery' might be pageable. Consider adding the x-ms-pageable extension.
PageableOperation R2029 Link Based on the response model schema, operation 'GalleryImageVersion_ListGalleryImageVersionsInGalleryImage' might be pageable. Consider adding the x-ms-pageable extension.
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'GalleryImageVersion_Delete' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'GalleryImage' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'GalleryImageVersion' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryModel'. Consider using the plural form of 'Gallery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageModel'. Consider using the plural form of 'GalleryImage' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
OperationIdNounConflictingModelNames R2063 Link OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImageVersionModel'. Consider using the plural form of 'GalleryImageVersion' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
DescriptionAndTitleMissing R4000 Link 'GalleryIdentifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'Resource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'VirtualMachineImageResource'
LocationMustHaveXmsMutability S4002 Link Property 'location' must have '"x-ms-mutability":["read", "create"]' extension defined. Resource Model: 'VirtualMachineImageResource'
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'identifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'identifier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recommended' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'disallowed' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'purchasePlan' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'vCPUs' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'memory' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'publishingProfile' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'storageProfile' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'replicationStatus' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'managedImage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'osDiskImage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 21, 2018
@lmazuel
Copy link
Member

lmazuel commented May 21, 2018

@vanbasten23 please solve the conflicts and I merge the PR. Thanks

@vanbasten2323
Resolved merge conflicts.
b757a4e
@vanbasten2323
Updated the readme.md
fa546f9
@vanbasten2323
Updated the example.
cdaa5b4
@vanbasten2323
do some experiments.
5a18325
@vanbasten2323
Cleaned up unused files.
e7bb836
@vanbasten2323
added empty example file.
604b39f
@vanbasten2323
Added example for GetGallery api.
e8b5fbd
@vanbasten2323
Added example for DeleteGallery api. Passed the local validation.
7477feb
@vanbasten2323
Added example for PutGalleryImage api. Passed the local validation.
bbde0de
@vanbasten2323
Added example for GetGalleryImage api. Passed the local validation.
14e0a17
@vanbasten2323
Added example for DeleteGalleryImage api. Passed the local validation.
f5bd197
@vanbasten2323
Added example for PutGalleryImageVersion api. Passed the local valida…
0329884 
…tion.
@vanbasten2323
Added example for GetGalleryImageVersion api. Passed the local valida…
7c9b26b 
…tion.
@vanbasten2323
Added example for DeleteGalleryImageVersion api. Passed the local val…
6f4661c 
…idation.
@vanbasten2323
Added example for ListGalleriesInAResourceGroup api. Passed the local…
8e46ef9 
… validation.
@vanbasten2323
Added example for ListGalleriesInASubscription api. Passed the local …
ee7a6de 
…validation.
@vanbasten2323
Added example for ListGalleryImagesInGallery api. Passed the local va…
3619af8 
…lidation.
@vanbasten2323
Added example for ListGalleryImageVersionsInGalleryImage api. Passed …
e5ef375 
…the local validation.
@vanbasten2323
Fixed typos in the example provided.
ce1cfe9
@vanbasten2323
Fixed typos in the example provided.
98063fc
@vanbasten2323
Added the supression for gallery, gallery image, and gallery image ve…
70f7a27 
…rsion.
@vanbasten2323
Correct the suppression.
4c60939
@AutorestCI
Copy link

AutorestCI commented May 23, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: bundle install && rake arm:regen_all_profiles['azure_mgmt_compute']
Finished with return code 127
and output:

/bin/sh: 1: bundle: not found

@lmazuel
Copy link
Member

lmazuel commented May 23, 2018

LGTM!! Merging :)

@lmazuel lmazuel merged commit d828ff3 into Azure:master May 23, 2018
@AutorestCI AutorestCI mentioned this pull request May 23, 2018
Merged
@hyonholee hyonholee mentioned this pull request Sep 27, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanbasten23 vanbasten23 vanbasten23 left review comments

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@lmazuel lmazuel lmazuel approved these changes

Assignees

@lmazuel lmazuel

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vanbasten2323 @AutorestCI @azuresdkciprbot @lmazuel @ravbhatnagar @vanbasten23