Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppressions for linting errors. Approved by Gaurav #3060

Merged
merged 1 commit into from
May 23, 2018

Conversation

blocphan
Copy link
Contributor

@blocphan blocphan commented May 11, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/notificationhubs/resource-manager/readme.md

⚠️0 new Warnings.(9 total)
0 new Errors.(2 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/notificationhubs/resource-manager/readme.md

⚠️0 new Warnings.(10 total)
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@marstr
Copy link
Member

marstr commented May 15, 2018

@ravbhatnagar, can you confirm that you've approved of these?

Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending @ravbhatnagar's approval, this looks fine from my perspective.

@marstr marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 21, 2018
@marstr
Copy link
Member

marstr commented May 21, 2018

Adding the label to help get the attention of @ravbhatnagar for confirmation.

@ravbhatnagar
Copy link
Contributor

Looks good for suppression.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 23, 2018
@marstr marstr merged commit 64b3600 into Azure:master May 23, 2018
@AutorestCI
Copy link

AutorestCI commented May 23, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2610

@AutorestCI
Copy link

AutorestCI commented May 23, 2018

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2897

@AutorestCI
Copy link

AutorestCI commented May 23, 2018

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#187

@AutorestCI
Copy link

AutorestCI commented May 23, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1892

mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Adding identity property  in vm patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants