Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extension setup API and example #30592

Conversation

vedkale
Copy link
Member

@vedkale vedkale commented Sep 16, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Sep 16, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Sep 16, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/hybridcompute/armhybridcompute https://apiview.dev/Assemblies/Review/cc99eb4c91204d199d8e40aed71bc06e?revisionId=3bb9c3051ed0498f9429d9d01cc2eb26
JavaScript @azure/arm-hybridcompute https://apiview.dev/Assemblies/Review/bd79793b6b53409d8de21847c605dc64?revisionId=8d9ae3f012d34225a0c2e0a9a6ec1690
Java azure-resourcemanager-hybridcompute https://apiview.dev/Assemblies/Review/b79886348ebe497b9ddc99d286cb6e99?revisionId=009e02fe122f439f992ffb36b2e86c82
.Net Azure.ResourceManager.HybridCompute There is no API change compared with the previous version
Swagger Microsoft.HybridCompute https://apiview.dev/Assemblies/Review/31dae74112a04fb7b3a4a58e2c398536?revisionId=fd38a0bbc3534bceb99ba20be60d9df6

@razvanbadea-msft
Copy link
Contributor

You can also fix the Swagger ModelValidation check for the added example

@razvanbadea-msft razvanbadea-msft added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 17, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 17, 2024
@vedkale vedkale removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 18, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 18, 2024
@razvanbadea-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 19, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 19, 2024
@razvanbadea-msft
Copy link
Contributor

I am signing off on the PR because there are no blocking comment. However, you should consider updating the examples before merging the PR.

@vedkale
Copy link
Member Author

vedkale commented Sep 30, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@vedkale
Copy link
Member Author

vedkale commented Sep 30, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@vedkale vedkale added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Sep 30, 2024
@vedkale
Copy link
Member Author

vedkale commented Sep 30, 2024

Asking for ARM feedback again because I updated the model and the examples, another review would be appreciated, thanks!

Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 4, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Oct 21, 2024
@vedkale vedkale removed the no-recent-activity There has been no recent activity on this issue. label Oct 21, 2024
@vedkale vedkale enabled auto-merge (squash) October 21, 2024 23:02
@vedkale vedkale merged commit e869288 into Azure:release-hybridcompute-Microsoft.HybridCompute-2024-09-10-preview Oct 21, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArcReview ArcSignedOff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants