-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] remove unsupported VM types #3039
Conversation
Some SKUs don't have enough RAM to support Kubernetes workloads reliably, so we're removing support for those types. This change won't accomplish that validation, but will prevent SDK users from being led astray and trying to provision those types.
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/containerservices/resource-manager/readme.md
|
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/containerservices/resource-manager/readme.md
|
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/containerservices/resource-manager/readme.md
|
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/containerservices/resource-manager/readme.md
|
@mboersma a few question to understand:
|
No, but roughly 50% of the time if a user provisioned an AKS cluster with the smaller VM types that I propose to remove here.
Not today, but soon. In the next week or two, users specifying these removed VM SKUs will get a specific error about "VM not large enough for AKS," which we think is better than letting someone try and fail about half the time. This change isn't crucial since the validation will really be done server-side, but it should keep things consistent and documentation correct. |
Ok, so you will change live the current ApiVersion. As long as the server will fail in a close future, I'm fine with the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since server will refuse them anyway
They can still scale and upgrade that cluster using its existing VM type. The server-side change will only reject these sizes when creating new clusters. |
Automation for azure-sdk-for-nodeA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Some SKUs don't have enough RAM to support Kubernetes workloads reliably, so we're removing support for those types. This change won't accomplish that validation, but will prevent SDK users from
being led astray and trying to provision those types.
cc: @weinong
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger