[DataFactory] blob events trigger #3008

cesher · 2018-05-03T22:27:46Z

No description provided.

AutorestCI · 2018-05-03T22:30:51Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

AutorestCI · 2018-05-03T22:32:04Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#18

AutorestCI · 2018-05-03T22:33:06Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2770

AutorestCI · 2018-05-03T22:36:56Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1845

azuresdkciprbot · 2018-05-03T22:37:08Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(5 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-03T22:37:08Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(9 total)

❌0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-03T22:45:36Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(5 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-03T22:45:36Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(9 total)

❌0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

hvermis · 2018-05-03T22:51:43Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+      "properties": {
+        "typeProperties":
+        {
+          "description": "Blob Events Trigger properties",


Add dot at the end of description. The linter catches these as errors.

hvermis · 2018-05-03T22:52:29Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+          "x-ms-client-flatten": true,
+          "properties": {
+            "blobPath": {
+              "description": "path to container, folder, blob, or file extension for which events can trigger the pipeline.",


Start the description with upper case

hvermis · 2018-05-03T22:53:04Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+              "type": "string"
+            },
+            "events": {
+              "description": "the type of events for which we want to trigger the pipeline.",


Maybe: "The type of events that cause this trigger to fire."

hvermis · 2018-05-03T22:55:23Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+              "$ref": "#/definitions/BlobEventTypes"
+            },
+            "scope": {
+              "description": "the resource id of the Storage Account.",


Upper case. "ARM resource ID" instead of "resource id"

hvermis · 2018-05-03T22:56:28Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+              "type": "string"
+            },
+            "maxConcurrency": {
+              "description": "the max number of parallel events to handle when it is triggered.",


Upper case. "when triggered."

hvermis · 2018-05-03T22:57:07Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+              "description": "the resource id of the Storage Account.",
+              "type": "string"
+            },
+            "maxConcurrency": {


You might want to add validation for this - should be more than 0 at least, and do you have max for this value?

added minimum of 1. Max is configurable, so not specifying.

hvermis · 2018-05-03T22:57:32Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+          "modelAsString": true
+        }
+      },
+      "description": "blob event types"


Upper case and dot.

azuresdkciprbot · 2018-05-03T23:43:43Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(5 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-03T23:43:43Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(9 total)

❌0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

hvermis · 2018-05-03T23:45:47Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+          "x-ms-client-flatten": true,
+          "properties": {
+            "blobPath": {
+              "description": "Path to container, folder, blob, or file extension for which events can trigger the pipeline.",


Is this relative path? Can you add an example, or be more specific in the description?

azuresdkciprbot · 2018-05-03T23:53:03Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(5 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-03T23:53:03Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(9 total)

❌0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T00:14:48Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(9 total)

❌0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T00:14:48Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(5 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

hvermis

Need to make sure the types are correct for properties

ravbhatnagar · 2018-05-08T08:44:44Z

New model type blobtrigger got added. Looks fine.

hvermis · 2018-05-08T18:08:33Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+          "description": "Blob Events Trigger properties.",
+          "x-ms-client-flatten": true,
+          "properties": {
+            "blobPath": {


@marstr This property will be changed, please do not merge yet.

marstr · 2018-05-08T20:19:55Z

Just to be clear, I'm holding out on reviewing until @hvermis has signed-off, under the assumption that until she approves there are changes coming.

azuresdkciprbot · 2018-05-10T18:13:46Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(9 total)

❌0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-10T18:13:46Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️

0 new Warnings.(6 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

cesher · 2018-05-15T00:14:54Z

@marstr could you review the latest changes please, @hvermis has signed off.

marstr · 2018-05-15T23:23:29Z

Ready for me to merge, @cesher?

cesher · 2018-05-16T17:36:22Z

@marstr yes please.

blob events trigger

ce3cce8

azuresdkci assigned marstr May 3, 2018

azuresdkci requested a review from marstr May 3, 2018 22:28

AutorestCI mentioned this pull request May 3, 2018

[AutoPR datafactory/resource-manager] [DataFactory] blob events trigger Azure/azure-sdk-for-python#2527

Merged

This was referenced May 3, 2018

[AutoPR datafactory/resource-manager] [DataFactory] blob events trigger AutorestCI/azure-libraries-for-java#141

Merged

[AutoPR datafactory/resource-manager] [DataFactory] blob events trigger Azure/azure-sdk-for-node#2832

Merged

marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 3, 2018

AutorestCI mentioned this pull request May 3, 2018

[AutoPR datafactory/resource-manager] [DataFactory] blob events trigger Azure/azure-sdk-for-go#1786

Merged

hvermis approved these changes May 3, 2018

View reviewed changes

hvermis reviewed May 3, 2018

View reviewed changes

address review feedback

af2af51

hvermis requested changes May 4, 2018

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 8, 2018

hvermis reviewed May 8, 2018

View reviewed changes

resolve blob path property issue

31a95ab

hvermis approved these changes May 10, 2018

View reviewed changes

marstr approved these changes May 15, 2018

View reviewed changes

marstr merged commit 8c6dc3e into Azure:master May 16, 2018

cesher mentioned this pull request May 17, 2018

[DataFactory] Blob Events Trigger sample json Azure/azure-sdk-for-net#4330

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DataFactory] blob events trigger #3008

[DataFactory] blob events trigger #3008

cesher commented May 3, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

azuresdkciprbot commented May 3, 2018

azuresdkciprbot commented May 3, 2018

azuresdkciprbot commented May 3, 2018

azuresdkciprbot commented May 3, 2018

hvermis May 3, 2018

hvermis May 3, 2018

hvermis May 3, 2018

hvermis May 3, 2018

hvermis May 3, 2018

hvermis May 3, 2018

hvermis May 3, 2018

cesher May 3, 2018

hvermis May 3, 2018

azuresdkciprbot commented May 3, 2018

azuresdkciprbot commented May 3, 2018

hvermis May 3, 2018

azuresdkciprbot commented May 3, 2018

azuresdkciprbot commented May 3, 2018

azuresdkciprbot commented May 4, 2018

azuresdkciprbot commented May 4, 2018

hvermis left a comment

ravbhatnagar commented May 8, 2018

hvermis May 8, 2018

marstr commented May 8, 2018 •

edited by hvermis

Loading

azuresdkciprbot commented May 10, 2018

azuresdkciprbot commented May 10, 2018

cesher commented May 15, 2018

marstr commented May 15, 2018

cesher commented May 16, 2018

[DataFactory] blob events trigger #3008

[DataFactory] blob events trigger #3008

Conversation

cesher commented May 3, 2018 • edited by azuresdkci Loading

AutorestCI commented May 3, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 3, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented May 3, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 3, 2018 • edited Loading

Automation for azure-sdk-for-go

azuresdkciprbot commented May 3, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 3, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 3, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 3, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azuresdkciprbot commented May 3, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 3, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Choose a reason for hiding this comment

azuresdkciprbot commented May 3, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 3, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 4, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 4, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

hvermis left a comment

Choose a reason for hiding this comment

ravbhatnagar commented May 8, 2018

Choose a reason for hiding this comment

marstr commented May 8, 2018 • edited by hvermis Loading

azuresdkciprbot commented May 10, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 10, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

cesher commented May 15, 2018

marstr commented May 15, 2018

cesher commented May 16, 2018

cesher commented May 3, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

marstr commented May 8, 2018 •

edited by hvermis

Loading