Added x-mx-odata properties for some resources #2943

vrdmr · 2018-04-25T00:19:42Z

This work is required for the cmdlet migration work we are doing to move to Swagger based SDK.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

… cmdlet work

AutorestCI · 2018-04-25T00:20:22Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-04-25T00:21:30Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#1959

AutorestCI · 2018-04-25T00:21:35Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2653

AutorestCI · 2018-04-25T00:25:03Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpslty9vz6/rest/specification/automation/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpslty9vz6/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.95', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4272/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4272)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.95->2.1.95)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2015-10"} .
Processing batch task - {"tag":"package-2017-05-preview"} .
Processing batch task - {"tag":"package-2018-01-preview"} .
FATAL: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: startIndex
   at System.String.LastIndexOf(Char value, Int32 startIndex, Int32 count)
   at AutoRest.Go.Model.CodeModelGo.PackageVerDir() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Model\CodeModelGo.cs:line 64
   at AutoRest.Go.Model.CodeModelGo.get_DefaultUserAgent() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Model\CodeModelGo.cs:line 83
   at AutoRest.Go.Model.CodeModelGo.get_UserAgent() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Model\CodeModelGo.cs:line 31
   at AutoRest.Go.Templates.VersionTemplate.<ExecuteAsync>d__1.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\obj\Razor\Templates\VersionTemplate.cshtml:line 28
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.CodeGeneratorGo.<Generate>d__6.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\CodeGeneratorGo.cs:line 91
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2018-01-preview"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

azuresdkciprbot · 2018-04-25T00:25:35Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(88 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-25T00:25:35Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(131 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

mcardosos · 2018-04-25T00:34:19Z

...mation/resource-manager/Microsoft.Automation/stable/2015-10-31/hybridRunbookWorkerGroup.json

@@ -255,7 +255,8 @@
        },
        "x-ms-pageable": {
          "nextLinkName": "nextLink"
-        }
+        },
+        "x-ms-odata": "./definitions.json#/definitions/HybridRunbookWorkerGroup"


HybridRunbookWorkerGroup [](start = 55, length = 24)

Also add the $filter parameter

mcardosos · 2018-04-25T00:34:40Z

...fication/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/jobSchedule.json

@@ -258,7 +258,8 @@
        },
        "x-ms-pageable": {
          "nextLinkName": "nextLink"
-        }
+        },
+        "x-ms-odata": "./definitions.json#/definitions/JobSchedule"


JobSchedule [](start = 55, length = 11)

$filter parameter is missing

azuresdkciprbot · 2018-04-30T18:45:10Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(131 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-30T18:45:10Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(88 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-30T21:25:28Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(131 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-30T21:25:28Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(88 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

vrdmr · 2018-05-01T00:06:17Z

@mcardosos Could you please review this PR. Thanks, Varad.

mcardosos

For awareness, there are linter errors. I know they were not introduced in this PR.

Added x-mx-odata properties for some resources currently required for…

c9699bb

… cmdlet work

azuresdkci assigned mcardosos Apr 25, 2018

azuresdkci requested a review from mcardosos April 25, 2018 00:20

mcardosos reviewed Apr 25, 2018

View reviewed changes

New filters and nit fixes

a3a9d73

This was referenced Apr 30, 2018

[AutoPR automation/resource-manager] Added x-mx-odata properties for some resources Azure/azure-sdk-for-python#2498

Closed

[AutoPR automation/resource-manager] Added x-mx-odata properties for some resources Azure/azure-sdk-for-node#2815

Merged

Fix the Webhook Model

9a49b7a

mcardosos approved these changes May 1, 2018

View reviewed changes

mcardosos merged commit 207e5b8 into Azure:master May 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added x-mx-odata properties for some resources #2943

Added x-mx-odata properties for some resources #2943

vrdmr commented Apr 25, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Apr 25, 2018 •

edited

Loading

AutorestCI commented Apr 25, 2018 •

edited

Loading

AutorestCI commented Apr 25, 2018 •

edited

Loading

AutorestCI commented Apr 25, 2018 •

edited

Loading

azuresdkciprbot commented Apr 25, 2018

azuresdkciprbot commented Apr 25, 2018

mcardosos Apr 25, 2018

vrdmr Apr 30, 2018

mcardosos Apr 25, 2018

vrdmr Apr 30, 2018

azuresdkciprbot commented Apr 30, 2018

azuresdkciprbot commented Apr 30, 2018

azuresdkciprbot commented Apr 30, 2018

azuresdkciprbot commented Apr 30, 2018

vrdmr commented May 1, 2018

mcardosos left a comment

Added x-mx-odata properties for some resources #2943

Added x-mx-odata properties for some resources #2943

Conversation

vrdmr commented Apr 25, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Apr 25, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Apr 25, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 25, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Apr 25, 2018 • edited Loading

Automation for azure-sdk-for-go

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

mcardosos Apr 25, 2018

Choose a reason for hiding this comment

vrdmr Apr 30, 2018

Choose a reason for hiding this comment

mcardosos Apr 25, 2018

Choose a reason for hiding this comment

vrdmr Apr 30, 2018

Choose a reason for hiding this comment

azuresdkciprbot commented Apr 30, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 30, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented Apr 30, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 30, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

vrdmr commented May 1, 2018

mcardosos left a comment

Choose a reason for hiding this comment

vrdmr commented Apr 25, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Apr 25, 2018 •

edited

Loading

AutorestCI commented Apr 25, 2018 •

edited

Loading

AutorestCI commented Apr 25, 2018 •

edited

Loading

AutorestCI commented Apr 25, 2018 •

edited

Loading