VirtualNetworkGateway identity fix

[Khushboo-Baheti]

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

[openapi-pipeline-app]

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

[openapi-pipeline-app]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

Compared specs (v0.10.9)	new version	base version
networkVirtualAppliance.json	2024-01-01(fd4a7f2)	2023-11-01(main)
virtualNetworkGateway.json	2024-01-01(fd4a7f2)	2023-11-01(main)

️⚠️LintDiff: 0 Warnings warning [Detail]

Compared specs (v2.2.2)	new version	base version
package-2024-01	package-2024-01(fd4a7f2)	package-2024-01(guptavertika/release-network-Microsoft.Network-official-2024-01-01)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L37
❌ DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L159
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L191
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L252
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L325
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L378
❌ ParametersInPost	gatewayVip is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L385
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L415
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L442
❌ PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L443
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L475
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L496
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L541
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L562
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L607
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L628
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L664
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L685
❌ ParametersInPost	peer is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L692
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L728
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L749
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L799
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L835
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L856
❌ ParametersInPost	peer is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L863
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L899
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L920
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L959
❌ ResourceNameRestriction	The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L986
❌ PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L987

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️⌛PR Summary pending [Detail]

️⌛Automated merging requirements met pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
❌ RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=433896&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 "

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Swagger	Microsoft.Network	https://apiview.dev/Assemblies/Review/9a91f46aa0a846acaae91aba821517fb?revisionId=a8ad49e6c8144404b61da4e5d3162f59