Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Factory]Add schema mapping for hierarchical data #2906

Merged
merged 3 commits into from
Jun 8, 2018
Merged

[Data Factory]Add schema mapping for hierarchical data #2906

merged 3 commits into from
Jun 8, 2018

Conversation

charlesshen-msft
Copy link
Contributor

@charlesshen-msft charlesshen-msft commented Apr 19, 2018 •
edited by azuresdkci
Loading

No description provided.

@azuresdkci azuresdkci requested a review from lmazuel April 19, 2018 09:13
@AutorestCI AutorestCI mentioned this pull request Apr 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 19, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

@AutorestCI AutorestCI mentioned this pull request Apr 19, 2018
Open
@AutorestCI
Copy link

AutorestCI commented Apr 19, 2018 •
edited
Loading

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#18

@AutorestCI AutorestCI mentioned this pull request Apr 19, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Apr 19, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1998

@AutorestCI AutorestCI mentioned this pull request Apr 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 19, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2770

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 14 Error(s): 1
After the PR: Warning(s): 14 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@charlesshen-msft
Copy link
Contributor Author

@hvermis

lmazuel
lmazuel reviewed Apr 19, 2018
View reviewed changes
.../resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Pipeline.json Outdated
@@ -1616,6 +1616,10 @@
"columnMappings": {
"type": "object",
"description": "Column mappings. Type: string (or Expression with resultType string)."
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update or add an example for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@hvermis hvermis changed the title [Data Factory]Add schema mapping for hierarchical data [Do not merge][Data Factory]Add schema mapping for hierarchical data Apr 19, 2018
@charlesshen-msft charlesshen-msft changed the title [Do not merge][Data Factory]Add schema mapping for hierarchical data [Data Factory]Add schema mapping for hierarchical data Apr 24, 2018
@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️0 new Warnings.(5 total)
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datafactory/resource-manager/readme.md

⚠️0 new Warnings.(9 total)
❌0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

lmazuel
lmazuel requested changes Apr 24, 2018
View reviewed changes
.../resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Pipeline.json
@@ -1615,7 +1615,11 @@
"properties": {
"columnMappings": {
"type": "object",
"description": "Column mappings. Type: string (or Expression with resultType string)."
"description": "Column mappings. Example: \"UserId: MyUserId, Group: MyGroup, Name: MyName\" Type: string (or Expression with resultType string)."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant, x-ms-example, like this:
https://github.com/iamapi/azure-rest-api-specs/tree/a3c2bff7ee233f1de44032b1fccc27450874c77f/specification/datafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no additional resource or API added but only added a property, I checked the examples, all of them are based on a resource, I couldn't find a suitable place to add. I added examples and test cases in SDK. @lmazuel

@lmazuel
Copy link
Member

lmazuel commented May 21, 2018

I'm about to close this PR for inactivity. Friendly reminder. Thank you.

@hvermis
Copy link
Contributor

hvermis commented May 21, 2018

@lmazuel Please wait for couple days. I think our China team is OOF

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jun 6, 2018
Merged
@lmazuel lmazuel merged commit 962108d into Azure:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

Assignees

@lmazuel lmazuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@charlesshen-msft @AutorestCI @azuresdkciprbot @lmazuel @hvermis