Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EG] System events reformat #28706

Merged
merged 42 commits into from
Jun 3, 2024
Merged

Conversation

l0lawrence
Copy link
Member

No description provided.

Copy link

openapi-pipeline-app bot commented Apr 16, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.

Copy link

openapi-pipeline-app bot commented Apr 16, 2024

Swagger Validation Report

️❌BreakingChange: 503 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.9) new version base version
SystemEvents.json 2024-01-01(0676dd1) 2024-01-01(main)

Only 30 items are listed, please refer to log for more details.

Rule Message
1023 - TypeFormatChanged The new version has a different format 'double' than the previous one 'duration'.
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L2284:9
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L1737:9
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L28:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L28:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L3292:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L2591:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L7004:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L6185:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L63:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L60:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L82:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L76:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L101:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L92:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L132:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L119:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L163:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L146:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L204:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L183:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L245:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L220:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L270:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L242:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L295:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L264:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L575:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L502:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L329:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L293:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L358:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L317:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L392:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L346:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L421:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L370:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L462:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L405:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L503:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L440:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L527:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L460:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L551:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L481:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L600:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L523:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L638:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L555:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L676:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L587:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L700:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L607:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L795:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L697:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L836:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L734:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L860:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L754:7
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L1252:7
Old: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L821:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-01-01 package-2024-01-01(0676dd1) package-2024-01-01(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ PropertyType Property should have a defined type.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L2280


The following errors/warnings exist before current PR submission:

Rule Message
⚠️ PropertyType Property should have a defined type.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L429
⚠️ PropertyType Property should have a defined type.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L470
⚠️ PropertyType Property should have a defined type.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L613
⚠️ PropertyType Property should have a defined type.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L658
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L1631
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L1827
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L6069
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L6934
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L6942
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L7009
⚠️ PropertyType Property should have a defined type.
Location: Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json#L7750
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Apr 16, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Pipeline Framework Failed in generating from 0114e14c6e369db3dfbb54f4125ca81a2127f4dd. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Write-Error: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:120
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  120 |  … ectFolder = & $processScript $typespecFolder $commitid $repoHttpsUrl  …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk project at
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents
    fatal: 'sdkAuto/28706/' is not a valid branch namehint: See `man git check-ref-format`hint: Disable this message with "git config advice.refSyntax false"
  • error	Fatal error: fatal: 'sdkAuto/28706/' is not a valid branch namehint: See `man git check-ref-format`hint: Disable this message with "git config advice.refSyntax false"
    error	Fatal error: Error: fatal: 'sdkAuto/28706/' is not a valid branch namehint: See `man git check-ref-format`hint: Disable this message with "git config advice.refSyntax false"    at Object.action (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:1445:25)    at PluginStore.exec (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:1494:29)    at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:1921:43    at new Promise (<anonymous>)    at GitExecutorChain.handleTaskData (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:1919:16)    at GitExecutorChain.<anonymous> (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:1903:44)    at Generator.next (<anonymous>)    at fulfilled (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:52:24)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    error	The following packages are still pending:
    error
️❌ azure-sdk-for-python failed [Detail]
  • Code Generator Failed in generating from 0114e14c6e369db3dfbb54f4125ca81a2127f4dd. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[automation_init.sh] npm notice
    warn		specification/eventgrid/data-plane/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
    warn	Skip package processing as generation is failed
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Apr 16, 2024

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Apr 24, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Apr 25, 2024
@@ -153,7 +144,7 @@ namespace Microsoft.EventGrid.SystemEvents {
`@odataType`: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the @discriminator field here should be @odata.type (note the added '.'):

Based on the events they have listed here:

https://learn.microsoft.com/en-us/azure/event-grid/event-schema-media-services?tabs=cloud-event-schema#joboutputstatechange

   "@odata.type": "#Microsoft.Media.JobOutputAsset",

@@ -55,13 +55,11 @@ model SubscriptionValidationEventData {
/** The validation code sent by Azure Event Grid to validate an event subscription.
* To complete the validation handshake, the subscriber must either respond with this validation code as part of the validation response,
* or perform a GET request on the validationUrl (available starting version 2018-05-01-preview). */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(apologies, can't leave a comment on unchanged code)

A few of the comments in here make reference to IDs that aren't valid (they have SystemEvents in them, but it's not in their online docs):

  • "Microsoft.EventGrid.SystemEvents.MQTTClientCreatedOrUpdated"
  • "Microsoft.EventGrid.SystemEvents.MQTTClientDeleted"
  • "Microsoft.EventGrid.SystemEvents.MQTTClientSessionConnected",
  • "Microsoft.EventGrid.SystemEvents.MQTTClientSessionDisconnected"
  • "Microsoft.EventGrid.SystemEvents.SubscriptionDeletedEvent",
  • "Microsoft.EventGrid.SystemEvents.SubscriptionValidationEvent"

The MQTT ones are here, for example:
https://learn.microsoft.com/en-us/azure/event-grid/event-schema-event-grid-namespace?tabs=cloud-event-schema

I just noticed this when I regen'd and they came up differently than last time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up adding these to my PR to this PR. So SOON.


/** Router Job Worker Selector Time to Live in Seconds */
@encode("ISO8601") // TODO verify this is timespan in C#
ttlSeconds?: duration;
ttlSeconds: duration;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something odd going on here. I have an older version of the JSON for this that lists 'ttlSeconds' as a float, not a string (or duration).

Looking at the swagger I see it's the case there as well:

HOWEVER, looking at the user-facing docs, they've doc'd it as a string! So I'm not 100% on what is right here - did they make a breaking change at some point?

https://learn.microsoft.com/en-us/azure/event-grid/communication-services-router-events#microsoftcommunicationrouterjobqueued

CC: @lmazuel

@@ -692,78 +692,78 @@ model AcsRouterWorkerSelector {
key?: string;

/** Router Job Worker Selector Label Operator */
operator?: AcsRouterLabelOperator;
operator: AcsRouterLabelOperator;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/** Router Job Worker Selector State */
selectorState?: AcsRouterWorkerSelectorState;
selectorState: AcsRouterWorkerSelectorState;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is actually under 'state', not 'selectorState':

@l0lawrence l0lawrence marked this pull request as ready for review June 3, 2024 15:32
@l0lawrence l0lawrence requested a review from Kishp01 as a code owner June 3, 2024 15:32
@lmazuel lmazuel merged commit a58614a into Azure:main Jun 3, 2024
27 of 32 checks passed
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
* refactor

* updayrd

* format

* add apicenter

* update new events

* tsp format

* new events

* modelAsString for Media Union as False

* tsp format

* Revert "tsp format"

This reverts commit 1a01cf8.

* Revert "modelAsString for Media Union as False"

This reverts commit 6b60581.

* remove ReadOnly

* rename resources

* remove duplicate vault

* remove Optional from Nullable Types part 1

* add csharp to x-ms-client-names

* typo

* swagger typo

* formatting

* Client Name Overrides JS EG System Events

* Adding in renames for Go

* fix RecordingDurationMs casing

* Fixing something that Libba refused to for like months now.

* Removing SystemEvents from the constant names

* Should be a number == float64.

* Field name is labelOperator, not operator.

(as shown here: https://github.com/Azure/azure-rest-api-specs/blob/0a8300f818c1df4018e2586540bed4c72c7c5375/specification/eventgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L2120)

* Field is state, not selectorState:

https://github.com/Azure/azure-rest-api-specs/blob/0a8300f818c1df4018e2586540bed4c72c7c5375/specification/eventgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L2171

* More renames to bring us to par with what we had before.

* Adding in some docs that were missing for unions.

* format

* fix warnigns

* moving around clientNames

* spellcheck

* try to update csharp clientNames

* tsp format

* missing labelValue x-ms-client-name

* format

* nit typo

* update csharp

---------

Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com>
Co-authored-by: ripark <ripark@microsoft.com>
trangevi added a commit to trangevi/azure-rest-api-specs that referenced this pull request Jun 12, 2024
commit 4ee5306
Author: Darren Cohen <39422044+dargilco@users.noreply.github.com>
Date:   Mon Jun 10 16:53:36 2024 -0700

    Move Python class renaming to client.tsp

commit 36d9e57
Author: Darren Cohen <39422044+dargilco@users.noreply.github.com>
Date:   Mon Jun 10 12:06:34 2024 -0700

    Regenerate examples

commit ac08a31
Author: Darren Cohen <39422044+dargilco@users.noreply.github.com>
Date:   Mon Jun 10 12:04:19 2024 -0700

    Add missing public access of ModelType

commit 1e69395
Author: Darren Cohen <39422044+dargilco@users.noreply.github.com>
Date:   Mon Jun 10 11:20:08 2024 -0700

    limit scope of text and image embedding clients to Python only

commit 4478a53
Author: Darren Cohen <39422044+dargilco@users.noreply.github.com>
Date:   Mon Jun 10 07:59:52 2024 -0700

    Support image input in chat completions

commit 6dee548
Merge: 54ca985 f45a76f
Author: Darren Cohen <39422044+dargilco@users.noreply.github.com>
Date:   Mon Jun 10 07:54:14 2024 -0700

    Merge remote-tracking branch 'origin/main' into dargilco/ai-model-inference

commit f45a76f
Author: Ayush Gupta - SQL <166794972+guptaayush007@users.noreply.github.com>
Date:   Mon Jun 10 13:20:39 2024 +0530

    Downgraded the version of ManagedInstances to generate .Net SDK for sql/resource manager (Azure#29316)

    * Downgraded the version of ManagedInstances and DistributedAvailabilityGroups Api due to .Net Sdk build failures caused by error : MembersMustExist  in these API's

    * restored the version of ManagedInstance Api as previous

    * Update the version of ManagedInstance APi to previous version 22-08-01 as having build erros while building .net sdk with error 'implementation but it does exist in the contract.'

    ---------

    Co-authored-by: Ji Wang <jiwang5@microsoft.com>

commit 1cb8cb0
Author: InbalZim <48387592+InbalZim@users.noreply.github.com>
Date:   Mon Jun 10 10:48:40 2024 +0300

    [Microsoft.StorageMover] [UploadLimitSchedule] [v2024-07-01] (Azure#29082)

    * Implemented ULS - copied v2024-07-01 files (incl. readme) from RPSaaSMaster branch

    * Removed reference to `v2024-05-01-preview`

commit 224f1c7
Author: Weidong Xu <weidxu@microsoft.com>
Date:   Mon Jun 10 00:01:56 2024 +0800

    vmware, mgmt, tsp, bug fix for leaseTime to int64 (Azure#29351)

commit c2f037e
Author: Steven Nguyen <30740718+snguyen64@users.noreply.github.com>
Date:   Sun Jun 9 11:57:40 2024 -0400

    update(acns): advanced networking profile to note addition costs (Azure#29146)

commit e8ead1c
Author: nnagarajanmsft <94897071+nnagarajanmsft@users.noreply.github.com>
Date:   Sun Jun 9 21:27:21 2024 +0530

    Nnagarajanmsft elasticsan microsoft.elastic san 2024 05 01 (Azure#28828)

    * Adds base for updating Microsoft.ElasticSan from version stable/2023-01-01 to version 2024-05-01

    * Updates readme

    * Updates API version in new specs and examples

    * Add EnforceDataIntegrityCheck and generate and validate examples

    * Run swagger prettier check for files reported in checks

    * Run prettier for all jsons

    * add modelerfour to disable flatten to avoid JS breaking

    * Add new field in VolumeGroupUpdateProperties

    ---------

    Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>

commit 25afa22
Author: Libba Lawrence <llawrence@microsoft.com>
Date:   Fri Jun 7 16:16:19 2024 -0700

    [EG] mark internal all (Azure#29366)

    * internal csharp

    * remove - apply to all

    * update - js doesnt recognize internal?

    * try this

    * tsp format

    * update

    * update version

commit 54ca985
Merge: 0aeb368 e90dc8b
Author: Darren Cohen <39422044+dargilco@users.noreply.github.com>
Date:   Fri Jun 7 15:30:18 2024 -0700

    Merge remote-tracking branch 'origin/main' into dargilco/ai-model-inference

commit e90dc8b
Author: Konrad Jamrozik <kojamroz@microsoft.com>
Date:   Fri Jun 7 14:26:15 2024 -0700

    Update uniform-versioning.md and glossary.md: minor fixups (Azure#29368)

    * Update uniform-versioning.md

    * Update glossary.md

commit 86b70ce
Author: pjohari-ms <84465928+pjohari-ms@users.noreply.github.com>
Date:   Fri Jun 7 15:56:05 2024 -0500

    [Microsoft.DocumentDB] Bug fix for preview API Version 2024-05-15-preview (Azure#29344)

    * Bug fix for version 05-15-preview

    * Renamed models for better naming

commit 0d5a422
Author: Jim Chou <77021369+jimchou-dev@users.noreply.github.com>
Date:   Fri Jun 7 08:52:52 2024 -0700

    [ACS][Communication][Chat] 2024-06-05-preview public preview API spec (Azure#28875)

commit b22c642
Author: Konrad Jamrozik <kojamroz@microsoft.com>
Date:   Thu Jun 6 14:11:56 2024 -0700

    Update directory-structure.md: clarify service, service group, uniform versioning. (Azure#28929)

commit 0aeb368
Author: Darren Cohen <39422044+dargilco@users.noreply.github.com>
Date:   Thu Jun 6 09:48:55 2024 -0700

    Remove CapacityType

commit bf820ef
Author: miaxzhitong <146033271+miaxzhitong@users.noreply.github.com>
Date:   Thu Jun 6 08:25:30 2024 -0700

    Azure Map Rendering 20240401 (Azure#27950)

    * Adds base for updating Render from version stable/2022-08-01 to version 2024-04-01

    * Updates readme

    * Updates API version in new specs and examples

    * update static map API doc

    * small change on static map doc

    * update tilesetId section

    * add static map supported tilesetid and trafficLayer

    * update range table and static image example

    * fix typo

    * add additional static image example

    * error fix

    * run prettier on static image example json

    * set tilesetId as optional

    * update max/min latitude/longitude table

    * update Accept header for static image API

    * error fix

    * add explanation for Accept header

    * typo

    * add parameter limitation

    * improve wording

    * add path and pin parameter type

    * fix tables

    * improve on example

    * typo fix

    * run prettier

    * wording fix

    * map attribution description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * state tile description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map tile description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map tileset description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map copyright caption description change

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map copyright bounding description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * weather radar tile description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * weather infrared tiles description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map copyright tile description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map copyright world description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * remove pricing tiers applies

    * Adds base for updating Render from version stable/2022-08-01 to version 2024-04-01

    * Updates readme

    * Updates API version in new specs and examples

    * update static map API doc

    * small change on static map doc

    * update tilesetId section

    * add static map supported tilesetid and trafficLayer

    * update range table and static image example

    * fix typo

    * add additional static image example

    * error fix

    * run prettier on static image example json

    * set tilesetId as optional

    * update max/min latitude/longitude table

    * update Accept header for static image API

    * error fix

    * add explanation for Accept header

    * typo

    * add parameter limitation

    * improve wording

    * add path and pin parameter type

    * fix tables

    * improve on example

    * typo fix

    * run prettier

    * wording fix

    * map attribution description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * state tile description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map tile description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map tileset description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map copyright caption description change

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map copyright bounding description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * weather radar tile description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * weather infrared tiles description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map copyright tile description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * map copyright world description update

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * remove pricing tiers applies

    * reduce get copyright example length

    * add summary for render 20240401

    * remove summary from static image

    * remove please from language and view

    * add package-2024-04-01 to readme

    * revert back common change

    * revert changes in maps readme

    * \n fix

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * typo fix

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * typo fix for map copyright caption

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * typo fix for statetile

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    * typo fix for map copyright world

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>

    ---------

    Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>
    Co-authored-by: Joel Hendrix <jhendrix@microsoft.com>

commit f98d676
Author: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>
Date:   Wed Jun 5 22:38:52 2024 -0400

    Enable stream-stype serialization for Java Communication Job Router (Azure#29328)

commit d88c94b
Author: Priyanshi Jain <87351063+priyjain358@users.noreply.github.com>
Date:   Thu Jun 6 03:34:21 2024 +0530

    [Microsoft.AzureStackHCI] Add 2024-04-01 for StackHCI (Azure#29110)

    * Add 2024-04-01 for StackHCI

    * add missing properties

    * add log collection job type

    * changes in sdk suppressions

    * sdk suppression changes

commit 491e00d
Author: Dylan Martinez <martinez.dylanj@gmail.com>
Date:   Wed Jun 5 15:03:47 2024 -0700

    Update `securityPostureReference` in VMScaleSet API (Azure#28891)

    * update securityPostureRef properties in VMScaleSet spec

    * add securityPostureReference to UpdateVMProfile definition and fix min version

    * add prettier changes

    * remove unsupported 'major.*' from spec

    * add optional fields in security posture example

    * add required fields

    * correct minimum api version

    * add prettier fixes

    * remove extensionsSettings property

    * create new Update model for security posture reference & update

    * fix validation issue

    * Create sdk-suppressions.yaml

    * add azure-sdk-for-go suppression

    * Update sdk-suppressions.yaml

    ---------

    Co-authored-by: Dylan Martinez <dymartinez@microsoft.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Alancere <804873052@qq.com>
    Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>

commit d9f06f3
Author: Francisco Gamino <Francisco-Gamino@users.noreply.github.com>
Date:   Wed Jun 5 11:13:49 2024 -0700

    Update 2023-12-01 Microsoft.Web functionAppConfig definition (Azure#29226)

    * Rename enum to functionsDeploymentStorageType

    * Update enum name to camel case

    * Update enum names to camel case

commit 336fc73
Author: Jose Alvarez <jpalvarezl@users.noreply.github.com>
Date:   Wed Jun 5 18:50:53 2024 +0200

    Fixed typo in documentation (Azure#29341)

commit 32f566e
Author: Samir Solanki <samirsolanki@outlook.com>
Date:   Tue Jun 4 20:42:48 2024 -0700

    Merge release api management 2023 09 01 preview - Active (Azure#29184)

    * Adds base for updating Microsoft.ApiManagement from version preview/2023-05-01-preview to version 2023-09-01-preview

    * Updates readme

    * Updates API version in new specs and examples

    * feat(apim): Introduce gateway resource (Azure#27757)

    * WIP

    * Update sample

    * WIP

    * Add GatewayNameParameter

    * Clean up

    * Update sample

    * Add another sample

    * Add sample for delete gateway

    * Remove endpoints

    * Fix typo

    * Add list sample

    * Clean up

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Add disclaimer

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Make it pretty 💄

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Refer to new file

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Add missing ApiManagementGatewayListResult

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Update sample reference

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Remove ApiManagementGatewayIdentity + List by operation

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Add more sample

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Latest version of common types

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Remove 200 for delete

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Formatting and re-order

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Align with spec

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Align sample with spec

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Error response from common types

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Rename SKU name

    * Have seperate SKU for patch to not make it mandatory

    * Remove empty required

    * Improve note

    * Rename schema

    * Remove unused type

    * sku.capacity should not be required

    ---------

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

    * Add loggers, diagnostics, certificates and backends to workspace (Azure#27262)

    * Add loggers to workspaces

    * Add diagnostics to workspace

    * Add certificates to workspace

    * Add backends to workspaces

    * Change DiagnosticContract to DiagnosticContractProperties in patch

    * Revert back DiagnosticContractProperties to DiagnosticContract

    * Fix CI and add files to readme

    * Fix example

    * remove reconnect endpoint

    * Add suppressions

    * Try different suppression where

    * Try different suppression

    * Try other suppression

    * another test

    * finally working suppression

    * remove unwanted line

    * remove secret examples (Azure#28409)

    * Modify CircuitBreaker and BackendPool Contract (Azure#28397)

    * md cb contract

    * modify pool contract

    * correct the limits

    ---------

    Co-authored-by: Samir Solanki <samirsolanki@outlook.com>

    * Common Error Response (Azure#28408)

    * add operation statuses resource (Azure#28591)

    * add operation statuses resource

    * fix api-version

    * Add locations/operationsResults endpoint for DELETE workflow (Azure#28808)

    * add operation results

    * fix spec

    * operationresults

    * fix file name

    * feat(Workspace): Add new SkuType for Workspace (Azure#28903)

    * new skutype

    * virtualNetworkType

    * remove default from patch

    * List skus API

    * add model for sku

    * caps enums

    * feat)Gateway): Adding gateway config resource (Azure#28478)

    * added gateway config resource

    * removing Head gateway Config call

    * updates

    * resolving errors

    * trying to resolve more model validations

    * resolving some model validations

    * resolving model validations

    * resoloving delete example errors

    * Swagger Prettier

    * prettier

    * updating so patch has same response as get and put

    * removing path for gateway config

    * addressing comment

    * addressing comments

    * nit

    * path updatess

    * updating as per comments

    * Adding workspaceLinks

    * resolving some of the errors

    * resolved some errors

    * resolving some of the errors

    * resolving some more errors

    * npx prettier

    * addressing comments

    * updated based on comments

    * lint updates

    * nit updates

    ---------

    Co-authored-by: Samir Solanki <samirsolanki@outlook.com>

    * Fix generation errors (Azure#29207)

    * fix(apim): Remove duplicate ErrorResponse schema due to move to common schema

    * Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway

    * Revert "Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway"

    This reverts commit 8d4753d.

    * Remove ApiManagement Prefix for GatewayConfigConnections

    * Revert "Remove ApiManagement Prefix for GatewayConfigConnections"

    This reverts commit 3e8197f.

    * Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway

    * Create sdk-suppressions.yaml

    ---------

    Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
    Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
    Co-authored-by: Rafał Mielowski <rmielowski@microsoft.com>
    Co-authored-by: Mahsa Sadi <mahsasadi@microsoft.com>
    Co-authored-by: Vidisha Shah <102258037+vidishamsft@users.noreply.github.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

commit ceb3b7f
Author: jaclin1111 <jacobyslin@gmail.com>
Date:   Tue Jun 4 20:41:22 2024 -0700

    Update virtualMachine.json (Azure#29112)

    remove "feature in preview"

    Co-authored-by: Theodore Chang <thchan@microsoft.com>

commit 09c187c
Author: Tricia Rosario <triciapsr@gmail.com>
Date:   Tue Jun 4 20:39:42 2024 -0700

    Storage Task Assignment Swagger Updates (Azure#29050)

    * SDK team improvements

    * Report APIs contain filtering

    * PR comment add more examples

    * Fix example path

    * Fix duplicate schema issue

    ---------

    Co-authored-by: Tricia Rosario <trrosari@microsoft.com>

commit f6f50c6
Author: Sean McCullough <44180881+seanmcc-msft@users.noreply.github.com>
Date:   Tue Jun 4 17:39:18 2024 -0500

    Storage STG 94 (Azure#28327)

    * added swagger (Azure#28199)

    * [STG94] Updated STG94 Files Readme (Azure#28201)

    * added swagger

    * updated readme

    * small fix

    * added new blob swagger (Azure#28245)

    * added blob readme (Azure#28246)

    * Ran prettier on the 2024-08-04 files swagger file (Azure#28358)

    * Added AuthenticationErrorDetail to StorageError (Azure#28360)

    * NFS Share Snapshot (Azure#28362)

    * Added GetAccountInfo() API to Container and Blob level (Azure#28297)

    * Storage Error Codes for Copies (Azure#28359)

    * Revert "Storage Error Codes for Copies (Azure#28359)"

    This reverts commit 8b14ba4.

    ---------

    Co-authored-by: Tamer Sherif <69483382+tasherif-msft@users.noreply.github.com>

commit 814c367
Author: shraddhasun <128851887+shraddhasun@users.noreply.github.com>
Date:   Tue Jun 4 14:39:17 2024 -0700

    Add new api-version 2024-02-01-preview to main (Azure#29105)

    * Add 2024-02-01-preview to main

    * fix typespec errors

    * remove operations.json

    * fix linters

    * delete unusued file

    * edit readme

    * remove suppressions

    * Update specification/azurestackhci/Operations.Management/tspconfig.yaml

    Co-authored-by: Mike Harder <mharder@microsoft.com>

    * Update specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml

    Co-authored-by: Mike Harder <mharder@microsoft.com>

    * ID to id

    * remove unnecessary suppress

    * fix examples

    * copy private folder changes

    ---------

    Co-authored-by: Mike Harder <mharder@microsoft.com>

commit 1c0fd99
Author: Ralf Beckers <bexxx@users.noreply.github.com>
Date:   Tue Jun 4 22:04:04 2024 +0200

    Add v3.2 for Speech to text (3.2p2 as base) (Azure#28664)

    * Add v3.2 for Speech to text (3.2p2 as base)

    * Update swagger with new changes and updated version number

    * Update readme.md with new version

    * Added evaluation token errors

    * Revert ttl changes for transcriptions

    * Finalized api changes for GA

    * Try fix avocado error

commit f6fbf63
Author: Jose Alvarez <jpalvarezl@users.noreply.github.com>
Date:   Tue Jun 4 20:35:33 2024 +0200

    [OpenAI] [Inference] TSP definition updates for `v2024_05_01_preview` service release (Azure#29182)

    * Azure OpenAI: 2024-04-01-preview updates

    * add audio formats

    * post-merge fix incl. tool update for enum conversion to union

    * minor: spellcheck fix

    * refine duration encoding for word start/end

    * enable serialization into azure json and rename customization class name

    * Added new customBlockList filter and fields to OYD

    * Adding changes to authentication for Vector Search

    * Adjusted docs for OYD vector search auth models

    * Added missing field and retrieved documents

    * Examples added

    * corrected examples api-versions in json

    * Reformat

    * Recompile after reformat

    * PR comments: wrong plural and type precision

    * Revert added tab to service spec

    Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com>

    * Added readme entry for generated openAPI doc

    * Trying to improve folder structure

    * Removed moved and renamed generated.json files

    * Reverted last 3 commits

    * Added entry for generated.json swagger in the readme

    * Changed enum to nonExpandable

    * Ran formatter

    ---------

    Co-authored-by: Travis Wilson <travisw@microsoft.com>
    Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com>
    Co-authored-by: Shawn Fang <shafang@microsoft.com>
    Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com>

commit cb458eb
Author: Shawn Fang <45607042+mssfang@users.noreply.github.com>
Date:   Tue Jun 4 11:35:09 2024 -0700

    [OAI-Assistant] Added Missing annotation and delete unnecessary  annotation (Azure#29297)

    * fixed the error

    * npx tsp compile updates

    ---------

    Co-authored-by: Travis Wilson <travisw@microsoft.com>
    Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com>

commit fbf0006
Author: will <koyasu221b@gmail.com>
Date:   Tue Jun 4 22:32:04 2024 +0800

    RouteMatrix 2024-06-01-preview (Azure#29153)

    * first commit

    * fix

    * Add operationType

    * rename to pointType

    * fix

    * update

    * Update example

    * update

    * update description for default value

    * update description

    * Remove axleCount for RouteMatrix

    * Update vehicleSpec

    * update description

    * Update description

    * remove async result

    * Revert "remove async result"

    This reverts commit b7b2728.

    * Remove Summary

    * follow azure's convention

    * Remove Accept-Language for RouteMatrix

    * Update retention period to 24 hours

    * Add createdDateTime

    * Add suppressions

    * Update description

    ---------

    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Joel Hendrix <jhendrix@microsoft.com>

commit b77b86f
Author: Konrad Jamrozik <kojamroz@microsoft.com>
Date:   Tue Jun 4 02:58:08 2024 -0700

    Update ci-fix.md: clarify that `SDK azure-powershell` is owned by `Azure.Core`. (Azure#29318)

    * Update ci-fix.md

    * Update ci-fix.md

    * Update ci-fix.md

commit 67e8e17
Author: Konrad Jamrozik <kojamroz@microsoft.com>
Date:   Mon Jun 3 22:57:42 2024 -0700

    Add info about `SDK azure-sdk-for-*` checks and `SDK azure-powershell` to `ci-fix` doc; Clean up markdownlint rules and `ci-fix` doc. (Azure#29311)

commit ca620a2
Author: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com>
Date:   Tue Jun 4 13:54:51 2024 +0800

    Update readme.md (Azure#29313)

commit a5a01e0
Author: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com>
Date:   Tue Jun 4 11:35:03 2024 +0800

    Update readme.python.md (Azure#29309)

    * Update readme.python.md

    * Update readme.md

    ---------

    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

commit b1a1498
Author: raghumunukutla <55466801+raghumunukutla@users.noreply.github.com>
Date:   Mon Jun 3 18:33:48 2024 -0700

    Update readme.md to show up documentation for preview version (Azure#29165)

commit d687907
Author: zdelacerda-microsoft <90284189+zdelacerda-microsoft@users.noreply.github.com>
Date:   Mon Jun 3 21:33:16 2024 -0400

    Imagebuilder API Release 2024-02-01 (Azure#28896)

    * Copy files from stable/2023-07-01

    Copied the files in a separate commit.
    This allows reviewers to easily diff subsequent changes against the previous spec.

    * Update version to stable/2024-02-01

    Updated the API version from stable/2023-07-01 to stable/2024-02-01.

    * Added tag for 2024-02-01 in readme file

    * copying over 2024-02-01 changes from ADO

    * Revert "copying over 2024-02-01 changes from ADO"

    This reverts commit aa54d74.

    * adding changes from ado

    * adding autorun as custom word

    * adding autorun to custom-words.txt

    * fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error

    * fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error

    * changing type from string back to object

    * changing type from string back to object

    * Revert "changing type from string back to object"

    This reverts commit b0b5122.

    revert commit

    * Revert "fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error"

    This reverts commit 0e52ddf.

    * referencing examples file

    * writing suppression for lintdiff

    * removing userassignedidentity

    * fixing bad version mismatch

    * fixing suppression

    * prettier changes

    * fixing where syntax

    * fixing where suppress 2

    * where suppress 3

    * where supress 4

    * where suppress 5

    * suppressing entire file

commit 0031475
Author: Chenjie Shi <tadelesh.shi@live.cn>
Date:   Tue Jun 4 09:32:44 2024 +0800

     Microsoft.ScVmm TypeSpec onboarding (Azure#26644)

    * Init tsp for Microsoft.ScVmm

    * Some changes towards passing tsv

    * Updates to fix lint errors, remove unused types, regenerate examples, etc.

    * Created shareable 'force' param

    * Figured out the incantation to rename a file case-sensitively

    * Restored string bool enums.

    * Removed all examples

    * Regenerate examples

    * Updated ARM ID properties. Added script to sort output to compare with sorted old swagger

    * Additional changes.

    * Removed unused XXUpdate models, Added @secret for password,

    * Fixed Azure#8, Azure#6, #5

    * Fixed #2

    * Update swagger to be in sync with previous fixes.

    * Workaround for CloudCapacity readonly

    * Additional fixes.

    * fix ModelValidation

    * update void

    * VM Instance Update Properties changes

    * spell check and prettier validation fix

    * fix for identifier bug

    * workaround for Azure/typespec-azure#449

    * format

    * spell and prettier check improvements

    * use encodedName replace projectdName

    * Add summary annotations

    * summary

    * update kind and void

    * lro azure-async-operation

    * fix

    * tsp compilation warning

    * TypeSpec Validation fix

    * Update tspconfig.yaml

    * config change

    * Removed Read Only Property from Examples to fix Swagger ModelValidation

    * Revert Boolean to Enum with type Union in TypeSpec

    * specs-pr repo PR review changes to specs repo

    * Remove sorted json file used for comparison

    * Fix TypeSpec PR pipeline failure

    * make extendedLocation for VM Instance read and create

    * typespec validation fix

    ---------

    Co-authored-by: Will Temple <will@wtemple.net>
    Co-authored-by: Allen Zhang <allenzhang@live.com>
    Co-authored-by: Alancere <804873052@qq.com>
    Co-authored-by: Harshit Surana <hsurana@microsoft.com>

commit 12ff370
Author: Sherylueen <warmflyingheart@gmail.com>
Date:   Tue Jun 4 07:25:20 2024 +0800

    Sherylueen appcomplianceautomation microsoft.app compliance automation 2024 06 27 (Azure#28981)

    * Adds base for updating Microsoft.AppComplianceAutomation from version preview/2022-11-16-preview to version 2024-06-27

    * Updates readme

    * Updates API version in new specs and examples

    * add new stable version for Microsoft.AppComplianceAutomation

    * remove the useless example file

    * fix spell check

    * remove query in get evidence api

    * remove the singleton annotation

    * fix compile error

    * fix compile error of v56

    * fix compile error

    * fix all compile error and make the swagger align with before

    * tsp prettier

    * change scoping name

    * upgrade the commontypes from v3 to v5

    * change commonTypes version to v3

    * add service-dir

    * format tspconfig.yaml

    * modify tspconfig.yaml

    * remove custom operations

    * modify re pattern of snapshot name

    * make the resource x-ms-client-name properties

    * format typespec

    * remove suffix of snapshot

    * use requestBody replace parameters

    * Revert "use requestBody replace parameters"

    This reverts commit e4dd975.

    * tsp format

    * remove dotnet from tspconfig.yaml and add azure-sdk-for-net-track2 in readme

    * add sdk-suppressions.yaml

    * Update tspconfig.yaml

    * Update tspconfig.yaml

    * rename operationid

    * rename getScopingQuestions and move model reportBaseProperties to alias

    ---------

    Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Alancere <804873052@qq.com>
    Co-authored-by: Weidong Xu <weidxu@microsoft.com>

commit ad9955f
Author: Joanna-Yang-Art <137839107+Joanna-Yang-Art@users.noreply.github.com>
Date:   Mon Jun 3 15:57:55 2024 -0700

    Add new networking code owner (Azure#29281)

commit a58614a
Author: Libba Lawrence <llawrence@microsoft.com>
Date:   Mon Jun 3 12:44:29 2024 -0700

    [EG] System events reformat (Azure#28706)

    * refactor

    * updayrd

    * format

    * add apicenter

    * update new events

    * tsp format

    * new events

    * modelAsString for Media Union as False

    * tsp format

    * Revert "tsp format"

    This reverts commit 1a01cf8.

    * Revert "modelAsString for Media Union as False"

    This reverts commit 6b60581.

    * remove ReadOnly

    * rename resources

    * remove duplicate vault

    * remove Optional from Nullable Types part 1

    * add csharp to x-ms-client-names

    * typo

    * swagger typo

    * formatting

    * Client Name Overrides JS EG System Events

    * Adding in renames for Go

    * fix RecordingDurationMs casing

    * Fixing something that Libba refused to for like months now.

    * Removing SystemEvents from the constant names

    * Should be a number == float64.

    * Field name is labelOperator, not operator.

    (as shown here: https://github.com/Azure/azure-rest-api-specs/blob/0a8300f818c1df4018e2586540bed4c72c7c5375/specification/eventgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L2120)

    * Field is state, not selectorState:

    https://github.com/Azure/azure-rest-api-specs/blob/0a8300f818c1df4018e2586540bed4c72c7c5375/specification/eventgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json#L2171

    * More renames to bring us to par with what we had before.

    * Adding in some docs that were missing for unions.

    * format

    * fix warnigns

    * moving around clientNames

    * spellcheck

    * try to update csharp clientNames

    * tsp format

    * missing labelValue x-ms-client-name

    * format

    * nit typo

    * update csharp

    ---------

    Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com>
    Co-authored-by: ripark <ripark@microsoft.com>

commit 8713240
Author: Libba Lawrence <llawrence@microsoft.com>
Date:   Mon Jun 3 12:43:59 2024 -0700

    [EG] GA client.tsp updates (Azure#29208)

    * try this

    * ver

    * update

    * details

    * update

    * renew locks result rename

    * add new version - testing

    * remove diff

    * ga version

    * update

    * try alias

    * all operations mark as internal to allow for topic/sub customization

    * remove

    * tsp format

    * alias change

    * details

    * changes

    * after merge required regen

    * nit

    * try

    * tsp format

    * edits off of lang

    * only python

    * nit

    * Fixing some names for Go, based on Go arch feedback.

    * One more rename

    * Update specification/eventgrid/Azure.Messaging.EventGrid/client.tsp

    * fixing go diff

    * update

    * update internal

    ---------

    Co-authored-by: ripark <ripark@microsoft.com>

commit bf97382
Author: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com>
Date:   Mon Jun 3 17:44:55 2024 +0800

    Update readme.python.md (Azure#29301)

commit cd47418
Author: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com>
Date:   Mon Jun 3 10:28:33 2024 +0300

    Add Entra ID OAuthe2 token support (Azure#29032)

    * Add AAD OAuthe2 token support

    * EntraIdToken

    * Update specification/ai/HealthInsights/HealthInsights.OpenAPI/service.tsp

    Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>

    * remove suppression

    * update spec after merge

    ---------

    Co-authored-by: koen-mertens <138520871+koen-mertens@users.noreply.github.com>
    Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>

commit 92a02c9
Author: Alex Matei (Microsoft) <168020294+almat-msft@users.noreply.github.com>
Date:   Fri May 31 19:39:07 2024 -0700

    Added Common Types, Managed Identity v6  (Azure#29155)

commit f4c6c86
Author: Mark Cowlishaw <markcowl@microsoft.com>
Date:   Fri May 31 16:42:11 2024 -0700

    Fix deprecated linter reference (Azure#29294)

commit 01d1832
Author: YunsongB <39966392+YunsongB@users.noreply.github.com>
Date:   Fri May 31 11:41:41 2024 -0600

    Fix spec error for OpenAI api ver 2024-05-01-preview; (Azure#29293)

    Co-authored-by: Yunsong Bai <yunba@microsoft.com>

commit 5b4680d
Author: Jose Alvarez <jpalvarezl@users.noreply.github.com>
Date:   Fri May 31 18:46:46 2024 +0200

    Assistant SDK V2 changes (depending on the Assistant V1 PR) (Azure#29067)

    * initial commit for models in support of streaming Assistants calls

    * merge + pr feedback

    * [OpenAI] [Assistants] PR feedback (Azure#28786)

    * Adding streaming events and modified class visibilities

    * Represented the alias as a union to align better with the swagger and have a class generated

    * Adding chunk classes to be included on code emission

    * Update specification/ai/OpenAI.Assistants/streaming/events.tsp

    * Added usage models for run and runStep (Azure#28864)

    * Added usage models for run and runStep

    * Added added annotation

    * Added warning suppresion for nullable fields

    * Compiled with new models and unions

    * back ported everything to a past version. Extracted SubmitToolOutputsOptions model

    * re-compile

    * Removed toolresources for now and added warning supressions

    * Brought up to date the classes related to streaming for AssistantStreamEvent

    * Making filename mandatory uploadFile operation

    * Project compilation

    * Re-formated definitiones according to CI instructions

    * Added new service version

    * Figuring out error highlights in vscode

    * Added get method listVectorStore

    * extracted union

    * Added create vector store method

    * Adding method to get single vector store

    * Added update methods for vector store

    * Added deletion method for vector stores

    * Removed assistant specific file models and operations

    * Added operation for listing vector store files

    * Added create file for vector store method

    * Added the rest of the file operations

    * Re-structured files under vector_store

    * Reformated correctly

    * Added first operation for vector store file batch

    * Added file listing per vector store file batch

    * WIP: AssistantsApiResponseFormatOption generates as anyOf of instead of oneOf

    * corrected values for enum

    * Adjusted Assistant response object

    * Added browse azure tool call type and renamed retrieval to file_search

    * Adding models for createAssistantsOptions

    * Updated assistant update models

    * Added TruncationObject

    * Added tool_choice to run related objects

    * Added new fields to ThreadRun model

    * Added attachements and tool resources to thread and message related models

    * 2nd pass to thread and message related files

    * Renamed 'retrieva'->'file_search' added 'browse'

    * Removed deprecated file endpoints and add java customizations for code gen

    * Spellchecks

    * Added missing documentation

    * -clear

    * Renamed union

    * TSP validation check

    * Reverted nullability of fileName

    * re-compiled

    * Added new file purposes

    * Removed openapi v2 and v3 files generated with the placeholder version

    * reformating

    * Added AOAI fields for Files

    * Added missing tool_resource object to createThreadAndRunRequest

    * Updated docs and removed Browse tools for this release

    * Maded the stream events public to expose types and docs to users

    * Made stream events publics

    * PR feedback and solved one open comment left for UpdateThreadOptions

    * remove single-use options model, merge into route params directly

    * proactively add 2024-05-01-preview label

    * Removed model removed in upstream branch

    * Recompile

    * Removed 05_01 from service version enum ... for now

    * Restored example

    * Added string type to AssistantStreamEvent

    * tsp validation check

    * Duplicate doc annotation

    * Removed duplicate entries

    * Added documentation for API response formats

    * Applied formatter

    * Removed package and annotation usage causing issues in Java emitter

    * Made temperature and top_p nullable for assistant create request

    * Commented out linter rule breaking code emission

    * Corrected double dot in documentation

    * Restored linter rules for formater and adjusted definition of JSON polymorphic type

    * Cleaned up comment

    * Split out the string variants into their own union

    * tsp format

    * PR feedback

    ---------

    Co-authored-by: Travis Wilson <travisw@microsoft.com>
    Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com>

commit 4328382
Author: zhejiao <145073190+zhejiao@users.noreply.github.com>
Date:   Fri May 31 07:22:49 2024 -0700

    Review request for Microsoft.HybridCompute to add version preview/2024-05-20-preview (Azure#29070)

    * Copy files from preview/2024-03-31-preview

    Copied the files in a separate commit.
    This allows reviewers to easily diff subsequent changes against the previous spec.

    * Update version to preview/2024-05-20-preview

    Updated the API version from preview/2024-03-31-preview to preview/2024-05-20-preview.

    * Added tag for 2024-05-20-preview in readme file

    * Add more SubscriptionStatus values, ErrorDetails, BillingEndDate and Hotpatch Management Properties

    * Make prettier happy

commit 061b617
Author: Akshit Goyal <goyalakshit.ag@gmail.com>
Date:   Fri May 31 07:20:59 2024 -0700

    Add NSP API to multiple services under Microsoft.Insights RP (Azure#28680)

    * Add API and examples for NSP in ScheduledQueryRules

    * Add API and examples for NSP in DataCollectionEndpoints

    * Minor fixes for the api specs for ScheduledQueryRules and DCE

    * Add NSP API for Action Groups

    * Add new API to README.md

    * Fix examples to include right param names

    * Fix styling errors

    * Include old version in default package tag

    * Fix Swagger LintDiff validation issues

    * Resolve resource name pattern restriction for configName in NSP

    * Fix typo in param name

    * Fix LintDiff warnings and errors

    * Update spec title

    * Update README with the correct package ver

    * Rever back to original NSP swagger model

    * Update README

    * Replace 200 with 202 for reconcile

    * Update reconcile examples with 202 response

    * Fix 202 response headers for reconcile

    * Update error object ref for LintDiff validation

    * Fix LintDiff Warnings: Update swagger to use v5 types

    * Fix LintDiff warnings

    * Fix LintDiff warnings

    * Fix Prettier check

    * Resolve comments and update Data models

    * Resolve merge conflicts for README

    * Fix README

    * Create sdk-suppressions.yaml

    * Refactor NSP definitions into a common file

    * Resolve merge conflicts

    * Refactor code to use NSP Common types

    * update API paths with nsp param name

    * Fix param declaration in paths and add parameter definition

    * Change str to int accross all API examples for accessRule ver property

    ---------

    Co-authored-by: Akshit Goyal <akshitgoyal@microsoft.com>
    Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>

commit 775b4ba
Author: mmorr-msft <51933005+mmorr-msft@users.noreply.github.com>
Date:   Fri May 31 07:02:17 2024 -0700

    Create Mircosoft.VerifiedId Resource Provider public preview (Azure#28933)

    * copy verifiedid from private

    * fix latest style rules

    * rerun validate

    * change key name

    * re-run local validation

    * update examples

    * manually fix generated docs

    * trying to make it pass validation, local validation won't run

    * maybe fixed?

    * fix lists?

commit bc06df2
Author: Saurabh Chugh <saurabh.chugh0323@gmail.com>
Date:   Thu May 30 19:03:03 2024 -0700

    Getting rid of redundant credential resources in dotnet sdk (Azure#29093)

    Co-authored-by: Saurabh Chugh <saurabhchugh@microsoft.com>
    Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>

commit 9582151
Author: Weidong Xu <weidxu@microsoft.com>
Date:   Fri May 31 06:46:37 2024 +0800

    radiologyinsights, tsp-config, java on final-type of LRO (Azure#29273)

    Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>

commit dc27f9b
Author: jonathanserbent <34686049+jonathanserbent@users.noreply.github.com>
Date:   Thu May 30 15:09:34 2024 -0500

    Azure Search DataPlane 2024-07-01 (Azure#29058)

    * Copy over old spec

    * Update version to 07-01

    * Add feature spec changes

    * Update docs.microsoft.com to learn.microsoft.com

    * Use common error response instead of our own model

    * Make skillsetCount required

    * Add additional feature changes

    * update readme tags

    * Fix error in readme

    * Update Examples

    * Running Prettier

    * Running Prettier

    * Addition feature change

    * Applying Feedback

    * Apply feedback to update Description

    Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>

    * Applying feedback on vectorizerName description change

    Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>

    * Adding x-ms-client-name to RawVectorQuery

    ---------

    Co-authored-by: Jonathan Serbent <jserbent@microsoft.com>
    Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>

commit 51031c3
Author: qfai <404630507@qq.com>
Date:   Thu May 30 22:13:12 2024 +0800

    Qfai developerhub microsoft.dev hub 2024 05 01 preview (Azure#29229)

    * add iac endpoints

    * change workflow v3 to v5

    * fix module validation error

    ---------

    Co-authored-by: qfai <quke@microsoft.com>

commit ce625c0
Author: Udit Sharma <usharma6@jhu.edu>
Date:   Thu May 30 07:12:36 2024 -0700

    Add TLS 1_3 support for storage (Azure#29175)

    * Add TLS 1_3 support for storage

    * Add support for account level cold access tier

    ---------

    Co-authored-by: Udit Sharma <uditsharma@microsoft.com>

commit 7605afe
Author: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com>
Date:   Thu May 30 16:06:44 2024 +0800

    [mongocluster] update python config (Azure#29259)

    * update python config

    * java config

    ---------

    Co-authored-by: XiaofeiCao <xiaofeicao@microsoft.com>

commit fba917f
Author: Jingshu918 <138486531+Jingshu918@users.noreply.github.com>
Date:   Thu May 30 11:07:35 2024 +0800

    Add Credential Property In DynamicsCrm For New Feature (Azure#29238)

commit 34f8f3f
Author: Mike Harder <mharder@microsoft.com>
Date:   Wed May 29 17:35:07 2024 -0700

    [TypeSpecValidation/LinterRuleset] Fail if deprecated rulesets detected (Azure#29270)

commit 19b6661
Author: Mike Harder <mharder@microsoft.com>
Date:   Wed May 29 14:23:03 2024 -0700

    [TypeSpecValidation] Add tests for LinterRuleset (Azure#29267)

commit b692152
Author: Chandan Agrawal <121222832+cagrawal-msft@users.noreply.github.com>
Date:   Thu May 30 02:49:44 2024 +0530

    Updating Swagger for new xlsAccountServiceMetada EnableExtendedGroups (Azure#29142)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants