Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typos in compute. #2865

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Fix minor typos in compute. #2865

merged 1 commit into from
Apr 16, 2018

Conversation

hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Apr 12, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Apr 12, 2018

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#2

@annatisch
Copy link
Member

annatisch commented Apr 12, 2018

@hyonholee - The description says minor typos - but the API version has changed?

@AutorestCI
Copy link

AutorestCI commented Apr 12, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2276

@AutorestCI
Copy link

AutorestCI commented Apr 12, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1620

@AutorestCI
Copy link

AutorestCI commented Apr 12, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2710

@hyonholee
Copy link
Contributor Author

hyonholee commented Apr 13, 2018

@annatisch The API version is not changed. I changed only the API versions of example files, which are currently wrong. I fixed the API version of example files with correct API version values.

@annatisch
Copy link
Member

@hyonholee - the model PR_ONLY=true CI job is showing a number of model validation errors in the samples - e.g.:

error: Found errors in validating the response with statusCode "200" for x-ms-example "Create a scale set from a custom image." in operation "VirtualMachineScaleSets_CreateOrUpdate".:

{ code: 'RESPONSE_VALIDATION_ERROR',
  id: 'OAV108',
  message: 'Found errors in validating the response with statusCode "200" for x-ms-example "Create a scale set from a custom image." in operation "VirtualMachineScaleSets_CreateOrUpdate".',
  innerErrors: 
   [ { code: 'RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE',
       id: 'OAV111',
       message: 'Following response status codes "200" for operation "VirtualMachineScaleSets_CreateOrUpdate" were present in the swagger spec, however they were not present in x-ms-examples. Please provide them.' } ] }

Could you take a look?
There's also errors in the linter PR_ONLY=true job.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 137 Error(s): 0
After the PR: Warning(s): 137 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 137 Error(s): 0
After the PR: Warning(s): 137 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@hyonholee
Copy link
Contributor Author

@annatisch I updated the example files and now model PR_ONLY=true CI job passes. For linter PR_ONLY=true job, Neil will send another PR.

@hyonholee
Copy link
Contributor Author

Hi, please merge it if there is no more concern. Thanks.

@annatisch
Copy link
Member

@AutorestCI regenerate azure-sdk-for-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants