remove ArmTagsProperty from PrivateCloud #28562

cataggar · 2024-04-02T16:23:33Z

This is to fix for the current AVS API 2023-09-01 recently merged in #28023. tags is already defined as part of TrackedResource and should not be defined again. There is an internal Teams thread about this. It is causing the tooling to show every PR as a breaking change. Related issues:

azure-rest-api-specs/specification/vmware/resource-manager/Microsoft.AVS/stable/2023-09-01/vmware.json

Lines 8697 to 8731 in 9ac34f2

    
           "PrivateCloud": { 
        
             "type": "object", 
        
             "description": "A private cloud resource", 
        
             "properties": { 
        
               "properties": { 
        
                 "$ref": "#/definitions/PrivateCloudProperties", 
        
                 "description": "The resource-specific properties for this resource.", 
        
                 "x-ms-client-flatten": true, 
        
                 "x-ms-mutability": [ 
        
                   "read", 
        
                   "create" 
        
                 ] 
        
               }, 
        
               "tags": { 
        
                 "type": "object", 
        
                 "description": "Resource tags.", 
        
                 "additionalProperties": { 
        
                   "type": "string" 
        
                 } 
        
               }, 
        
               "sku": { 
        
                 "$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/Sku", 
        
                 "description": "The SKU (Stock Keeping Unit) assigned to this resource." 
        
               }, 
        
               "identity": { 
        
                 "$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/SystemAssignedServiceIdentity", 
        
                 "description": "The managed service identities assigned to this resource." 
        
               } 
        
             }, 
        
             "required": [ 
        
               "sku" 
        
             ], 
        
             "allOf": [ 
        
               { 
        
                 "$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/TrackedResource"

azure-rest-api-specs/specification/common-types/resource-management/v5/types.json

Lines 56 to 90 in 9ac34f2

    
           "TrackedResource": { 
        
             "title": "Tracked Resource", 
        
             "description": "The resource model definition for an Azure Resource Manager tracked top level resource which has 'tags' and a 'location'", 
        
             "type": "object", 
        
             "properties": { 
        
               "tags": { 
        
                 "type": "object", 
        
                 "additionalProperties": { 
        
                   "type": "string" 
        
                 }, 
        
                 "x-ms-mutability": [ 
        
                   "read", 
        
                   "create", 
        
                   "update" 
        
                 ], 
        
                 "description": "Resource tags." 
        
               }, 
        
               "location": { 
        
                 "type": "string", 
        
                 "x-ms-mutability": [ 
        
                   "read", 
        
                   "create" 
        
                 ], 
        
                 "description": "The geo-location where the resource lives" 
        
               } 
        
             }, 
        
             "required": [ 
        
               "location" 
        
             ], 
        
             "allOf": [ 
        
               { 
        
                 "$ref": "#/definitions/Resource" 
        
               } 
        
             ] 
        
           },

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-04-02T16:23:36Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-04-02T16:23:37Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` Runtime Exception	"new":"https://github.com/Azure/azure-rest-api-specs/blob/167a6d472a6923f1611debea607e0674e939c38e/specification/vmware/resource-manager/Microsoft.AVS/stable/2023-09-01/vmware.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/vmware/resource-manager/Microsoft.AVS/stable/2023-09-01/vmware.json", "details":"incompatible properties : tags "

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail]

Compared specs (v2.2.0)	new version	base version
package-2023-09-01	package-2023-09-01(167a6d4)	package-2023-09-01(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` UnSupportedPatchProperties	Mark the property 'properties.provisioningState', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L4682
`❌` UnSupportedPatchProperties	Mark the property 'properties.provisioningState', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L4994
`❌` UnSupportedPatchProperties	Mark the property 'properties.provisioningState', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L5411
`❌` UnSupportedPatchProperties	Mark the property 'properties.provisioningState', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L5969
`❌` UnSupportedPatchProperties	Mark the property 'properties.provisioningState', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L6399

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-02T16:23:37Z

Swagger Generation Artifacts

️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=423884&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 "

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded in generating from 28402c19b6bf2360516a0f89344c59a495ec58aa. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-avs [Preview SDK Changes] Breaking Change Detected

azure-arm-avs-5.0.0.tgz

Only showing 120 items here. Refer to log for details.

info	[Changelog]   - Added Interface WorkloadNetworkPortMirroringListResult
info	[Changelog]   - Added Interface WorkloadNetworkPortMirroringUpdate
info	[Changelog]   - Added Interface WorkloadNetworkPublicIPListResult
info	[Changelog]   - Added Interface WorkloadNetworksCreateDhcpHeaders
info	[Changelog]   - Added Interface WorkloadNetworksCreateDnsServiceHeaders
info	[Changelog]   - Added Interface WorkloadNetworksCreateDnsZoneHeaders
info	[Changelog]   - Added Interface WorkloadNetworksCreatePortMirroringHeaders
info	[Changelog]   - Added Interface WorkloadNetworksCreatePublicIPHeaders
info	[Changelog]   - Added Interface WorkloadNetworksCreateSegmentsHeaders
info	[Changelog]   - Added Interface WorkloadNetworksCreateVMGroupHeaders
info	[Changelog]   - Added Interface WorkloadNetworksDeleteDhcpHeaders
info	[Changelog]   - Added Interface WorkloadNetworksDeleteDnsServiceHeaders
info	[Changelog]   - Added Interface WorkloadNetworksDeleteDnsZoneHeaders
info	[Changelog]   - Added Interface WorkloadNetworksDeletePortMirroringHeaders
info	[Changelog]   - Added Interface WorkloadNetworksDeletePublicIPHeaders
info	[Changelog]   - Added Interface WorkloadNetworksDeleteSegmentHeaders
info	[Changelog]   - Added Interface WorkloadNetworksDeleteVMGroupHeaders
info	[Changelog]   - Added Interface WorkloadNetworkSegmentListResult
info	[Changelog]   - Added Interface WorkloadNetworkSegmentUpdate
info	[Changelog]   - Added Interface WorkloadNetworksUpdateDhcpHeaders
info	[Changelog]   - Added Interface WorkloadNetworksUpdateDnsServiceHeaders
info	[Changelog]   - Added Interface WorkloadNetworksUpdateDnsZoneHeaders
info	[Changelog]   - Added Interface WorkloadNetworksUpdatePortMirroringHeaders
info	[Changelog]   - Added Interface WorkloadNetworksUpdateSegmentsHeaders
info	[Changelog]   - Added Interface WorkloadNetworksUpdateVMGroupHeaders
info	[Changelog]   - Added Interface WorkloadNetworkVirtualMachineListResult
info	[Changelog]   - Added Interface WorkloadNetworkVMGroupListResult
info	[Changelog]   - Added Interface WorkloadNetworkVMGroupUpdate
info	[Changelog]   - Added Type Alias ActionType
info	[Changelog]   - Added Type Alias CloudLinkProvisioningState
info	[Changelog]   - Added Type Alias CreatedByType
info	[Changelog]   - Added Type Alias DnsZoneType
info	[Changelog]   - Added Type Alias HcxEnterpriseSiteProvisioningState
info	[Changelog]   - Added Type Alias IscsiPathProvisioningState
info	[Changelog]   - Added Type Alias IscsiPathsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias IscsiPathsGetResponse
info	[Changelog]   - Added Type Alias IscsiPathsListByPrivateCloudNextResponse
info	[Changelog]   - Added Type Alias IscsiPathsListByPrivateCloudResponse
info	[Changelog]   - Added Type Alias Origin
info	[Changelog]   - Added Type Alias PrivateCloudsRotateNsxtPasswordResponse
info	[Changelog]   - Added Type Alias PrivateCloudsRotateVcenterPasswordResponse
info	[Changelog]   - Added Type Alias ScriptCmdletAudience
info	[Changelog]   - Added Type Alias ScriptCmdletProvisioningState
info	[Changelog]   - Added Type Alias ScriptPackageProvisioningState
info	[Changelog]   - Added Type Alias SkuTier
info	[Changelog]   - Added Type Alias SystemAssignedServiceIdentityType
info	[Changelog]   - Added Type Alias VirtualMachineProvisioningState
info	[Changelog]   - Added Type Alias VirtualMachinesRestrictMovementResponse
info	[Changelog]   - Added Type Alias WorkloadNetworkDhcpEntityUpdateUnion
info	[Changelog]   - Added Type Alias WorkloadNetworkProvisioningState
info	[Changelog]   - Interface CloudLink has a new optional parameter provisioningState
info	[Changelog]   - Interface Cluster has a new optional parameter vsanDatastoreName
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter sku
info	[Changelog]   - Interface Datastore has a new optional parameter elasticSanVolume
info	[Changelog]   - Interface Endpoints has a new optional parameter hcxCloudManagerIp
info	[Changelog]   - Interface Endpoints has a new optional parameter nsxtManagerIp
info	[Changelog]   - Interface Endpoints has a new optional parameter vcenterIp
info	[Changelog]   - Interface HcxEnterpriseSite has a new optional parameter provisioningState
info	[Changelog]   - Interface ManagementCluster has a new optional parameter clusterId
info	[Changelog]   - Interface ManagementCluster has a new optional parameter clusterSize
info	[Changelog]   - Interface ManagementCluster has a new optional parameter hosts
info	[Changelog]   - Interface ManagementCluster has a new optional parameter provisioningState
info	[Changelog]   - Interface ManagementCluster has a new optional parameter vsanDatastoreName
info	[Changelog]   - Interface Operation has a new optional parameter actionType
info	[Changelog]   - Interface PrivateCloud has a new optional parameter dnsZoneType
info	[Changelog]   - Interface PrivateCloud has a new optional parameter virtualNetworkId
info	[Changelog]   - Interface PrivateCloudUpdate has a new optional parameter dnsZoneType
info	[Changelog]   - Interface PrivateCloudUpdate has a new optional parameter sku
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Interface ScriptCmdlet has a new optional parameter audience
info	[Changelog]   - Interface ScriptCmdlet has a new optional parameter provisioningState
info	[Changelog]   - Interface ScriptPackage has a new optional parameter provisioningState
info	[Changelog]   - Interface Sku has a new optional parameter capacity
info	[Changelog]   - Interface Sku has a new optional parameter family
info	[Changelog]   - Interface Sku has a new optional parameter size
info	[Changelog]   - Interface Sku has a new optional parameter tier
info	[Changelog]   - Interface VirtualMachine has a new optional parameter provisioningState
info	[Changelog]   - Interface WorkloadNetwork has a new optional parameter provisioningState
info	[Changelog]   - Interface WorkloadNetworkGateway has a new optional parameter provisioningState
info	[Changelog]   - Interface WorkloadNetworkVirtualMachine has a new optional parameter provisioningState
info	[Changelog]   - Type of parameter addonType of interface AddonProperties is changed from "SRM" | "VR" | "HCX" | "Arc" to "Arc" | "HCX" | "SRM" | "VR"
info	[Changelog]   - Type of parameter type of interface PlacementPolicyProperties is changed from "VmVm" | "VmHost" to "VmHost" | "VmVm"
info	[Changelog]   - Type of parameter type of interface ScriptExecutionParameter is changed from "SecureValue" | "Value" | "Credential" to "Credential" | "SecureValue" | "Value"
info	[Changelog]   - Type of parameter dhcpType of interface WorkloadNetworkDhcpEntity is changed from "SERVER" | "RELAY" to "RELAY" | "SERVER"
info	[Changelog]   - Added Enum KnownActionType
info	[Changelog]   - Added Enum KnownCloudLinkProvisioningState
info	[Changelog]   - Added Enum KnownCreatedByType
info	[Changelog]   - Added Enum KnownDnsZoneType
info	[Changelog]   - Added Enum KnownHcxEnterpriseSiteProvisioningState
info	[Changelog]   - Added Enum KnownIscsiPathProvisioningState
info	[Changelog]   - Added Enum KnownOrigin
info	[Changelog]   - Added Enum KnownScriptCmdletAudience
info	[Changelog]   - Added Enum KnownScriptCmdletProvisioningState
info	[Changelog]   - Added Enum KnownScriptPackageProvisioningState
info	[Changelog]   - Added Enum KnownSystemAssignedServiceIdentityType
info	[Changelog]   - Added Enum KnownVirtualMachineProvisioningState
info	[Changelog]   - Added Enum KnownWorkloadNetworkProvisioningState
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDhcp has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDhcpAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDnsService has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDnsServiceAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDnsZone has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDnsZoneAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdatePortMirroring has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdatePortMirroringAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateSegments has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateSegmentsAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateVMGroup has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateVMGroupAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.get has a new signature
info	[Changelog]   - Interface Operation no longer has parameter properties
info	[Changelog]   - Parameter location of interface TrackedResource is now required
info	[Changelog]   - Type of parameter origin of interface Operation is changed from string to Origin
info	[Changelog]   - Type of parameter identity of interface PrivateCloud is changed from PrivateCloudIdentity to SystemAssignedServiceIdentity
info	[Changelog]   - Type of parameter identity of interface PrivateCloudUpdate is changed from PrivateCloudIdentity to SystemAssignedServiceIdentity
info	[Changelog]   - Removed Enum KnownResourceIdentityType
info	[Changelog]   - Removed Enum KnownWorkloadNetworkName

Present SDK breaking changes suppressions
Interface Operation no longer has parameter properties
Operation WorkloadNetworks.beginUpdateDhcp has a new signature
Operation WorkloadNetworks.beginUpdateDhcpAndWait has a new signature
Operation WorkloadNetworks.beginUpdateDnsService has a new signature
Operation WorkloadNetworks.beginUpdateDnsServiceAndWait has a new signature
Operation WorkloadNetworks.beginUpdateDnsZone has a new signature
Operation WorkloadNetworks.beginUpdateDnsZoneAndWait has a new signature
Operation WorkloadNetworks.beginUpdatePortMirroring has a new signature
Operation WorkloadNetworks.beginUpdatePortMirroringAndWait has a new signature
Operation WorkloadNetworks.beginUpdateSegments has a new signature
Operation WorkloadNetworks.beginUpdateSegmentsAndWait has a new signature
Operation WorkloadNetworks.beginUpdateVMGroup has a new signature
Operation WorkloadNetworks.beginUpdateVMGroupAndWait has a new signature
Operation WorkloadNetworks.get has a new signature
Parameter location of interface TrackedResource is now required
Removed Enum KnownResourceIdentityType
Removed Enum KnownWorkloadNetworkName
Type of parameter identity of interface PrivateCloud is changed from PrivateCloudIdentity to SystemAssignedServiceIdentity
Type of parameter identity of interface PrivateCloudUpdate is changed from PrivateCloudIdentity to SystemAssignedServiceIdentity
Type of parameter origin of interface Operation is changed from string to Origin

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning in generating from 28402c19b6bf2360516a0f89344c59a495ec58aa. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/vmware/Microsoft.AVS/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-avs [Preview SDK Changes] Breaking Change Detected

azure-mgmt-avs-1.0.0b1.zip
azure_mgmt_avs-1.0.0b1-py3-none-any.whl

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group IscsiPathsOperations
info	[Changelog]   - Model Addon has a new parameter system_data
info	[Changelog]   - Model CloudLink has a new parameter provisioning_state
info	[Changelog]   - Model CloudLink has a new parameter system_data
info	[Changelog]   - Model Cluster has a new parameter system_data
info	[Changelog]   - Model Cluster has a new parameter vsan_datastore_name
info	[Changelog]   - Model ClusterUpdate has a new parameter sku
info	[Changelog]   - Model Datastore has a new parameter elastic_san_volume
info	[Changelog]   - Model Datastore has a new parameter system_data
info	[Changelog]   - Model Endpoints has a new parameter hcx_cloud_manager_ip
info	[Changelog]   - Model Endpoints has a new parameter nsxt_manager_ip
info	[Changelog]   - Model Endpoints has a new parameter vcenter_ip
info	[Changelog]   - Model ExpressRouteAuthorization has a new parameter system_data
info	[Changelog]   - Model GlobalReachConnection has a new parameter system_data
info	[Changelog]   - Model HcxEnterpriseSite has a new parameter provisioning_state
info	[Changelog]   - Model HcxEnterpriseSite has a new parameter system_data
info	[Changelog]   - Model ManagementCluster has a new parameter vsan_datastore_name
info	[Changelog]   - Model Operation has a new parameter action_type
info	[Changelog]   - Model PlacementPolicy has a new parameter system_data
info	[Changelog]   - Model PrivateCloud has a new parameter dns_zone_type
info	[Changelog]   - Model PrivateCloud has a new parameter system_data
info	[Changelog]   - Model PrivateCloud has a new parameter virtual_network_id
info	[Changelog]   - Model PrivateCloudUpdate has a new parameter dns_zone_type
info	[Changelog]   - Model PrivateCloudUpdate has a new parameter sku
info	[Changelog]   - Model ProxyResource has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model ScriptCmdlet has a new parameter audience
info	[Changelog]   - Model ScriptCmdlet has a new parameter provisioning_state
info	[Changelog]   - Model ScriptCmdlet has a new parameter system_data
info	[Changelog]   - Model ScriptExecution has a new parameter system_data
info	[Changelog]   - Model ScriptPackage has a new parameter provisioning_state
info	[Changelog]   - Model ScriptPackage has a new parameter system_data
info	[Changelog]   - Model Sku has a new parameter capacity
info	[Changelog]   - Model Sku has a new parameter family
info	[Changelog]   - Model Sku has a new parameter size
info	[Changelog]   - Model Sku has a new parameter tier
info	[Changelog]   - Model TrackedResource has a new parameter system_data
info	[Changelog]   - Model VirtualMachine has a new parameter provisioning_state
info	[Changelog]   - Model VirtualMachine has a new parameter system_data
info	[Changelog]   - Model WorkloadNetwork has a new parameter provisioning_state
info	[Changelog]   - Model WorkloadNetwork has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkDhcp has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkDnsService has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkDnsZone has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkGateway has a new parameter provisioning_state
info	[Changelog]   - Model WorkloadNetworkGateway has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkPortMirroring has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkPublicIP has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkSegment has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkVMGroup has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkVirtualMachine has a new parameter provisioning_state
info	[Changelog]   - Model WorkloadNetworkVirtualMachine has a new parameter system_data
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model Operation no longer has parameter properties
info	[Changelog]   - Operation WorkloadNetworksOperations.get no longer has parameter workload_network_name
info	[Changelog]   - Parameter location of model PrivateCloud is now required
info	[Changelog]   - Parameter location of model TrackedResource is now required

Present SDK breaking changes suppressions
Model Operation no longer has parameter properties
Operation WorkloadNetworksOperations.get no longer has parameter workload_network_name
Parameter location of model PrivateCloud is now required
Parameter location of model TrackedResource is now required

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded in generating from 28402c19b6bf2360516a0f89344c59a495ec58aa. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		specification/vmware/Microsoft.AVS/tspconfig.yaml skipped due to azure-sdk-for-net not found in tspconfig.yaml
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Avs [Preview SDK Changes]
- Microsoft.Azure.Management.Avs.3.0.0.nupkg
- Microsoft.Azure.Management.Avs.3.0.0.symbols.nupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded in generating from 28402c19b6bf2360516a0f89344c59a495ec58aa. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
warn		specification/vmware/Microsoft.AVS/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/avs/armavs [Preview SDK Changes] Breaking Change Detected

Only showing 120 items here. Refer to log for details.

info	[Changelog] - New enum type `ScriptCmdletProvisioningState` with values `ScriptCmdletProvisioningStateCanceled`, `ScriptCmdletProvisioningStateFailed`, `ScriptCmdletProvisioningStateSucceeded`
info	[Changelog] - New enum type `ScriptPackageProvisioningState` with values `ScriptPackageProvisioningStateCanceled`, `ScriptPackageProvisioningStateFailed`, `ScriptPackageProvisioningStateSucceeded`
info	[Changelog] - New enum type `SystemAssignedServiceIdentityType` with values `SystemAssignedServiceIdentityTypeNone`, `SystemAssignedServiceIdentityTypeSystemAssigned`
info	[Changelog] - New enum type `VirtualMachineProvisioningState` with values `VirtualMachineProvisioningStateCanceled`, `VirtualMachineProvisioningStateFailed`, `VirtualMachineProvisioningStateSucceeded`
info	[Changelog] - New enum type `WorkloadNetworkProvisioningState` with values `WorkloadNetworkProvisioningStateBuilding`, `WorkloadNetworkProvisioningStateCanceled`, `WorkloadNetworkProvisioningStateDeleting`, `WorkloadNetworkProvisioningStateFailed`, `WorkloadNetworkProvisioningStateSucceeded`, `WorkloadNetworkProvisioningStateUpdating`
info	[Changelog] - New function `*ClientFactory.NewIscsiPathsClient() *IscsiPathsClient`
info	[Changelog] - New function `NewIscsiPathsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*IscsiPathsClient, error)`
info	[Changelog] - New function `*IscsiPathsClient.BeginCreateOrUpdate(context.Context, string, string, IscsiPath, *IscsiPathsClientBeginCreateOrUpdateOptions) (*runtime.Poller[IscsiPathsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*IscsiPathsClient.BeginDelete(context.Context, string, string, *IscsiPathsClientBeginDeleteOptions) (*runtime.Poller[IscsiPathsClientDeleteResponse], error)`
info	[Changelog] - New function `*IscsiPathsClient.Get(context.Context, string, string, *IscsiPathsClientGetOptions) (IscsiPathsClientGetResponse, error)`
info	[Changelog] - New function `*IscsiPathsClient.NewListByPrivateCloudPager(string, string, *IscsiPathsClientListByPrivateCloudOptions) *runtime.Pager[IscsiPathsClientListByPrivateCloudResponse]`
info	[Changelog] - New function `*WorkloadNetworkDhcpEntityUpdate.GetWorkloadNetworkDhcpEntityUpdate() *WorkloadNetworkDhcpEntityUpdate`
info	[Changelog] - New function `*WorkloadNetworkDhcpRelayUpdate.GetWorkloadNetworkDhcpEntityUpdate() *WorkloadNetworkDhcpEntityUpdate`
info	[Changelog] - New function `*WorkloadNetworkDhcpServerUpdate.GetWorkloadNetworkDhcpEntityUpdate() *WorkloadNetworkDhcpEntityUpdate`
info	[Changelog] - New struct `AddonListResult`
info	[Changelog] - New struct `CloudLinkListResult`
info	[Changelog] - New struct `ClusterListResult`
info	[Changelog] - New struct `DatastoreListResult`
info	[Changelog] - New struct `ElasticSanVolume`
info	[Changelog] - New struct `ExpressRouteAuthorizationListResult`
info	[Changelog] - New struct `GlobalReachConnectionListResult`
info	[Changelog] - New struct `HcxEnterpriseSiteListResult`
info	[Changelog] - New struct `IscsiPath`
info	[Changelog] - New struct `IscsiPathListResult`
info	[Changelog] - New struct `IscsiPathProperties`
info	[Changelog] - New struct `OperationListResult`
info	[Changelog] - New struct `PlacementPolicyListResult`
info	[Changelog] - New struct `PrivateCloudListResult`
info	[Changelog] - New struct `ScriptCmdletListResult`
info	[Changelog] - New struct `ScriptExecutionListResult`
info	[Changelog] - New struct `ScriptPackageListResult`
info	[Changelog] - New struct `SystemAssignedServiceIdentity`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `VirtualMachineListResult`
info	[Changelog] - New struct `WorkloadNetworkDNSServiceListResult`
info	[Changelog] - New struct `WorkloadNetworkDNSServiceUpdate`
info	[Changelog] - New struct `WorkloadNetworkDNSZoneListResult`
info	[Changelog] - New struct `WorkloadNetworkDNSZoneUpdate`
info	[Changelog] - New struct `WorkloadNetworkDhcpListResult`
info	[Changelog] - New struct `WorkloadNetworkDhcpRelayUpdate`
info	[Changelog] - New struct `WorkloadNetworkDhcpServerUpdate`
info	[Changelog] - New struct `WorkloadNetworkDhcpUpdate`
info	[Changelog] - New struct `WorkloadNetworkGatewayListResult`
info	[Changelog] - New struct `WorkloadNetworkListResult`
info	[Changelog] - New struct `WorkloadNetworkPortMirroringListResult`
info	[Changelog] - New struct `WorkloadNetworkPortMirroringUpdate`
info	[Changelog] - New struct `WorkloadNetworkProperties`
info	[Changelog] - New struct `WorkloadNetworkPublicIPListResult`
info	[Changelog] - New struct `WorkloadNetworkSegmentListResult`
info	[Changelog] - New struct `WorkloadNetworkSegmentUpdate`
info	[Changelog] - New struct `WorkloadNetworkVMGroupListResult`
info	[Changelog] - New struct `WorkloadNetworkVMGroupUpdate`
info	[Changelog] - New struct `WorkloadNetworkVirtualMachineListResult`
info	[Changelog] - New field `SystemData` in struct `Addon`
info	[Changelog] - New anonymous field `AddonListResult` in struct `AddonsClientListResponse`
info	[Changelog] - New anonymous field `ExpressRouteAuthorizationListResult` in struct `AuthorizationsClientListResponse`
info	[Changelog] - New field `SystemData` in struct `CloudLink`
info	[Changelog] - New field `ProvisioningState` in struct `CloudLinkProperties`
info	[Changelog] - New anonymous field `CloudLinkListResult` in struct `CloudLinksClientListResponse`
info	[Changelog] - New field `SystemData` in struct `Cluster`
info	[Changelog] - New field `VsanDatastoreName` in struct `ClusterProperties`
info	[Changelog] - New field `SKU` in struct `ClusterUpdate`
info	[Changelog] - New anonymous field `ClusterListResult` in struct `ClustersClientListResponse`
info	[Changelog] - New field `SystemData` in struct `Datastore`
info	[Changelog] - New field `ElasticSanVolume` in struct `DatastoreProperties`
info	[Changelog] - New anonymous field `DatastoreListResult` in struct `DatastoresClientListResponse`
info	[Changelog] - New field `HcxCloudManagerIP`, `NsxtManagerIP`, `VcenterIP` in struct `Endpoints`
info	[Changelog] - New field `SystemData` in struct `ExpressRouteAuthorization`
info	[Changelog] - New field `SystemData` in struct `GlobalReachConnection`
info	[Changelog] - New anonymous field `GlobalReachConnectionListResult` in struct `GlobalReachConnectionsClientListResponse`
info	[Changelog] - New field `SystemData` in struct `HcxEnterpriseSite`
info	[Changelog] - New field `ProvisioningState` in struct `HcxEnterpriseSiteProperties`
info	[Changelog] - New anonymous field `HcxEnterpriseSiteListResult` in struct `HcxEnterpriseSitesClientListResponse`
info	[Changelog] - New field `VsanDatastoreName` in struct `ManagementCluster`
info	[Changelog] - New field `ActionType` in struct `Operation`
info	[Changelog] - New anonymous field `OperationListResult` in struct `OperationsClientListResponse`
info	[Changelog] - New anonymous field `PlacementPolicyListResult` in struct `PlacementPoliciesClientListResponse`
info	[Changelog] - New field `SystemData` in struct `PlacementPolicy`
info	[Changelog] - New field `SystemData` in struct `PrivateCloud`
info	[Changelog] - New field `DNSZoneType`, `VirtualNetworkID` in struct `PrivateCloudProperties`
info	[Changelog] - New field `SKU` in struct `PrivateCloudUpdate`
info	[Changelog] - New field `DNSZoneType` in struct `PrivateCloudUpdateProperties`
info	[Changelog] - New anonymous field `PrivateCloudListResult` in struct `PrivateCloudsClientListInSubscriptionResponse`
info	[Changelog] - New anonymous field `PrivateCloudListResult` in struct `PrivateCloudsClientListResponse`
info	[Changelog] - New field `Capacity`, `Family`, `Size`, `Tier` in struct `SKU`
info	[Changelog] - New field `SystemData` in struct `ScriptCmdlet`
info	[Changelog] - New field `Audience`, `ProvisioningState` in struct `ScriptCmdletProperties`
info	[Changelog] - New anonymous field `ScriptCmdletListResult` in struct `ScriptCmdletsClientListResponse`
info	[Changelog] - New field `SystemData` in struct `ScriptExecution`
info	[Changelog] - New anonymous field `ScriptExecutionListResult` in struct `ScriptExecutionsClientListResponse`
info	[Changelog] - New field `SystemData` in struct `ScriptPackage`
info	[Changelog] - New field `ProvisioningState` in struct `ScriptPackageProperties`
info	[Changelog] - New anonymous field `ScriptPackageListResult` in struct `ScriptPackagesClientListResponse`
info	[Changelog] - New field `SystemData` in struct `VirtualMachine`
info	[Changelog] - New field `ProvisioningState` in struct `VirtualMachineProperties`
info	[Changelog] - New anonymous field `VirtualMachineListResult` in struct `VirtualMachinesClientListResponse`
info	[Changelog] - New field `Properties`, `SystemData` in struct `WorkloadNetwork`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkDNSService`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkDNSZone`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkDhcp`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkGateway`
info	[Changelog] - New field `ProvisioningState` in struct `WorkloadNetworkGatewayProperties`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkPortMirroring`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkPublicIP`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkSegment`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkVMGroup`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkVirtualMachine`
info	[Changelog] - New field `ProvisioningState` in struct `WorkloadNetworkVirtualMachineProperties`
info	[Changelog] - New anonymous field `WorkloadNetworkDNSServiceListResult` in struct `WorkloadNetworksClientListDNSServicesResponse`
info	[Changelog] - New anonymous field `WorkloadNetworkDNSZoneListResult` in struct `WorkloadNetworksClientListDNSZonesResponse`
info	[Changelog] - New anonymous field `WorkloadNetworkDhcpListResult` in struct `WorkloadNetworksClientListDhcpResponse`
info	[Changelog] - New anonymous field `WorkloadNetworkGatewayListResult` in struct `WorkloadNetworksClientListGatewaysResponse`
info	[Changelog] - New anonymous field `WorkloadNetworkPortMirroringListResult` in struct `WorkloadNetworksClientListPortMirroringResponse`
info	[Changelog] - New anonymous field `WorkloadNetworkPublicIPListResult` in struct `WorkloadNetworksClientListPublicIPsResponse`
info	[Changelog] - New anonymous field `WorkloadNetworkListResult` in struct `WorkloadNetworksClientListResponse`
info	[Changelog] - New anonymous field `WorkloadNetworkSegmentListResult` in struct `WorkloadNetworksClientListSegmentsResponse`
info	[Changelog] - New anonymous field `WorkloadNetworkVMGroupListResult` in struct `WorkloadNetworksClientListVMGroupsResponse`
info	[Changelog] - New anonymous field `WorkloadNetworkVirtualMachineListResult` in struct `WorkloadNetworksClientListVirtualMachinesResponse`
info	[Changelog]
info	[Changelog] Total 100 breaking change(s), 213 additive change(s).

Present SDK breaking changes suppressions
Enum `ResourceIdentityType` has been removed
Enum `WorkloadNetworkName` has been removed
Field `AddonList` of struct `AddonsClientListResponse` has been removed
Field `CloudLinkList` of struct `CloudLinksClientListResponse` has been removed
Field `ClusterList` of struct `ClustersClientListResponse` has been removed
Field `DatastoreList` of struct `DatastoresClientListResponse` has been removed
Field `ExpressRouteAuthorizationList` of struct `AuthorizationsClientListResponse` has been removed
Field `GlobalReachConnectionList` of struct `GlobalReachConnectionsClientListResponse` has been removed
Field `HcxEnterpriseSiteList` of struct `HcxEnterpriseSitesClientListResponse` has been removed
Field `OperationList` of struct `OperationsClientListResponse` has been removed
Field `PlacementPoliciesList` of struct `PlacementPoliciesClientListResponse` has been removed
Field `PrivateCloudList` of struct `PrivateCloudsClientListInSubscriptionResponse` has been removed
Field `PrivateCloudList` of struct `PrivateCloudsClientListResponse` has been removed
Field `Properties` of struct `Operation` has been removed
Field `ScriptCmdletsList` of struct `ScriptCmdletsClientListResponse` has been removed
Field `ScriptExecutionsList` of struct `ScriptExecutionsClientListResponse` has been removed
Field `ScriptPackagesList` of struct `ScriptPackagesClientListResponse` has been removed
Field `VirtualMachinesList` of struct `VirtualMachinesClientListResponse` has been removed
Field `WorkloadNetworkDNSServicesList` of struct `WorkloadNetworksClientListDNSServicesResponse` has been removed
Field `WorkloadNetworkDNSZonesList` of struct `WorkloadNetworksClientListDNSZonesResponse` has been removed
Field `WorkloadNetworkDhcpList` of struct `WorkloadNetworksClientListDhcpResponse` has been removed
Field `WorkloadNetworkGatewayList` of struct `WorkloadNetworksClientListGatewaysResponse` has been removed
Field `WorkloadNetworkList` of struct `WorkloadNetworksClientListResponse` has been removed
Field `WorkloadNetworkPortMirroringList` of struct `WorkloadNetworksClientListPortMirroringResponse` has been removed
Field `WorkloadNetworkPublicIPsList` of struct `WorkloadNetworksClientListPublicIPsResponse` has been removed
Field `WorkloadNetworkSegmentsList` of struct `WorkloadNetworksClientListSegmentsResponse` has been removed
Field `WorkloadNetworkVMGroupsList` of struct `WorkloadNetworksClientListVMGroupsResponse` has been removed
Field `WorkloadNetworkVirtualMachinesList` of struct `WorkloadNetworksClientListVirtualMachinesResponse` has been removed
Function `*WorkloadNetworksClient.BeginUpdateDNSService` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkDNSService, *WorkloadNetworksClientBeginUpdateDNSServiceOptions)` to `(context.Context, string, string, string, WorkloadNetworkDNSServiceUpdate, *WorkloadNetworksClientBeginUpdateDNSServiceOptions)`
Function `*WorkloadNetworksClient.BeginUpdateDNSZone` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkDNSZone, *WorkloadNetworksClientBeginUpdateDNSZoneOptions)` to `(context.Context, string, string, string, WorkloadNetworkDNSZoneUpdate, *WorkloadNetworksClientBeginUpdateDNSZoneOptions)`
Function `*WorkloadNetworksClient.BeginUpdateDhcp` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkDhcp, *WorkloadNetworksClientBeginUpdateDhcpOptions)` to `(context.Context, string, string, string, WorkloadNetworkDhcpUpdate, *WorkloadNetworksClientBeginUpdateDhcpOptions)`
Function `*WorkloadNetworksClient.BeginUpdatePortMirroring` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkPortMirroring, *WorkloadNetworksClientBeginUpdatePortMirroringOptions)` to `(context.Context, string, string, string, WorkloadNetworkPortMirroringUpdate, *WorkloadNetworksClientBeginUpdatePortMirroringOptions)`
Function `*WorkloadNetworksClient.BeginUpdateSegments` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkSegment, *WorkloadNetworksClientBeginUpdateSegmentsOptions)` to `(context.Context, string, string, string, WorkloadNetworkSegmentUpdate, *WorkloadNetworksClientBeginUpdateSegmentsOptions)`
Function `*WorkloadNetworksClient.BeginUpdateVMGroup` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkVMGroup, *WorkloadNetworksClientBeginUpdateVMGroupOptions)` to `(context.Context, string, string, string, WorkloadNetworkVMGroupUpdate, *WorkloadNetworksClientBeginUpdateVMGroupOptions)`
Function `*WorkloadNetworksClient.Get` parameter(s) have been changed from `(context.Context, string, string, WorkloadNetworkName, *WorkloadNetworksClientGetOptions)` to `(context.Context, string, string, *WorkloadNetworksClientGetOptions)`
Struct `AddonList` has been removed
Struct `CloudLinkList` has been removed
Struct `ClusterList` has been removed
Struct `DatastoreList` has been removed
Struct `ExpressRouteAuthorizationList` has been removed
Struct `GlobalReachConnectionList` has been removed
Struct `HcxEnterpriseSiteList` has been removed
Struct `LogSpecification` has been removed
Struct `MetricDimension` has been removed
Struct `MetricSpecification` has been removed
Struct `OperationList` has been removed
Struct `OperationProperties` has been removed
Struct `PlacementPoliciesList` has been removed
Struct `PrivateCloudIdentity` has been removed
Struct `PrivateCloudList` has been removed
Struct `ScriptCmdletsList` has been removed
Struct `ScriptExecutionsList` has been removed
Struct `ScriptPackagesList` has been removed
Struct `ServiceSpecification` has been removed
Struct `VirtualMachinesList` has been removed
Struct `WorkloadNetworkDNSServicesList` has been removed
Struct `WorkloadNetworkDNSZonesList` has been removed
Struct `WorkloadNetworkDhcpList` has been removed
Struct `WorkloadNetworkGatewayList` has been removed
Struct `WorkloadNetworkList` has been removed
Struct `WorkloadNetworkPortMirroringList` has been removed
Struct `WorkloadNetworkPublicIPsList` has been removed
Struct `WorkloadNetworkSegmentsList` has been removed
Struct `WorkloadNetworkVMGroupsList` has been removed
Struct `WorkloadNetworkVirtualMachinesList` has been removed
Type of `Operation.Origin` has been changed from `*string` to `*Origin`
Type of `PrivateCloud.Identity` has been changed from `*PrivateCloudIdentity` to `*SystemAssignedServiceIdentity`
Type of `PrivateCloudUpdate.Identity` has been changed from `*PrivateCloudIdentity` to `*SystemAssignedServiceIdentity`
Type of `WorkloadNetworkDNSZoneProperties.DNSServices` has been changed from `*int64` to `*int32`
Type of `WorkloadNetworkDhcpServer.LeaseTime` has been changed from `*int64` to `*int32`

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning in generating from 28402c19b6bf2360516a0f89344c59a495ec58aa. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-avs [Preview SDK Changes]
- pom.xml
- azure-resourcemanager-avs-1.2.0-beta.1-sources.jar
- azure-resourcemanager-avs-1.2.0-beta.1.jar

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning in generating from 28402c19b6bf2360516a0f89344c59a495ec58aa. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.5.2` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️vmware [Preview Schema Changes]

️⚠️ azure-powershell warning [Detail]

⚠️Warning in generating from 28402c19b6bf2360516a0f89344c59a495ec58aa. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
warn		specification/vmware/Microsoft.AVS/tspconfig.yaml skipped due to azure-powershell not found in tspconfig.yaml
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.vmware.DefaultTag [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-02T16:23:37Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/avs/armavs	https://apiview.dev/Assemblies/Review/002d4025b23b4299a8d5ac660d16826d?revisionId=b7354e6c71154da7bb6c4f8ae0dcdca3
Java	azure-resourcemanager-avs	https://apiview.dev/Assemblies/Review/ab655a3669ab4e108f3d5b0376655237?revisionId=b273692d800f432793b63cb7bdaacb5f
JavaScript	@azure/arm-avs	https://apiview.dev/Assemblies/Review/993c23ef90ad48f1a7e3dba3509092d5?revisionId=dd4d24fe4bd7470ea54b04c8e2d69d78
TypeSpec	Microsoft.AVS	https://apiview.dev/Assemblies/Review/b636962f14194499812c6df83e4356be?revisionId=f68f69d5405444bb881830a817f9b426
Swagger	Microsoft.AVS	https://apiview.dev/Assemblies/Review/dd22cc1e4e82435faa6fcd5d1735979f?revisionId=6a2915ae145442fda69fc43423589f28

cataggar · 2024-04-03T14:45:13Z

Position 26 of 31 in the ARM review queue.

cataggar · 2024-04-05T21:26:18Z

Position 19 of 33 in ARM review queue.

cataggar · 2024-04-09T12:55:40Z

Position 21 of 48.

cataggar · 2024-04-10T16:31:16Z

Position 17 of 51.

cataggar · 2024-04-12T16:05:09Z

ARM Review queue took 7 business days. Just waiting for BreakingChange-Go-Sdk-Suppression-Approved now.

cataggar · 2024-04-15T14:49:54Z

/pr RequestMerge

* remove ArmTagsProperty from PrivateCloud * Create sdk-suppressions.yaml * azure-sdk-for-go suppression * Update sdk-suppressions.yaml --------- Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Alancere <804873052@qq.com> Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>

remove ArmTagsProperty from PrivateCloud

75bbfae

This was referenced Apr 2, 2024

[AutoPR vmware] remove ArmTagsProperty from PrivateCloud azure-sdk/azure-resource-manager-schemas#4573

Draft

[AutoPR sdk/resourcemanager/avs/armavs] remove ArmTagsProperty from PrivateCloud azure-sdk/azure-sdk-for-go#9526

Closed

azure-sdk added the BreakingChange-Go-Sdk label Apr 2, 2024

This was referenced Apr 2, 2024

[AutoPR Microsoft.Azure.Management.Avs] remove ArmTagsProperty from PrivateCloud azure-sdk/azure-sdk-for-net#7639

Closed

[AutoPR @azure/arm-avs] remove ArmTagsProperty from PrivateCloud azure-sdk/azure-sdk-for-js#9406

Closed

azure-sdk added the BreakingChange-JavaScript-Sdk label Apr 2, 2024

This was referenced Apr 2, 2024

[AutoPR azure-resourcemanager-avs] remove ArmTagsProperty from PrivateCloud azure-sdk/azure-sdk-for-java#10054

Closed

[AutoPR azure-mgmt-avs] remove ArmTagsProperty from PrivateCloud azure-sdk/azure-sdk-for-python#6787

Closed

azure-sdk added the BreakingChange-Python-Sdk label Apr 2, 2024

azure-sdk mentioned this pull request Apr 2, 2024

[AutoPR Az.vmware.DefaultTag] remove ArmTagsProperty from PrivateCloud azure-sdk/azure-powershell#6265

Closed

JeffreyRichter added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label Apr 2, 2024

Merge branch 'main' into ArmTagsProperty

8e5e2a3

gary-x-li added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 12, 2024

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 12, 2024

Create sdk-suppressions.yaml

4e23b57

openapi-pipeline-app bot added the BreakingChange-Python-Sdk-Suppression label Apr 12, 2024

azure-sdk removed the BreakingChange-Python-Sdk label Apr 12, 2024

azure-sdk-for-go suppression

6e6f726

openapi-pipeline-app bot added the BreakingChange-Go-Sdk-Suppression label Apr 12, 2024

azure-sdk removed the BreakingChange-Go-Sdk label Apr 12, 2024

Update sdk-suppressions.yaml

167a6d4

openapi-pipeline-app bot added the BreakingChange-JavaScript-Sdk-Suppression label Apr 12, 2024

qiaozha added the BreakingChange-JavaScript-Sdk-Suppression-Approved label Apr 12, 2024

azure-sdk removed the BreakingChange-JavaScript-Sdk label Apr 12, 2024

msyyc added the BreakingChange-Python-Sdk-Suppression-Approved label Apr 12, 2024

raych1 added the BreakingChange-Go-Sdk-Suppression-Approved label Apr 15, 2024

microsoft-github-policy-service bot added the MergeRequested label Apr 15, 2024

raosuhas approved these changes Apr 15, 2024

View reviewed changes

raosuhas merged commit e934daa into Azure:main Apr 15, 2024
30 of 32 checks passed

cataggar deleted the ArmTagsProperty branch April 15, 2024 19:37

raych1 mentioned this pull request Apr 19, 2024

ARM labels are reset in the spec pull request with newly added SDK suppression file Azure/azure-sdk-tools#8130

Closed

tadelesh mentioned this pull request Sep 26, 2024

[Release] sdk/resourcemanager/avs/armavs/2.0.0 Azure/azure-sdk-for-go#23502

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove ArmTagsProperty from PrivateCloud #28562

remove ArmTagsProperty from PrivateCloud #28562

cataggar commented Apr 2, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 2, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 2, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 2, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 2, 2024 •

edited

Loading

cataggar commented Apr 3, 2024

cataggar commented Apr 5, 2024

cataggar commented Apr 9, 2024 •

edited

Loading

cataggar commented Apr 10, 2024

cataggar commented Apr 12, 2024 •

edited

Loading

cataggar commented Apr 15, 2024

	"PrivateCloud": {
	"type": "object",
	"description": "A private cloud resource",
	"properties": {
	"properties": {
	"$ref": "#/definitions/PrivateCloudProperties",
	"description": "The resource-specific properties for this resource.",
	"x-ms-client-flatten": true,
	"x-ms-mutability": [
	"read",
	"create"
	]
	},
	"tags": {
	"type": "object",
	"description": "Resource tags.",
	"additionalProperties": {
	"type": "string"
	}
	},
	"sku": {
	"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/Sku",
	"description": "The SKU (Stock Keeping Unit) assigned to this resource."
	},
	"identity": {
	"$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/SystemAssignedServiceIdentity",
	"description": "The managed service identities assigned to this resource."
	}
	},
	"required": [
	"sku"
	],
	"allOf": [
	{
	"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/TrackedResource"

	"TrackedResource": {
	"title": "Tracked Resource",
	"description": "The resource model definition for an Azure Resource Manager tracked top level resource which has 'tags' and a 'location'",
	"type": "object",
	"properties": {
	"tags": {
	"type": "object",
	"additionalProperties": {
	"type": "string"
	},
	"x-ms-mutability": [
	"read",
	"create",
	"update"
	],
	"description": "Resource tags."
	},
	"location": {
	"type": "string",
	"x-ms-mutability": [
	"read",
	"create"
	],
	"description": "The geo-location where the resource lives"
	}
	},
	"required": [
	"location"
	],
	"allOf": [
	{
	"$ref": "#/definitions/Resource"
	}
	]
	},

remove ArmTagsProperty from PrivateCloud #28562

remove ArmTagsProperty from PrivateCloud #28562

Conversation

cataggar commented Apr 2, 2024 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Apr 2, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Apr 2, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 2, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Apr 2, 2024 • edited Loading

Generated ApiView

cataggar commented Apr 3, 2024

cataggar commented Apr 5, 2024

cataggar commented Apr 9, 2024 • edited Loading

cataggar commented Apr 10, 2024

cataggar commented Apr 12, 2024 • edited Loading

cataggar commented Apr 15, 2024

cataggar commented Apr 2, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 2, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 2, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 2, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 2, 2024 •

edited

Loading

cataggar commented Apr 9, 2024 •

edited

Loading

cataggar commented Apr 12, 2024 •

edited

Loading