Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Eviction Policy Property for VirtualMachineScaleSetVMProfile for version 2017-12-01 #2836

Merged
merged 2 commits into from
Apr 9, 2018
Merged

Added Eviction Policy Property for VirtualMachineScaleSetVMProfile for version 2017-12-01 #2836

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab26646
comit
mahajanudit-microsoft Apr 8, 2018
57858e7
Changed evictionpolicy modelasstring to true
mahajanudit-microsoft Apr 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions specification/compute/resource-manager/Microsoft.Compute/stable/2017-12-01/compute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6915,6 +6915,18 @@
"name": "VirtualMachinePriorityTypes",
"modelAsString": true
}
},
"evictionPolicy": {
"type": "string",
"description": "Specifies the eviction policy for virtual machines in the low priority scale set. <br><br>Minimum api-version: 2017-10-30-preview",
"enum": [
"Deallocate",
"Delete"
],
"x-ms-enum": {
"name": "VirtualMachineEvictionPolicyTypes",
"modelAsString": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking modelAsString as false can cause breaking changes if new enum types are added. Please reconsider this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will change it to true then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}
}
},
"description": "Describes a virtual machine scale set virtual machine profile."
Expand Down