Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Local and Virtual Gateway Examples #2833

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Add Local and Virtual Gateway Examples #2833

merged 2 commits into from
Apr 10, 2018

Conversation

markjbrown
Copy link
Contributor

@markjbrown markjbrown commented Apr 6, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI AutorestCI mentioned this pull request Apr 6, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 6, 2018 •
edited
Loading

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#22

@AutorestCI
Copy link

AutorestCI commented Apr 6, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2610

This was referenced Apr 6, 2018
Merged
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 6, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2376

@AutorestCI AutorestCI mentioned this pull request Apr 6, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 6, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1491

sergey-shandar
sergey-shandar suggested changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markjbrown The PR contains breaking changes in a stable spec.

...tion/network/resource-manager/Microsoft.Network/stable/2018-02-01/virtualNetworkGateway.json Outdated
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/setvpnclientipsecparameters": {
"post": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markjbrown why is this operation removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dug into this and apparently the examples were written against 2018-01-01 and not the latest version. I will go back and apply the example updates to 2018-02-01. Is there a way to update just this file in the current PR or should I cancel this PR and resubmit? Thanks.

...tion/network/resource-manager/Microsoft.Network/stable/2018-02-01/virtualNetworkGateway.json Outdated
@@ -1639,13 +1619,6 @@
},
"description": "VpnClientProtocols for Virtual network gateway."
},
"vpnClientIpsecPolicies": {
"type": "array",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here.

...tion/network/resource-manager/Microsoft.Network/stable/2018-02-01/virtualNetworkGateway.json Outdated
"AES256",
"GCMAES256",
"GCMAES128"
"AES256"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This's breaking changes.

...tion/network/resource-manager/Microsoft.Network/stable/2018-02-01/virtualNetworkGateway.json Outdated
"SHA384",
"GCMAES256",
"GCMAES128"
"SHA384"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This's breaking changes.

...tion/network/resource-manager/Microsoft.Network/stable/2018-02-01/virtualNetworkGateway.json Outdated
@@ -2273,136 +2240,6 @@
],
"description": "An IPSec Policy configuration for a virtual network gateway connection"
},
"VpnClientIPsecParameters": {
"properties": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes.

@markjbrown
Copy link
Contributor Author

@sergey-shandar I've updated the PR with the fix for the breaking changes. Can you review? Thanks.

@sergey-shandar sergey-shandar merged commit 3b0a560 into Azure:master Apr 10, 2018
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 81
After the PR: Warning(s): 0 Error(s): 80

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 81
After the PR: Warning(s): 0 Error(s): 82

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@markjbrown
Copy link
Contributor Author

Reviewed the errors above. I plan on addressing the missing examples next month. The PM who created these started with the 2018-01-01 version which did not have SetVpnclientIpsecParameters and GetVpnclientIpsecParameters operations in them. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@DeepakRajendranMsft DeepakRajendranMsft Awaiting requested review from DeepakRajendranMsft

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@sergey-shandar sergey-shandar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markjbrown @AutorestCI @azuresdkciprbot @sergey-shandar