-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add paths to suppression #28271
Closed
Closed
add paths to suppression #28271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR validation pipeline restarted successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Swagger Validation Report
|
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/b6ad3dd4a2696511a436abcacd81a064dae042f4/specification/vmware/resource-manager/Microsoft.AVS/stable/2023-09-01/vmware.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/vmware/resource-manager/Microsoft.AVS/stable/2023-03-01/vmware.json", "details":"incompatible properties : tags " |
The following breaking changes are detected by comparison with the latest preview version:
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/b6ad3dd4a2696511a436abcacd81a064dae042f4/specification/vmware/resource-manager/Microsoft.AVS/stable/2023-09-01/vmware.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/vmware/resource-manager/Microsoft.AVS/preview/2021-01-01-preview/vmware.json", "details":"incompatible properties : tags " |
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.0) | new version | base version |
---|---|---|
default | default(b6ad3dd) | default(AVS/suppression) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
XmsClientName |
Value of 'x-ms-client-name' cannot be the same as 'privateCloud' Property/Model. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L390 |
docLinkLocale |
The documentation link in the description contains locale info, please change it to the link without locale. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L398 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L470 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:name. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L470 |
LroPatch202 |
The async patch operation should return 202. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L475 |
XmsClientName |
Value of 'x-ms-client-name' cannot be the same as 'addon' Property/Model. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L728 |
docLinkLocale |
The documentation link in the description contains locale info, please change it to the link without locale. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L736 |
XmsClientName |
Value of 'x-ms-client-name' cannot be the same as 'authorization' Property/Model. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L993 |
docLinkLocale |
The documentation link in the description contains locale info, please change it to the link without locale. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1001 |
XmsClientName |
Value of 'x-ms-client-name' cannot be the same as 'cloudLink' Property/Model. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1249 |
docLinkLocale |
The documentation link in the description contains locale info, please change it to the link without locale. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1257 |
XmsClientName |
Value of 'x-ms-client-name' cannot be the same as 'cluster' Property/Model. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1505 |
docLinkLocale |
The documentation link in the description contains locale info, please change it to the link without locale. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1513 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:name. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1590 |
LroPatch202 |
The async patch operation should return 202. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1595 |
XmsClientName |
Value of 'x-ms-client-name' cannot be the same as 'datastore' Property/Model. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1868 |
docLinkLocale |
The documentation link in the description contains locale info, please change it to the link without locale. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1876 |
XmsClientName |
Value of 'x-ms-client-name' cannot be the same as 'placementPolicy' Property/Model. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2214 |
docLinkLocale |
The documentation link in the description contains locale info, please change it to the link without locale. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2222 |
ConsistentPatchProperties |
The property 'properties.vmMembers' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2307 |
ConsistentPatchProperties |
The property 'properties.hostMembers' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2307 |
ConsistentPatchProperties |
The property 'properties.affinityStrength' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2307 |
ConsistentPatchProperties |
The property 'properties.azureHybridBenefitType' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2307 |
XmsClientName |
Value of 'x-ms-client-name' cannot be the same as 'globalReachConnection' Property/Model. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2771 |
docLinkLocale |
The documentation link in the description contains locale info, please change it to the link without locale. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2779 |
XmsClientName |
Value of 'x-ms-client-name' cannot be the same as 'hcxEnterpriseSite' Property/Model. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3027 |
docLinkLocale |
The documentation link in the description contains locale info, please change it to the link without locale. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3035 |
EvenSegmentedPathForPutOperation |
API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments). Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3168 |
XmsClientName |
Value of 'x-ms-client-name' cannot be the same as 'scriptExecution' Property/Model. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3656 |
docLinkLocale |
The documentation link in the description contains locale info, please change it to the link without locale. Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3664 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Mar 15, 2024
This was referenced Mar 15, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI-BreakingChange-Go
CI-BreakingChange-JavaScript
CI-BreakingChange-Python
resource-manager
TypeSpec
Authored with TypeSpec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #28023 feedback.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.