Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft.ConfidentialLedger] Add new version preview/2024-03-07-preview #28133

Conversation

andpiccione
Copy link
Member

@andpiccione andpiccione commented Mar 7, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason.
    Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

Purpose of this PR: add a new optional enum property EnclavePlatform to the ARM REST API specifications for Managed CCF.

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Mar 7, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

Copy link

openapi-pipeline-app bot commented Mar 7, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 14 Errors, 7 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
confidentialledger.json 2024-03-07-preview(d0b4302) 2022-05-13(main)
confidentialledger.json 2024-03-07-preview(d0b4302) 2023-06-28-preview(main)
managedccf.json 2024-03-07-preview(d0b4302) 2023-06-28-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L832:7
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L677:7
1034 - AddedRequiredProperty The new version has new required property 'location' that was not found in the old version.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L144:13
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L144:13
1034 - AddedRequiredProperty The new version has new required property 'location' that was not found in the old version.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L235:13
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L235:13
1034 - AddedRequiredProperty The new version has new required property 'location' that was not found in the old version.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L243:13
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L243:13
1034 - AddedRequiredProperty The new version has new required property 'location' that was not found in the old version.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L292:13
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L289:13
1034 - AddedRequiredProperty The new version has new required property 'location' that was not found in the old version.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L300:13
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L297:13
1034 - AddedRequiredProperty The new version has new required property 'location' that was not found in the old version.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L846:11
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L691:11
1034 - AddedRequiredProperty The new version has new required property 'location' that was not found in the old version.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L824:5
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L663:5
1037 - ConstraintIsWeaker The new version has a less constraining 'minLength' value than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L127:9
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L127:9
1037 - ConstraintIsWeaker The new version has a less constraining 'minLength' value than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L169:9
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L169:9
1037 - ConstraintIsWeaker The new version has a less constraining 'minLength' value than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L217:9
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L217:9
1037 - ConstraintIsWeaker The new version has a less constraining 'minLength' value than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L274:9
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L271:9
1037 - ConstraintIsWeaker The new version has a less constraining 'minLength' value than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L329:9
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L326:9
1037 - ConstraintIsWeaker The new version has a less constraining 'minLength' value than the previous one.
New: common-types/resource-management/v3/types.json#L638:5
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L710:5
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L144:13
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L144:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L235:13
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L235:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L243:13
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L243:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L292:13
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L289:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L300:13
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L297:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L846:11
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L691:11
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L824:5
Old: Microsoft.ConfidentialLedger/stable/2022-05-13/confidentialledger.json#L663:5
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-preview-2024-03 package-preview-2024-03(d0b4302) default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L54
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L144
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L161
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L187
RepeatedPathInfo The 'ledgerName' already appears in the path, please don't repeat it in the request body.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L227
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L243
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L249
PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L266
UnSupportedPatchProperties Mark the property 'properties.provisioningState', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L287
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L292
LroPatch202 The async patch operation should return 202.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L297
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L300
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L455
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L511
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L62
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L79
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L105
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L124
ResponseSchemaSpecifiedForSuccessStatusCode The 201 success status code has missing response schema. 200 and 201 success status codes for an ARM PUT operation must have a response schema specified.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L124
RepeatedPathInfo The 'appName' already appears in the path, please don't repeat it in the request body.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L145
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L161
LroStatusCodesReturnTypeSchema 200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'ManagedCCF_Create', Response code: '201'
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L165
UnSupportedPatchProperties Mark the property 'properties.provisioningState', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L202
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:nodeCount.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L207
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L207
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L215
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L219
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L370
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/managedccf.json#L426
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ConfidentialLedger/preview/2024-03-07-preview/confidentialledger.json#L47
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Mar 7, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed in generating from 637d6d06c813358a40baf79cd59f25bd3ef1288f. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to packe sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • Azure.ResourceManager.ConfidentialLedger [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.ConfidentialLedger.ConfidentialLedgerExtensions' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.ConfidentialLedger.ConfidentialLedgerResource' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.ConfidentialLedger.Models.AadBasedSecurityPrincipal' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.ConfidentialLedger.Models.CertBasedSecurityPrincipal' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.ConfidentialLedger.Models.ConfidentialLedgerNameAvailabilityContent' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.ConfidentialLedger.Models.ConfidentialLedgerNameAvailabilityResult' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.ConfidentialLedger.Models.ConfidentialLedgerNameUnavailableReason' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.ConfidentialLedger.Models.ConfidentialLedgerProperties' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.ConfidentialLedger.Models.ConfidentialLedgerProvisioningState' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.ConfidentialLedger.Models.ConfidentialLedgerRoleName' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.ConfidentialLedger.Models.ConfidentialLedgerType' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.ConfidentialLedger/Debug/netstandard2.0/Azure.ResourceManager.ConfidentialLedger.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/confidentialledger/Azure.ResourceManager.ConfidentialLedger/src/Azure.ResourceManager.ConfidentialLedger.csproj::TargetFramework=netstandard2.0]
    Parse Suppression File Errors
    No suppression file added.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 637d6d06c813358a40baf79cd59f25bd3ef1288f. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh]
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[automation_init.sh] npm notice Run `npm install -g npm@10.7.0` to update!
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-confidentialledger [Preview SDK Changes]
    • azure_mgmt_confidentialledger-1.0.0-py3-none-any.whl
    • azure-mgmt-confidentialledger-1.0.0.zip
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 637d6d06c813358a40baf79cd59f25bd3ef1288f. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-confidentialledger [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-confidentialledger-1.0.0-beta.5.jar
    • azure-resourcemanager-confidentialledger-1.0.0-beta.5-sources.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 637d6d06c813358a40baf79cd59f25bd3ef1288f. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/confidentialledger/armconfidentialledger [Preview SDK Changes]
️🔄 azure-sdk-for-js inProgress [Detail]
️️✔️ azure-powershell succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 637d6d06c813358a40baf79cd59f25bd3ef1288f. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.confidentialledger.DefaultTag [Preview SDK Changes]
    • Az.ConfidentialLedger.0.1.0.nupkg
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Mar 7, 2024

@andpiccione
Copy link
Member Author

The required check Breaking Change(Cross-Version) is failing due to changes that are not related to this new API version (see details).

This new preview API version has been based off the latest preview version (2023-06-28-preview; see corresponding PR) and only modifies the REST API specs for Managed CCF (managedccf.json). It does not touch the REST API specs for Confidential Ledger (confidentialledger.json), even though all the detected breaking changes are coming from there.

Given that the previous PR / preview API version also had the same detected breaking changes and was eventually approved, I've added the BreakingChange-Approved-Previously label.

@andpiccione
Copy link
Member Author

andpiccione commented Mar 7, 2024

Addressing other failed checks:

  • The Swagger APIView check failed at the first attempt with the following error message Creating ApiView timeout because Microsoft.ConfidentialLedger is too large. However, it succeeded on a second attempt, so I suppose it can be ignored.

  • The SDK azure-sdk-for-net-track2 check is failing with a bunch of errors like XXX does not exist in the implementation but it does exist in the contract. However, I haven't modified the Confidential Ledger REST API specs and the failure is not related to these updates. I assume this can also be ignored and relates to the comment above.

@andpiccione andpiccione marked this pull request as ready for review March 7, 2024 15:35
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 7, 2024
@andpiccione andpiccione self-assigned this Mar 11, 2024
@raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 12, 2024
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 12, 2024
@andpiccione
Copy link
Member Author

The PR is ready to be merged (all requirements are met). We will wait for our backend to be ready before merging this new preview API version.

@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Apr 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Apr 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label May 6, 2024
@andpiccione andpiccione removed the no-recent-activity There has been no recent activity on this issue. label May 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels May 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jun 17, 2024
@andpiccione andpiccione removed the no-recent-activity There has been no recent activity on this issue. label Jun 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jul 8, 2024
@andpiccione andpiccione removed the no-recent-activity There has been no recent activity on this issue. label Jul 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jul 29, 2024
@andpiccione andpiccione removed the no-recent-activity There has been no recent activity on this issue. label Jul 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Aug 19, 2024
Copy link
Contributor

Hi, @andpiccione. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Sep 2, 2024
@andpiccione andpiccione removed the no-recent-activity There has been no recent activity on this issue. label Sep 2, 2024
@andpiccione
Copy link
Member Author

Closing in favor of #30653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants