Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Swagger Files For SQL Managed Database and Managed Instance #2706

Merged
merged 7 commits into from
Apr 17, 2018

Conversation

ziwa-msft
Copy link
Contributor

@ziwa-msft ziwa-msft commented Mar 20, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • [ x] The title of the PR is clear and informative.
  • [ x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • [x ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • [ x] If applicable, the PR references the bug/issue that it fixes.
  • [ x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@ziwa-msft ziwa-msft requested a review from a user March 20, 2018 09:41
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2018

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp4592p0o2/rest/specification/sql/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp4592p0o2/sdk', '--use=@microsoft.azure/autorest.python@~3.0', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4275/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4275)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0->3.0.44)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
FATAL: swagger-document-override/md-override-loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 81): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 82): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 83): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 84): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 85): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 86): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 87): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 88): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 89): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 90): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 91): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 92): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 93): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 94): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 95): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 96): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:51786) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 97): Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
FATAL: swagger-document/loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
Process() cancelled due to exception : Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
  Error: Could not read 'file:///tmp/tmp4592p0o2/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2018

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpoey53xah/rest/specification/sql/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpoey53xah/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4272/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4272)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.49)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
FATAL: swagger-document-override/md-override-loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 82): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 83): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 84): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 85): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 86): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 87): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 88): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 89): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 90): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 91): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 92): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 93): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 94): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 95): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 96): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 97): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:35946) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 98): Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
FATAL: swagger-document/loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
Process() cancelled due to exception : Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
  Error: Could not read 'file:///tmp/tmpoey53xah/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2018

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpwoct9v45/rest/specification/sql/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpwoct9v45/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.95', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4272/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4272)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.95->2.1.95)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-pure-2017-10-preview"} .
FATAL: swagger-document-override/md-override-loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 16): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 17): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 18): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 19): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 20): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 21): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 22): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 23): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 24): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 25): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 26): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 27): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 28): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 29): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 30): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 31): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:126430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 32): Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
FATAL: swagger-document/loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
Process() cancelled due to exception : Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
Failure during batch task - {"tag":"package-pure-2017-10-preview"} -- Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'..
  Error: Could not read 'file:///tmp/tmpwoct9v45/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2018

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpjv90v42c/rest/specification/sql/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpjv90v42c/sdk', '--nodejs']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4272/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4272)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (~2.1.25->2.1.46)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
FATAL: swagger-document-override/md-override-loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 84): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 85): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 86): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 87): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 88): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 89): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 90): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 91): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 92): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 93): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 94): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 95): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 96): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 97): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 98): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 99): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
(node:41795) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 100): Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
FATAL: swagger-document/loader - FAILED
FATAL: Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
Process() cancelled due to exception : Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.
  Error: Could not read 'file:///tmp/tmpjv90v42c/rest/specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/instanceFailoverGroups.json'.

@dsgouda
Copy link
Contributor

dsgouda commented Mar 20, 2018

Handling a bunch of network PRs right now

@azuresdkci azuresdkci assigned jianghaolu and unassigned dsgouda Mar 20, 2018
Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but looks good.

"tags": [
"ManagedDatabases"
],
"description": "Deletes the managed database.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletes a managed database

]
},
"status": {
"description": "Status for the database.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status of the database

"tags": [
"ManagedInstances"
],
"description": "Gets a list of managed instances in a resource group.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this actually work?

"application/json"
],
"paths": {
"/subscriptions/{subscriptionId}/providers/Microsoft.Sql/managedInstances": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test that this actually works.

"name" : "CLS15",
"tier" : "Standard",
"capacity": 22,
"vCores": 24,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vCores, storageSizeInGB and licenseType should be in "properties".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry. We caught this and got the change checked into dsmain. Will update when we've hit production and are ready for check-in. Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a swagger generating issue, or is it a production service issue?

@ziwa-msft
Copy link
Contributor Author

Addressed comments

@jianghaolu jianghaolu added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 28, 2018
@jianghaolu
Copy link
Contributor

Signed off from SDK side.

Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge from master and update readme.md.

@@ -182,6 +184,7 @@ input-file:
- Microsoft.Sql/preview/2015-05-01-preview/virtualNetworkRules.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add 2015\managedInstances.json to package-2017

@@ -63,6 +63,7 @@ input-file:
- Microsoft.Sql/preview/2015-05-01-preview/databaseAutomaticTuning.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge from master and add managedInstances and managedDatabase to ALL package-composite-v* sections.

@@ -182,6 +184,7 @@ input-file:
- Microsoft.Sql/preview/2015-05-01-preview/virtualNetworkRules.json
- Microsoft.Sql/preview/2017-03-01-preview/cancelOperations.json
- Microsoft.Sql/preview/2017-03-01-preview/dataWarehouseUserActivities.json
- Microsoft.Sql/preview/2017-03-01-preview/managedDatabases.json
- Microsoft.Sql/preview/2017-03-01-preview/renameDatabase.json
- Microsoft.Sql/preview/2017-03-01-preview/serverAutomaticTuning.json
- Microsoft.Sql/preview/2017-03-01-preview/serverDnsAliases.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add 2015\managedInstances.json to package-pure-2015 and add 2017\managedDatabases.json to package-pure-2017

@jaredmoo
Copy link
Contributor

jaredmoo commented Mar 28, 2018

  • package-composite-v* should contain any latest version of apis unless there is some backcompat isssue.
  • package-2017 should contain latest version of apis up to and including 2017.
  • package-2015 should contain latest version of apis up to and including 2015.
  • package-pure-2017 should contain all files of 2017 only.
  • package-pure-2015 should contain all files of 2015 only.

You should be adding both new apis to all of the above as appropriate. Make sure you merge from master so that you have package-composite-v3.

@ravbhatnagar
Copy link
Contributor

Signing off from ARM

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 5, 2018
@jianghaolu
Copy link
Contributor

Please let me know if you plan to address the comments from @jaredmoo. Thank you!

@jaredmoo
Copy link
Contributor

jaredmoo commented Apr 8, 2018

Please do not merge without the readme.md changes I requested or else generated SDKs will not be right

@jugeorge
Copy link
Contributor

We are planning on making the changes Jared requested, and we will also be adding InstanceFailoverGroup swagger in the readme because that is also ready. Waiting for the ARM manifest to be deployed (should be within a day or two). Our .NET SDKs are also ready and a PR will be started shortly.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 24 Error(s): 0
After the PR: Warning(s): 24 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@jugeorge
Copy link
Contributor

jugeorge commented Apr 17, 2018

@jianghaolu Our ARM manifest has been deployed and we fixed the readme. Please merge as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants