Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added descriptions to include Cosmos DB ARM template values #2701

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

WilliamAntonRohm
Copy link
Contributor

@WilliamAntonRohm WilliamAntonRohm commented Mar 19, 2018

per task 1158120

https://mseng.visualstudio.com/TechnicalContent/_queries/edit/1158120/?triage=true

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@WilliamAntonRohm WilliamAntonRohm requested a review from a user March 19, 2018 22:50
@WilliamAntonRohm WilliamAntonRohm changed the title added descriptions to include ARM template values added descriptions to include Cosmos DB ARM template values Mar 19, 2018
@AutorestCI
Copy link

AutorestCI commented Mar 19, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2486

@WilliamAntonRohm
Copy link
Contributor Author

#sign-off

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2018

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
Azure/azure-libraries-for-java#348

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2235

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1350

Copy link
Member

@mimig1 mimig1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmazuel lmazuel merged commit 11b7769 into Azure:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants