Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure OpenAI: fix object representation of response_format #26997

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

trrwilson
Copy link
Member

Reference: https://platform.openai.com/docs/api-reference/chat/create#chat-create-response_format

response_format has valid values of { "type": "text" } and { "type": "json_object" }. I unwittingly simplified this to an effective "text" | "json_object" in our TypeSpec, which ultimately leads to request errors when attempting to set the type.

This change addresses the problem by consistently aligning with the discriminated type pattern: ChatCompletionsResponseFormat is an "abstract" model with a @discriminator for type while ChatCompletionsTextResponseFormat and ChatCompletionsJsonResponseFormat are extended types. It's a bit odd to have no additional data beyond the discriminator itself set in that manner, but this is the right way to get emission to cooperate and also retains the proper flexibility if configurable response formats are introduced in the future.

Copy link

openapi-pipeline-app bot commented Dec 7, 2023

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes (label: BreakingChangeReviewRequired). See the PR description for help.
  • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.

Copy link

openapi-pipeline-app bot commented Dec 7, 2023

Swagger Validation Report

️❌BreakingChange: 9 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
generated.json 2023-12-01-preview(c1affaf) 2023-12-01-preview(main)
Rule Message
1026 - TypeChanged The new version has a different type 'object' than the previous one 'string'.
New: inference/preview/2023-12-01-preview/generated.json#L1800:9
Old: inference/preview/2023-12-01-preview/generated.json#L1790:9
1026 - TypeChanged The new version has a different type 'object' than the previous one 'string'.
New: inference/preview/2023-12-01-preview/generated.json#L1822:5
Old: inference/preview/2023-12-01-preview/generated.json#L1812:5
1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
New: inference/preview/2023-12-01-preview/generated.json#L1800:9
Old: inference/preview/2023-12-01-preview/generated.json#L1790:9
1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
New: inference/preview/2023-12-01-preview/generated.json#L1822:5
Old: inference/preview/2023-12-01-preview/generated.json#L1812:5
1034 - AddedRequiredProperty The new version has new required property 'type' that was not found in the old version.
New: inference/preview/2023-12-01-preview/generated.json#L1825:7
1034 - AddedRequiredProperty The new version has new required property 'type' that was not found in the old version.
New: inference/preview/2023-12-01-preview/generated.json#L1800:9
Old: inference/preview/2023-12-01-preview/generated.json#L1790:9
1034 - AddedRequiredProperty The new version has new required property 'type' that was not found in the old version.
New: inference/preview/2023-12-01-preview/generated.json#L1822:5
Old: inference/preview/2023-12-01-preview/generated.json#L1812:5
1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
New: inference/preview/2023-12-01-preview/generated.json#L1800:9
Old: inference/preview/2023-12-01-preview/generated.json#L1790:9
1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
New: inference/preview/2023-12-01-preview/generated.json#L1822:5
Old: inference/preview/2023-12-01-preview/generated.json#L1812:5
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.6) new version base version
default default(c1affaf) default(main)
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 21 Errors, 0 Warnings failed [Detail]
Rule Message
INVALID_TYPE Expected type object but found type string
Url: inference/preview/2023-12-01-preview/generated.json#L671:34
ExampleUrl: preview/2023-12-01-preview/examples/audio_transcription_text.json#L8:13
RESPONSE_BODY_NOT_IN_EXAMPLE Response statusCode 200 for operation GetAudioTranscriptionAsPlainText has no response body provided in the example, however the response does have a "schema" defined in the swagger spec.
Url: inference/preview/2023-12-01-preview/generated.json#L86:22
ExampleUrl: preview/2023-12-01-preview/examples/audio_transcription_text.json#L10:16
INVALID_TYPE Expected type object but found type string
Url: inference/preview/2023-12-01-preview/generated.json#L859:32
ExampleUrl: preview/2023-12-01-preview/examples/audio_translation_text.json#L8:13
RESPONSE_BODY_NOT_IN_EXAMPLE Response statusCode 200 for operation GetAudioTranslationAsPlainText has no response body provided in the example, however the response does have a "schema" defined in the swagger spec.
Url: inference/preview/2023-12-01-preview/generated.json#L137:22
ExampleUrl: preview/2023-12-01-preview/examples/audio_translation_text.json#L10:16
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: system_fingerprint
Url: inference/preview/2023-12-01-preview/generated.json#L1613:24
ExampleUrl: preview/2023-12-01-preview/examples/chat_completions.json
INVALID_FORMAT Object didn't pass validation for format uri: {search endpoint}
Url: inference/preview/2023-12-01-preview/generated.json#L1196:21
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_azure_search_minimum.json#L8:13
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: system_fingerprint
Url: inference/preview/2023-12-01-preview/generated.json#L1613:24
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_azure_search_minimum.json
INVALID_FORMAT Object didn't pass validation for format uri: {search endpoint}
Url: inference/preview/2023-12-01-preview/generated.json#L1196:21
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_azure_search_image_vector.json#L8:13
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: system_fingerprint
Url: inference/preview/2023-12-01-preview/generated.json#L1613:24
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_azure_search_image_vector.json
INVALID_FORMAT Object didn't pass validation for format uri: {search endpoint}
Url: inference/preview/2023-12-01-preview/generated.json#L1196:21
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_azure_search_advanced.json#L8:13
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: system_fingerprint
Url: inference/preview/2023-12-01-preview/generated.json#L1613:24
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_azure_search_advanced.json
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: system_fingerprint
Url: inference/preview/2023-12-01-preview/generated.json#L1613:24
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_aml_index.json
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: system_fingerprint
Url: inference/preview/2023-12-01-preview/generated.json#L1613:24
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_cosmos_db.json
INVALID_FORMAT Object didn't pass validation for format uri: {search endpoint}
Url: inference/preview/2023-12-01-preview/generated.json#L2667:21
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_elasticsearch.json#L8:13
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: system_fingerprint
Url: inference/preview/2023-12-01-preview/generated.json#L1613:24
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_elasticsearch.json
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: key
Url: inference/preview/2023-12-01-preview/generated.json#L3099:46
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_pinecone.json#L8:13
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: apiKey
Url: inference/preview/2023-12-01-preview/generated.json#L3099:46
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_pinecone.json#L8:13
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: system_fingerprint
Url: inference/preview/2023-12-01-preview/generated.json#L1613:24
ExampleUrl: preview/2023-12-01-preview/examples/extensions_chat_completions_pinecone.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: revised_prompt
Url: inference/preview/2023-12-01-preview/generated.json#L3024:25
ExampleUrl: preview/2023-12-01-preview/examples/image_generation.json#L27:27
REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND In operation GetAudioTranscriptionAsResponseObject, parameter file is required in the swagger spec but is not present in the provided example parameter values.
Url: inference/preview/2023-12-01-preview/generated.json#L440:15
ExampleUrl: preview/2023-12-01-preview/examples/audio_transcription_object.json
REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND In operation GetAudioTranslationAsResponseObject, parameter file is required in the swagger spec but is not present in the provided example parameter values.
Url: inference/preview/2023-12-01-preview/generated.json#L507:15
ExampleUrl: preview/2023-12-01-preview/examples/audio_translation_object.json
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Dec 7, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs] Generate from 411483dcac6620bcb1a375de7aedbbea2a4dac53. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    warn		specification/cognitiveservices/data-plane/AzureOpenAI/inference/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 131 | �[0m               �[36;1mGeneratePackage `�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 131 | �[0m               �[36;1mGeneratePackage `�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to packe sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 131 | �[0m               �[36;1mGeneratePackage `�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  • Azure.AI.OpenAI [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️❌ azure-sdk-for-java failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from 411483dcac6620bcb1a375de7aedbbea2a4dac53. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    warn		specification/cognitiveservices/data-plane/AzureOpenAI/inference/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py]  WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/compiler@0.51.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/rest@0.51.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/http@0.51.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/openapi@0.51.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/versioning@0.51.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@azure-tools/typespec-azure-core@0.37.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
    cmderr	[generate.py] npm WARN EBADENGINE   package: '@azure-tools/typespec-client-generator-core@0.37.0',
    cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
    cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
    cmderr	[generate.py] npm WARN EBADENGINE }
    cmderr	[generate.py]
    cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 10.2.5
    cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.5>
    cmderr	[generate.py] npm notice Run `npm install -g npm@10.2.5` to update!
    cmderr	[generate.py] npm notice
    cmderr	[generate.py] java.lang.RuntimeException: Failed to complete postprocessing.
    cmderr	[generate.py] 	at com.azure.autorest.postprocessor.Postprocessor.postProcess(Postprocessor.java:109)
    cmderr	[generate.py] 	at com.azure.typespec.Main.handleDPG(Main.java:138)
    cmderr	[generate.py] 	at com.azure.typespec.Main.main(Main.java:90)
    cmderr	[generate.py] Caused by: java.lang.RuntimeException: Unable to complete customization
    cmderr	[generate.py] 	at com.azure.autorest.postprocessor.Postprocessor.postProcess(Postprocessor.java:102)
    cmderr	[generate.py] 	... 2 more
    cmderr	[generate.py] Caused by: java.lang.NullPointerException
    cmderr	[generate.py] 	at com.azure.autorest.postprocessor.Postprocessor.postProcess(Postprocessor.java:97)
    cmderr	[generate.py] 	... 2 more
    cmderr	[generate.py] Emitter "@azure-tools/typespec-java" crashed! This is a bug.
    cmderr	[generate.py] Please file an issue at https://github.com/Azure/autorest.java/issues
    cmderr	[generate.py] Error: JAR ended with code '1'.
    cmderr	[generate.py]     at ChildProcess.<anonymous> (file:///mnt/vss/_work/1/s/azure-sdk-for-java/sdk/openai/azure-ai-openai/TempTypeSpecFiles/OpenAI.Inference/node_modules/@azure-tools/typespec-java/dist/src/emitter.js:106:37)
    cmderr	[generate.py]     at ChildProcess.emit (node:events:513:28)
    cmderr	[generate.py]     at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)
    cmderr	[generate.py] --------------------------------------------------
    cmderr	[generate.py] Library Version                0.11.3
    cmderr	[generate.py] TypeSpec Compiler Version      0.51.0
    cmderr	[generate.py] --------------------------------------------------
    cmderr	[generate.py] �[31;1mWrite-Error: �[31;1mFailed to generate sdk project at /mnt/vss/_work/1/s/azure-sdk-for-java/sdk/openai/azure-ai-openai�[0m
    error	Fatal error: The "path" argument must be of type string. Received undefined
    The "path" argument must be of type string. Received undefined
    TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
        at new NodeError (node:internal/errors:387:5)
        at validateString (node:internal/validators:162:11)
        at Object.basename (node:path:1309:5)
        at Object.exports.getPackageData (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/types/PackageData.js:38:82)
        at /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:210:194
        at Array.map (<anonymous>)
        at workflowHandleReadmeMdOrTypeSpecProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:210:164)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at async Object.exports.workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:98:13)
        at async Object.exports.sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:211:13)
        at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
️🔄 azure-sdk-for-js inProgress [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Dec 7, 2023

Generated ApiView

Language Package Name ApiView Link
TypeSpec OpenAI.Inference https://apiview.dev/Assemblies/Review/33c383575c29449c9d99346163b0afa3

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane TypeSpec Authored with TypeSpec labels Dec 7, 2023
@lmazuel lmazuel merged commit 3e0e2a9 into main Dec 7, 2023
24 of 30 checks passed
@lmazuel lmazuel deleted the user/travisw/aoai_response_format_fix branch December 7, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants