Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadMe file of 2023-05-01 swagger LongTermRetentionBackups and LongTermRetentionPolicies #26683

Conversation

lululilliancoding
Copy link
Contributor

@lululilliancoding lululilliancoding commented Nov 13, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • [ x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [ x] I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

ahnj12 and others added 2 commits October 25, 2023 14:45
Reverting global tag to stable GA version for SDK release
Copy link

Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

Copy link

Swagger pipeline can not start as the pull request has merge conflicts.

1 similar comment
Copy link

Swagger pipeline can not start as the pull request has merge conflicts.

Copy link

Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

Copy link

Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

Copy link

Swagger pipeline can not start as the pull request has merge conflicts.

1 similar comment
Copy link

Swagger pipeline can not start as the pull request has merge conflicts.

Copy link

Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

Copy link

Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

Copy link

Swagger pipeline can not start as the pull request has merge conflicts.

1 similar comment
Copy link

Swagger pipeline can not start as the pull request has merge conflicts.

Copy link

Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

Copy link

openapi-pipeline-app bot commented Nov 13, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app bot commented Nov 13, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.6) new version base version
default default(29c90e4) default(main)
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/sql/resource-manager/readme.md
tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 13, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/sql/armsql - Approved - 2.0.0-beta.3
+	Function `*timeRFC3339.Parse` has been removed
+	Function `*timeRFC3339.UnmarshalText` has been removed
+	Function `timeRFC3339.MarshalText` has been removed


️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 68cabef0795cb594f556bf8656d63425972d1873. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.3
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.3` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-sql [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation LongTermRetentionBackupsOperations.begin_change_access_tier
    info	[Changelog]   - Added operation LongTermRetentionBackupsOperations.begin_change_access_tier_by_resource_group
    info	[Changelog]   - Added operation group JobPrivateEndpointsOperations
    info	[Changelog]   - Model FailoverGroupReadOnlyEndpoint has a new parameter target_server
    info	[Changelog]   - Model FailoverGroupUpdate has a new parameter partner_servers
    info	[Changelog]   - Model InstancePool has a new parameter dns_zone
    info	[Changelog]   - Model InstancePool has a new parameter maintenance_configuration_id
    info	[Changelog]   - Model InstancePoolUpdate has a new parameter dns_zone
    info	[Changelog]   - Model InstancePoolUpdate has a new parameter license_type
    info	[Changelog]   - Model InstancePoolUpdate has a new parameter maintenance_configuration_id
    info	[Changelog]   - Model InstancePoolUpdate has a new parameter sku
    info	[Changelog]   - Model InstancePoolUpdate has a new parameter subnet_id
    info	[Changelog]   - Model InstancePoolUpdate has a new parameter v_cores
    info	[Changelog]   - Model LongTermRetentionBackup has a new parameter backup_storage_access_tier
    info	[Changelog]   - Model LongTermRetentionBackup has a new parameter is_backup_immutable
    info	[Changelog]   - Model Server has a new parameter is_i_pv6_enabled
    info	[Changelog]   - Model ServerUpdate has a new parameter is_i_pv6_enabled
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 68cabef0795cb594f556bf8656d63425972d1873. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.Sql [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 68cabef0795cb594f556bf8656d63425972d1873. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-sql-generated [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 68cabef0795cb594f556bf8656d63425972d1873. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/sql/armsql [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Function `timeRFC3339.MarshalText` has been removed
    info	[Changelog] - Function `*timeRFC3339.Parse` has been removed
    info	[Changelog] - Function `*timeRFC3339.UnmarshalText` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New enum type `BackupStorageAccessTier` with values `BackupStorageAccessTierArchive`, `BackupStorageAccessTierHot`
    info	[Changelog] - New function `*ClientFactory.NewJobPrivateEndpointsClient() *JobPrivateEndpointsClient`
    info	[Changelog] - New function `NewJobPrivateEndpointsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*JobPrivateEndpointsClient, error)`
    info	[Changelog] - New function `*JobPrivateEndpointsClient.BeginCreateOrUpdate(context.Context, string, string, string, string, JobPrivateEndpoint, *JobPrivateEndpointsClientBeginCreateOrUpdateOptions) (*runtime.Poller[JobPrivateEndpointsClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*JobPrivateEndpointsClient.BeginDelete(context.Context, string, string, string, string, *JobPrivateEndpointsClientBeginDeleteOptions) (*runtime.Poller[JobPrivateEndpointsClientDeleteResponse], error)`
    info	[Changelog] - New function `*JobPrivateEndpointsClient.Get(context.Context, string, string, string, string, *JobPrivateEndpointsClientGetOptions) (JobPrivateEndpointsClientGetResponse, error)`
    info	[Changelog] - New function `*JobPrivateEndpointsClient.NewListByAgentPager(string, string, string, *JobPrivateEndpointsClientListByAgentOptions) *runtime.Pager[JobPrivateEndpointsClientListByAgentResponse]`
    info	[Changelog] - New function `*LongTermRetentionBackupsClient.BeginChangeAccessTier(context.Context, string, string, string, string, ChangeLongTermRetentionBackupAccessTierParameters, *LongTermRetentionBackupsClientBeginChangeAccessTierOptions) (*runtime.Poller[LongTermRetentionBackupsClientChangeAccessTierResponse], error)`
    info	[Changelog] - New function `*LongTermRetentionBackupsClient.BeginChangeAccessTierByResourceGroup(context.Context, string, string, string, string, string, ChangeLongTermRetentionBackupAccessTierParameters, *LongTermRetentionBackupsClientBeginChangeAccessTierByResourceGroupOptions) (*runtime.Poller[LongTermRetentionBackupsClientChangeAccessTierByResourceGroupResponse], error)`
    info	[Changelog] - New function `dateTimeRFC3339.MarshalText() ([]byte, error)`
    info	[Changelog] - New function `*dateTimeRFC3339.Parse(string) error`
    info	[Changelog] - New function `*dateTimeRFC3339.UnmarshalText([]byte) error`
    info	[Changelog] - New struct `ChangeLongTermRetentionBackupAccessTierParameters`
    info	[Changelog] - New struct `ErrorAdditionalInfo`
    info	[Changelog] - New struct `ErrorDetail`
    info	[Changelog] - New struct `ErrorResponse`
    info	[Changelog] - New struct `JobPrivateEndpoint`
    info	[Changelog] - New struct `JobPrivateEndpointListResult`
    info	[Changelog] - New struct `JobPrivateEndpointProperties`
    info	[Changelog] - New field `DNSZone`, `MaintenanceConfigurationID` in struct `InstancePoolProperties`
    info	[Changelog] - New field `Properties`, `SKU` in struct `InstancePoolUpdate`
    info	[Changelog] - New field `BackupStorageAccessTier`, `IsBackupImmutable` in struct `LongTermRetentionBackupProperties`
    info	[Changelog]
    info	[Changelog] Total 3 breaking change(s), 31 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 68cabef0795cb594f556bf8656d63425972d1873. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-sql [View full logs]  [Preview SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation group JobPrivateEndpoints
    info	[Changelog]   - Added operation FailoverGroups.beginTryPlannedBeforeForcedFailover
    info	[Changelog]   - Added operation FailoverGroups.beginTryPlannedBeforeForcedFailoverAndWait
    info	[Changelog]   - Added operation LongTermRetentionBackups.beginChangeAccessTier
    info	[Changelog]   - Added operation LongTermRetentionBackups.beginChangeAccessTierAndWait
    info	[Changelog]   - Added operation LongTermRetentionBackups.beginChangeAccessTierByResourceGroup
    info	[Changelog]   - Added operation LongTermRetentionBackups.beginChangeAccessTierByResourceGroupAndWait
    info	[Changelog]   - Added Interface ChangeLongTermRetentionBackupAccessTierParameters
    info	[Changelog]   - Added Interface ErrorAdditionalInfo
    info	[Changelog]   - Added Interface ErrorDetail
    info	[Changelog]   - Added Interface ErrorResponse
    info	[Changelog]   - Added Interface FailoverGroupsTryPlannedBeforeForcedFailoverHeaders
    info	[Changelog]   - Added Interface FailoverGroupsTryPlannedBeforeForcedFailoverOptionalParams
    info	[Changelog]   - Added Interface JobPrivateEndpoint
    info	[Changelog]   - Added Interface JobPrivateEndpointListResult
    info	[Changelog]   - Added Interface JobPrivateEndpointsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface JobPrivateEndpointsDeleteOptionalParams
    info	[Changelog]   - Added Interface JobPrivateEndpointsGetOptionalParams
    info	[Changelog]   - Added Interface JobPrivateEndpointsListByAgentNextOptionalParams
    info	[Changelog]   - Added Interface JobPrivateEndpointsListByAgentOptionalParams
    info	[Changelog]   - Added Interface LongTermRetentionBackupsChangeAccessTierByResourceGroupOptionalParams
    info	[Changelog]   - Added Interface LongTermRetentionBackupsChangeAccessTierOptionalParams
    info	[Changelog]   - Added Type Alias BackupStorageAccessTier
    info	[Changelog]   - Added Type Alias FailoverGroupsTryPlannedBeforeForcedFailoverResponse
    info	[Changelog]   - Added Type Alias FreeLimitExhaustionBehavior
    info	[Changelog]   - Added Type Alias JobPrivateEndpointsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias JobPrivateEndpointsGetResponse
    info	[Changelog]   - Added Type Alias JobPrivateEndpointsListByAgentNextResponse
    info	[Changelog]   - Added Type Alias JobPrivateEndpointsListByAgentResponse
    info	[Changelog]   - Added Type Alias LongTermRetentionBackupsChangeAccessTierByResourceGroupResponse
    info	[Changelog]   - Added Type Alias LongTermRetentionBackupsChangeAccessTierResponse
    info	[Changelog]   - Interface Database has a new optional parameter encryptionProtectorAutoRotation
    info	[Changelog]   - Interface Database has a new optional parameter freeLimitExhaustionBehavior
    info	[Changelog]   - Interface Database has a new optional parameter useFreeLimit
    info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter encryptionProtectorAutoRotation
    info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter freeLimitExhaustionBehavior
    info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter useFreeLimit
    info	[Changelog]   - Interface ElasticPool has a new optional parameter availabilityZone
    info	[Changelog]   - Interface ElasticPool has a new optional parameter minCapacity
    info	[Changelog]   - Interface ElasticPool has a new optional parameter preferredEnclaveType
    info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter availabilityZone
    info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter minCapacity
    info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter preferredEnclaveType
    info	[Changelog]   - Interface FailoverGroupReadOnlyEndpoint has a new optional parameter targetServer
    info	[Changelog]   - Interface FailoverGroupUpdate has a new optional parameter partnerServers
    info	[Changelog]   - Interface InstancePool has a new optional parameter dnsZone
    info	[Changelog]   - Interface InstancePool has a new optional parameter maintenanceConfigurationId
    info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter dnsZone
    info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter licenseType
    info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter maintenanceConfigurationId
    info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter sku
    info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter subnetId
    info	[Changelog]   - Interface InstancePoolUpdate has a new optional parameter vCores
    info	[Changelog]   - Interface LongTermRetentionBackup has a new optional parameter backupStorageAccessTier
    info	[Changelog]   - Interface LongTermRetentionBackup has a new optional parameter isBackupImmutable
    info	[Changelog]   - Interface ManagedDatabase has a new optional parameter isLedgerOn
    info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter isLedgerOn
    info	[Changelog]   - Interface PrivateEndpointConnection has a new optional parameter groupIds
    info	[Changelog]   - Interface Server has a new optional parameter isIPv6Enabled
    info	[Changelog]   - Interface ServerUpdate has a new optional parameter isIPv6Enabled
    info	[Changelog]   - Interface SqlVulnerabilityAssessmentScanRecord has a new optional parameter lastScanTime
    info	[Changelog]   - Added Enum KnownBackupStorageAccessTier
    info	[Changelog]   - Added Enum KnownFreeLimitExhaustionBehavior
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 68cabef0795cb594f556bf8656d63425972d1873. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.3
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.3` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from 68cabef0795cb594f556bf8656d63425972d1873. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.sql.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.sql.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 13, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/sql/armsql https://apiview.dev/Assemblies/Review/82f4c59b110b4a9e83289f33a09a7c36
.Net Azure.ResourceManager.Sql https://apiview.dev/Assemblies/Review/2725d9c350dd4ca0ab80d6b0bf83d445
JavaScript @azure/arm-sql https://apiview.dev/Assemblies/Review/59494ebff817462194aac4c0acd4a282

@@ -24,7 +24,7 @@ These are the global settings for the Sql API.
title: SqlManagementClient
description: 'The Azure SQL Database management API provides a RESTful set of web services that interact with Azure SQL Database services to manage your databases. The API enables you to create, retrieve, update, and delete databases.'
openapi-type: arm
tag: package-preview-2023-05
tag: package-composite-v5
Copy link
Contributor

@ericshape ericshape Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM reviewers and @rkmanda , we revert "package-composite-v5" for downstream SDK client generation.

It was charged to "package-preview-2023-05" by mistake. Thus, all the Avacado failed pipelines could be ignored.

At the same time, all the failed messages in "Swagger SDK Breaking Change Tracking failed" should be ignored.

@ericshape
Copy link
Contributor

@lululilliancoding Please do not use customized PR description.

Please copy and paste the PR description from #26666

@lululilliancoding
Copy link
Contributor Author

@lululilliancoding Please do not use customized PR description.

Please copy and paste the PR description from #26666

Updated

@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Nov 14, 2023
@TimLovellSmith TimLovellSmith added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 17, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 17, 2023
@raych1 raych1 added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Nov 20, 2023
@lululilliancoding
Copy link
Contributor Author

/pr RequestMerge

@raosuhas raosuhas merged commit 4428e09 into Azure:main Nov 21, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants