Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication] Review request for managed identity stable api version 2023 04 01 #26345

Merged
merged 4 commits into from
Oct 26, 2023

fix sender user name model validation example

4683a3c
Select commit
Loading
Failed to load commit list.
Merged

[Communication] Review request for managed identity stable api version 2023 04 01 #26345

fix sender user name model validation example
4683a3c
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff failed Oct 23, 2023 in 2m 57s

~[NotRequired_Staging] Swagger LintDiff failed

ppe/LintDiff: 4 Errors, 1 Warnings
View more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-2023-04 package-2023-04(4683a3c) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/communication/resource-manager/Microsoft.Communication/stable/2023-04-01/SenderUsernames.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 2: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined')
Location: azure-rest-api-specs/blob/4683a3c81450ea896cfbd9e28bd4ad8292c51f45/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/communication/resource-manager/Microsoft.Communication/stable/2023-04-01/EmailServices.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 2: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 3: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined')
Location: azure-rest-api-specs/blob/4683a3c81450ea896cfbd9e28bd4ad8292c51f45/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/communication/resource-manager/Microsoft.Communication/stable/2023-04-01/Domains.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 2: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 3: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined')
Location: azure-rest-api-specs/blob/4683a3c81450ea896cfbd9e28bd4ad8292c51f45/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/communication/resource-manager/Microsoft.Communication/stable/2023-04-01/CommunicationServices.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 2: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 3: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 4: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 5: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 6: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 7: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined')
Location: azure-rest-api-specs/blob/4683a3c81450ea896cfbd9e28bd4ad8292c51f45/#L1
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get SenderUsernames resource
Location: Microsoft.Communication/stable/2023-04-01/SenderUsernames.json#L127