Release network microsoft.network official 2023 06 01 #26218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01 to version 2023-06-01
…5599) * add DeleteBastionShareableLinkByToken endpoint * fix location link format
* add profile to put example * fixed RuleCollectionGroupWithHttpHeadersToInsert example * add profile to Policy model * description change * indentation * ListIdpsSignatures description change * direction description+enum fix * fix FirewallPolicyIDPSSignatureSeverity description
…tion Firewall (#26149) * Add support for JSChallenge action Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules * Update WafPolicyGet.json * Update WafPolicyCreateOrUpdate.json
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| networkVirtualAppliance.json | 2022-11-01(a586567) | 2022-11-01(main) |
| virtualWan.json | 2022-11-01(a586567) | 2022-11-01(main) |
| networkVirtualAppliance.json | 2023-02-01(a586567) | 2023-02-01(main) |
| virtualWan.json | 2023-02-01(a586567) | 2023-02-01(main) |
| networkVirtualAppliance.json | 2023-04-01(a586567) | 2023-04-01(main) |
| virtualWan.json | 2023-04-01(a586567) | 2023-04-01(main) |
| networkVirtualAppliance.json | 2023-05-01(a586567) | 2023-05-01(main) |
| virtualWan.json | 2023-05-01(a586567) | 2023-05-01(main) |
Only 7 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkVirtualAppliances/{networkVirtualApplianceName}/networkVirtualApplianceConnections/{connectionName}' removed or restructured? Old: Microsoft.Network/stable/2022-11-01/virtualWan.json#L5037:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkVirtualAppliances/{networkVirtualApplianceName}/networkVirtualApplianceConnections' removed or restructured? Old: Microsoft.Network/stable/2022-11-01/virtualWan.json#L5229:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkVirtualAppliances/{networkVirtualApplianceName}/networkVirtualApplianceConnections/{connectionName}' removed or restructured? Old: Microsoft.Network/stable/2023-02-01/virtualWan.json#L5037:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkVirtualAppliances/{networkVirtualApplianceName}/networkVirtualApplianceConnections' removed or restructured? Old: Microsoft.Network/stable/2023-02-01/virtualWan.json#L5229:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkVirtualAppliances/{networkVirtualApplianceName}/networkVirtualApplianceConnections/{connectionName}' removed or restructured? Old: Microsoft.Network/stable/2023-04-01/virtualWan.json#L5037:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkVirtualAppliances/{networkVirtualApplianceName}/networkVirtualApplianceConnections' removed or restructured? Old: Microsoft.Network/stable/2023-04-01/virtualWan.json#L5229:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkVirtualAppliances/{networkVirtualApplianceName}/networkVirtualApplianceConnections/{connectionName}' removed or restructured? Old: Microsoft.Network/stable/2023-05-01/virtualWan.json#L5037:5 |
️❌Breaking Change(Cross-Version): 10 Errors, 80 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| applicationGateway.json | 2023-06-01(a586567) | 2023-05-01(main) |
| applicationGatewayWafDynamicManifests.json | 2023-06-01(a586567) | 2023-05-01(main) |
| applicationSecurityGroup.json | 2023-06-01(a586567) | 2023-05-01(main) |
| availableDelegations.json | 2023-06-01(a586567) | 2023-05-01(main) |
| availableServiceAliases.json | 2023-06-01(a586567) | 2023-05-01(main) |
| azureFirewall.json | 2023-06-01(a586567) | 2023-05-01(main) |
| azureFirewallFqdnTag.json | 2023-06-01(a586567) | 2023-05-01(main) |
| azureWebCategory.json | 2023-06-01(a586567) | 2023-05-01(main) |
| bastionHost.json | 2023-06-01(a586567) | 2023-05-01(main) |
| checkDnsAvailability.json | 2023-06-01(a586567) | 2023-05-01(main) |
| cloudServiceNetworkInterface.json | 2023-06-01(a586567) | 2023-05-01(main) |
| cloudServicePublicIpAddress.json | 2023-06-01(a586567) | 2023-05-01(main) |
| cloudServiceSwap.json | 2023-06-01(a586567) | 2023-05-01(main) |
| customIpPrefix.json | 2023-06-01(a586567) | 2023-05-01(main) |
| ddosCustomPolicy.json | 2023-06-01(a586567) | 2023-05-01(main) |
| ddosProtectionPlan.json | 2023-06-01(a586567) | 2023-05-01(main) |
| dscpConfiguration.json | 2023-06-01(a586567) | 2023-05-01(main) |
| endpointService.json | 2023-06-01(a586567) | 2023-05-01(main) |
| expressRouteCircuit.json | 2023-06-01(a586567) | 2023-05-01(main) |
| expressRouteCrossConnection.json | 2023-06-01(a586567) | 2023-05-01(main) |
| expressRoutePort.json | 2023-06-01(a586567) | 2023-05-01(main) |
| expressRouteProviderPort.json | 2023-06-01(a586567) | 2023-05-01(main) |
| firewallPolicy.json | 2023-06-01(a586567) | 2023-05-01(main) |
| ipAllocation.json | 2023-06-01(a586567) | 2023-05-01(main) |
| ipGroups.json | 2023-06-01(a586567) | 2023-05-01(main) |
| loadBalancer.json | 2023-06-01(a586567) | 2023-05-01(main) |
| natGateway.json | 2023-06-01(a586567) | 2023-05-01(main) |
| network.json | 2023-06-01(a586567) | 2023-05-01(main) |
| network.json | 2023-06-01(a586567) | 2022-06-01-preview(main) |
| networkInterface.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkManager.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkManager.json | 2023-06-01(a586567) | 2022-04-01-preview(main) |
| networkManagerActiveConfiguration.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkManagerActiveConfiguration.json | 2023-06-01(a586567) | 2022-04-01-preview(main) |
| networkManagerConnection.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkManagerConnection.json | 2023-06-01(a586567) | 2022-04-01-preview(main) |
| networkManagerConnectivityConfiguration.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkManagerConnectivityConfiguration.json | 2023-06-01(a586567) | 2022-04-01-preview(main) |
| networkManagerEffectiveConfiguration.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkManagerEffectiveConfiguration.json | 2023-06-01(a586567) | 2022-04-01-preview(main) |
| networkManagerGroup.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkManagerGroup.json | 2023-06-01(a586567) | 2022-04-01-preview(main) |
| networkManagerScopeConnection.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkManagerScopeConnection.json | 2023-06-01(a586567) | 2022-04-01-preview(main) |
| networkManagerSecurityAdminConfiguration.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkManagerSecurityAdminConfiguration.json | 2023-06-01(a586567) | 2022-04-01-preview(main) |
| networkProfile.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkSecurityGroup.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkVirtualAppliance.json | 2023-06-01(a586567) | 2023-05-01(main) |
| networkWatcher.json | 2023-06-01(a586567) | 2023-05-01(main) |
| operation.json | 2023-06-01(a586567) | 2023-05-01(main) |
| privateEndpoint.json | 2023-06-01(a586567) | 2023-05-01(main) |
| privateLinkService.json | 2023-06-01(a586567) | 2023-05-01(main) |
| publicIpAddress.json | 2023-06-01(a586567) | 2023-05-01(main) |
| publicIpPrefix.json | 2023-06-01(a586567) | 2023-05-01(main) |
| routeFilter.json | 2023-06-01(a586567) | 2023-05-01(main) |
| routeTable.json | 2023-06-01(a586567) | 2023-05-01(main) |
| securityPartnerProvider.json | 2023-06-01(a586567) | 2023-05-01(main) |
| serviceCommunity.json | 2023-06-01(a586567) | 2023-05-01(main) |
| serviceEndpointPolicy.json | 2023-06-01(a586567) | 2023-05-01(main) |
| serviceTags.json | 2023-06-01(a586567) | 2023-05-01(main) |
| usage.json | 2023-06-01(a586567) | 2023-05-01(main) |
| virtualNetwork.json | 2023-06-01(a586567) | 2023-05-01(main) |
| virtualNetworkGateway.json | 2023-06-01(a586567) | 2023-05-01(main) |
| virtualNetworkTap.json | 2023-06-01(a586567) | 2023-05-01(main) |
| virtualRouter.json | 2023-06-01(a586567) | 2023-05-01(main) |
| virtualWan.json | 2023-06-01(a586567) | 2023-05-01(main) |
| vmssNetworkInterface.json | 2023-06-01(a586567) | 2023-05-01(main) |
| vmssPublicIpAddress.json | 2023-06-01(a586567) | 2023-05-01(main) |
| webapplicationfirewall.json | 2023-06-01(a586567) | 2023-05-01(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 7 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 7 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/listEffectiveVirtualNetworks' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L418:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/listActiveSecurityUserRules' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L143:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/networkGroups/{networkGroupName}/listEffectiveVirtualNetworks' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerGroup.json#L240:5 |
|
| The new version is missing a definition that was found in the old version. Was 'EffectiveVirtualNetworksParameter' removed or renamed? New: Microsoft.Network/stable/2023-06-01/networkManager.json#L422:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L476:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActiveSecurityUserRule' removed or renamed? New: Microsoft.Network/stable/2023-06-01/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActiveDefaultSecurityUserRule' removed or renamed? New: Microsoft.Network/stable/2023-06-01/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is missing a definition that was found in the old version. Was 'DefaultUserRulePropertiesFormat' removed or renamed? New: Microsoft.Network/stable/2023-06-01/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
️🔄LintDiff inProgress [Detail]
️❌Avocado: 2 Errors, 6 Warnings failed [Detail]
Only 7 items are listed, please refer to log for more details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 790 Errors, 0 Warnings failed [Detail]
Only 7 items are listed, please refer to log for more details.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=396540&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - sdk/resourcemanager/network/armnetwork - Approved - 5.0.0+ Struct `PropagatedRouteTableNfv` has been removed + Struct `RoutingConfigurationNfvSubResource` has been removed + Struct `RoutingConfigurationNfv` has been removed + Type of `VirtualApplianceConnectionProperties.RoutingConfiguration` has been changed from `*RoutingConfigurationNfv` to `*RoutingConfiguration`
❌azure-sdk-for-js - @azure/arm-network - Approved - 33.0.0+ Type of parameter routingConfiguration of interface NetworkVirtualApplianceConnection is changed from RoutingConfigurationNfv to RoutingConfiguration
❌azure-sdk-for-python-track2 - track2_azure-mgmt-network - Approved - 25.1.0+ Model NetworkVirtualAppliance no longer has parameter virtual_appliance_connections + Removed operation group NetworkVirtualApplianceConnectionsOperations
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Network [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.Network [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.Models.ApplicationGatewayListener Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.ApplicationGatewayListener(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.ETag>, Azure.Core.ResourceIdentifier, Azure.Core.ResourceIdentifier, System.Nullable<Azure.ResourceManager.Network.Models.ApplicationGatewayProtocol>, Azure.Core.ResourceIdentifier, Azure.Core.ResourceIdentifier, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.NetworkVirtualApplianceConnectionData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.NetworkVirtualApplianceConnectionData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.String, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, System.Nullable<System.Int64>, System.Nullable<System.Int64>, System.Collections.Generic.IEnumerable<System.String>, System.Nullable<System.Boolean>, Azure.ResourceManager.Network.Models.RoutingConfigurationNfv)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.NetworkVirtualApplianceData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.NetworkVirtualApplianceData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.Core.AzureLocation>, System.Collections.Generic.IDictionary<System.String, System.String>, Azure.ResourceManager.Models.ManagedServiceIdentity, System.Nullable<Azure.ETag>, Azure.ResourceManager.Network.Models.VirtualApplianceSkuProperties, System.String, System.Collections.Generic.IEnumerable<System.String>, Azure.Core.ResourceIdentifier, System.Collections.Generic.IEnumerable<System.String>, System.String, System.Nullable<System.Int64>, System.String, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.VirtualApplianceNicProperties>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.VirtualApplianceAdditionalNicProperties>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.WritableSubResource>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.WritableSubResource>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.WritableSubResource>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, System.String, Azure.ResourceManager.Network.Models.VirtualApplianceDelegationProperties, Azure.ResourceManager.Network.Models.PartnerManagedResourceProperties)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Network.Models.PropagatedRouteTableNfv' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Network.Models.RoutingConfigurationNfv' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Network.Models.RoutingConfigurationNfvSubResource' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Network/Debug/netstandard2.0/Azure.ResourceManager.Network.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.3 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3> cmderr [automation_generate.sh] npm notice Run `npm install -g npm@10.2.3` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-network [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation NetworkSecurityPerimetersOperations.patch info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model NetworkVirtualAppliance no longer has parameter virtual_appliance_connections info [Changelog] - Removed operation group NetworkVirtualApplianceConnectionsOperations
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-network-generated [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Type of `VirtualApplianceConnectionProperties.RoutingConfiguration` has been changed from `*RoutingConfigurationNfv` to `*RoutingConfiguration` info [Changelog] - Struct `PropagatedRouteTableNfv` has been removed info [Changelog] - Struct `RoutingConfigurationNfv` has been removed info [Changelog] - Struct `RoutingConfigurationNfvSubResource` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New value `ActionTypeJSChallenge` added to enum type `ActionType` info [Changelog] - New value `BastionHostSKUNameDeveloper` added to enum type `BastionHostSKUName` info [Changelog] - New value `FirewallPolicyIDPSSignatureDirectionFour`, `FirewallPolicyIDPSSignatureDirectionThree` added to enum type `FirewallPolicyIDPSSignatureDirection` info [Changelog] - New value `VirtualNetworkGatewaySKUNameErGwScale` added to enum type `VirtualNetworkGatewaySKUName` info [Changelog] - New value `VirtualNetworkGatewaySKUTierErGwScale` added to enum type `VirtualNetworkGatewaySKUTier` info [Changelog] - New value `WebApplicationFirewallActionJSChallenge` added to enum type `WebApplicationFirewallAction` info [Changelog] - New enum type `FirewallPolicyIntrusionDetectionProfileType` with values `FirewallPolicyIntrusionDetectionProfileTypeAdvanced`, `FirewallPolicyIntrusionDetectionProfileTypeBasic`, `FirewallPolicyIntrusionDetectionProfileTypeExtended`, `FirewallPolicyIntrusionDetectionProfileTypeStandard` info [Changelog] - New function `*ManagementClient.BeginDeleteBastionShareableLinkByToken(context.Context, string, string, BastionShareableLinkTokenListRequest, *ManagementClientBeginDeleteBastionShareableLinkByTokenOptions) (*runtime.Poller[ManagementClientDeleteBastionShareableLinkByTokenResponse], error)` info [Changelog] - New struct `BastionShareableLinkTokenListRequest` info [Changelog] - New struct `InternetIngressPublicIPsProperties` info [Changelog] - New field `HostNames` in struct `ApplicationGatewayListenerPropertiesFormat` info [Changelog] - New field `Profile` in struct `FirewallPolicyIntrusionDetection` info [Changelog] - New field `InternetIngressPublicIPs` in struct `VirtualAppliancePropertiesFormat` info [Changelog] info [Changelog] Total 7 breaking change(s), 20 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-network [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added Interface BastionShareableLinkTokenListRequest info [Changelog] - Added Interface DdosCustomPoliciesDeleteHeaders info [Changelog] - Added Interface DeleteBastionShareableLinkByTokenOptionalParams info [Changelog] - Added Interface InternetIngressPublicIpsProperties info [Changelog] - Added Interface NetworkManagementClientDeleteBastionShareableLinkByTokenHeaders info [Changelog] - Added Type Alias DeleteBastionShareableLinkByTokenResponse info [Changelog] - Added Type Alias FirewallPolicyIntrusionDetectionProfileType info [Changelog] - Interface ApplicationGatewayListener has a new optional parameter hostNames info [Changelog] - Interface FirewallPolicyIntrusionDetection has a new optional parameter profile info [Changelog] - Interface NetworkVirtualAppliance has a new optional parameter internetIngressPublicIps info [Changelog] - Added Enum KnownFirewallPolicyIntrusionDetectionProfileType info [Changelog] - Enum KnownActionType has a new value JSChallenge info [Changelog] - Enum KnownBastionHostSkuName has a new value Developer info [Changelog] - Enum KnownVirtualNetworkGatewaySkuName has a new value ErGwScale info [Changelog] - Enum KnownVirtualNetworkGatewaySkuTier has a new value ErGwScale info [Changelog] - Enum KnownWebApplicationFirewallAction has a new value JSChallenge info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Type of parameter routingConfiguration of interface NetworkVirtualApplianceConnection is changed from RoutingConfigurationNfv to RoutingConfiguration
️🔄 azure-resource-manager-schemas inProgress [Detail]
️❌ azure-powershell failed [Detail]
command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
⚠️Az.network.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.network.DefaultTag
Generated ApiView
|
This was referenced Oct 13, 2023
AzureRestAPISpecReview
added
ARMReview
CI-MissingBaseCommit
new-api-version
resource-manager
WaitForARMFeedback
|
Hi @Joanna-Yang-Art! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Oct 13, 2023
* fixes * making changes in new api version --------- Co-authored-by: Manas Chakka <manaschakka@microsoft.com>
* [NVA] Internet Ingress Parameters * LintDiff Fix * Minor Fix
|
Approving the suppression from last PR |
zizw123
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Alancere
added
the
Approved-SdkBreakingChange-Go
|
/pr RequestMerge |
scbedd
reviewed
Nov 7, 2023
Thanks @scomtott for sign off, yes we already got ARM sign off and don't think it is a blocking issue for this release. This PR is a combination of all NRP partner PRs. We will reach out to NRP partners who made those changes and see if anything they could do with the error or it is something they think of by design and the test need to have an update or ignore it. Attached email discussion @rkmanda or whoever help merge PRs, please kindly help us merge this PR |
scbedd
approved these changes
Nov 7, 2023
The swagger modelValidation should be fixed, if you only need to update your examples, what is blocking this? |
Hi @zizw123 The ModelValidation shouldn't block us from merged this PR, we have been seeing the error on every release, before it was not blocked us in Automated merging requirements met. |
zizw123
deleted the
release-network-Microsoft.Network-official-2023-06-01
branch
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Nov 8, 2023
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01 * Updates readme * Updates API version in new specs and examples * Add missing DeleteBastionShareableLinkByToken API back to swagger (#25599) * add DeleteBastionShareableLinkByToken endpoint * fix location link format * Adding Developer Sku (#25887) * Firewall Policy - IDPS profiles (#25666) * add profile to put example * fixed RuleCollectionGroupWithHttpHeadersToInsert example * add profile to Policy model * description change * indentation * ListIdpsSignatures description change * direction description+enum fix * fix FirewallPolicyIDPSSignatureSeverity description * hostnames for l4 listeners (#25982) * added ergwscale support (#25969) * Fixed examples for gateway load balancer (#26058) * Add support for JSChallenge action in Application Gateway Web application Firewall (#26149) * Add support for JSChallenge action Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules * Update WafPolicyGet.json * Update WafPolicyCreateOrUpdate.json * DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (#26248) * fixes * making changes in new api version --------- Co-authored-by: Manas Chakka <manaschakka@microsoft.com> * [NVA] Internet Ingress Parameters (#26262) * [NVA] Internet Ingress Parameters * LintDiff Fix * Minor Fix * Added description for each of the enums for ApplicationGatewayProtocol (#26437) * Added description for each of the enums for ApplicationGatewayProtocol * Spacing for prettier checks * Remove routingConfigNfv (#25962) * remove routingConfigNfv * remove api from older versions * remove PUT nvaconnection from older versions * apply prettier check * add suppression for modelValidation * remove suppression due to approval * Fix lint errors & add supressions (#26494) * fix lint error * add supression for ResourceNameRestriction & LroErrorContent * fix example accordingly --------- Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com> Co-authored-by: Sijie Lin <97983749+msftsijielin@users.noreply.github.com> Co-authored-by: anvrao1 <109107918+anvrao1@users.noreply.github.com> Co-authored-by: NiviShenker <99583088+NiviShenker@users.noreply.github.com> Co-authored-by: gdhillon24 <105729965+gdhillon24@users.noreply.github.com> Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: Manas Chakka <mchakka@gmail.com> Co-authored-by: Manas Chakka <manaschakka@microsoft.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: rutuja-s <42910715+rutuja-s@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.