Release release sentinel microsoft.security insights 2023 09 01 preview #25845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w/2023-08-01-preview to version 2023-09-01-preview
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| AlertRules.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| AlertRules.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| AutomationRules.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| AutomationRules.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| BillingStatistics.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| Bookmarks.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| Bookmarks.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| ContentPackages.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| ContentProductPackages.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| ContentProductTemplates.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| ContentTemplates.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| Enrichment.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| Entities.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| EntityQueries.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| EntityQueryTemplates.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| FileImports.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| Hunts.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| Incidents.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| Incidents.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| Metadata.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| Metadata.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| OfficeConsents.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| OnboardingStates.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| OnboardingStates.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| Recommendations.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| SecurityMLAnalyticsSettings.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| SecurityMLAnalyticsSettings.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| Settings.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| SourceControls.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| ThreatIntelligence.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| ThreatIntelligence.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| TriggeredAnalyticsRuleRuns.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| Watchlists.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| Watchlists.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| WorkspaceManagerAssignments.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| WorkspaceManagerConfigurations.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| WorkspaceManagerGroups.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| WorkspaceManagerMembers.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| AlertTypes.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| AlertTypes.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| ContentCommonTypes.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| EntityTypes.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| EntityTypes.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| IncidentTypes.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| IncidentTypes.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| RelationTypes.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| ThreatIntelligenceTypes.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| dataConnectorDefinitions.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| dataConnectors.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
| operations.json | 2023-09-01-preview(b90857c) | 2023-02-01(main) |
| operations.json | 2023-09-01-preview(b90857c) | 2023-08-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| package-preview-2023-09 | package-preview-2023-09(b90857c) | default(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/Bookmarks.json#L566 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/EntityQueries.json#L484 |
|
Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/EntityQueryTemplates.json#L234 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/EntityQueryTemplates.json#L292 |
|
Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/Incidents.json#L1245 |
|
Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/Incidents.json#L1332 |
|
Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/operations.json#L83 |
|
Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique. The duplicate x-ms-enum name: priority, path: $['RecommendationPriority'] Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/Recommendations.json#L511 |
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get a template. Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/ContentTemplates.json#L148 |
|
| OperationId should contain the verb: 'dataconnectorscheckrequirements' in:'DataConnectorsCheckRequirements_Post'. Consider updating the operationId Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/dataConnectors.json#L488 |
|
| OperationId should contain the verb: 'gettimeline' in:'EntitiesGetTimeline_list'. Consider updating the operationId Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/Entities.json#L243 |
|
| Based on the response model schema, operation 'Entities_Queries' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/Entities.json#L281 |
|
| Based on the response model schema, operation 'SentinelOnboardingStates_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/OnboardingStates.json#L178 |
|
| Based on the response model schema, operation 'GetRecommendations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/Recommendations.json#L38 |
|
| Based on the response model schema, operation 'ProductSettings_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/Settings.json#L38 |
|
| The resource SourceControl does not have a corresponding delete operation. Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/SourceControls.json#L343 |
|
| Based on the response model schema, operation 'ThreatIntelligenceIndicatorMetrics_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/ThreatIntelligence.json#L334 |
|
| OperationId should contain the verb: 'jobs' in:'WorkspaceManagerAssignmentJobs_Create'. Consider updating the operationId Location: Microsoft.SecurityInsights/preview/2023-09-01-preview/WorkspaceManagerAssignments.json#L297 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Sep 18, 2023
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
|
Hi @xuhumsft! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Sep 18, 2023
|
Breaking changes previously reviewed and approved in #25826. |
mikekistler
added
the
Approved-BreakingChange
xuhumsft
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
visingla-ms
approved these changes
Sep 20, 2023
visingla-ms
deleted the
release-release-Sentinel-Microsoft.SecurityInsights-2023-09-01-preview
branch
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Sep 20, 2023
dargilco
pushed a commit
that referenced
this pull request
Sep 21, 2023
…ew (#25845) * Adds base for updating Microsoft.SecurityInsights from version preview/2023-08-01-preview to version 2023-09-01-preview * Updates readme * Updates API version in new specs and examples
rhurey
added a commit
that referenced
this pull request
Sep 27, 2023
* [TypeSpec] Upgrade to 0.48.0 (#25797)
* Move 2020-06-30 from prreview to stable (#25788)
Co-authored-by: Zeeshan Sayyed <sazeesha@microsoft.com>
* Update readme.python.md (#25787)
* Update readme.python.md (#25808)
* [Azure Cognitive Search] New API version 2023-10-01-Preview (#25657)
* Initial commit (copy from 07-01 and rename to 10-01)
* Add new IndexProjections feature definition
* New SplitSkill parameters
* New AzureOpenAIEmbeddingSkill
* Miscellaneous existing features that were missing from swagger
* Breaking changes to VectorSearch and new Vectorizer option
* Add filterType and exhaustive KNN options to vector search.
* Fix build errors and update README
* Move filter type outside of vector object, and remove single vector query option
* Add filterType and exhaustive KNN to 2023-07-01-Preview API
* Revert "Add filterType and exhaustive KNN to 2023-07-01-Preview API"
This reverts commit 56a0bbd64556a08b29d941406e56db83519ff1c0.
* Respond to feedback
* Add semanticQuery search parameter
* Update default for semanticErrorHandling
* Remove AML vectorizer
* Update descriptions per feedback
* add asm- prefix to upgrades field on mesh ops (#25600)
* Adding the x-ms-pageable extension for rulestack POST list APIs. (#25772)
* [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2023-06-01 (#25642)
* Restructured folder (#25623)
* corrective change (#25748)
* Alec baird desktopvirtualization microsoft.desktop virtualization 2023 09 05 (#25747)
* Adds base for updating Microsoft.DesktopVirtualization from version preview/2023-07-07-preview to version 2023-09-05
* Updates readme
* Updates API version in new specs and examples
* Added Scaling breaking changes to swagger
* ARG Query Generation API in 2023-09-01-preview (#25699)
* Adds base for updating Microsoft.ResourceGraph from version stable/2022-10-01 to version 2023-09-01-preview
* Updates readme
* Updates API version in new specs and examples
* Updated ARG Swagger Specs by Adding Copilot Swagger.
* Updated ARG Copilot Swagger Spec with Linter Fix.
* Updated ARG Swagger Spec ReadMe with Avocado Fix.
* Updated ARG Swagger Specs to Handle Linter Issue.
* [ACR] Mark all endpoints as deprecated for 3 oldest preview API's (#25554)
* Update containerregistry.json
* Update containerregistry.json
* Update containerregistry_build.json
* [TypeSpec Validation] Skip deleted folders in Get-TypeSpec-Folders.ps1 (#25841)
- Fixes #25839
* [Hub Generated] Publish private branch 'azure-kusto/devCM' (#25434)
* introduce version 2023-08-15 base (copy of 2023-05-02)
* [AutoSync] ee0e78b60ea Merged PR 8558577: Start DB soft delete orchestration only if data recoverability enabled
* [AutoSync] 805c12a9c08 Merged PR 8564800: Automatic sync from dev to devCM
* [AutoSync] 4dde0dd1d96 Merged PR 8565943: [Swagger] declare both Location & Azure-AsyncOperation headers
* [AutoSync] 73264aa5f91 Merged PR 8617414: [Swagger] allow zone update on cluster patch
* [AutoSync] 4104e27d106 Merged PR 8629398: [Sawgger] sandboxCustomImage
* OutboundNetworkDependenciesEndpointProperties - EndpointDetail - add ipAddress
---------
Co-authored-by: swagger-automation <swagger@microsoft.com>
* [Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2023-07-12-preview (#25472)
* Adds base for updating Microsoft.AlertsManagement from version preview/2019-05-05-preview to version 2023-07-12-preview
* Updates readme
* Updates API version in new specs and examples
* added enrichments api
* fixing errors
* fixed more erros
* cont
* cont
* cont
* cont
* cont
* trying to fix errors
* cont
* cont
* cont
* cont
* used v5/types.json
* Used Resource definition from common-types
* Updated descriptions.
* set "x-ms-parameter-location": "method" for "scope" parameter
* Suppress lint err
* another try to suppress lint err
* [TypeSpec Validation] Remove duplicate error messages in Get-TypeSpec-Folders.ps1 (#25846)
- Continuation of #25841
* Add missing api version for python sdk. (#25672)
* java configure, mgmt, playwright, client name (#25854)
* java configure, mgmt, playwright, client name
* Update readme.java.md
* [App Configuration] Introduce API version 2023-10-01 (#25454)
* Promote to stable.
* Update API version to 2023-10-01
* Add readme tag for new api versin.
* Specify new api version in multi-api generation.
* Include latest api version in default tag.
* fix package tags.
* Updated Rooms Readme to use latest API version as default (#25835)
* Renaming MPCNetwork to follow the typespec convention (#25821)
* rename MPCNetwork
* special-casing two-letter acryonyms
* rename healthInsights (#25810)
* [Hub Generated] Publish private branch 'tbyfield-devcenter-Microsoft.DevCenter-2023-08-01-preview' (#25692)
* add or modify files
* Removed reference to 2023-06-01-preview API in readme.md. This API version was not published to public repo
* [Hub Generated] Review request for Microsoft.Help to add version preview/2023-09-01-preview (#25604)
* Adds base for updating Microsoft.Help from version stable/2023-06-01 to version 2023-09-01-preview
* Updates readme
* Updates API version in new specs and examples
* adding swagger for public preview
* update readme
* updating documentation
* adding documentation
* fix list
* addressing comments
* updating description
* updating continue GT
* fixing errors
* fixing enum
* fix prettier check
* adding Guidance
* update
* Update GT documentation
* Update GT example
* fix GT doc errors
* fix doc
* fix error
* [TypeSpec Validation] verify folder structure (#25712)
* folder structure
* typespec folder depth limit
* main.tsp and client.tsp
* fix windows separator issue
* fix x-ms-mutability (#25825)
* [Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-08-01 (#25633)
* Adds base for updating Microsoft.ContainerService/aks from version stable/2023-07-01 to version 2023-08-01
* Updates readme
* Updates API version in new specs and examples
* update (#25468)
* Adding Azure Service Mesh and related changes. (#25482)
* Adding Azure Service Mesh and related changes.
* Fix a typo with api version in examples
* fix a bug with egressGayeways for Istio
* add resourceuid field to managed cluster properties (#25478)
* Adding examples for AzureServiceMesh (#25535)
* Adding an example for AzureServiceMesh
* remove unneeded adonprofiles object
* Adding ingressGateway to the ASM example.
* Adding egressGateways to IstioComponents
* Add egressGateways to the request payload.
* Add BYO CA object to ServiceMeshProfile example
* Fix resource id format for Azure keyvault
* Enrich ASM examples (#25597)
* add asm- prefix to upgrades field on mesh ops (#25601)
---------
Co-authored-by: deveshdama <87668846+deveshdama@users.noreply.github.com>
Co-authored-by: daru__ <ptd2108@columbia.edu>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* Release release sentinel microsoft.security insights 2023 09 01 preview (#25845)
* Adds base for updating Microsoft.SecurityInsights from version preview/2023-08-01-preview to version 2023-09-01-preview
* Updates readme
* Updates API version in new specs and examples
* [Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2023-09-15-preview (#25326)
* Adds base for updating Microsoft.DocumentDB from version preview/2023-03-15-preview to version 2023-09-15-preview
* Updates readme
* Updates API version in new specs and examples
* Add remoteAccountName in DTS create job
* Update cosmos-db.json
* Update custom-words.txt
* Added EnablePriorityBasedExecution and DefaultPriorityLevel properties (#25470)
* Added Changes for Priority Based Execution
* Whitespace change
---------
Co-authored-by: Achint Agrawal <acagrawal@microsoft.com>
* Added SecuredByPerimeter enum value
* Added liana's 04-15 changes - MaximumThroughput
* Fix comment
* Update model name
* Revert changes to model
* Added clarification for throughput/autoscaleSettings option
* Update MI Cassandra preview swagger (#25704)
* Updated preview swagger
* Removed repair additions and updated example files
* fix examples
* Fix prettier check for examples (#25833)
---------
Co-authored-by: Nitesh Vijay <niteshvijay@microsoft.com>
Co-authored-by: AdrianSibajaRetana <54075415+AdrianSibajaRetana@users.noreply.github.com>
Co-authored-by: Achint-Agrawal <45819170+Achint-Agrawal@users.noreply.github.com>
Co-authored-by: Achint Agrawal <acagrawal@microsoft.com>
Co-authored-by: Praful Johari <pjohari@microsoft.com>
Co-authored-by: carjackson-msft <124716637+carjackson-msft@users.noreply.github.com>
Co-authored-by: DrewKaufmann <131404826+DrewKaufmann@users.noreply.github.com>
Co-authored-by: Arthur Ma <arthurma@microsoft.com>
* Changed data type from uuid to string in API response (#25867)
Co-authored-by: Madhuri Jain <jmadhu@microsoft.com>
* Azure OpenAI: minimal, partial specification for Whisper transcription/translation (#25734)
* minimalistic whisper .tsp definitions
* merge, format, remove client.tsp changes for mvp simplicity
* speculative example JSON update for string response types
* restore header traits for swagger hints
* review pass, prioritize object response for OpenAPI v2
* PR feedback: fully distinguish transcription/translation models
* Updating the Azure Search code owners (#25842)
* Updating the Azure Search code owners
* Removing old code owner
* Removing other stale owners, adding Giuliano
---------
Co-authored-by: Conor Joplin <cojoplin@microsoft.com>
* in-place rename of prompt_annotations to prompt_filter_results (#25880)
* [OpenAI] Update swagger with latest TypeSpec (#25883)
- Continuation of #25734
* Rename Microsoft.StorageTasks to Microsoft.StorageActions (#25847)
* Replace Microsoft.StorageTasks to Microsoft.StorageActions
* Updating readme.md file and OperationsList Example
* [Hub Generated] Review request for Microsoft.AlertsManagement to add example to version stable/2023-03-01 (#25552)
* add example
* fix typo
---------
Co-authored-by: Moshe Malka <momalka@microsoft.com>
* Updated readme.md for openapi subtype (#25884)
* Wwendyc playwrighttesting microsoft.azure playwright service 2023 10 01 preview (#25888)
* Updated readme.md for openapi subtype
* Updated swagger spec to remove required for read-only property
* Adding optional to dashboard Uri
* [Cdn] Add new preview API: 2023-07-01-preview (#24387)
* Copy latest stable version 2023-05-01 to preview directory
* Rename to 2023-07-01-preview version
* Update to new api and rebase all api validation fixes.
* Fix ModelValidationErrors in existing example files
* Revert "Fix ModelValidationErrors in existing example files"
This reverts commit 62ed1c164961f24232caab52d65dcc00984beaa2.
* Update comment
* try fix validation errors in endpoints_get:
* Try fix again
* Reuse cdn.json UrlSigningParamIdentifier
* Wwendyc playwrighttesting microsoft.azure playwright service 2023 10 01 preview (#25889)
* Updated readme.md for openapi subtype
* Updated swagger spec to remove required for read-only property
* Adding optional to dashboard Uri
* Made readonly fields as optional for data-plane
* managedapplications servicename (#25892)
* Fix serviceOperation version for 2023-06-01-preview (#25875)
* fix
* fix
* fix
* fix
* Update readme.python.md
---------
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
* [Hub Generated] Review request for Microsoft.ConnectedVMwarevSphere to add version stable/2023-10-01 (#25409)
* Adds base for updating Microsoft.ConnectedVMwarevSphere from version preview/2023-03-01-preview to version 2023-10-01
* Updates readme
* Updates API version in new specs and examples
* remove VM APIs
* update
* 2023-10-01-preview API Review feedback fixes (#25862)
* Remove authResourceId from open AI vectorizer and custom skill
* swagger changes in response to feedback
* rename to "VectorizableTextQuery"
---------
Co-authored-by: Robert Lee <robertlee@microsoft.com>
* Update readme.java.md (#25921)
* Update readme.java.md
* update directive
* remove track 1 settings
* Update cosmos-db.json to add type to operation (#25905)
* Release elasticsan microsoft.elastic san 2023 01 01 ga (#25687)
* Adds base for updating Microsoft.ElasticSan from version preview/2022-12-01-preview to version 2023-01-01
* Updates readme
* Updates API version in new specs and examples
* Added snapshot API & SourceId change (#25073)
* Added snapshot API & SourceId change
* removed state from virtualNetworkRule
* add CMK changes
* add object type on properties
* add managedby property
* Removed PATCH Snapshot API, Added forceDeleteFlags for volume, added provisioning state from volume, added publicNetworkAccess
* Added proper examples
* resolved Prettier check
* removed export, added enum for force-delete
* Updated operationID & resolved comments
---------
Co-authored-by: Harshjeet Aulakh <haulakh@microsoft.com>
* Adding update to x-ms-mutability (#25725)
* Adding update to x-ms-mutability
* updated examples as per need of teraform
* added managedBy in Update properties
* prettier check
---------
Co-authored-by: Harshjeet Aulakh <haulakh@microsoft.com>
* [Hub Generated] Review request for Microsoft.DocumentDB to add version stable/2023-09-15 (#25266)
* Adds base for updating Microsoft.DocumentDB from version stable/2023-04-15 to version 2023-09-15
* Updates readme
* Updates API version in new specs and examples
* burst capacity changes (#25116) (#25267)
* burst capacity changes
* Updated cosmos-db.json to include "type" of "Operation"
* Update cosmos-db.json to reflect customerManagedKeyStatus.
* lint fix (#25336)
* Fixed typo and removed semantic reference
* Validation fix (#25338)
* lint fix
* validation fix
* Added CustomerManagedKeyStatus enum and correspondent references.
* Update custom-words.txt
* Update cosmos-db.json
* rollback lint fix
* suppressing avocado errors
* Added space to rerun checks.
* prettier fix
* undo suppression as it is not working
* Added clarification for throughput/autoscaleSettings option
* removing added space
---------
Co-authored-by: vchske <chskelt@microsoft.com>
Co-authored-by: AdrianSibajaRetana <54075415+AdrianSibajaRetana@users.noreply.github.com>
Co-authored-by: carjackson-msft <124716637+carjackson-msft@users.noreply.github.com>
* Adding Provisioning,PendingCommit values in the ConfigurationState.. (#25618)
* Adding Provisioning,PendingCommit values in the ConfigurationState..
* Changes in the Internet Gateway Rules.
* 1. Reverting the changes in the InternetGatewayRules.
2. Added option enum param to the body in Post Action Upgrade
* Update `workflows/comment.yml`: add exponential backoff to adding `MergeRequested` label (#25942)
* [TypeSpec Validation] Add "specification/common-types" to triggers (#25945)
* [Hub Generated] Review request for Microsoft.ConfidentialLedger to add version preview/2023-06-28-preview (#24632)
* Adds base for updating Microsoft.ConfidentialLedger from version preview/2023-01-26-preview to version 2023-06-28-preview
* Updates readme
* Updates API version in new specs and examples
* added running state and mccf update example
* added backup and restore for ledger and mccf
* updated backup restore specs
* Sync fork (#25422)
* Update readme.md for latest SDK release (#24618)
Updating tag to release official SDKs based on latest preview version
* [typespec-ci] Add pr trigger for eng/tools/TypeSpecValidation (#24640)
* Azure OpenAI: reuse LRO response model as status polling model (#24556)
* Azure OpenAI: reuse LRO response model as status polling model
* incorporate unreachable type omission for limitation of breaking change triggers
* batch rename for new LRO tack
* Updates after clarification on sync parity snap
* Update: adjustments after re-snap to plans for converged sync API
* Adjustments based on feedback and .NET viability experiments
* Example naming update (caught by CI)
* Example update
* PR feedback and re-disabling ts (will treat separately)
* [TypeSpecValidation/ Format document (#24642)
* Typespec EGv2 Clean CI (#24361)
* update to ResourceAction
* add eventgrid to ci
* example files to be added
* publishexample model after 2018-01-01
* dummyfile
* casing
* remove enum doc
Co-authored-by: Mike Harder <mharder@microsoft.com>
* add examples
* update to just be 200 responses for now
* fix warnings
* response body
* remove additional properties
* remove additional prop 2
* ran prettier
* spacing
* format
* namespace got deleted
* remove utf-8
* format
* format
* nit sample
* Add specification/eventgrid to PR triggers
* update tsp format
* add package dir to c#
* .NET still using directory-name
* update package-dir
* try without quotes like previous config
* namespace
* namespaces
* dir of V2 as in feature branch
* commenting out csharp gen
---------
Co-authored-by: Mike Harder <mharder@microsoft.com>
* [typespec-ci] Discard git changes (#24650)
- Feature was accidentally lost in the bash-to-TypeScript conversion
* adding mutability flag to the identity property ACS (#24477)
* adding mutability flag to the identity property ACS
* Updated base tag to package preview 2023-04
* fix prettier issues
* Add new stable API-version 2023-05-01 in Microsoft.Dataprotection (#24011)
* Base commit from 2023-01-01
* Change API-version from 2023-01-01 to 2023-05-01
* Add hooks changes in Microsoft.Dataprotection
* Correctness fix resProperties,rehydrationPriority
Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>
* revert latest commit
* Add change for secureScore, Correctness fix resProperties,rehydrationPriority and update readme files
* Add example regarding change for secureScore
* Removing readonly secureScore from request
* Using UserAssignedIdentity from common-types definitions
---------
Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>
Co-authored-by: SHASHANK SINGH <shashasingh@microsoft.com>
Co-authored-by: amchandn <43201777+amchandn@users.noreply.github.com>
* update (#24655)
* [TypeSpecValidation] Enable simple-git logging (#24656)
* Add multi-vector support to search requests (#24614)
* Fixing the API-version in ManagedServices examples (#24578)
* Fixing the API-version in ManagedServices examples
* Addressing the swagger errors
* Addressing the Location header issue on Delete Registration assignment Async operation response
* [Hub Generated] Review request for Microsoft.NotificationHubs to add version preview/2023-01-01-preview (#24072)
* Adds base for updating Microsoft.NotificationHubs from version stable/2017-04-01 to version 2023-01-01-preview
* Updates readme
* Updates API version in new specs and examples
* Notification Hubs: adding API version 2023-01-01-preview
* Notification Hubs: udpating custom words
* Notification Hubs: updating custom-words
* Changing zoneRedundant (boolean) to zoneRedundancy (enum), making Network ACLs optional
* Notification Hubs: updating examples
* Notification Hubs: fixing property name
* Notification Hubs: fixing examples
* Notification Hubs: resolving some of PR comments
* Notification Hubs: adding x-ms-long-running-operation to one of Private Link operations
* Notification Hubs: removing internal MoveResourceRequest
* Notification Hubs: fixing merge marker
* Notification Hubs: fixing zoneRedundancy
* Notification Hubs: updating Swagger
* Notification Hubs: updating samples
* Notification Hubs: renaming $count to $top
* Notification Hubs: removing 200 response from PrivateEndpointConnection.Delete
* Notification Hubs: fixing async operation annotations
* NotificationHubs: suppressing linter error
* Notification Hubs: fixing async operation annotations
* Notification Hubs: fixing async operation annotations
* Notification Hubs: removing 201 for three operations
* Notification Hubs: adding back response 201 for Notification Hubs - Create or Update
* Notification Hubs: cleanup in 201 status codes
* Notification Hubs: updating ids in examples
* Notification Hubs: updating two examples
* fist add reademe.go.md (#24674)
* Updated correlationInterval example value (#24584)
* add 'location' in example parameter (#24675)
* update example parameter (#24676)
* update example parameter
* update file
* add typescript.md for new service (#24694)
* Form Recognizer v3.1 GA (2023-07-31) (#24634)
* Copy 2023-02-28-preview to 2023-07-31
* v3.1 GA changes
* Update documentation for REST docs
* Add 2023-06-01-preview for Web PubSub (#24268)
* Original commit
* Add 2023-06-01-preview for signalr and webpubsub
* remove no-op Avocado suppressions (#24703)
* Improve automation comment contents formatting (#24704)
* fix update example files for docs generation (#24710)
* fix update example files for docs generation
* fix prettier issues
---------
Co-authored-by: Joel Enikanorogbon <joelen@microsoft.com>
* FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#24716)
* Add prIssueManagement.yml to onboard repo to GitOps.ResourceManagement as FabricBot replacement
Owners of the FabricBot configuration should have received email notification. The same information contained in the email is published internally at: https://aka.ms/gim/fabricbot. Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html
Please review and merge this PR to complete the process of onboarding to the new service.
* Deleting fabricbot.json
---------
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
* Adding formatting on save for ts files (#24646)
* Adding formatting on save for ts files
* scoping to eng folder
* cleanup
* aligning prettier with typespec repo
* update tsv.ts formatting
* scoping typescript prettier to entire repo
* revert package-lock
* Added devcontainer for spec writers (#24622)
* Added devcontainer for spec authors
* Adding dockerfile
* Adding comment
* Adding convenient usage and conventions of the sdk repo path
* change MongoDbAtlasDriver name (#24709)
Co-authored-by: Zehua Chen <zehuachen@microsoft.com>
* Remove annotations (#24723)
* [Hub Generated] Publish private branch 'release-managedNetworkFabric-GA' (#24673)
* add or modify files
* Updating the readme.md
1. removing the private-preview data
* Removing the dotnet-sdk error
* Resolving the issue caused due to the backward compatibility.
* S360 Item - Missing Get SubscriptionOperations for 2021-10-01 version. (#24395)
* Resolving S320 Item - Missing Get SubscriptionOperations for 2021-10-01 version.
* Fix pipeline suggestions.
* Minor fix.
* Make Get Subscription operations sync in this version.
* Added suppress rules for failing lint errors.
* Fix suppression Issues.
* Minor fix suppression GetOperation200.
* Address minor fixes.
* Address GetOperation200 changes.
* Update readme.md: attempt suppression fix by adding ["202"] to "responses" to path
---------
Co-authored-by: Abhay Pratap <abhaypratap@microsoft.com>
Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
* add auth and fix some generated code issue in .net (#24725)
* add auth and fix some generated code issue in .net
* fixed style issue and revert property name change
* removed unused options in JS emitter
* Updated namespace value to Azure.Template
* revert examples-directory config change
* Update ci-fix cadl -> TypeSpec update (#24535)
* Update codeowners for postgresql (#24456)
Got a new team created in Azure org @Azure/azure-sdk-write-postgresql
* Add base64 formatting to contentInBase64 property (#24617)
* Add base64 formatting to contentInBase64 property
* Update base64 string
* Update base64 example string in SendEmail.json
* [Hub Generated] Review request for Microsoft.DevCenter to add version preview/2023-07-01-preview (#24291)
* Adds base for updating Microsoft.DevCenter from version preview/2023-01-01-preview to version 2023-07-01-preview
* Updates readme
* Updates API version in new specs and examples
* Add schedule and troubleshoot APIs, add generic id property, update examples
* Add troubleshoot example and update environment examples
* Add ID to project
* Add environment operations API
* Re-add last operation ID
* Run prettier
* Add ID to delay result
* Add suppression for host parameters validation
* Remove last operation ID
* Update with aligned operations API, URI property, file type log response
* Remove old examples
* Fix naming
* Update TTL to 90 days on operations, add delete operationkind
* Add sourceType
* Remove old model
* Use an enum for status
* Consolidate on "sourceUri" for consistency with "uri" property
* Description updates
* Add NotStarted state
* Add default response and missing LRO options to resolve LintDiff warning.
* [Contoso.WidgetManager] Fix formatting (#24744)
- Fixes CI for #24725
* [Maps Search] Fix the array parameters in examples (#24658)
* Fix the array parameters in examples
* Prettier fix
* [OpenAI.Inference] Adding support for OpenAI functions. (#24534)
* Adding 2023-07-01-preview
* updating codegen
* Adding definitions for functions.
* fixes
* updates
* regenerated
* updating examples
* Updating based on some PR feedback
---------
Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com>
Co-authored-by: Travis Wilson <travisw@microsoft.com>
* [TypeSpec Validation] Move compile from "postinstall" to "build" (#24745)
- Compiling in "postinstall" breaks existing tools that copy "package.json" from repo root to spec folder
* Update Pricesheet properties for savingsPlan (#24708)
* Update consumption.json
* Update PriceSheet.json
* Update consumption.json
* Update PriceSheet.json
* Update consumption.json
* Update PriceSheet.json
* Update consumption.json
* Update consumption.json
* Update consumption.json
* Update PriceSheet.json
* elasticsan preview refresh microsoft.elasticsan 2022-12-01-preview (#24494)
* Adds base for updating Microsoft.ElasticSan from version preview/2021-11-20-preview to version 2022-12-01-preview
* Updates readme
* Updates API version in new specs and examples
* Added PE related changes
* Added Private Link resource API
* Nit change to correct the path for privateLinkResource API
* Updated Lint errors
* prettier check
* resolved comments & added publicNetworkAccess
* removed publicNetworkAccess & NIT changes
* Updated the list operations
* resolved lintDiff
* proper value for examples and removed value from PECollections
* resolved comments
* spell check resolved
* removing volumeCreateParameter
* [Hub Generated] Publish private branch 'InbalZim-storagemover-Microsoft.StorageMover-RPSaaSMaster-2023-07-01-preview' (#24390)
* add or modify files
* Updated `credentials` models according to PR #24318 + reverted unwanted changes to `readme.md`
* Removed URI format from SMB credentials to support it receiving empty string in order to clean-up their value
* Removed extra hierarchy of `AzureStorageFileShareEndpointBaseProperties`
* improve NR Examples (#24636)
* improve NR Examples
* addressing AutoRun Errors
* Fixing Prettier Issue
* Adding NextLink in Max Examples
* Formatting Azure Resource Id
* Updating Format of azure subscriptionIds
* update code owner (#24754)
* Update readme.python.md (#24758)
* [TypeSpecValidation] Refactor package.json (#24756)
- Improves upon #24745
- Creates eng/tools/package.json for all EngSys tools
- Moves "postinstall" to eng/tools/TypeSpecValidation/package.json
- Technically incorrect if the package were ever to be published to a registry
- In practice, the best way I have found so far to use source-based tools in a TypeScript repo
* workflow-bot comments: update breaking changes alternative C to point to alternative B (#24770)
* [Communication] Job Router Public Preview v2022-07-18 (#23804)
* Updated JR swagger with maxNumberOfJobs
* job scheduling swagger changes
* Enforce DistributionMode.kind to be read-only
* retry with removing Required tag from abstract property for DistributionMode
* WorkerState stopped showing up in generated swagger
* Add reofferTimeUtc to decline offer API
* Prettier
* Prettier
* rename WorkerState to RouterWorkerState
* more fixes in polymorphic types
* Rename decline offer request
* prettier fix
* add example for scheduled job
* cpsell fix
* fix response schema validation error
* address review feedback item round 1
* SDK review changes
* More API changes
* Update distribution mode required properties
* Renamings
* job matching mode added
* prettier fixes
* fix examples refs
* update ref examples
* update swagger spec
* fix enum mismatch
* change operator to labelOperator in classification policy get and update ops example
* Update specification/communication/data-plane/JobRouter/preview/2022-07-18-preview/communicationservicejobrouter.json
Co-authored-by: Liangying.Wei <lianwei@microsoft.com>
* hide redundant communicationerror and communicationerrorresponse during codegen
* revert commit
* fix typo
* test whether removing kind from request works
* revert removing kind from request
* make kind read-only
* run prettier
* try adding properties to empty classes
---------
Co-authored-by: Rajarshi Sarkar 🦄 <rsarkar@microsoft.com>
Co-authored-by: Rajarshi Sarkar <73562869+sarkar-rajarshi@users.noreply.github.com>
Co-authored-by: Liangying.Wei <lianwei@microsoft.com>
* [OpenAI] Rename properties for Java (#24596)
* renames
* more renames
* testing on the deploymentOrModelName
* revert for no breaking changes
* [TypeSpec] Upgrade to 0.46.0 (#24776)
* [OpenAI] Update generated autorest (#24788)
- Continuation of #24596
* Dynatrace.Observability merge to public repo (#24101)
* Initial Commit
* Updating version in all files
* Removed version from readme
* removing version which are not available from readme
* Resolving PR comments (#24205)
* Features/users/abhargava/merge to public repo (#24230)
* Resolving PR comments
* Features/users/abhargava/merge to public repo (#24233)
* Resolving PR comments
* Responding to the comment in PR review
* Fixed typo
* Features/users/abhargava/merge to public repo (#24253)
* Resolving PR comments
* Responding to the comment in PR review
* Fixed typo
* Added a suppression for Avacado issue
* Adding the required field
* Updating suppression reason
* Updating path for suppression
* Adding suppression for deprecated API
* suppression
* suppress
* Update specification/dynatrace/resource-manager/readme.md
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
* updating path in suppression
* updating suppression
* updating suppression
* Update specification/dynatrace/resource-manager/readme.md: WIP: fixing suppressions
Iteratively work on fixing suppressions
* Update readme.md: update suppressions
* Update readme.md: update suppressions
* Update readme.md: remove Avocado suppressions
---------
Co-authored-by: kanupriyasinghh <113429657+kanupriyasinghh@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
* Double Header Fix (#24760)
* [OpenAI.Inference] Adding content filter support (#24652)
* first-pass adding annotation
* FilterResult definitions
* move Filter definitions to common
* cleaning up naming and imports
* adding version headers
* added descriptions to objects
* correct self_harm JSON projection
* Correct to "prompt_annotations"
* "prompt_annotations" for chat, too
* Update specification/cognitiveservices/OpenAI.Inference/models/completions.common.tsp
Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com>
* Add per-choice content_filter_results to /completions
* tsp compile after merge
* recompile with 0.46.0 after today's update
---------
Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com>
Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com>
* Update OpenAI PR assignment (#24794)
* Update OpenAI PR assignment
* Update pull_request_assignment.yml
* [typespec-ci] Automatically detect spec folders to validate (#24629)
* [fist] mgmt, update service name (#24781)
* [typespec-pr] Add pipeline (#24802)
* [typespec-ci] Remove path wildcard (#24804)
* Update engsys CODEOWNERS (#24808)
* Align optionality of content filter categories (#24819)
* Add spec ARM PR review workflow diagram to ARM PR description template. (#24823)
* Add spec PR review workflow diagram to ARM PR description template.
* Update control_plane_template.md: fix link to diagram (#24828)
* Added generator config for OpenAI `Functions` for the Java SDK (#24765)
* Remove repeatability support for token revocation endpoint (#24589)
* Update clientTYpe (#24503)
* [Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (#24048)
* Revert "Revert "[Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (#23832)" (#23923)"
This reverts commit e6c0e188a74d051a3a44728ce058e85447553392.
* Removed 202 and Async supression.
* Update documentation.
* Updated documentation
---------
Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>
* [package-lock.json] Add names to local dependencies (#24846)
- Command "npm update" removes these names, but "npm install" adds them
- It's probably better to keep the names, since users are more likely to run "npm install"
* Update ci-fix.md: add API Doc Preview TSG (#24843)
* Update ci-fix.md: add API Doc Preview TSG
* Remove unsupported SQL Pool Rename/move operation (#24517)
* Updated text for property isSoftDeleteFeatureStateEditable (#24713)
* Updating folder structure for Microsoft.Migrate (#24550)
* folders restructure and update readme
* revert removed offazure in readme
* Removing readonly flag from top level object (#24848)
* [ACS JobRouter] Add misssing descriptions (#24842)
* Updated JR swagger with maxNumberOfJobs
* sync with upstream main
* add descriptions
* prettier fix
* add more missing descriptions
* add more description fixes
---------
Co-authored-by: williamzhao87 <williamzhao87@gmail.com>
* a couple of representation tweaks for codegen (#24847)
* Removed FunctionDefinition as custom class (#24870)
* Update readme.python.md (#24873)
* Update readme.python.md
* Update readme.python.md
* add title in typescript.md (#24879)
* Ericasp/number lookup preview (#24787)
* add isoCountryCode field (#24223)
* changed isoCountryCode description
---------
Co-authored-by: Erica <34174887+ericasp16@users.noreply.github.com>
Co-authored-by: Erica Sponsler <ericasp@microsoft.com>
* Update communicationserviceschat.json (#24845)
* update client name in typescript.md (#24894)
* update sphere ts.md (#24895)
* Convert previous preview version Private Link to GA: 2023-06-30 for mysql (#24738)
* copy previous version as base for 2023-06-30
* update api version
* update readme
* fix arm id
* Fixed code owner for NRP (#24889)
* Synapse SDK release [2023-06] (#24908)
* Anfranci/fixstartexectemplate2 (#24885)
* fix start job exec template required property
* fix start job exec template required property
* fix start job exec template required property
* SRP Swagger Updates for Jan23 [2023-01-01] Api Version GA (#23918)
* Full copy from 2022-09-01 to 2023-01-01 without any changes
* update examples api version, update swagger api version for each swagger, update readme files
* Feature: AutoUptier for LCM with example
* prettier check
* Update new deafults for allowBlobPublicAccess and allowCrossTenantReplication
* Feature: ObjectReplicationRestorePoint APIs with examples, validation and prettier check
* Feature: Customer Initiated Migration with validation and prettier check
* Feature: Planned Failover with validation and prettier check
* Feature: BlobInventoryPolicyFilter creation time with validation and prettier check
* Revert "Feature: ObjectReplicationRestorePoint APIs with examples, validation and prettier check"
This reverts commit 6942ddfc948f9693cd04e4768a361a6ab0607332.
* Address comments for autoUptier
* address Migration comments
* Update allowedMethods for CORS
* Revert "Address comments for autoUptier"
This reverts commit 5ac6d025ef1d2c5b5898f9e102d6f1cfa4271840.
* Revert "Feature: AutoUptier for LCM with example"
This reverts commit a1469d0b51914d11058e0cab8a7cc294e5aae761.
* remove autoUptier example
* targetSkuName description and migration name parameter
* Remove Get customer initiated migration
* Fix targetSkuName required property, fix typo
* Address lint diff new errors
* Add get migration back, fix uri for post migration
* remove query parameter from post migration
* Resolve Lint Diff errors
* Spell Chek errors
* Fix Post Migration example to return header
---------
Co-authored-by: Udit Sharma <uditsharma@microsoft.com>
* [Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-06-01 (#24581)
* Adds base for updating Microsoft.ContainerService/aks from version stable/2023-05-01 to version 2023-06-01
* Updates readme
* Updates API version in new specs and examples
* Hobov2 Swagger (#24471)
* Hobov2 Swagger
* fix error
* update python & java readmes (#24462)
* Bring Node os upgrade channel up GA from preview except security patch (#24487)
* bring nodeosimage up to GA except for security channel
* Update managedClusters.json
* add vpa (#24508)
Co-authored-by: zhifanhui <zhifanhui@microsoft.com>
* Allow user to specify draintimeout in ga api (#24488)
---------
Co-authored-by: Xu Xue <55420084+xuexu6666@users.noreply.github.com>
Co-authored-by: Paul Miller <paul.miller@gmail.com>
Co-authored-by: huizhifan <60024380+huizhifan@users.noreply.github.com>
Co-authored-by: zhifanhui <zhifanhui@microsoft.com>
Co-authored-by: Paul Miller <pmiller@microsoft.com>
* Release network microsoft.network official 2023 04 01 2 (#24841)
* Adds base for updating Microsoft.Network from version stable/2023-02-01 to version 2023-04-01
* Updates readme
* Updates API version in new specs and examples
* Double Header Fix (#24783)
* Add Basic sku to applicationGateway.json (#24717)
* Add http listeners alias to frontend ip config (#24718)
* Sync mode property on Load balancer backend pool (#24685)
* Sync mode property on Load balancer backend pool
* model fix
---------
Co-authored-by: unknown <anjbal@DESKTOP-ML6T5PL.redmond.corp.microsoft.com>
* Migrate to IP based LB API change (#24633)
* Migrate to IP based LB API change
* Nit Fix
* NIT Fix
* Add body param pools
* Param name update
---------
Co-authored-by: unknown <anjbal@DESKTOP-ML6T5PL.redmond.corp.microsoft.com>
---------
Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com>
Co-authored-by: russsantos <127546568+russsantos@users.noreply.github.com>
Co-authored-by: anjbal <137822143+anjbal@users.noreply.github.com>
Co-authored-by: unknown <anjbal@DESKTOP-ML6T5PL.redmond.corp.microsoft.com>
* Adding new APIs for billing visibility in new version 2023-07-01-preview for Microsoft.Elastic (#24587)
* Base API Commit
* Changing API version to 2023-07-01-preview
* Adding new apis for billing visibility
* updating readme.md
* added partnerEntityUri in the response
* model validation fixed
* taking parameters from v5 common types
* [typespec-ci] Improve change detection (#24825)
- Fixes #24813
- Fixes #24818
* [typespec - pr] Validate all specs if any changes to common files (#24826)
- Fixes #24814
* [typespec-ci] Disable PR trigger (#24920)
* Storage STG 90 (#24915)
* Added new version of Data Lake swagger (#23905)
* Added new Files swagger (#23907)
* Paginated Directory Delete (#24146)
* mgmt, java, azurestackhci, dedup name "Update" (#24924)
* update parameter name in selfhelp sample (#24928)
* Update TypeSpec get started guide (#24901)
* Update TypeSpec get started guide
* Update documentation/typespec-rest-api-dev-process.md
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
---------
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* [Hub Generated] Review request for Products to add version preview/2023-05-01-preview (#24678)
* Adds base for updating Products from version preview/2023-01-01-preview to version 2023-05-01-preview
* Updates readme
* Updates API version in new specs and examples
* 2023-05-01-preview version
* fix locations
* fix readme
* fix validations 1
* fix RAM
* Add has RI
* Remove dynamic page size query param
* Refactor operation id
* Fix readme
* Fix products operation id
* Documentation fix 1
* Documentation fix 2
* Documentation fix 3
* spell check fixes
* prettier fixes
---------
Co-authored-by: Oren Kafka <orkafka@microsoft.com>
* [Get-TypeSpec-Folders.ps1] Sort output alphabetically (#24932)
* [Validate-TypeSpec.ps1] Add GitClean switch (#24933)
- Continuation of #24629
* [Hub Generated] Publish private branch 'RPSaaSMaster' - NetworkCloud 2023-07-01 stable API (#24722)
* add or modify files
* removed non-published old private preview
* New stable api 2023-04-01 Microsoft.RedHatOpenShift (#23772)
* Previous API version
* New API 2023-04-01
* Fix swagger linting error
* Added xmsEnum for OutboundType
* Re-word description for OutboundType
* Microsoft.OperationalInsights: Correcting Total retention in days limitation. (#24574)
* OperationalInsights: 2022-10-01 stable version
* Actual changes.
* More fixes.
* more changes.
* Removing redundant breaking change.
* Workspace identity: referencing standard types.
* Referencing managed identity standard type, refactoring booleans into enum.
* Fixing examples.
* Removing duplicate resource.
* Update Workspaces.json
* Update Clusters.json
* Revert "Update Clusters.json"
This reverts commit 4eb99cf4699afeb95dc2bab1ee071c7d4f9ee2c5.
* Revert "Update Workspaces.json"
This reverts commit c16bc82f2ec8a35131c1ec54d2dca147eca929d1.
* Returning to our identity implementation.
* OperationalInsights 2022-10-01: Changing retentionInDaysAsDefault to boolean representation.
* redundant comma.
* redundant comma.
* Adding missing example header.
* Update TablesDelete.json
* Microsoft.OperationalInsights: Correcting Total retention in days limitation.
* config reademe.go.md (#24941)
* config reademe.go.md
* format
* [Hub Generated] Publish private branch 'main' (#23608)
* add swagger
* updated swagger
* Updated readme for Unified Vision Service
* fixed build error
* update api version
* fixed typo
* update comment
* Add examples
* fixed
* prettier
* add custom word
* Address some comments
---------
Co-authored-by: KUAN LU <kualu@microsoft.com>
* Changing operation name to match other related API for documentation (#24588)
* Update computeRPCommon.json (#24910)
* add directive mobilenetwork reademe.go.md (#24942)
* sql readme.go.md directive (#24610)
* sql readme.go.md directive
* rename to ServerPrivateEndpointConnectionProperties
* lenient-model-deduplication
* Saifahmed098 databoxedge microsoft.data box edge 2023 07 01 (#24926)
* Adds base for updating Microsoft.DataBoxEdge from version stable/2022-03-01 to version 2023-07-01
* Updates readme
* Updates API version in new specs and examples
* Adding string KubernetesWorkloadProfile in databoxedgeProperties
* Update readme.python.md (#24980)
* Update readme.python.md
* Update readme.python.md
* [ACS - Call Automation] [Beta2] Api spec for 2023-06-15-preview (#24482)
* Add beta2 api spec
* add readme
* fix lines
* Fix readme
* Added repeatability
* Fix 202 long running
* Fix header
* Fix the base
* Fix check
* added x-ms-long-running-operation
* add location
* fix example
* test
* test
* test
* fix
* test
* fix test
* test
* Fix
* test
* test
* fix
* Remove LRO
* Updates as per ARB feedback
* Updates as per ARB feedback
* Fix senddtmfTones
* Fix error
* Fix send dtmf description
* Update/remove obsolete docs (#24946)
* Add openapi docs for OpenAI api version 2023-07-01-preview (#24992)
* rename EdgeZoneStorageAccountType back to StorageAccountType to avoid breaking (#24988)
* Adding new optional parameter to Auto Patching (#24554)
* [TypeSpec Validation] Get-TypeSpec-Folders.ps1 should only validate all specs on selected files (#25010)
- Fixes #25006
* Update readme.python.md (#25009)
* Update readme.python.md
* Update readme.python.md
* [Hub Generated] Review request for Products to add version preview/2023-05-01-preview (#25014)
* Documentation fixes
* Documentation fixes 2
* Documentation fixes 3
* Documentation fixes 4
* Documentation fixes 5
---------
Co-authored-by: Oren Kafka <orkafka@microsoft.com>
* fix enum mismatch (#24559)
* Moving Markup rules API into separate file (#25003)
* [ACS Chat] [Rest API] Added chat thread metadata and participant meta… (#24837)
* [ACS Chat] [Rest API] Added chat thread metadata and participant metadata. (#24243)
* Updating ACS Chat swagger with Chat thread and participant metadata.
* Fixed swagger version.
* Fixed swagger version.
* Re-added data retention policy to the swagger.
* Update communicationserviceschat.json - changed metadata from string to dictionary
* Update communicationserviceschat.json
* Update communicationserviceschat.json
Corrected size limitations - should be 1k, not 2k
* Update communicationserviceschat.json
Added metadata to patch thread request
* Update communicationserviceschat.json
---------
Co-authored-by: Andrei Giurgiu <agiurg@microsoft.com>
* remove data retention from 2023-07-01
---------
Co-authored-by: Andrei Giurgiu <agiurg@microsoft.com>
Co-authored-by: Lu Chen <luc@microsoft.com>
* Added missing ArchiveStatus value (#25024)
* Update PrivateEndpointConnections to 2022-11-01-preview in v5 SDK (#25015)
* sql readme.go.md directive (#25029)
* sql readme.go.md directive
* fix
* [TypeSpec Validation] Rename yml files to match pipelines (#25036)
* Update readme.python.md (#25035)
* Disable creation of perimeter base rule (#24945)
* Disable creation of perimeter base rule
* Made NSP rule readonly
* Added email/sms rule changes
* Minor fix
* [Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-06-02-preview (#24922)
* Adds base for updating Microsoft.ContainerService/aks from version preview/2023-05-02-preview to version 2023-06-02-preview
* Updates readme
* Updates API version in new specs and examples
* Hobov2 Change Swagger Preview (#24472)
* Hobov2 Swagger
* fix error
* Add SSHAccess property to agent pool (#24460)
* Add SSHAccess property to agent pool
* add new line
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
---------
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
* update python & java readmes (#24461)
* Image Integrity swagger in 20203-06-02-preview (#24454)
* Image Integrity swagger in 20203-060-20-preview
* f
* f
* ff
---------
Co-authored-by: fseldow <fseldow@V-BRMCCA-MOBILE.redmond.corp.microsoft.com>
* Azure Service Mesh - BYO CA, Egress Gateway and Mesh Revisions (#24453)
* Azure Service Mesh - BYO CA and Egress Gateway
* prettier fix.
* adding changes for for revisions and meshversioncompatibilityprofile
* adding a missing parameter
* Changes as per lint failures
* Mikolaj/add custom node config 2023 06 02 preview (#24539)
* feat: add Ulimit config and updated sysctl ranges to swagger
* fix: use ulimits in json of LinuxOSConfig
* feat: add response example
* fix: add ulimits to custom words
* Revert "fix: add ulimits to custom words"
This reverts commit 949673772bb77447d5b3975ea5da27767c9705e2.
---------
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
* add Drain Timeout in preview (#24579)
Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>
* fix: remove ulimits from swagger spec (#24921)
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
* address ARM review comments (#25005)
* address ARM review comments
* added a missing description.
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
---------
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
---------
Co-authored-by: Xu Xue <55420084+xuexu6666@users.noreply.github.com>
Co-authored-by: Tongyao Si <tosi@microsoft.com>
Co-authored-by: Xinhe Li <xinhl@microsoft.com>
Co-authored-by: fseldow <fseldow@V-BRMCCA-MOBILE.redmond.corp.microsoft.com>
Co-authored-by: deveshdama <87668846+deveshdama@users.noreply.github.com>
Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com>
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
Co-authored-by: Wenjun Gao <wenjungaoat@gmail.com>
Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* [Hub Generated] Add new api version 2023-05-01 for Microsoft.App (#24939)
* Adds base for updating Microsoft.App from version preview/2023-04-01-preview to version 2023-05-01
* Updates readme
* Updates API version in new specs and examples
* Revert AppGw HttpListeners alias change (#24966)
* [Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-06-01-preview (#24426)
* Adds base for updating Microsoft.ContainerRegistry from version preview/2023-01-01-preview to version 2023-06-01-preview
* Updates readme
* Updates API version in new specs and examples
* Added new api version 2023-06-01-preview
* Fixed examples
* Fixed Prettier check.
* Fix lint error.
* fix pretty print
* Try fix avacodo error
* Fix the default tag
* add directive in readme.go.md
---------
Co-authored-by: Alancere <804873052@qq.com>
* [Hub Generated] Publish private branch 'u/michaelshikh/azure-kusto-Microsoft.Kusto-2023-05-02' (#24964)
* kusto 2023-05-02 fix "final-state-via" header
* take 2
* remove "x-ms-long-running-operation-options"
* remove "x-ms-long-running-operation-options"
* Release sentinel 2023 07 01 preview (#24557)
* Adds base for updating Microsoft.SecurityInsights from version preview/2023-06-01-preview to version 2023-07-01-preview
* Updates readme
* Updates API version in new specs and examples
* Added Approved and Backlog to Hunts Status enum (#24552)
* [Sentinel] [New Public API] Add swagger doc for dataConnectorDefinition API (#24509)
* add dataConnectorDefinition API doc
* update examples
* add pattern
* update pattern
* update pattern
* update description
* update description
* small fix
* small fix
* small fix
* small fix
* update swagger document based on feedback from the SDK team (#24555)
* Fix dataConnectorDefinition (new API) (#24759)
* fix swagger doc
* typo
* fix int format
* Fix pattern (#24807)
* remove pattern
* add and fix - reuired parameter in the new validation
* add and fix - reuired parameter in the new validation
* fix pattren
* fix pattren
* Remove CloudError.cs file (#24962)
Remove CloudError.cs. Added by mistake in https://github.com/Azure/azure-rest-api-specs/pull/24807/files
* Add pagination (#24986)
* add pagination
---------
Co-authored-by: artafres <94412144+artafres@users.noreply.github.com>
Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com>
* Update documentation for Cost Details to specify Resource group and management group is not supported (#24844)
* Update readme.python.md (#25055)
* [Hub Generated] Review request for Microsoft.Management to add version stable/2023-04-01 (#24976)
* Adds base for updating Microsoft.Management from version stable/2021-04-01 to version 2023-04-01
* Updates readme
* Updates API version in new specs and examples
* [Hub Generated] Review request for Microsoft.LabServices to add version stable/2023-06-07 (#24981)
* Adds base for updating Microsoft.LabServices from version stable/2022-08-01 to version 2023-06-07
* Updates readme
* Updates API version in new specs and examples
* added v2023-06-07 spec
* reset clouderror change
* update version date
* updated times
* fix times in examples
* update inviteuser example
* reinclude x-mx-identifiers
* Update for Swagger PrettierCheck
* TLS Default version updated to enforce TLS 1.2 (#24440)
Co-authored-by: Daniel Salazar Mora <dsalazar@microsoft.com>
* Update the ARM spec PR review workflow diagram (#25071)
* update python config (#25074)
* Add MicrosoftProduct to ProductType enum (#25046)
Co-authored-by: Oren Kafka <orkafka@microsoft.com>
* Initial version of the code-signing dataplane service (#22310)
* Initial version of the code-signing dataplane service
* Remove error objects since those come from the Azure Core namespace
* fix: added azure.codesigning.json resulting file
* fix: use newer version dependency syntax
* Rolling back version change per PR feedback
* fix: polling operation mapping per PR feedback
* Adding x-ms-examples for example validation
* fix: added custom-words per PR feedback
* Renamed parameter definition to match open api json definition
* fix: modified the api-version to synch up with the folder api-version
* Adding details json cadl validation
* refactor: moved from cadl to typespec
* chore: attach azure.codesiging.json definition
* chore: remove package-lock.json since its unneeded.
* feat: adding get sign eku operation & example
fix: sign long running operation
* chore: removed unused swagger.json generated
* chore: removing data-plane swagger generated, keeping just the typespec project
* Readding the swagger information for dataplane service
* fix: ci issues pointed
examples are not referenced on the swagger file
resources should not be read only
* added examples to typespec definition
* fix: examples
* more fixes for example.json operations
* even more fixes for example.json operations
* fix: minor
Remove optional parameter from region. since its required.
Added description to namespace definition
Removed optional parameter from operation status, since the id is required.
Added suppression of warning
* Added fixes to azure.codesigning.json generation
* Added required property of id to examples
* Switched property to a more descriptive naming for the eku response
* fix: moved examples to a non version specific folder
* fix: the compiler didnt liked not using the preview folder, rolling back
* feat: added oauth2 security definition
* fix: removed api-version from example path
* style: change casing of operations to camel case
fix: per guidance modified the getsignEku operation into listSignEku
* Update azure.codesigning.json generated by tsp compiler
* fix: modified ResourceAction to LongRunningResourceAction per feedback
* docs: added enum descriptions to each value on hash algorithms
* fix: pinned to current versions to avoid ci errors by using latest dependency
* Added prefix of StandardResourceOperations interface to Resource operations
* fix: sign operation should return 202 Accepted on example
* fix: sign operation should return 202 Accepted on example
* style: tsp format result
* refactor: removed unused mapping to parent resource
* refactor: removing typespec-python emitter
* Adding get sign root certificate operation
* fix: adding custom word rootcert
* fix: adding api version parameter
* Added resource provider folder per ci finding
* chore: removing package.json per PR feedback
* Renaming folder to remove "Microsoft." path per feedback from PR
see: https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/typespec-structure-guidelines.md for guidelines
* feat: expanded the typespec options to include the lang generation
* Fix: Based on review from API stewardship team
Added more detailed information for docs and summary of operations
Refactored getSignRootCertificate operation to use RpcOperation instead of custom operation
Pluralized the listSignEkus operation
Renamed models to provide more detailed description of their purposed
Eliminated the custom enum in favor of the typespec enum provided
* refactor: moved version to 2023-06-15 based on feedback of ACS Eng team
* refactor: renamed models following azure team feedback
* Update tspconfig.yaml
Applied latest schema of emitter options and parameters.
* fix: adding back missing custom words, fixing coffeelake casing
* docs: updated samples to include varied hashes to represent a more familiar request for customers
* docs: updated the docs clauses of the typespec file to avoid repetitions on the docs generated.
* fix: update README.md of data-plane generation to include the correct tag
* Regenerated azure.codesigning.json file
* Based on pr build feedback, updated custom words definition
* docs: per compiler feedback, adding doc definition for versioning
* fix: outdated examples of data-plane swagger
* fix: per PR feedback, using T payload for Foundations.OperationStatus
* chore: updated Azure.CodeSigning swagger generated using tsp v0.46.0
* fix: removed autorest from the dependencies per feedback
fix: added suppression for custom RPC operation
* Removing json examples for compliance with avocado pipeline
* fix: Adding examples to tsp directory
* Corrected samples
---------
Co-authored-by: Ray Chen <raychen@microsoft.com>
* [Bug-Fix] Minor change in Managed Network Fabric (#24948)
* Changes Made:
1. InternetGateways - type param is renamed to gatewayType
2. NetworkFabricSkus - type param is renamed to skuType
3. AccessControlLists:
-> action -> type is renamed to actionType
-> matchcondition -> ipmatchCondition -> type is renamed to ipType
4. NetworkTapRule
-> action -> type is renamed to actionType
-> matchcondition -> ipmatchCondition -> type is renamed to ipType
New Params:
1. In RoutePolicies: -> statements -> defaultAction [Permit | Deny -> default Deny] is added.
2. In RoutePolicy -> condition -> conditionType is added.
3. In AccessControlLists: -> matchConfiguration -> defaultAction [Permit | Deny -> default Permit] is added.
* Reverting the changes made for "type" parameter.
* Add Microsoft.StorageTasks Service | Swagger API Review (Ring 0 Service) (#24798)
* Add the Readme files and StorageTasks Spec file with CRUD and List by subs and rg with examples
* Rectify provider namespace to Microsoft.StorageTask and refactor examples into folders
* Address Lint diff failure to use the model from common-types
* Update Operations API with defaut response
* Add List Storage Task Assignment ARM Ids API
* Add POST List Storage Task Run Report Summary API
* Adding x-ms-identifiers
* Spell corrections
* Fix spell check errors
* Add 201 response code to PUT task operation
* Address minor changes and comments to reuse existing schema, update examples
* Add request body to List Summary Report API, Add Example. Remove 200 status code from Delete Async
* Add example reference to API file
* Adding Storage task action preview API with example
* Correct spelling
* Addig allowed resource type constraint
* Change the Reporting API to GET with Arm resource type Microsoft.StorageTasks/storageTasks/reports
* Address PR comments, correct and rephrease operation ids
* Change to proxy resource
* Fix typo
* Better instructions in footnotes for the ARM spec PR review workflow diagram (#25076)
* Updated request models for R2026 issue agrifood microsoft.ag food platform 2023-06-01-preview (#25057)
* Adds base for updating Microsoft.AgFoodPlatform from version preview/2021-09-01-preview to version 2023-06-01-preview
* Updates readme
* Updates API version in new specs and examples
* Rename changes + Control Plane BYOL changes
* added examples
* added examples for data Connector Apis
* fixing lint issues
* reorder and updated description
* node description updated.
* updated like Solution Apis
* beautify json examples
* prettier fix
* custom words + spelling fix
* system data lower case
* removed dataConnectorName from example + lint fix
* fixed lint issue in example
* prettier fix
* Default Error response + 201 code
* Description updated
* request model made same as response in patch
* added status code 201 in PUT API
* updated solution example
* updated changes for OAuth renaming
* updated Data Connector examples
* example update
* corrected typo
* syncing to latest DI Agri branch
* added MADMA in custom-words file
* data connector delete example updated
* solution example updated
* xms error fix
* added xms-identifier
* fixing examples
* updated create or update example
* prettier fix
* solution fix
* updated examples
* prettier fix
* lint issue fix
* fixing lint diff
---------
Co-authored-by: Abhishek Khatri <akhatri@microsoft.com>
* privateEndpointConnections and privateLinkServiceConnectionState naming fixes (#24810)
* Add comment handler for /pr RequestMerge (#25091)
* Sync expression Support From DataFactory To Synapse (#25054)
* Sync expression Support From DataFactory To Synaps…
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
…ew (#25845) * Adds base for updating Microsoft.SecurityInsights from version preview/2023-08-01-preview to version 2023-09-01-preview * Updates readme * Updates API version in new specs and examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.