Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ExpressRouteCrossConnection Route Table Summary Record #2574

Merged
merged 4 commits into from
Mar 5, 2018
Merged

Update ExpressRouteCrossConnection Route Table Summary Record #2574

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a9e940
Update CrossConnection Route Table Summary record
gimotwanMSFT Mar 1, 2018
b9a1c90
Address review comments
gimotwanMSFT Mar 2, 2018
d91cff5
Update prefixesReceived to stateOrPrefixesReceived
gimotwanMSFT Mar 2, 2018
21e87bb
address review comments - add meaningful description for Neighbour
gimotwanMSFT Mar 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...crosoft.Network/stable/2018-02-01/examples/ExpressRouteCrossConnectionBgpPeeringList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"parameters": {
"crossConnectionName": "CrossConnection-6e918437-5077-4ffe-b45f-0b7c0672da4b",
"resourceGroupName": "rg1",
"resourceGroupName": "CrossConnection-SiliconValley",
"api-version": "2018-02-01",
"subscriptionId": "subid"
},
Expand All @@ -10,8 +10,8 @@
"body": {
"value": [
{
"name": "AzurePrivatePeering",
"id": "/subscriptions/99c33776-9f4e-4e58-abe8-9263db1b9c6e/resourceGroups/CrossConnection-Boydton1DC/providers/Microsoft.Network/expressRouteCrossConnections/CrossConnection-9547feab-3c14-4e8b-8d0e-b5e74cd5ed7a/peerings/AzurePrivatePeering",
"name": "AzurePrivatePeering",
"id": "/subscriptions/subid/resourceGroups/CrossConnection-SiliconValley/providers/Microsoft.Network/expressRouteCrossConnections/CrossConnection-6e918437-5077-4ffe-b45f-0b7c0672da4b/peerings/AzurePrivatePeering",
"etag": "W/\"72090554-7e3b-43f2-80ad-99a9020dcb11\"",
"properties": {
"provisioningState": "Succeeded",
Expand Down
4 changes: 2 additions & 2 deletions ...ft.Network/stable/2018-02-01/examples/ExpressRouteCrossConnectionListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"parameters": {
"api-version": "2018-02-01",
"resourceGroupName": "CrossConnectionSiliconValley",
"resourceGroupName": "CrossConnection-SiliconValley",
"subscriptionId": "subid"
},
"responses": {
Expand All @@ -10,7 +10,7 @@
"value": [
{
"name": "CrossConnection-6e918437-5077-4ffe-b45f-0b7c0672da4b",
"id": "/subscriptions/subid/resourceGroups/CrossConnectionSiliconValley/providers/Microsoft.Network/expressRouteCrossConnections/CrossConnection-6e918437-5077-4ffe-b45f-0b7c0672da4b",
"id": "/subscriptions/subid/resourceGroups/CrossConnectionSilicon-Valley/providers/Microsoft.Network/expressRouteCrossConnections/CrossConnection-6e918437-5077-4ffe-b45f-0b7c0672da4b",
"type": "Microsoft.Network/expressRouteCrossConnections",
"location": "brazilsouth",
"properties": {
Expand Down
12 changes: 5 additions & 7 deletions ...oft.Network/stable/2018-02-01/examples/ExpressRouteCrossConnectionsRouteTableSummary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,20 @@
"value": [
{
"neighbor": "10.6.1.112",
"v": 4 ,
"as": 65514,
"asn": 65514,
"upDown": "1d14h",
"statePfxRcd": "Active"
"prefixesReceived": "Active"
},
{
"neighbor": "10.6.1.113",
"v": 4 ,
"as": 65514,
"asn": 65514,
"upDown": "1d14h",
"statePfxRcd": "1"
"prefixesReceived": "1"
}
]
}
},
"202": {
}
}
}
}
47 changes: 43 additions & 4 deletions ...ork/resource-manager/Microsoft.Network/stable/2018-02-01/expressRouteCrossConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
"tags": [
"ExpressRouteCrossConnections"
],
"operationId": "ExpressRouteCrossConnections_Put",
"operationId": "ExpressRouteCrossConnections_CreateOrUpdate",
"description": "Update the specified ExpressRouteCrossConnection.",
"parameters": [
{
Expand Down Expand Up @@ -455,13 +455,13 @@
"200": {
"description": "Update successful. The operation returns the resulting ExpressRouteCrossConnectionPeering resource.",
"schema": {
"$ref": "#/definitions/ExpressRouteCircuitPeering"
"$ref": "./expressRouteCircuit.json#/definitions/ExpressRouteCircuitPeering"
}
},
"201": {
"description": "Create successful. The operation returns the resulting ExpressRouteCrossConnectionPeering resource.",
"schema": {
"$ref": "#/definitions/ExpressRouteCircuitPeering"
"$ref": "./expressRouteCircuit.json#/definitions/ExpressRouteCircuitPeering"
}
}
},
Expand Down Expand Up @@ -582,7 +582,7 @@
"200": {
"description": "Request successful. The operation returns the resulting ExpressRouteCrossConnectionsRouteTableSummary resource.",
"schema": {
"$ref": "./expressRouteCircuit.json#/definitions/ExpressRouteCircuitsRoutesTableSummaryListResult"
"$ref": "#/definitions/ExpressRouteCrossConnectionsRoutesTableSummaryListResult"
}
},
"202": {
Expand Down Expand Up @@ -661,6 +661,45 @@
}
},
"definitions": {
"ExpressRouteCrossConnectionRoutesTableSummary": {
"properties": {
"neighbor": {
"type": "string",
"description": "Neighbor"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a more meaningful description

},
"asn": {
"type": "integer",
"format": "int32",
"description": "Autonomous system number."
},
"upDown": {
"type": "string",
"description": "The length of time that the BGP session has been in the Established state, or the current status if not in the Established state."
},
"prefixesReceived": {
"type": "string",
"description": "Current state of the BGP session, and the number of prefixes that have been received from a neighbor or peer group."
}
},
"description": "The routes table associated with the ExpressRouteCircuit."
},
"ExpressRouteCrossConnectionsRoutesTableSummaryListResult": {
"properties": {
"value": {
"type": "array",
"items": {
"$ref": "#/definitions/ExpressRouteCrossConnectionRoutesTableSummary"
},
"description": "A list of the routes table."
},
"nextLink": {
"type": "string",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be marked as readonly

"description": "The URL to get the next set of results."
}
},
"description": "Response for ListRoutesTable associated with the Express Route Cross Connections."
},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove blank line

"ExpressRouteCircuitReference": {
"properties": {
"id": {
Expand Down