Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ZRS support for snapshots, new apiversion 2018-04-01 #2552

Merged
merged 9 commits into from
Mar 8, 2018
Merged

Adding ZRS support for snapshots, new apiversion 2018-04-01 #2552

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2454b4c
adding disk.json zrs support for snapshots
Feb 27, 2018
2f5fb5d
change modelAsString to true to support new enums
Feb 27, 2018
a2b30ed
adding create option restore
Feb 28, 2018
9f8bb74
adding example files
Feb 28, 2018
a03f02c
adding examples folder and moving files
Mar 1, 2018
12cebc9
adding file
Mar 1, 2018
844284b
Update readme.md
Mar 6, 2018
dbb4893
adding 200 responses...
Mar 7, 2018
184f929
Merge branch 'master' of https://github.com/carissasun/azure-rest-api…
Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/compute/resource-manager/Microsoft.Compute/stable/2017-12-01/compute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4502,7 +4502,7 @@
],
"x-ms-enum": {
"name": "DiskCreateOptionTypes",
"modelAsString": false
"modelAsString": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olydis Does this constitute a breaking change for C#?

Copy link
Contributor Author

@carissasun carissasun Feb 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is needed in order to add new create types, in addition I'm changing it in disk.json so the two need to match

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhendrixMSFT yes (and for other languages)

}
},
"StorageAccountType": {
Expand All @@ -4514,7 +4514,7 @@
],
"x-ms-enum": {
"name": "StorageAccountTypes",
"modelAsString": false
"modelAsString": true
}
},
"ManagedDiskParameters": {
Expand Down
Loading