Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] [Microsoft.Security] Publish private branch 'aditdalvi-security-Microsoft.Security-2022-11-20-preview' to add version stable/2023-11-15 #25515

Conversation

aditdalvi
Copy link
Member

@aditdalvi aditdalvi commented Aug 24, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@aditdalvi aditdalvi requested a review from msyyc as a code owner August 24, 2023 16:32
@aditdalvi
Copy link
Member Author

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/14134

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 24, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-workflow-bot
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 8, 2023
@aditdalvi aditdalvi removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 8, 2023
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 8, 2023
@aditdalvi
Copy link
Member Author

@mentat9 thanks for your review comments. I've addressed all of them. Please take a look whenever you get a chance. Thanks!

@mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 9, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 9, 2023
@mentat9
Copy link
Member

mentat9 commented Sep 9, 2023

@aditdalvi - Signed off for ARM with comments: please take a look.

@msyyc
Copy link
Member

msyyc commented Sep 11, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Alancere Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Sep 11, 2023
@aditdalvi
Copy link
Member Author

@msyyc can I please get an approval for SDK breaking changes for Python?

@msyyc
Copy link
Member

msyyc commented Sep 12, 2023

@msyyc can I please get an approval for SDK breaking changes for Python?

Approved for python

@aditdalvi
Copy link
Member Author

/pr RequestMerge

@rkmanda rkmanda merged commit 32c178f into main Sep 12, 2023
28 of 30 checks passed
@rkmanda rkmanda deleted the published/Azure/azure-rest-api-specs-pr/aditdalvi-security-Microsoft.Security-2022-11-20-preview branch September 12, 2023 19:04
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
…i-security-Microsoft.Security-2022-11-20-preview' to add version stable/2023-11-15 (#25515)

* Initial commit

* Update api-version to GA and set displayName to read-only

* Fix validation errors

* More APIs and changes to operationIds

* Fix prettier failures

* Try fixing Prettier again

* Add more properties to the response

* Fix semantic validation

* Update examples

* Add 202 Accepted as a response in onboarding

* Add x-ms-long-running-operation

* Fix more linting issues

* Fix more linting issues

* Remove 202 for now to see if pipeline runs

* Put 202 back

* Add provisioning state

* Add 201 response

* Update descriptions

* Update example

* Modifications based on feedback from PMs, designers and NDA customers

* Fix model validation

* Update PR based on #24938

* Fix build errors

* Address feedback from ARM reviewer

* Fix reference

* fix readme.python.md

* Update example header value

* Address PR feedback

* Update description based on PR feedback

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants