[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-08-01-preview #25345

AntonioVT · 2023-08-16T22:21:03Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

…ew/2023-06-01-preview to version 2023-07-01-preview

…into AntonioVT-containerregistry-Microsoft.ContainerRegistry-2023-07-01-preview

openapi-pipeline-app · 2023-08-16T22:21:05Z

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-08-16T22:21:06Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 11 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
containerregistry.json	2023-08-01-preview(f9821dd)	2023-07-01(main)
containerregistry.json	2023-08-01-preview(f9821dd)	2023-06-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v5/types.json#L308:9 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4122:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v5/types.json#L283:11 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L7802:11
⚠️ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: common-types/resource-management/v5/types.json#L264:7 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L7786:7
⚠️ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: common-types/resource-management/v5/types.json#L264:7 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L7818:7
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v5/types.json#L265:9 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L7787:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v5/types.json#L270:9 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L7791:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v5/types.json#L275:9 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L7795:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v5/types.json#L265:9 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L7819:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v5/types.json#L270:9 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L7823:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v5/types.json#L275:9 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L7827:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v5/types.json#L280:9 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L7799:9

️🔄CredScan inProgress [Detail]

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-2023-08-preview	package-2023-08-preview(f9821dd)	default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L1648
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L1902
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L1944
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2198
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2240
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2286
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2338
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2380
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2416
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2455
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2498
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2550
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2605
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2656
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2692
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2776
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2821
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2857
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2899
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L2945
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L3000
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L3058
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L3730
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L3772
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L3818
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L3870
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L3928
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L3982
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L4021
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-08-01-preview/containerregistry.json#L4063

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/containerregistry/resource-manager/readme.md tag: specification/containerregistry/resource-manager/readme.md#tag-package-2023-08-preview

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️🔄PoliCheck inProgress [Detail]

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-16T22:21:07Z

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/containerregistry/armcontainerregistry - Approved - 1.1.0-beta.4

-	Enum `ActivationStatus` has been removed
-	Enum `AuditLogStatus` has been removed
-	Enum `AzureADAuthenticationAsArmPolicyStatus` has been removed
-	Enum `CertificateType` has been removed
-	Enum `ConnectedRegistryMode` has been removed
-	Enum `ConnectionState` has been removed
-	Enum `LogLevel` has been removed
-	Enum `PipelineOptions` has been removed
-	Enum `PipelineRunSourceType` has been removed
-	Enum `PipelineRunTargetType` has been removed
-	Enum `PipelineSourceType` has been removed
-	Enum `TLSStatus` has been removed
-	Field `AnonymousPullEnabled` of struct `RegistryPropertiesUpdateParameters` has been removed
-	Field `AnonymousPullEnabled` of struct `RegistryProperties` has been removed
-	Field `AzureADAuthenticationAsArmPolicy`, `SoftDeletePolicy` of struct `Policies` has been removed
-	Function `*ClientFactory.NewConnectedRegistriesClient` has been removed
-	Function `*ClientFactory.NewExportPipelinesClient` has been removed
-	Function `*ClientFactory.NewImportPipelinesClient` has been removed
-	Function `*ClientFactory.NewPipelineRunsClient` has been removed
-	Function `*ConnectedRegistriesClient.BeginCreate` has been removed
-	Function `*ConnectedRegistriesClient.BeginDeactivate` has been removed
-	Function `*ConnectedRegistriesClient.BeginDelete` has been removed
-	Function `*ConnectedRegistriesClient.BeginUpdate` has been removed
-	Function `*ConnectedRegistriesClient.Get` has been removed
-	Function `*ConnectedRegistriesClient.NewListPager` has been removed
-	Function `*ExportPipelinesClient.BeginCreate` has been removed
-	Function `*ExportPipelinesClient.BeginDelete` has been removed
-	Function `*ExportPipelinesClient.Get` has been removed
-	Function `*ExportPipelinesClient.NewListPager` has been removed
-	Function `*ImportPipelinesClient.BeginCreate` has been removed
-	Function `*ImportPipelinesClient.BeginDelete` has been removed
-	Function `*ImportPipelinesClient.Get` has been removed
-	Function `*ImportPipelinesClient.NewListPager` has been removed
-	Function `*PipelineRunsClient.BeginCreate` has been removed
-	Function `*PipelineRunsClient.BeginDelete` has been removed
-	Function `*PipelineRunsClient.Get` has been removed
-	Function `*PipelineRunsClient.NewListPager` has been removed
-	Function `NewConnectedRegistriesClient` has been removed
-	Function `NewExportPipelinesClient` has been removed
-	Function `NewImportPipelinesClient` has been removed
-	Function `NewPipelineRunsClient` has been removed
-	Struct `ActivationProperties` has been removed
-	Struct `AzureADAuthenticationAsArmPolicy` has been removed
-	Struct `ConnectedRegistryListResult` has been removed
-	Struct `ConnectedRegistryProperties` has been removed
-	Struct `ConnectedRegistryUpdateParameters` has been removed
-	Struct `ConnectedRegistryUpdateProperties` has been removed
-	Struct `ConnectedRegistry` has been removed
-	Struct `ExportPipelineListResult` has been removed
-	Struct `ExportPipelineProperties` has been removed
-	Struct `ExportPipelineTargetProperties` has been removed
-	Struct `ExportPipeline` has been removed
-	Struct `ImportPipelineListResult` has been removed
-	Struct `ImportPipelineProperties` has been removed
-	Struct `ImportPipelineSourceProperties` has been removed
-	Struct `ImportPipeline` has been removed
-	Struct `LoggingProperties` has been removed
-	Struct `LoginServerProperties` has been removed
-	Struct `ParentProperties` has been removed
-	Struct `PipelineRunListResult` has been removed
-	Struct `PipelineRunProperties` has been removed
-	Struct `PipelineRunRequest` has been removed
-	Struct `PipelineRunResponse` has been removed
-	Struct `PipelineRunSourceProperties` has been removed
-	Struct `PipelineRunTargetProperties` has been removed
-	Struct `PipelineRun` has been removed
-	Struct `PipelineSourceTriggerDescriptor` has been removed
-	Struct `PipelineSourceTriggerProperties` has been removed
-	Struct `PipelineTriggerDescriptor` has been removed
-	Struct `PipelineTriggerProperties` has been removed
-	Struct `ProgressProperties` has been removed
-	Struct `SoftDeletePolicy` has been removed
-	Struct `StatusDetailProperties` has been removed
-	Struct `SyncProperties` has been removed
-	Struct `SyncUpdateProperties` has been removed
-	Struct `TLSCertificateProperties` has been removed
-	Struct `TLSProperties` has been removed

❌azure-sdk-for-python-track2 - track2_azure-mgmt-containerregistry - 10.1.0

-	Model Policies no longer has parameter azure_ad_authentication_as_arm_policy
-	Model Policies no longer has parameter soft_delete_policy
-	Model Registry no longer has parameter anonymous_pull_enabled
-	Model RegistryUpdateParameters no longer has parameter anonymous_pull_enabled

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3e3098d. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.ContainerRegistry [View full logs] [Release SDK Changes]
- Azure.ResourceManager.ContainerRegistry.1.2.0-alpha.20230830.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 3e3098d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-containerregistry [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group ArchiveVersionsOperations
info	[Changelog]   - Added operation group ArchivesOperations

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 3e3098d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-containerregistry-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3e3098d. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/containerregistry/armcontainerregistry [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ErrorResponse.Error` has been changed from `*ErrorResponseBody` to `*ErrorDetail`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `PackageSourceType` with values `PackageSourceTypeRemote`
info	[Changelog] - New function `NewArchiveVersionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ArchiveVersionsClient, error)`
info	[Changelog] - New function `*ArchiveVersionsClient.BeginCreate(context.Context, string, string, string, string, string, *ArchiveVersionsClientBeginCreateOptions) (*runtime.Poller[ArchiveVersionsClientCreateResponse], error)`
info	[Changelog] - New function `*ArchiveVersionsClient.BeginDelete(context.Context, string, string, string, string, string, *ArchiveVersionsClientBeginDeleteOptions) (*runtime.Poller[ArchiveVersionsClientDeleteResponse], error)`
info	[Changelog] - New function `*ArchiveVersionsClient.Get(context.Context, string, string, string, string, string, *ArchiveVersionsClientGetOptions) (ArchiveVersionsClientGetResponse, error)`
info	[Changelog] - New function `*ArchiveVersionsClient.NewListPager(string, string, string, string, *ArchiveVersionsClientListOptions) *runtime.Pager[ArchiveVersionsClientListResponse]`
info	[Changelog] - New function `NewArchivesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ArchivesClient, error)`
info	[Changelog] - New function `*ArchivesClient.BeginCreate(context.Context, string, string, string, string, Archive, *ArchivesClientBeginCreateOptions) (*runtime.Poller[ArchivesClientCreateResponse], error)`
info	[Changelog] - New function `*ArchivesClient.BeginDelete(context.Context, string, string, string, string, *ArchivesClientBeginDeleteOptions) (*runtime.Poller[ArchivesClientDeleteResponse], error)`
info	[Changelog] - New function `*ArchivesClient.Get(context.Context, string, string, string, string, *ArchivesClientGetOptions) (ArchivesClientGetResponse, error)`
info	[Changelog] - New function `*ArchivesClient.NewListPager(string, string, string, *ArchivesClientListOptions) *runtime.Pager[ArchivesClientListResponse]`
info	[Changelog] - New function `*ArchivesClient.Update(context.Context, string, string, string, string, ArchiveUpdateParameters, *ArchivesClientUpdateOptions) (ArchivesClientUpdateResponse, error)`
info	[Changelog] - New function `*ClientFactory.NewArchiveVersionsClient() *ArchiveVersionsClient`
info	[Changelog] - New function `*ClientFactory.NewArchivesClient() *ArchivesClient`
info	[Changelog] - New struct `Archive`
info	[Changelog] - New struct `ArchiveListResult`
info	[Changelog] - New struct `ArchivePackageSourceProperties`
info	[Changelog] - New struct `ArchiveProperties`
info	[Changelog] - New struct `ArchiveUpdateParameters`
info	[Changelog] - New struct `ArchiveUpdateProperties`
info	[Changelog] - New struct `ArchiveVersion`
info	[Changelog] - New struct `ArchiveVersionListResult`
info	[Changelog] - New struct `ArchiveVersionProperties`
info	[Changelog] - New struct `DebianArchivePackageSourceProperties`
info	[Changelog] - New struct `DebianArchiveProperties`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponseForContainerRegistry`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 43 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3e3098d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-containerregistry [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-containerregistry-11.0.0-beta.1.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]   - Added Interface ImportPipeline
info	[Changelog]   - Added Interface ImportPipelineListResult
info	[Changelog]   - Added Interface ImportPipelinesCreateHeaders
info	[Changelog]   - Added Interface ImportPipelinesCreateOptionalParams
info	[Changelog]   - Added Interface ImportPipelinesDeleteHeaders
info	[Changelog]   - Added Interface ImportPipelinesDeleteOptionalParams
info	[Changelog]   - Added Interface ImportPipelinesGetOptionalParams
info	[Changelog]   - Added Interface ImportPipelinesListNextOptionalParams
info	[Changelog]   - Added Interface ImportPipelinesListOptionalParams
info	[Changelog]   - Added Interface ImportPipelineSourceProperties
info	[Changelog]   - Added Interface LoggingProperties
info	[Changelog]   - Added Interface LoginServerProperties
info	[Changelog]   - Added Interface ParentProperties
info	[Changelog]   - Added Interface PipelineRun
info	[Changelog]   - Added Interface PipelineRunListResult
info	[Changelog]   - Added Interface PipelineRunRequest
info	[Changelog]   - Added Interface PipelineRunResponse
info	[Changelog]   - Added Interface PipelineRunsCreateHeaders
info	[Changelog]   - Added Interface PipelineRunsCreateOptionalParams
info	[Changelog]   - Added Interface PipelineRunsDeleteHeaders
info	[Changelog]   - Added Interface PipelineRunsDeleteOptionalParams
info	[Changelog]   - Added Interface PipelineRunsGetOptionalParams
info	[Changelog]   - Added Interface PipelineRunsListNextOptionalParams
info	[Changelog]   - Added Interface PipelineRunsListOptionalParams
info	[Changelog]   - Added Interface PipelineRunSourceProperties
info	[Changelog]   - Added Interface PipelineRunTargetProperties
info	[Changelog]   - Added Interface PipelineSourceTriggerDescriptor
info	[Changelog]   - Added Interface PipelineSourceTriggerProperties
info	[Changelog]   - Added Interface PipelineTriggerDescriptor
info	[Changelog]   - Added Interface PipelineTriggerProperties
info	[Changelog]   - Added Interface ProgressProperties
info	[Changelog]   - Added Interface SoftDeletePolicy
info	[Changelog]   - Added Interface StatusDetailProperties
info	[Changelog]   - Added Interface SyncProperties
info	[Changelog]   - Added Interface SyncUpdateProperties
info	[Changelog]   - Added Interface TlsCertificateProperties
info	[Changelog]   - Added Interface TlsProperties
info	[Changelog]   - Added Interface UserIdentityPropertiesAutoGenerated
info	[Changelog]   - Added Type Alias ActivationStatus
info	[Changelog]   - Added Type Alias ArchivesCreateResponse
info	[Changelog]   - Added Type Alias ArchivesDeleteResponse
info	[Changelog]   - Added Type Alias ArchivesGetResponse
info	[Changelog]   - Added Type Alias ArchivesListNextResponse
info	[Changelog]   - Added Type Alias ArchivesListResponse
info	[Changelog]   - Added Type Alias ArchivesUpdateResponse
info	[Changelog]   - Added Type Alias ArchiveVersionsCreateResponse
info	[Changelog]   - Added Type Alias ArchiveVersionsDeleteResponse
info	[Changelog]   - Added Type Alias ArchiveVersionsGetResponse
info	[Changelog]   - Added Type Alias ArchiveVersionsListNextResponse
info	[Changelog]   - Added Type Alias ArchiveVersionsListResponse
info	[Changelog]   - Added Type Alias AuditLogStatus
info	[Changelog]   - Added Type Alias AzureADAuthenticationAsArmPolicyStatus
info	[Changelog]   - Added Type Alias CacheRulesCreateResponse
info	[Changelog]   - Added Type Alias CacheRulesDeleteResponse
info	[Changelog]   - Added Type Alias CacheRulesGetResponse
info	[Changelog]   - Added Type Alias CacheRulesListNextResponse
info	[Changelog]   - Added Type Alias CacheRulesListResponse
info	[Changelog]   - Added Type Alias CacheRulesUpdateResponse
info	[Changelog]   - Added Type Alias CertificateType
info	[Changelog]   - Added Type Alias ConnectedRegistriesCreateResponse
info	[Changelog]   - Added Type Alias ConnectedRegistriesGetResponse
info	[Changelog]   - Added Type Alias ConnectedRegistriesListNextResponse
info	[Changelog]   - Added Type Alias ConnectedRegistriesListResponse
info	[Changelog]   - Added Type Alias ConnectedRegistriesUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedRegistryMode
info	[Changelog]   - Added Type Alias ConnectionState
info	[Changelog]   - Added Type Alias CredentialHealthStatus
info	[Changelog]   - Added Type Alias CredentialName
info	[Changelog]   - Added Type Alias CredentialSetsCreateResponse
info	[Changelog]   - Added Type Alias CredentialSetsDeleteResponse
info	[Changelog]   - Added Type Alias CredentialSetsGetResponse
info	[Changelog]   - Added Type Alias CredentialSetsListNextResponse
info	[Changelog]   - Added Type Alias CredentialSetsListResponse
info	[Changelog]   - Added Type Alias CredentialSetsUpdateResponse
info	[Changelog]   - Added Type Alias ExportPipelinesCreateResponse
info	[Changelog]   - Added Type Alias ExportPipelinesGetResponse
info	[Changelog]   - Added Type Alias ExportPipelinesListNextResponse
info	[Changelog]   - Added Type Alias ExportPipelinesListResponse
info	[Changelog]   - Added Type Alias ImportPipelinesCreateResponse
info	[Changelog]   - Added Type Alias ImportPipelinesGetResponse
info	[Changelog]   - Added Type Alias ImportPipelinesListNextResponse
info	[Changelog]   - Added Type Alias ImportPipelinesListResponse
info	[Changelog]   - Added Type Alias LogLevel
info	[Changelog]   - Added Type Alias PackageSourceType
info	[Changelog]   - Added Type Alias PipelineOptions
info	[Changelog]   - Added Type Alias PipelineRunsCreateResponse
info	[Changelog]   - Added Type Alias PipelineRunsGetResponse
info	[Changelog]   - Added Type Alias PipelineRunsListNextResponse
info	[Changelog]   - Added Type Alias PipelineRunsListResponse
info	[Changelog]   - Added Type Alias PipelineRunSourceType
info	[Changelog]   - Added Type Alias PipelineRunTargetType
info	[Changelog]   - Added Type Alias PipelineSourceType
info	[Changelog]   - Added Type Alias TlsStatus
info	[Changelog]   - Interface Policies has a new optional parameter azureADAuthenticationAsArmPolicy
info	[Changelog]   - Interface Policies has a new optional parameter softDeletePolicy
info	[Changelog]   - Interface Registry has a new optional parameter anonymousPullEnabled
info	[Changelog]   - Interface RegistryUpdateParameters has a new optional parameter anonymousPullEnabled
info	[Changelog]   - Added Enum KnownActivationStatus
info	[Changelog]   - Added Enum KnownAuditLogStatus
info	[Changelog]   - Added Enum KnownAzureADAuthenticationAsArmPolicyStatus
info	[Changelog]   - Added Enum KnownCertificateType
info	[Changelog]   - Added Enum KnownConnectedRegistryMode
info	[Changelog]   - Added Enum KnownConnectionState
info	[Changelog]   - Added Enum KnownCredentialHealthStatus
info	[Changelog]   - Added Enum KnownCredentialName
info	[Changelog]   - Added Enum KnownLogLevel
info	[Changelog]   - Added Enum KnownPackageSourceType
info	[Changelog]   - Added Enum KnownPipelineOptions
info	[Changelog]   - Added Enum KnownPipelineRunSourceType
info	[Changelog]   - Added Enum KnownPipelineRunTargetType
info	[Changelog]   - Added Enum KnownPipelineSourceType
info	[Changelog]   - Added Enum KnownTlsStatus
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type of parameter error of interface ErrorResponse is changed from ErrorResponseBody to ErrorDetail
info	[Changelog]   - Type of parameter identity of interface Task is changed from IdentityProperties to IdentityPropertiesAutoGenerated
info	[Changelog]   - Type of parameter identity of interface TaskRun is changed from IdentityProperties to IdentityPropertiesAutoGenerated
info	[Changelog]   - Type of parameter identity of interface TaskRunUpdateParameters is changed from IdentityProperties to IdentityPropertiesAutoGenerated
info	[Changelog]   - Type of parameter identity of interface TaskUpdateParameters is changed from IdentityProperties to IdentityPropertiesAutoGenerated

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3e3098d. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️containerregistry [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 3e3098d. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.containerregistry.DefaultTag [View full logs]

Az.ContainerRegistry.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.containerregistry.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-16T22:21:07Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/containerregistry/armcontainerregistry	https://apiview.dev/Assemblies/Review/91256b7d58874e3a9827a892ac23f77d
Java	azure-resourcemanager-containerregistry-generated	https://apiview.dev/Assemblies/Review/b8bbc013f8a3443299857b78ef07f62b
.Net	Azure.ResourceManager.ContainerRegistry	There is no API change compared with the previous version
JavaScript	@azure/arm-containerregistry	https://apiview.dev/Assemblies/Review/9ea46fcdf5db427fb89125142d6ac417

openapi-pipeline-app · 2023-08-16T22:41:21Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

AntonioVT · 2023-08-16T23:12:21Z

@ ARM-reviewer, this PR is adding new API version ~~"2023-07-01-preview"~~ "2023-08-01-preview", which is exactly the same as "2023-06-01-preview". The reason for this is that we have just released a stable version and we always pair it with a preview version.

The reason for this is that Azure Policy will use the latest released API, and some built-in policies use preview features. In order to not break Azure Policy, we bundle/ship two APIs together (stable and preview).

In the past PR we have defined multiple workitems to fix the issues. These should be fixed by the next API version, which we have planned for ~November 2023.
[RP] [Swagger] Migrate RP resources PATCH operations to follow ARM RPC
[RP] [Swagger] Review and Remove 200 Status code in LRO-Delete operations in registry/child resources
[RP] [Swagger] Review and update/define common models

AntonioVT · 2023-08-16T23:21:23Z

@raych1 Regarding Breaking Change in Go, these were approved in our past stable API PR, we are essentially moving from our defined ErrorResponse to the one defined in common-types/v5. Could you help me review/validate again, please?

openapi-pipeline-app · 2023-08-18T22:06:11Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

AntonioVT · 2023-08-18T22:07:55Z

Updated preview API version name from "2023-07-01-preview" to "2023-08-01-preview" due to conflict with Azure Policy and ARG.

sjanamma

…into AntonioVT-containerregistry-Microsoft.ContainerRegistry-2023-07-01-preview

AntonioVT · 2023-08-30T01:08:34Z

/pr RequestMerge

openapi-pipeline-app · 2023-08-30T01:42:00Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

… version preview/2023-08-01-preview (#25345) * Adds base for updating Microsoft.ContainerRegistry from version preview/2023-06-01-preview to version 2023-07-01-preview * Updates readme * Updates API version in new specs and examples * Update swagger, examples and readmes * Rename 2023-07-01-preview to 2023-08-01-preview * Rename 2023-07-01-preview to 2023-08-01-preview folder * Add supression rules * suppression from update

AntonioVT added 5 commits August 14, 2023 10:12

Adds base for updating Microsoft.ContainerRegistry from version previ…

6f7bbdd

…ew/2023-06-01-preview to version 2023-07-01-preview

Updates readme

1f5e8ea

Updates API version in new specs and examples

5065dfa

Update swagger, examples and readmes

8f6fe08

Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …

8bbb66c

…into AntonioVT-containerregistry-Microsoft.ContainerRegistry-2023-07-01-preview

AzureRestAPISpecReview added new-api-version resource-manager labels Aug 16, 2023

azure-sdk mentioned this pull request Aug 16, 2023

[AutoPR sdk/resourcemanager/containerregistry/armcontainerregistry] [Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-08-01-preview azure-sdk/azure-sdk-for-go#6888

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Aug 16, 2023

AntonioVT marked this pull request as ready for review August 16, 2023 22:41

AntonioVT requested review from msyyc and tadelesh as code owners August 16, 2023 22:41

openapi-assignment-bot bot assigned rkmanda Aug 16, 2023

AzureRestAPISpecReview added ARMReview CI-FixRequiredOnFailure WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 16, 2023

AntonioVT added 2 commits August 18, 2023 15:05

Rename 2023-07-01-preview to 2023-08-01-preview

c73f5b2

Rename 2023-07-01-preview to 2023-08-01-preview folder

0138bd3

AntonioVT changed the title ~~[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-07-01-preview~~ [Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-08-01-preview Aug 18, 2023

sjanamma approved these changes Aug 29, 2023

View reviewed changes

sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 29, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 29, 2023

AntonioVT added 2 commits August 28, 2023 21:06

Add supression rules

e9ff741

Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …

8393672

…into AntonioVT-containerregistry-Microsoft.ContainerRegistry-2023-07-01-preview

AzureRestAPISpecReview added the SuppressionReviewRequired label Aug 29, 2023

sjanamma added Approved-Suppression and removed SuppressionReviewRequired labels Aug 29, 2023

raych1 added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Aug 30, 2023

github-actions bot added the MergeRequested label Aug 30, 2023

suppression from update

f9821dd

AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test SuppressionReviewRequired and removed CI-FixRequiredOnFailure labels Aug 30, 2023

sjanamma merged commit 3e3098d into main Aug 30, 2023

sjanamma deleted the AntonioVT-containerregistry-Microsoft.ContainerRegistry-2023-07-01-preview branch August 30, 2023 01:41

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Aug 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-08-01-preview #25345

[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-08-01-preview #25345

AntonioVT commented Aug 16, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 16, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 16, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 16, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 16, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 16, 2023 •

edited

Loading

AntonioVT commented Aug 16, 2023 •

edited

Loading

AntonioVT commented Aug 16, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading

AntonioVT commented Aug 18, 2023

sjanamma left a comment

AntonioVT commented Aug 30, 2023

openapi-pipeline-app bot commented Aug 30, 2023

[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-08-01-preview #25345

[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-08-01-preview #25345

Conversation

AntonioVT commented Aug 16, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Getting help

openapi-pipeline-app bot commented Aug 16, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Aug 16, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 16, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 16, 2023 • edited Loading

Generated ApiView

openapi-pipeline-app bot commented Aug 16, 2023 • edited Loading

AntonioVT commented Aug 16, 2023 • edited Loading

AntonioVT commented Aug 16, 2023 • edited Loading

openapi-pipeline-app bot commented Aug 18, 2023 • edited Loading

AntonioVT commented Aug 18, 2023

sjanamma left a comment

Choose a reason for hiding this comment

AntonioVT commented Aug 30, 2023

openapi-pipeline-app bot commented Aug 30, 2023

AntonioVT commented Aug 16, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 16, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 16, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 16, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 16, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 16, 2023 •

edited

Loading

AntonioVT commented Aug 16, 2023 •

edited

Loading

AntonioVT commented Aug 16, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 18, 2023 •

edited

Loading