Release network microsoft.network official 2023 05 01 #25343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01 to version 2023-05-01
* Added additional scalable gateway changes * small formatting change * made documents prettier * prettier changes * added references to fix avocado * testing a fix * another test * added new test * new changes * removed update * new changes * updated specs * updated specs
* Public Preview Developer Bastion * Public Preview Developer Bastion * Bastion Developer Sku
Next Steps to Merge |
|
Hi, @htippanaboya! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| applicationGateway.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| applicationGatewayWafDynamicManifests.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| applicationSecurityGroup.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| availableDelegations.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| availableServiceAliases.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| azureFirewall.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| azureFirewallFqdnTag.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| azureWebCategory.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| bastionHost.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| checkDnsAvailability.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| cloudServiceNetworkInterface.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| cloudServicePublicIpAddress.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| cloudServiceSwap.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| customIpPrefix.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| ddosCustomPolicy.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| ddosProtectionPlan.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| dscpConfiguration.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| endpointService.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| expressRouteCircuit.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| expressRouteCrossConnection.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| expressRoutePort.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| expressRouteProviderPort.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| firewallPolicy.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| ipAllocation.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| ipGroups.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| loadBalancer.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| natGateway.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| network.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| network.json | 2023-05-01(98b1e64) | 2022-06-01-preview(main) |
| networkInterface.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkManager.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkManager.json | 2023-05-01(98b1e64) | 2022-04-01-preview(main) |
| networkManagerActiveConfiguration.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkManagerActiveConfiguration.json | 2023-05-01(98b1e64) | 2022-04-01-preview(main) |
| networkManagerConnection.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkManagerConnection.json | 2023-05-01(98b1e64) | 2022-04-01-preview(main) |
| networkManagerConnectivityConfiguration.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkManagerConnectivityConfiguration.json | 2023-05-01(98b1e64) | 2022-04-01-preview(main) |
| networkManagerEffectiveConfiguration.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkManagerEffectiveConfiguration.json | 2023-05-01(98b1e64) | 2022-04-01-preview(main) |
| networkManagerGroup.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkManagerGroup.json | 2023-05-01(98b1e64) | 2022-04-01-preview(main) |
| networkManagerScopeConnection.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkManagerScopeConnection.json | 2023-05-01(98b1e64) | 2022-04-01-preview(main) |
| networkManagerSecurityAdminConfiguration.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkManagerSecurityAdminConfiguration.json | 2023-05-01(98b1e64) | 2022-04-01-preview(main) |
| networkProfile.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkSecurityGroup.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkVirtualAppliance.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| networkWatcher.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| operation.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| privateEndpoint.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| privateLinkService.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| publicIpAddress.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| publicIpPrefix.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| routeFilter.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| routeTable.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| securityPartnerProvider.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| serviceCommunity.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| serviceEndpointPolicy.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| serviceTags.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| usage.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| virtualNetwork.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| virtualNetworkGateway.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| virtualNetworkTap.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| virtualRouter.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| virtualWan.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| vmssNetworkInterface.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| vmssPublicIpAddress.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
| webapplicationfirewall.json | 2023-05-01(98b1e64) | 2023-04-01(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 16 items are listed, please refer to log for more details.
️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
️🔄LintDiff inProgress [Detail]
️❌Avocado: 2 Errors, 6 Warnings failed [Detail]
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 452 Errors, 0 Warnings failed [Detail]
Only 16 items are listed, please refer to log for more details.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=380778&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-python-track2 - track2_azure-mgmt-network - Approved - 24.0.0+ Removed operation group NspLinkReconcileOperations + Removed operation group NspLinkReferenceReconcileOperations
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Network [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.Network [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.FirewallPolicyRuleCollectionGroupData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.FirewallPolicyRuleCollectionGroupData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.ETag>, System.Nullable<System.Int32>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.FirewallPolicyRuleCollectionInfo>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.SubnetData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.SubnetData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.ETag>, System.String, System.Collections.Generic.IEnumerable<System.String>, Azure.ResourceManager.Network.NetworkSecurityGroupData, Azure.ResourceManager.Network.RouteTableData, Azure.Core.ResourceIdentifier, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceEndpointProperties>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.ServiceEndpointPolicyData>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.PrivateEndpointData>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.NetworkIPConfiguration>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.NetworkIPConfigurationProfile>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.WritableSubResource>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ResourceNavigationLink>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceAssociationLink>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceDelegation>, System.String, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkPrivateEndpointNetworkPolicy>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkPrivateLinkServiceNetworkPolicy>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ApplicationGatewayIPConfiguration>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.VirtualNetworkGatewayData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.VirtualNetworkGatewayData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.Core.AzureLocation>, System.Collections.Generic.IDictionary<System.String, System.String>, Azure.ResourceManager.Resources.Models.ExtendedLocation, System.Nullable<Azure.ETag>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayIPConfiguration>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayType>, System.Nullable<Azure.ResourceManager.Network.Models.VpnType>, System.Nullable<Azure.ResourceManager.Network.Models.VpnGatewayGeneration>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, Azure.Core.ResourceIdentifier, Azure.ResourceManager.Network.Models.VirtualNetworkGatewaySku, Azure.ResourceManager.Network.Models.VpnClientConfiguration, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayPolicyGroup>, Azure.ResourceManager.Network.Models.BgpSettings, System.Collections.Generic.IEnumerable<System.String>, System.Nullable<System.Guid>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, System.Nullable<System.Boolean>, System.String, Azure.Core.ResourceIdentifier, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.VirtualNetworkGatewayNatRuleData>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<Azure.ResourceManager.Network.Models.ExpressRouteGatewayAdminState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Network/Debug/netstandard2.0/Azure.ResourceManager.Network.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1> cmderr [automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-network [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation LoadBalancersOperations.migrate_to_ip_based info [Changelog] - Model BackendAddressPool has a new parameter sync_mode info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Removed operation group NspLinkReconcileOperations info [Changelog] - Removed operation group NspLinkReferenceReconcileOperations
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-network-generated [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Release SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New value `ApplicationGatewaySKUNameBasic` added to enum type `ApplicationGatewaySKUName` info [Changelog] - New value `ApplicationGatewayTierBasic` added to enum type `ApplicationGatewayTier` info [Changelog] - New enum type `SyncMode` with values `SyncModeAutomatic`, `SyncModeManual` info [Changelog] - New function `*LoadBalancersClient.MigrateToIPBased(context.Context, string, string, *LoadBalancersClientMigrateToIPBasedOptions) (LoadBalancersClientMigrateToIPBasedResponse, error)` info [Changelog] - New struct `BastionHostPropertiesFormatNetworkACLs` info [Changelog] - New struct `IPRule` info [Changelog] - New struct `MigrateLoadBalancerToIPBasedRequest` info [Changelog] - New struct `MigratedPools` info [Changelog] - New struct `VirtualNetworkGatewayAutoScaleBounds` info [Changelog] - New struct `VirtualNetworkGatewayAutoScaleConfiguration` info [Changelog] - New field `SyncMode` in struct `BackendAddressPoolPropertiesFormat` info [Changelog] - New field `NetworkACLs`, `VirtualNetwork` in struct `BastionHostPropertiesFormat` info [Changelog] - New field `Size` in struct `FirewallPolicyPropertiesFormat` info [Changelog] - New field `Size` in struct `FirewallPolicyRuleCollectionGroupProperties` info [Changelog] - New field `DefaultOutboundAccess` in struct `SubnetPropertiesFormat` info [Changelog] - New field `AutoScaleConfiguration` in struct `VirtualNetworkGatewayPropertiesFormat` info [Changelog] info [Changelog] Total 0 breaking change(s), 24 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-network [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added operation LoadBalancers.migrateToIpBased info [Changelog] - Added Interface BastionHostPropertiesFormatNetworkAcls info [Changelog] - Added Interface IPRule info [Changelog] - Added Interface LoadBalancersMigrateToIpBasedOptionalParams info [Changelog] - Added Interface MigratedPools info [Changelog] - Added Interface MigrateLoadBalancerToIpBasedRequest info [Changelog] - Added Interface VirtualNetworkGatewayAutoScaleBounds info [Changelog] - Added Interface VirtualNetworkGatewayAutoScaleConfiguration info [Changelog] - Added Type Alias LoadBalancersMigrateToIpBasedResponse info [Changelog] - Added Type Alias SyncMode info [Changelog] - Interface BackendAddressPool has a new optional parameter syncMode info [Changelog] - Interface BastionHost has a new optional parameter networkAcls info [Changelog] - Interface BastionHost has a new optional parameter virtualNetwork info [Changelog] - Interface FirewallPolicy has a new optional parameter size info [Changelog] - Interface FirewallPolicyRuleCollectionGroup has a new optional parameter size info [Changelog] - Interface Subnet has a new optional parameter defaultOutboundAccess info [Changelog] - Interface VirtualNetworkGateway has a new optional parameter autoScaleConfiguration info [Changelog] - Added Enum KnownSyncMode info [Changelog] - Enum KnownApplicationGatewaySkuName has a new value Basic info [Changelog] - Enum KnownApplicationGatewayTier has a new value Basic
️🔄 azure-resource-manager-schemas inProgress [Detail]
️❌ azure-powershell failed [Detail]
command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
⚠️Az.network.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.network.DefaultTag
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
CI-FixRequiredOnFailure
CI-MissingBaseCommit
new-api-version
resource-manager
WaitForARMFeedback
|
Hi @htippanaboya! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
|
Hi @htippanaboya! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Aug 16, 2023
rkmanda
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
* Subnet property defaultOutboundAccess added * NIT update * NIT Fix description --------- Co-authored-by: unknown <anjbal@DESKTOP-ML6T5PL.redmond.corp.microsoft.com>
|
Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
rkmanda
approved these changes
Aug 21, 2023
rkmanda
deleted the
release-network-Microsoft.Network-official-2023-05-01
branch
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Aug 21, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Getting help
and https://aka.ms/ci-fix.
PRs that were already approved to release branch
#25132
#25220
#25107
There is no further difference beyond this PRs
The swagger avacado and model validation have been failing since the past releases. Attaching the PRs for the past releases below
(#24841)
(#24277)
Below WI created to start the work for above errors
https://msazure.visualstudio.com/One/_workitems/edit/17681613