Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HDInsight]Add New API Version 2023-08-15-Preview #25135

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

xinlifoobar
Copy link
Contributor

@xinlifoobar xinlifoobar commented Aug 3, 2023

…view

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Getting help

@openapi-workflow-bot
Copy link

Hi, @xinlifoobar! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 3, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    applications.json 2023-08-15-preview(b36f753) 2021-06-01(main)
    applications.json 2023-08-15-preview(b36f753) 2023-04-15-preview(main)
    cluster.json 2023-08-15-preview(b36f753) 2021-06-01(main)
    cluster.json 2023-08-15-preview(b36f753) 2023-04-15-preview(main)
    configurations.json 2023-08-15-preview(b36f753) 2021-06-01(main)
    configurations.json 2023-08-15-preview(b36f753) 2023-04-15-preview(main)
    extensions.json 2023-08-15-preview(b36f753) 2021-06-01(main)
    extensions.json 2023-08-15-preview(b36f753) 2023-04-15-preview(main)
    locations.json 2023-08-15-preview(b36f753) 2021-06-01(main)
    locations.json 2023-08-15-preview(b36f753) 2023-04-15-preview(main)
    operations.json 2023-08-15-preview(b36f753) 2021-06-01(main)
    operations.json 2023-08-15-preview(b36f753) 2023-04-15-preview(main)
    privateEndpointConnections.json 2023-08-15-preview(b36f753) 2021-06-01(main)
    privateEndpointConnections.json 2023-08-15-preview(b36f753) 2023-04-15-preview(main)
    privateLinkResources.json 2023-08-15-preview(b36f753) 2021-06-01(main)
    privateLinkResources.json 2023-08-15-preview(b36f753) 2023-04-15-preview(main)
    scriptActions.json 2023-08-15-preview(b36f753) 2021-06-01(main)
    scriptActions.json 2023-08-15-preview(b36f753) 2023-04-15-preview(main)
    virtualMachines.json 2023-08-15-preview(b36f753) 2021-06-01(main)
    virtualMachines.json 2023-08-15-preview(b36f753) 2023-04-15-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.4) new version base version
    package-2023-08-preview package-2023-08-preview(b36f753) default(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/configurations.json#L64
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/configurations.json#L122
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/configurations.json#L172
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/operations.json#L55
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/privateLinkResources.json#L64
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/privateLinkResources.json#L109
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/virtualMachines.json#L64
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/virtualMachines.json#L115
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/virtualMachines.json#L164
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'configurations' in:'Configurations_List'. Consider updating the operationId
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/configurations.json#L42
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: '{configurationname}' in:'Configurations_Update'. Consider updating the operationId
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/configurations.json#L84
    ⚠️ PageableOperation Based on the response model schema, operation 'Locations_ListUsages' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/locations.json#L77
    ⚠️ PageableOperation Based on the response model schema, operation 'PrivateLinkResources_ListByCluster' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.HDInsight/preview/2023-08-15-preview/privateLinkResources.json#L38
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
    readme: specification/hdinsight/resource-manager/readme.md
    json: Microsoft.HDInsight/preview/2023-08-15-preview/scriptActions.json
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 3, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ad6484f. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/hdinsight/armhdinsight [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `OutboundDependenciesManagedType` with values `OutboundDependenciesManagedTypeExternal`, `OutboundDependenciesManagedTypeManaged`
      info	[Changelog] - New field `OutboundDependenciesManagedType` in struct `NetworkProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ad6484f. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-hdinsight [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ad6484f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-hdinsight [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model NetworkProperties has a new parameter outbound_dependencies_managed_type
      info	[Changelog]   - Model StorageAccount has a new parameter enable_secure_channel
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ad6484f. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-hdinsight [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Type Alias OutboundDependenciesManagedType
      info	[Changelog]   - Interface NetworkProperties has a new optional parameter outboundDependenciesManagedType
      info	[Changelog]   - Interface StorageAccount has a new optional parameter enableSecureChannel
      info	[Changelog]   - Added Enum KnownOutboundDependenciesManagedType
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ad6484f. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️hdinsight [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from ad6484f. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.hdinsight.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.hdinsight.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 3, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/hdinsight/armhdinsight https://apiview.dev/Assemblies/Review/0317e12e8bdf43b2a7134c9fdb37544b
    Java azure-resourcemanager-hdinsight https://apiview.dev/Assemblies/Review/68bfd5df36644d65ab265e745c013c2a
    .Net Azure.ResourceManager.HDInsight https://apiview.dev/Assemblies/Review/c767596b886d4824bdfc32dd8dd06aff
    JavaScript @azure/arm-hdinsight https://apiview.dev/Assemblies/Review/d381929a81d543f3a4f840b88a6bc1ee

    @openapi-workflow-bot
    Copy link

    Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
    Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

    @openapi-workflow-bot
    Copy link

    Hi @xinlifoobar! The automation detected this pull request introduces changes to at least one existing API version that violate Azure's versioning policy. To comply with the policy, these changes must be made in a new API version. As a result, the automation added the NewApiVersionRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Introduce a new API version.
    Submit a new PR instead of this one, or modify this PR, so that it adds a new API version instead of introducing changes to existing API versions.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot avoid modifying existing API versions, then you can request an approval for them. Please follow the breaking changes process.
    This case applies even if:

    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.

    @xinlifoobar
    Copy link
    Contributor Author

    Hi @rkmanda. This is our preview API version and is not public yet. Could you please help us merge it?

    @maririos
    Copy link
    Member

    maririos commented Aug 9, 2023

    Hi @rkmanda. This is our preview API version and is not public yet. Could you please help us merge it?

    You need to follow the process described on #25135 (comment) to get an approval on the detection of the breaking changes

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2023

    Next Steps to Merge

    ⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

    ✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

    @xinlifoobar xinlifoobar changed the title Add outboundDependenciesManagedType to HDInsight 2023-04-15-Preview [HDInsight]Add New API Version 2023-08-15-Preview Aug 16, 2023
    @xinlifoobar xinlifoobar removed NewApiVersionRequired ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test labels Aug 16, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 16, 2023
    @openapi-pipeline-app openapi-pipeline-app bot added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Aug 16, 2023
    @openapi-workflow-bot
    Copy link

    Hi @xinlifoobar! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh

    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 16, 2023

    Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 21, 2023

    Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

    @xinlifoobar
    Copy link
    Contributor Author

    Which commits can I diff to see just the changes introduced in the new apiversion? If its hard to explain, it might even be worth redoing all your commits using openAPIHub and force pushing those commits over this branch, it should give us something easy to review. Or just adding commits that revert and then reapply the differences to the old api version.

    I tried OpenAPIHub but failed with below error so have to do this manually. I combined all in the same commit and hopefully this works. Thanks.

    URL: https://openapihub.azure-devex-tools.com/branch/create
    
    ApiError: Server encountered an internal server error.
        During API SAVE_NEW_SWAGGER_VERSION({"baseBranch":"main","isNewService":false,"branchOptions":"UnprotectedBranch","isNewDataPlane":false,"baseBranchType":"Default","confidentiality":"public","serviceName":"hdinsight","serviceType":"resource-manager","hasNewDataPlane":false,"rpName":"Microsoft.HDInsight","releaseState":"preview","version":"2023-08-15-preview","copyExamples":true,"basedOnVersion":"preview/2023-04-15-preview"})
        at https://openapihub.azure-devex-tools.com/static/build.js:415:147161
        at Generator.next (<anonymous>)
        at a (https://openapihub.azure-devex-tools.com/static/build.js:415:146160)
    The above error occurred in task SAVE_NEW_SWAGGER_VERSION
        created by CREATE_NEW/SAVE_NEW_SWAGGER_VERSION
        created by anonymous
    
    

    @xinlifoobar
    Copy link
    Contributor Author

    I think all these avocado failures probably need to be fixed to get this PR properly linted.

    The swagger JSON file is not referenced from the readme file.
    readme: specification/hdinsight/resource-manager/readme.md
    json: Microsoft.HDInsight/preview/2023-08-15-preview/applications.json

    Done.

    @openapi-pipeline-app
    Copy link

    Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

    @xinlifoobar xinlifoobar removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 22, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 22, 2023
    @ms-henglu
    Copy link
    Member

    Hi @xinlifoobar, I'd like to double confirm that the only change introduced between 2023-04-15-preview and 2023-08-15-preview is "outboundDependenciesManagedType"?

    @ms-henglu ms-henglu added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 22, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 22, 2023
    @xinlifoobar
    Copy link
    Contributor Author

    xinlifoobar commented Aug 23, 2023

    Hi @xinlifoobar, I'd like to double confirm that the only change introduced between 2023-04-15-preview and 2023-08-15-preview is "outboundDependenciesManagedType"?

    I have to do this because this saves effort than bypassing the breaking change process. Also, there are a lot more works behind this enum value so it is better to be in a new api version. I could confirm there are no new changes in this version.

    @xinlifoobar xinlifoobar removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 23, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 23, 2023
    @mikeharder mikeharder removed their request for review August 23, 2023 03:45
    @ms-henglu ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 23, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 23, 2023
    @xinlifoobar
    Copy link
    Contributor Author

    /pr RequestMerge

    @ms-henglu ms-henglu merged commit ad6484f into Azure:main Aug 23, 2023
    29 of 30 checks passed
    @openapi-pipeline-app
    Copy link

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants