Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Breaking Changes CI on exception #2500

Merged
merged 1 commit into from
Feb 15, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/breaking-change.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ var utils = require('../test/util/utils'),
execSync = require('child_process').execSync,
oad = require('oad');

// This map is used to store the mapping between files resolved and stored location
// This map is used to store the mapping between files resolved and stored location
var resolvedMapForNewSpecs = {};
let outputFolder = path.join(os.tmpdir(), "resolved");
// Used to enable running script outside TravisCI for debugging
Expand Down Expand Up @@ -46,6 +46,7 @@ function runOad(oldSpec, newSpec) {
return Promise.resolve();
}).catch(err => {
console.log(err);
process.exitCode = 1;
});
}

Expand All @@ -71,7 +72,7 @@ function processViaAutoRest(swaggerPath) {
let result = execSync(`${autoRestCmd}`, { encoding: 'utf8', maxBuffer: 1024 * 1024 * 64 });
resolvedMapForNewSpecs[outputFileNameWithExt] = path.join(outputFolder, outputFileNameWithExt);
} catch (err) {
// Do not update map in case of errors
// Do not update map in case of errors.
}

return Promise.resolve();
Expand Down