mgmt, managednetworkfabric, update java option #24569

weidongxu-microsoft · 2023-06-25T03:18:49Z

autorest option for Java to have a proper service name "Managed Network Fabric"

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
I commit to follow the Breaking Change Policy.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

If you want for the ARM team to review this PR, you must add the ARMReview label.
The automation may automatically add the ARMReview label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For additional help, see https://aka.ms/azsdk/support/spectools.

openapi-workflow-bot · 2023-06-25T03:18:52Z

Hi, @weidongxu-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-06-25T03:18:52Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.1.3)	new version	base version
default	default(82a5258)	default(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-25T03:18:53Z

Swagger Generation Artifacts

️⌛ApiDocPreview pending [Detail]

️⌛SDK Breaking Change Tracking pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-25T03:18:54Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-resourcemanager-managednetworkfabric	https://apiview.dev/Assemblies/Review/1cd753e47a7e4a5c8ecf216cc9de53ab
JavaScript	@azure/arm-managednetworkfabric	https://apiview.dev/Assemblies/Review/782b8ad9a4454cd0892c05aef628dc12

openapi-pipeline-app · 2023-06-25T03:34:17Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 686983b. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-managednetworkfabric [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 686983b. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-managednetworkfabric [View full logs] [Release SDK Changes]
- azure-arm-managednetworkfabric-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 686983b. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/managednetworkfabric/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
warn	No package detected after generation

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 686983b. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.7.2` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-managednetworkfabric [View full logs] [Release SDK Changes]
- azure-mgmt-managednetworkfabric-1.0.0b1.zip
- azure_mgmt_managednetworkfabric-1.0.0b1-py3-none-any.whl
```
info	[Changelog]   - Initial Release
```

_{Posted by Swagger Pipeline | How to fix these errors?}

weidongxu-microsoft · 2023-06-25T04:48:20Z

@kazrael2119

Please approve. It is Java autorest option, for release https://github.com/Azure/sdk-release-request/issues/4256.

I will do the merge.

kazrael2119 · 2023-06-26T01:39:13Z

@kazrael2119

Please approve. It is Java autorest option, for release Azure/sdk-release-request#4256.

I will do the merge.

@weidongxu-microsoft approved

AzureRestAPISpecReview added resource-manager RPaaS labels Jun 25, 2023

weidongxu-microsoft force-pushed the mgmt_managednetworkfabric_java-option branch from 7d78551 to dfbd060 Compare June 25, 2023 03:31

mgmt, managednetworkfabric, update java option

82a5258

weidongxu-microsoft force-pushed the mgmt_managednetworkfabric_java-option branch from dfbd060 to 82a5258 Compare June 25, 2023 03:43

weidongxu-microsoft marked this pull request as ready for review June 25, 2023 03:54

openapi-assignment-bot bot assigned kazrael2119 Jun 25, 2023

XiaofeiCao approved these changes Jun 25, 2023

View reviewed changes

kazrael2119 approved these changes Jun 26, 2023

View reviewed changes

ArthurMa1978 approved these changes Jun 26, 2023

View reviewed changes

weidongxu-microsoft merged commit 686983b into Azure:main Jun 27, 2023

harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023

mgmt, managednetworkfabric, update java option (Azure#24569)

9f1d4a2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgmt, managednetworkfabric, update java option #24569

mgmt, managednetworkfabric, update java option #24569

weidongxu-microsoft commented Jun 25, 2023

openapi-workflow-bot bot commented Jun 25, 2023

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

Breaking Changes Tracking

weidongxu-microsoft commented Jun 25, 2023

kazrael2119 commented Jun 26, 2023

mgmt, managednetworkfabric, update java option #24569

mgmt, managednetworkfabric, update java option #24569

Conversation

weidongxu-microsoft commented Jun 25, 2023

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

Due diligence checklist

ARM API changes review

Breaking change review

Getting help

openapi-workflow-bot bot commented Jun 25, 2023

openapi-pipeline-app bot commented Jun 25, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 25, 2023 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Jun 25, 2023 • edited Loading

Generated ApiView

openapi-pipeline-app bot commented Jun 25, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

weidongxu-microsoft commented Jun 25, 2023

kazrael2119 commented Jun 26, 2023

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading