Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved tags related paths into one file so operations prefixes is grouped by files #2449

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

vfedonkin
Copy link
Contributor

@vfedonkin vfedonkin commented Feb 8, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • [* ] The title of the PR is clear and informative.
  • [* ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • [* ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • [* ] If applicable, the PR references the bug/issue that it fixes.
  • [* ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Feb 8, 2018

Automation for azure-sdk-for-python

Was unable to create SDK azure-sdk-for-python PR for this closed PR.

@AutorestCI
Copy link

AutorestCI commented Feb 8, 2018

Automation for azure-sdk-for-go

Swagger to SDK encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmptvh593zn/rest/specification/apimanagement/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmptvh593zn/sdk', '--multiapi', '--package-version=nightly', '--use=@microsoft.azure/autorest.go@preview', "--user-agent='Azure-SDK-For-Go/nightly services'", '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4249; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core@2.0.4249/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4249)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (preview->2.1.71)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-03"} .
FATAL: System.InvalidOperationException: method RegionsClient.ListByService contains a null nextLinkName so it shouldn't be treated as a pageable operation
   at AutoRest.Go.Model.PageTypeGo..ctor(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISHvae20\92_20180207T233911\autorest.go\src\Model\PageTypeGo.cs:line 41
   at AutoRest.Go.Model.CodeModelGo.CreatePageableTypeForMethod(MethodGo method) in C:\Users\ci\AppData\Local\Temp\PUBLISHvae20\92_20180207T233911\autorest.go\src\Model\CodeModelGo.cs:line 298
   at AutoRest.Go.TransformerGo.TransformMethods(CodeModelGo cmg) in C:\Users\ci\AppData\Local\Temp\PUBLISHvae20\92_20180207T233911\autorest.go\src\TransformerGo.cs:line 278
   at AutoRest.Go.TransformerGo.TransformCodeModel(CodeModel cm) in C:\Users\ci\AppData\Local\Temp\PUBLISHvae20\92_20180207T233911\autorest.go\src\TransformerGo.cs:line 32
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISHvae20\92_20180207T233911\autorest.go\src\Program.cs:line 100
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2017-03"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

@vfedonkin
Copy link
Contributor Author

@solankisamir , could you please review this too?
Also, I deleted apimapisbytags.json, do we need to remove any reference to it in the documentation menu?
Thank you,
Vitaliy.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address validation errors here

@vfedonkin
Copy link
Contributor Author

@dsgouda, there are no errors but warnings only, Which one should we fix? PutRequestResponseScheme? It's not possible, since put method receives existing apiId and tagId to make an association between them, but GET method returns all other properties of the API and TAG. Anyway, the result of GET operation can be used as input for PUT, those properties will be just ignored.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, the naming for certain operations is against recommendations.

"tags": [
"ProductTags"
],
"operationId": "Tag_AssignToProduct",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PUT operations must usually be named as Tag_create or Tag_Update

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR was signed off by ARM #2257. We are just moving operation into different file, as it caused the Documentation CI to break

"tags": [
"ProductTags"
],
"operationId": "Tag_DetachFromProduct",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DELETE operations must be named as Tag_Delete

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR was signed off by ARM #2257. We are just moving operation into different file, as it caused the Documentation CI to break

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit aaa6f85 into Azure:master Feb 8, 2018
@solankisamir solankisamir mentioned this pull request Feb 9, 2018
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants