Add missing properties for Vmss zone GA

[wangjun198389]

Updated compute spec to include missing properties zoneBalance and platformFaultDomainCount in VirtualMachineScaleSetProperties. We are using 2017-12-01 api version which is zone GA version. Both properties are immutable and optional. These properties are only for zone scenario, which is in public preview now.

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 39
After the PR: Warning(s): 0 Error(s): 39

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[AutorestCI]

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: profileBuilder -s preview -name preview
Finished with return code 127
and output:

/bin/sh: 1: profileBuilder: not found

[anuchandy]

is x-zones some domain specific name?

[wangjun198389]

Somehow. "x-zones" or "zones redundant" or "cross zones" VMScaleSet.

[anuchandy]

@wangjun198389 you mentioned these are immutable properties, do you mean they are readonly if so please mark so. Or you mean they can set only once and cannot be changed later?

[wangjun198389]

@anuchandy Those new properties can set only once when creating, cannot be changed later.

[anuchandy]

@wangjun198389 sounds good, just one more question from my side - let's say we generate SDK from this PR ClientNew and used it to set these two properties as part of creation of resource1, suppose somebody is using current version of SDK say ClientOld (generated from the same api version spec in master) to do a PUT (update) on resource1, since these two properties does not exists in the model, payload will not contain them. In this case how server behaves? does it throw error?

[wangjun198389]

@anuchandy old client can put(update) successfully. Server side treat it as no change for these two new properties.

[anuchandy]

@wangjun198389 thanks. @ravbhatnagar looks good from SDK side, any comments from ARM side?

[ravbhatnagar]

new properties typically require a new api-version. but based on above comments, these properties are immutable. So its fine. Signing off!

[AutorestCI]

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#1949

[AutorestCI]

Automation for azure-sdk-for-go

Swagger to SDK encountered a Subprocess error: (azure-sdk-for-go)

Command: profileBuilder -s list -l ./profiles/2017-03-09/defintion.txt -name 2017-03-09
Finished with return code 127
and output:

/bin/sh: 1: profileBuilder: not found