[Monitor] Make all attributes of EventData class readonly (#2254)

[gucalder]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-python

Swagger to SDK encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 274, in create_context_pr
    base=sdk_base
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 137, in get_or_create_pull
    base=base
  File "/usr/local/lib/python3.6/dist-packages/github/Repository.py", line 994, in create_pull
    return self.__create_pull_1(*args, **kwds)
  File "/usr/local/lib/python3.6/dist-packages/github/Repository.py", line 1003, in __create_pull_1
    return self.__create_pull(title=title, body=body, base=base, head=head)
  File "/usr/local/lib/python3.6/dist-packages/github/Repository.py", line 1016, in __create_pull
    input=post_parameters
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 172, in requestJsonAndCheck
    return self.__check(*self.requestJson(verb, url, parameters, headers, input, cnx))
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 180, in __check
    raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 422 {'message': 'Validation Failed', 'errors': [{'resource': 'PullRequest', 'code': 'custom', 'message': 'No commits between master and restapi_auto_monitor/resource-manager'}], 'documentation_url': 'https://developer.github.com/v3/pulls/#create-a-pull-request'}

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 195, in rest_handle_action
    return rest_pull_open(body, github_con, restapi_repo, sdk_pr_target_repo, context_tags, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 264, in rest_pull_open
    create_context_pr(sdk_pr_target_repo, context_tags, sdk_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 283, in create_context_pr
    _LOGGER.info("Unable to manage Context PR %s:\n%s", context_pr.number, response)
UnboundLocalError: local variable 'context_pr' referenced before assignment

[AutorestCI]

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: profileBuilder -s preview -name preview
Finished with return code 127
and output:

/bin/sh: 1: profileBuilder: not found

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[olydis]

@gucalder Note that this is an SDK breaking change to stable APIs.

[olydis]

I know that the breaking change is rather cosmetic:

• code that wrote to one of the properties (but why would you?) will now be broken
• code that manually instantiated the return type (but why would you?) will be broken (reordered constructor parameters due to change in requiredness)

So the next SDK released based on this will require a major version bump.

[gucalder]

This was a request from a customer (#2254.)
From our point of view the class was already implicitly readonly since we have no destructive API call for activity logs (where the class is used.)

We are going to bump the SDK version anyway since other people are adding functionality and change existing APIs. Also the namespace of some classes changed due fixing an previous bug that has not been published yet. I will have a lot to document in the next SDK release that I am preparing now. Our next version of the SDK will be 0.19.0-preview instead of the current 0.18.1-preview.

[gucalder]

Ping.

[AutorestCI]

Automation for azure-sdk-for-go

Swagger to SDK encountered a Subprocess error: (azure-sdk-for-go)

Command: profileBuilder -s list -l ./profiles/2017-03-09/defintion.txt -name 2017-03-09
Finished with return code 127
and output:

/bin/sh: 1: profileBuilder: not found