Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix description for endTime in JobExecution #24360

Merged
merged 2 commits into from
Jun 13, 2023
Merged

fix description for endTime in JobExecution #24360

merged 2 commits into from
Jun 13, 2023

Conversation

anandanthony
Copy link
Contributor

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @anandanthony Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/bfbaf7193e9f0163965540c33d42e5759c2dc27c/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/Jobs.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/Jobs.json",
    "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.54/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=/mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/Jobs.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Schema violation: Array is too short (0),
    minimum 1\n - file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/Jobs.json:791:6 ($.definitions.Job.required)\nFATAL: swagger-document/individual/schema-validator - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.\n"
    ❌ Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/bfbaf7193e9f0163965540c33d42e5759c2dc27c/specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/Jobs.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/Jobs.json",
    "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.54/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=/mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/Jobs.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Schema violation: Array is too short (0),
    minimum 1\n - file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/Jobs.json:818:6 ($.definitions.Job.required)\nFATAL: swagger-document/individual/schema-validator - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.\n"
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-preview-2023-04 package-preview-2023-04(bfbaf71) package-preview-2023-04(main)
    package-preview-2022-11 package-preview-2022-11(bfbaf71) package-preview-2022-11(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L179
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L195
    ❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L209
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L252
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L318
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L383
    ❌ LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L399
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L447
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L515
    ❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L730
    ❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L796
    ❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
    Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L857
    ❌ PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L170
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L186
    ❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L203
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L242
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L304
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L364
    ❌ LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L380
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L418
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L472
    ❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L731
    ❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L757
    ❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L793
    ❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L823
    ❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L851
    ❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L884
    ❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L884
    ❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L963
    ❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
    Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L998
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-js - @azure/arm-appcontainers - Approved - 2.0.0-beta.4
    +	Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
+	Interface VnetConfiguration no longer has parameter runtimeSubnetId
+	Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
+	Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ac98588. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.7.1` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-appcontainers [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ContainerAppsOperations.begin_start
info	[Changelog]   - Added operation ContainerAppsOperations.begin_stop
info	[Changelog]   - Added operation group ContainerAppsAPIClientOperationsMixin
info	[Changelog]   - Model AzureCredentials has a new parameter kind
info	[Changelog]   - Model Configuration has a new parameter service
info	[Changelog]   - Model GithubActionConfiguration has a new parameter github_personal_access_token
info	[Changelog]   - Model JobConfiguration has a new parameter event_trigger_config
info	[Changelog]   - Model ManagedEnvironment has a new parameter peer_authentication
info	[Changelog]   - Model Replica has a new parameter init_containers
info	[Changelog]   - Model Replica has a new parameter running_state
info	[Changelog]   - Model Replica has a new parameter running_state_details
info	[Changelog]   - Model ReplicaContainer has a new parameter running_state
info	[Changelog]   - Model ReplicaContainer has a new parameter running_state_details
info	[Changelog]   - Model Revision has a new parameter running_state
info	[Changelog]   - Model Template has a new parameter service_binds
info	[Changelog]   - Model Template has a new parameter termination_grace_period_seconds
info	[Changelog]   - Model Volume has a new parameter mount_options
info	[Changelog]   - Model VolumeMount has a new parameter sub_path
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Operation JobsOperations.begin_stop_multiple_executions no longer has parameter job_execution_name
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ac98588. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-appcontainers [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ac98588. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*JobsClient.BeginStopMultipleExecutions` parameter(s) have been changed from `(context.Context, string, string, JobExecutionNamesCollection, *JobsClientBeginStopMultipleExecutionsOptions)` to `(context.Context, string, string, *JobsClientBeginStopMultipleExecutionsOptions)`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `ContainerAppContainerRunningState` with values `ContainerAppContainerRunningStateRunning`, `ContainerAppContainerRunningStateTerminated`, `ContainerAppContainerRunningStateWaiting`
info	[Changelog] - New enum type `ContainerAppReplicaRunningState` with values `ContainerAppReplicaRunningStateNotRunning`, `ContainerAppReplicaRunningStateRunning`, `ContainerAppReplicaRunningStateUnknown`
info	[Changelog] - New enum type `RevisionRunningState` with values `RevisionRunningStateDegraded`, `RevisionRunningStateFailed`, `RevisionRunningStateProcessing`, `RevisionRunningStateRunning`, `RevisionRunningStateStopped`, `RevisionRunningStateUnknown`
info	[Changelog] - New function `*ClientFactory.NewContainerAppsAPIClient() *ContainerAppsAPIClient`
info	[Changelog] - New function `NewContainerAppsAPIClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ContainerAppsAPIClient, error)`
info	[Changelog] - New function `*ContainerAppsAPIClient.JobExecution(context.Context, string, string, string, *ContainerAppsAPIClientJobExecutionOptions) (ContainerAppsAPIClientJobExecutionResponse, error)`
info	[Changelog] - New function `*ContainerAppsClient.BeginStart(context.Context, string, string, *ContainerAppsClientBeginStartOptions) (*runtime.Poller[ContainerAppsClientStartResponse], error)`
info	[Changelog] - New function `*ContainerAppsClient.BeginStop(context.Context, string, string, *ContainerAppsClientBeginStopOptions) (*runtime.Poller[ContainerAppsClientStopResponse], error)`
info	[Changelog] - New struct `JobConfigurationEventTriggerConfig`
info	[Changelog] - New struct `JobScale`
info	[Changelog] - New struct `JobScaleRule`
info	[Changelog] - New struct `ManagedEnvironmentPropertiesPeerAuthentication`
info	[Changelog] - New struct `Mtls`
info	[Changelog] - New struct `Service`
info	[Changelog] - New struct `ServiceBind`
info	[Changelog] - New field `Kind` in struct `AzureCredentials`
info	[Changelog] - New field `Service` in struct `Configuration`
info	[Changelog] - New field `GithubPersonalAccessToken` in struct `GithubActionConfiguration`
info	[Changelog] - New field `EventTriggerConfig` in struct `JobConfiguration`
info	[Changelog] - New field `PeerAuthentication` in struct `ManagedEnvironmentProperties`
info	[Changelog] - New field `RunningState`, `RunningStateDetails` in struct `ReplicaContainer`
info	[Changelog] - New field `InitContainers`, `RunningState`, `RunningStateDetails` in struct `ReplicaProperties`
info	[Changelog] - New field `RunningState` in struct `RevisionProperties`
info	[Changelog] - New field `ServiceBinds`, `TerminationGracePeriodSeconds` in struct `Template`
info	[Changelog] - New field `MountOptions` in struct `Volume`
info	[Changelog] - New field `SubPath` in struct `VolumeMount`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 45 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ac98588. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-appcontainers [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias ContainerAppReplicaRunningState
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetDetectorResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRevisionResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRootResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsNextResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsNextResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsResponse
info	[Changelog]   - Added Type Alias ContainerAppsGetAuthTokenResponse
info	[Changelog]   - Added Type Alias ContainerAppsStartResponse
info	[Changelog]   - Added Type Alias ContainerAppsStopResponse
info	[Changelog]   - Added Type Alias ContainerAppsUpdateResponse
info	[Changelog]   - Added Type Alias ExtendedLocationTypes
info	[Changelog]   - Added Type Alias IngressClientCertificateMode
info	[Changelog]   - Added Type Alias JobExecutionResponse
info	[Changelog]   - Added Type Alias JobExecutionRunningState
info	[Changelog]   - Added Type Alias JobProvisioningState
info	[Changelog]   - Added Type Alias JobsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias JobsExecutionsListNextResponse
info	[Changelog]   - Added Type Alias JobsExecutionsListResponse
info	[Changelog]   - Added Type Alias JobsGetResponse
info	[Changelog]   - Added Type Alias JobsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias JobsListByResourceGroupResponse
info	[Changelog]   - Added Type Alias JobsListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias JobsListBySubscriptionResponse
info	[Changelog]   - Added Type Alias JobsListSecretsResponse
info	[Changelog]   - Added Type Alias JobsStartResponse
info	[Changelog]   - Added Type Alias JobsStopMultipleExecutionsResponse
info	[Changelog]   - Added Type Alias JobsUpdateResponse
info	[Changelog]   - Added Type Alias LogLevel
info	[Changelog]   - Added Type Alias ManagedCertificateDomainControlValidation
info	[Changelog]   - Added Type Alias ManagedCertificatesCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesGetResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesListNextResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesListResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesUpdateResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsGetDetectorResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsListDetectorsResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsDiagnosticsGetRootResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsGetAuthTokenResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesNextResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsUpdateResponse
info	[Changelog]   - Added Type Alias RevisionRunningState
info	[Changelog]   - Added Type Alias TriggerType
info	[Changelog]   - Interface AzureCredentials has a new optional parameter kind
info	[Changelog]   - Interface CertificateProperties has a new optional parameter subjectAlternativeNames
info	[Changelog]   - Interface Configuration has a new optional parameter maxInactiveRevisions
info	[Changelog]   - Interface Configuration has a new optional parameter service
info	[Changelog]   - Interface ContainerApp has a new optional parameter environmentId
info	[Changelog]   - Interface ContainerApp has a new optional parameter eventStreamEndpoint
info	[Changelog]   - Interface ContainerApp has a new optional parameter extendedLocation
info	[Changelog]   - Interface ContainerApp has a new optional parameter latestReadyRevisionName
info	[Changelog]   - Interface ContainerApp has a new optional parameter managedBy
info	[Changelog]   - Interface ContainerApp has a new optional parameter workloadProfileName
info	[Changelog]   - Interface ContainerAppSecret has a new optional parameter identity
info	[Changelog]   - Interface ContainerAppSecret has a new optional parameter keyVaultUrl
info	[Changelog]   - Interface CustomHostnameAnalysisResult has a new optional parameter conflictWithEnvironmentCustomDomain
info	[Changelog]   - Interface Dapr has a new optional parameter enableApiLogging
info	[Changelog]   - Interface Dapr has a new optional parameter httpMaxRequestSize
info	[Changelog]   - Interface Dapr has a new optional parameter httpReadBufferSize
info	[Changelog]   - Interface Dapr has a new optional parameter logLevel
info	[Changelog]   - Interface DaprComponent has a new optional parameter secretStoreComponent
info	[Changelog]   - Interface GithubActionConfiguration has a new optional parameter githubPersonalAccessToken
info	[Changelog]   - Interface Ingress has a new optional parameter clientCertificateMode
info	[Changelog]   - Interface Ingress has a new optional parameter corsPolicy
info	[Changelog]   - Interface Ingress has a new optional parameter exposedPort
info	[Changelog]   - Interface Ingress has a new optional parameter ipSecurityRestrictions
info	[Changelog]   - Interface Ingress has a new optional parameter stickySessions
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter customDomainConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter daprConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter eventStreamEndpoint
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter infrastructureResourceGroup
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kedaConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kind
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter peerAuthentication
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter workloadProfiles
info	[Changelog]   - Interface Replica has a new optional parameter initContainers
info	[Changelog]   - Interface Replica has a new optional parameter runningState
info	[Changelog]   - Interface Replica has a new optional parameter runningStateDetails
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter execEndpoint
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter logStreamEndpoint
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter runningState
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter runningStateDetails
info	[Changelog]   - Interface Revision has a new optional parameter lastActiveTime
info	[Changelog]   - Interface Revision has a new optional parameter runningState
info	[Changelog]   - Interface ScaleRule has a new optional parameter tcp
info	[Changelog]   - Interface Secret has a new optional parameter identity
info	[Changelog]   - Interface Secret has a new optional parameter keyVaultUrl
info	[Changelog]   - Interface Template has a new optional parameter initContainers
info	[Changelog]   - Interface Template has a new optional parameter serviceBinds
info	[Changelog]   - Interface Template has a new optional parameter terminationGracePeriodSeconds
info	[Changelog]   - Interface Volume has a new optional parameter mountOptions
info	[Changelog]   - Interface Volume has a new optional parameter secrets
info	[Changelog]   - Interface VolumeMount has a new optional parameter subPath
info	[Changelog]   - Added Enum KnownAction
info	[Changelog]   - Added Enum KnownAffinity
info	[Changelog]   - Added Enum KnownApplicability
info	[Changelog]   - Added Enum KnownConnectedEnvironmentProvisioningState
info	[Changelog]   - Added Enum KnownContainerAppContainerRunningState
info	[Changelog]   - Added Enum KnownContainerAppReplicaRunningState
info	[Changelog]   - Added Enum KnownExtendedLocationTypes
info	[Changelog]   - Added Enum KnownIngressClientCertificateMode
info	[Changelog]   - Added Enum KnownJobExecutionRunningState
info	[Changelog]   - Added Enum KnownJobProvisioningState
info	[Changelog]   - Added Enum KnownLogLevel
info	[Changelog]   - Added Enum KnownManagedCertificateDomainControlValidation
info	[Changelog]   - Added Enum KnownRevisionRunningState
info	[Changelog]   - Added Enum KnownTriggerType
info	[Changelog]   - Enum KnownContainerAppProvisioningState has a new value Deleting
info	[Changelog]   - Enum KnownIngressTransportMethod has a new value Tcp
info	[Changelog]   - Enum KnownStorageType has a new value Secret
info	[Changelog]   - Added function getContinuationToken
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface VnetConfiguration no longer has parameter runtimeSubnetId
info	[Changelog]   - Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
info	[Changelog]   - Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ac98588. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️app [View full logs] 
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs]Release - Generate from ac98588. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.app.DefaultTag [View full logs]  
      error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.app.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/appcontainers/armappcontainers https://apiview.dev/Assemblies/Review/269a5acfb81c43c286eeed6f990c4ba6
    Java azure-resourcemanager-appcontainers https://apiview.dev/Assemblies/Review/bc8b95f6fce549f0bc4227b4d62b1916
    JavaScript @azure/arm-appcontainers https://apiview.dev/Assemblies/Review/5770947743764e9ba1347011e53bb0bb

    @azure-sdk azure-sdk mentioned this pull request Jun 8, 2023
    Closed
    This was referenced Jun 8, 2023
    Closed
    Closed
    Closed
    @azure-sdk azure-sdk mentioned this pull request Jun 8, 2023
    Closed
    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 12, 2023
    @kazrael2119
    Copy link
    Contributor

    @qiaozha this js sdk breaking is existing breaking , so I add "approve-sdkbreakingchange-javascript" label

    @chunyu3 chunyu3 merged commit ac98588 into main Jun 13, 2023
    @chunyu3 chunyu3 deleted the anfranci/fixDescriptionJobExecPrevVers branch June 13, 2023 02:51
    @azure-sdk azure-sdk mentioned this pull request Jun 13, 2023
    Closed
    This was referenced Jun 13, 2023
    Closed
    Closed
    This was referenced Jun 13, 2023
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jijohn14 jijohn14 jijohn14 approved these changes

    @howang-ms howang-ms Awaiting requested review from howang-ms

    Assignees

    @Wzb123456789 Wzb123456789

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-JavaScript CI-BreakingChange-Go CI-BreakingChange-JavaScript FixS360 resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @anandanthony @kazrael2119 @jijohn14 @chunyu3 @Wzb123456789 @AzureRestAPISpecReview @mikekistler