Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging the ManagedNetworkFabric changes in RPSaaSMaster into main #24254

Merged

Conversation

Mohana-Krishna-Nali
Copy link
Contributor

The below given PRs are approved and merged into the RPSaaSMaster.

  1. https://github.com/Azure/azure-rest-api-specs-pr/pull/11537
  2. https://github.com/Azure/azure-rest-api-specs-pr/pull/11749
  3. https://github.com/Azure/azure-rest-api-specs-pr/pull/12117

This PR contains the combination of the all the above three PRs.

@openapi-workflow-bot
Copy link

Hi, @Mohana-Krishna-Nali Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 1, 2023

    Swagger Validation Report

    ️❌BreakingChange: 62 Errors, 1 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    L3IsolationDomains.json 2023-02-01-preview(eba3bef) 2023-02-01-preview(main)
    NetworkFabrics.json 2023-02-01-preview(eba3bef) 2023-02-01-preview(main)
    RoutePolicies.json 2023-02-01-preview(eba3bef) 2023-02-01-preview(main)
    common.json 2023-02-01-preview(eba3bef) 2023-02-01-preview(main)
    IpCommunities.json 2023-02-01-preview(eba3bef) 2023-02-01-preview(main)
    IpExtendedCommunities.json 2023-02-01-preview(eba3bef) 2023-02-01-preview(main)
    IpPrefixes.json 2023-02-01-preview(eba3bef) 2023-02-01-preview(main)
    IpCommunityLists.json 2023-02-01-preview(eba3bef) 2023-02-01-preview(main)
    IpPrefixLists.json 2023-02-01-preview(eba3bef) 2023-02-01-preview(main)

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedNetworkFabric/ipCommunityLists/{ipCommunityListName}' removed or restructured?
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L37:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedNetworkFabric/ipCommunityLists' removed or restructured?
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L255:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ManagedNetworkFabric/ipCommunityLists' removed or restructured?
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L295:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedNetworkFabric/ipPrefixLists/{ipPrefixListName}' removed or restructured?
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L37:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedNetworkFabric/ipPrefixLists' removed or restructured?
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L255:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ManagedNetworkFabric/ipPrefixLists' removed or restructured?
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L295:5
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoutePolicyPatchProperties' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L363:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L363:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'IpCommunityListProperties' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L333:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'IpCommunityList' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L333:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'IpCommunityListPatch' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L333:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'IpCommunityListPatchProperties' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L333:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L333:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ProvisioningState' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L333:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'IpPrefixListProperties' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L333:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'IpPrefixList' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L333:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'IpPrefixListPatch' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L333:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'IpPrefixListPatchProperties' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L333:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L333:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ProvisioningState' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L37:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L333:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L38:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L649:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L38:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L649:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupNameParameter' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L38:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpCommunityLists.json#L649:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L38:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L468:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L38:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L468:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupNameParameter' removed or renamed?
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L38:3
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/IpPrefixLists.json#L468:3
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/L3IsolationDomains.json#L2328:9
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/L3IsolationDomains.json#L2328:9
    1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L909:15
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L911:15
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L909:15
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L911:15
    1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L938:15
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L940:15
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L938:15
    Old: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L940:15
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 10 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-2023-02-01-preview package-2023-02-01-preview(eba3bef) package-2023-02-01-preview(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L401
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L427
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L442
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L446
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L460
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L474
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L490
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L494
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L508
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/RoutePolicies.json#L522


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/L3IsolationDomains.json#L2108
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/L3IsolationDomains.json#L2152
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/L3IsolationDomains.json#L2418
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/L3IsolationDomains.json#L2485
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/L3IsolationDomains.json#L2654
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L873
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L898
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L906
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L935
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ManagedNetworkFabric/preview/2023-02-01-preview/NetworkFabrics.json#L1192
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]

    Tag package-2023-02-01-preview; Prod region: Not deployed; Canary region: Not deployed

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 1, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking


    ️⚠️ azure-sdk-for-java warning [Detail]
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cf7d994. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cf7d994. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/managednetworkfabric/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      warn	No package detected after generation
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cf7d994. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.7.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-managednetworkfabric [View full logs]  [Release SDK Changes]
      info	[Changelog]   - Initial Release
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 1, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Java azure-resourcemanager-managednetworkfabric https://apiview.dev/Assemblies/Review/ffed42a152dd412fba429be19f2a2745

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS labels Jun 1, 2023
    @openapi-workflow-bot
    Copy link

    Hi @Mohana-Krishna-Nali, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @AzureRestAPISpecReview AzureRestAPISpecReview added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 5, 2023
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @Mohana-Krishna-Nali Mohana-Krishna-Nali removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 6, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 6, 2023
    @ms-zhenhua ms-zhenhua added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 7, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 7, 2023
    @ms-zhenhua
    Copy link
    Contributor

    @Mohana-Krishna-Nali Please reach out to Azure Breaking Changes Reviewers azbreakchangereview@microsoft.com to get a breaking changes approval and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers.

    @mikekistler
    Copy link
    Member

    Breaking changes previously reviewed and approved.

    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 7, 2023
    @Mohana-Krishna-Nali Mohana-Krishna-Nali removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 7, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 7, 2023
    @ms-zhenhua ms-zhenhua added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 8, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 8, 2023
    @Wzb123456789 Wzb123456789 added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 9, 2023
    @chunyu3 chunyu3 merged commit cf7d994 into main Jun 9, 2023
    @chunyu3 chunyu3 deleted the dev/v-mnali/Merging-managedNetworkFabric-RPSaaSMasterChanges branch June 9, 2023 02:05
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    …zure#24254)
    
    * Merging the RPSaaSMaster PRs into main
    1. Azure/azure-rest-api-specs-pr#11537
    2. Azure/azure-rest-api-specs-pr#11749
    3. Azure/azure-rest-api-specs-pr#12117
    
    * updating swagger-to-sdk in readme.md
    
    * Minor changes - to resolve the dotnet and python sdk issues
    
    * minor change to resolve the  dotnet sdk issue
    
    * solved sdk issue having incompatible type for optionB description.
    
    * Resolving the Duplicated model name with non-identical definitions issue.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants