-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging the ManagedNetworkFabric changes in RPSaaSMaster into main #24254
Merging the ManagedNetworkFabric changes in RPSaaSMaster into main #24254
Conversation
Hi, @Mohana-Krishna-Nali Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
L3IsolationDomains.json | 2023-02-01-preview(eba3bef) | 2023-02-01-preview(main) |
NetworkFabrics.json | 2023-02-01-preview(eba3bef) | 2023-02-01-preview(main) |
RoutePolicies.json | 2023-02-01-preview(eba3bef) | 2023-02-01-preview(main) |
common.json | 2023-02-01-preview(eba3bef) | 2023-02-01-preview(main) |
IpCommunities.json | 2023-02-01-preview(eba3bef) | 2023-02-01-preview(main) |
IpExtendedCommunities.json | 2023-02-01-preview(eba3bef) | 2023-02-01-preview(main) |
IpPrefixes.json | 2023-02-01-preview(eba3bef) | 2023-02-01-preview(main) |
IpCommunityLists.json | 2023-02-01-preview(eba3bef) | 2023-02-01-preview(main) |
IpPrefixLists.json | 2023-02-01-preview(eba3bef) | 2023-02-01-preview(main) |
Only 30 items are listed, please refer to log for more details.
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 10 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.2) | new version | base version |
---|---|---|
package-2023-02-01-preview | package-2023-02-01-preview(eba3bef) | package-2023-02-01-preview(main) |
[must fix]The following errors/warnings are introduced by current PR:
The following errors/warnings exist before current PR submission:
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]
Tag package-2023-02-01-preview; Prod region: Not deployed; Canary region: Not deployed
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @Mohana-Krishna-Nali, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
@Mohana-Krishna-Nali Please reach out to Azure Breaking Changes Reviewers azbreakchangereview@microsoft.com to get a breaking changes approval and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers. |
Breaking changes previously reviewed and approved. |
…zure#24254) * Merging the RPSaaSMaster PRs into main 1. Azure/azure-rest-api-specs-pr#11537 2. Azure/azure-rest-api-specs-pr#11749 3. Azure/azure-rest-api-specs-pr#12117 * updating swagger-to-sdk in readme.md * Minor changes - to resolve the dotnet and python sdk issues * minor change to resolve the dotnet sdk issue * solved sdk issue having incompatible type for optionB description. * Resolving the Duplicated model name with non-identical definitions issue.
The below given PRs are approved and merged into the RPSaaSMaster.
This PR contains the combination of the all the above three PRs.