Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new parameter "MarketplaceStatus" in the "MarketplaceSaaSInfo" response in 2023-02-01-preview #24010

Closed
wants to merge 4 commits into from

Conversation

RheaHooda23
Copy link
Contributor

@RheaHooda23 RheaHooda23 commented May 16, 2023

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @RheaHooda23 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 16, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    elastic.json 2023-05-01-preview(5bc1e8d) 2020-07-01(main)
    elastic.json 2023-05-01-preview(5bc1e8d) 2023-02-01-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.1.2) new version base version
    default default(5bc1e8d) default(main)
    ️❌Avocado: 31 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
    readme: specification/elastic/resource-manager/readme.md
    json: Microsoft.Elastic/preview/2023-05-01-preview/elastic.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/AllTrafficFilters_list.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/AssociateTrafficFilter_Update.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/AssociatedFiltersForDeployment_list.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/DeploymentInfo_List.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/DetachAndDeleteTrafficFilter_Delete.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/DetachTrafficFilters_Update.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/ElasticVersions_List.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/ExternalUserInfo.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/IPTrafficFilter_Create.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/Monitor_Upgrade.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/MonitoredResources_List.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/Monitors_Create.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/Monitors_Delete.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/Monitors_Get.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/Monitors_List.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/Monitors_ListByResourceGroup.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/Monitors_Update.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/Operations_List.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/Organizations_GetApiKey.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/PrivateLinkTrafficFilters_Create.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/TagRules_CreateOrUpdate.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/TagRules_Delete.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/TagRules_Get.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/TagRules_List.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/TrafficFilters_Delete.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/UpgradableVersions_Details.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/VMCollection_Update.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/VMHost_List.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/elastic/resource-manager/readme.md
    json: preview/2023-05-01-preview/examples/VMIngestion_Details.json
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.Elastic' for api version '2023-05-01-preview'. The supported api-versions are '2020-07-01-preview,
    2020-07-01,
    2021-09-01-preview,
    2021-10-01-preview,
    2022-05-05-preview,
    2022-07-01-preview,
    2022-09-01-preview,
    2023-02-01-preview'."
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 16, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 5a98d4923d3eaa644e1e97a3d2a3e1bbc93f1d82. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.6` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-elastic [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group ElasticVersionsOperations
      info	[Changelog]   - Model MonitorProperties has a new parameter generate_api_key
      info	[Changelog]   - Model UserApiKeyResponse has a new parameter properties
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model ElasticMonitorResource no longer has parameter generate_api_key
      info	[Changelog]   - Model UserApiKeyResponse no longer has parameter api_key
      info	[Changelog]   - Operation OrganizationsOperations.get_api_key no longer has parameter resource_group_name
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 5a98d4923d3eaa644e1e97a3d2a3e1bbc93f1d82. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-elastic [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 5a98d4923d3eaa644e1e97a3d2a3e1bbc93f1d82. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/elastic/armelastic [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*OrganizationsClient.GetAPIKey` parameter(s) have been changed from `(context.Context, string, *OrganizationsClientGetAPIKeyOptions)` to `(context.Context, *OrganizationsClientGetAPIKeyOptions)`
      info	[Changelog] - Field `GenerateAPIKey` of struct `MonitorResource` has been removed
      info	[Changelog] - Field `APIKey` of struct `UserAPIKeyResponse` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `*ClientFactory.NewVersionsClient() *VersionsClient`
      info	[Changelog] - New function `NewVersionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VersionsClient, error)`
      info	[Changelog] - New function `*VersionsClient.NewListPager(string, *VersionsClientListOptions) *runtime.Pager[VersionsClientListResponse]`
      info	[Changelog] - New struct `UserAPIKeyResponseProperties`
      info	[Changelog] - New struct `VersionListFormat`
      info	[Changelog] - New struct `VersionListProperties`
      info	[Changelog] - New struct `VersionsListResponse`
      info	[Changelog] - New field `GenerateAPIKey` in struct `MonitorProperties`
      info	[Changelog] - New field `Properties` in struct `UserAPIKeyResponse`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 13 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 5a98d4923d3eaa644e1e97a3d2a3e1bbc93f1d82. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️elastic [View full logs
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from 5a98d4923d3eaa644e1e97a3d2a3e1bbc93f1d82. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.elastic.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.elastic.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @RheaHooda23 RheaHooda23 requested a review from poshett May 16, 2023 11:24
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 16, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/elastic/armelastic https://apiview.dev/Assemblies/Review/561b6351d2664325973c61e2248cc751
    Java azure-resourcemanager-elastic https://apiview.dev/Assemblies/Review/4cd7bfe6c8f14ced9f25a135b6006bec

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @RheaHooda23 RheaHooda23 added the Liftr Marketplace-Liftr RPs label May 16, 2023
    @v-jiaodi v-jiaodi added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label May 17, 2023
    @openapi-workflow-bot
    Copy link

    Hi @RheaHooda23, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview CI-FixRequiredOnFailure CI-MissingBaseCommit new-api-version WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NewApiVersionRequired labels May 17, 2023
    @openapi-workflow-bot
    Copy link

    Hi @RheaHooda23, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi, @RheaHooda23, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @RheaHooda23 RheaHooda23 deleted the users/rheahooda/addNewParam branch May 17, 2023 17:49
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMReview CI-FixRequiredOnFailure CI-MissingBaseCommit Liftr Marketplace-Liftr RPs new-api-version resource-manager RPaaS WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants