Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spec definition for Nested template parameter #23959

Merged
merged 9 commits into from
Jun 15, 2023

Conversation

abatishchev
Copy link
Contributor

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @abatishchev Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 12, 2023

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    resources.json 2022-09-01(b883d72) 2022-09-01(main)
    Rule Message
    1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
    New: Microsoft.Resources/stable/2022-09-01/resources.json#L4616:9
    Old: Microsoft.Resources/stable/2022-09-01/resources.json#L4616:9
    1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
    New: Microsoft.Resources/stable/2022-09-01/resources.json#L4616:9
    Old: Microsoft.Resources/stable/2022-09-01/resources.json#L4616:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.3) new version base version
    package-resources-2022-09 package-resources-2022-09(b883d72) package-resources-2022-09(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Resources/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L52
    OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L53
    NoDuplicatePathsForScopeParameter Path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}/cancel' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}/validate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}/exportTemplate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/providers/Microsoft.Management/managementGroups/{groupId}/providers/Microsoft.Resources/deployments/{deploymentName}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/providers/Microsoft.Management/managementGroups/{groupId}/providers/Microsoft.Resources/deployments/{deploymentName}/cancel' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/providers/Microsoft.Management/managementGroups/{groupId}/providers/Microsoft.Resources/deployments/{deploymentName}/validate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/providers/Microsoft.Management/managementGroups/{groupId}/providers/Microsoft.Resources/deployments/{deploymentName}/whatIf' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/providers/Microsoft.Management/managementGroups/{groupId}/providers/Microsoft.Resources/deployments/{deploymentName}/exportTemplate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/providers/Microsoft.Resources/deployments/{deploymentName}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/providers/Microsoft.Resources/deployments/{deploymentName}/cancel' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/providers/Microsoft.Resources/deployments/{deploymentName}/validate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/providers/Microsoft.Resources/deployments/{deploymentName}/whatIf' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/providers/Microsoft.Resources/deployments/{deploymentName}/exportTemplate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Resources/deployments/{deploymentName}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Resources/deployments/{deploymentName}/cancel' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Resources/deployments/{deploymentName}/validate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Resources/deployments/{deploymentName}/whatIf' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Resources/deployments/{deploymentName}/exportTemplate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}/operations/{operationId}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}/operations' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/providers/Microsoft.Management/managementGroups/{groupId}/providers/Microsoft.Resources/deployments/{deploymentName}/operations/{operationId}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/providers/Microsoft.Management/managementGroups/{groupId}/providers/Microsoft.Resources/deployments/{deploymentName}/operations' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/providers/Microsoft.Resources/deployments/{deploymentName}/operations/{operationId}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/providers/Microsoft.Resources/deployments/{deploymentName}/operations' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Resources/deployments/{deploymentName}' that has the scope parameter.'.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L68
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L88
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L97
    NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L124
    PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Deployments_CreateOrUpdateAtScope' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.Resources/stable/2022-09-01/resources.json#L135
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 75 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Operations_List.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L38:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_DeleteAtScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L69:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_CheckExistenceAtScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L103:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_GetAtScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L189:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_CancelAtScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L223:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ValidateAtScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L255:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ExportTemplateAtScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L308:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ListAtScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L342:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_DeleteAtTenantScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L392:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_CheckExistenceAtTenantScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L423:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_GetAtTenantScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L503:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_CancelAtTenantScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L534:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ValidateAtTenantScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L563:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ExportTemplateAtTenantScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L675:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ListAtTenantScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L706:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_DeleteAtManagementGroupScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L753:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_CheckExistenceAtManagementGroupScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L787:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_GetAtManagementGroupScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L873:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_CancelAtManagementGroupScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L907:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ValidateAtManagementGroupScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L939:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ExportTemplateAtManagementGroupScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L1057:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ListAtManagementGroupScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L1091:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_DeleteAtSubscriptionScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L1141:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_CheckExistenceAtSubscriptionScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L1175:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_GetAtSubscriptionScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L1261:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_CancelAtSubscriptionScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L1295:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ValidateAtSubscriptionScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L1327:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ExportTemplateAtSubscriptionScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L1445:15
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_ListAtSubscriptionScope.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L1479:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Deployments_Delete.
    Url: Microsoft.Resources/stable/2022-09-01/resources.json#L1529:17
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 12, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/resources/armresources - Approved - 2.0.0
    +	Operation `*TagsClient.CreateOrUpdateAtScope` has been changed to LRO, use `*TagsClient.BeginCreateOrUpdateAtScope` instead.
    +	Operation `*TagsClient.DeleteAtScope` has been changed to LRO, use `*TagsClient.BeginDeleteAtScope` instead.
    +	Operation `*TagsClient.UpdateAtScope` has been changed to LRO, use `*TagsClient.BeginUpdateAtScope` instead.
    +	Type of `DeploymentProperties.Parameters` has been changed from `any` to `map[string]*DeploymentParameter`
    +	Type of `DeploymentWhatIfProperties.Parameters` has been changed from `any` to `map[string]*DeploymentParameter`









    azure-sdk-for-js - @azure/arm-changes - Approved - 2.0.0
    +	Interface ChangesListNextOptionalParams no longer has parameter skipToken
    +	Interface ChangesListNextOptionalParams no longer has parameter top
    azure-sdk-for-js - @azure/arm-links - Approved - 3.0.0
    +	Interface ResourceLinksListAtSubscriptionNextOptionalParams no longer has parameter filter
    azure-sdk-for-js - @azure/arm-locks - Approved - 3.0.0
    +	Interface ManagementLocksListAtResourceGroupLevelNextOptionalParams no longer has parameter filter
    +	Interface ManagementLocksListAtResourceLevelNextOptionalParams no longer has parameter filter
    +	Interface ManagementLocksListAtSubscriptionLevelNextOptionalParams no longer has parameter filter
    +	Interface ManagementLocksListByScopeNextOptionalParams no longer has parameter filter
    azure-sdk-for-js - @azure/arm-policy - Approved - 6.0.0-beta.1
    +	Class PolicyClient has a new signature
    +	Parameter subscriptionId of class PolicyClient is now required
    azure-sdk-for-js - @azure/arm-resources-subscriptions - Approved - 3.0.0
    +	Class SubscriptionClient has a new signature
    +	Operation Subscriptions.get has a new signature
    +	Operation Subscriptions.listLocations has a new signature
    azure-sdk-for-js - @azure/arm-resources - Approved - 6.0.0
    +	Removed operation TagsOperations.createOrUpdateAtScope
    +	Removed operation TagsOperations.deleteAtScope
    +	Removed operation TagsOperations.updateAtScope
    +	Type of parameter parameters of interface DeploymentProperties is changed from Record to {
            [propertyName: string]: DeploymentParameter;
        }
    azure-sdk-for-js - @azure/arm-templatespecs - Approved - 3.0.0
    +	Interface TemplateSpecsListByResourceGroupNextOptionalParams no longer has parameter expand
    +	Interface TemplateSpecsListBySubscriptionNextOptionalParams no longer has parameter expand
    azure-sdk-for-python-track2 - track2_azure-mgmt-resource - Approved - 23.1.0b1
    +	Parameter mode of model DenySettings is now required
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 4940129. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:881
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 881 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:881
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 881 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cannot force update branch 'sdkAuto/Azure.ResourceManager.Resources' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/Azure.ResourceManager.Resources' as it is the current HEAD of the repository.
    • ️✔️Azure.ResourceManager.Resources [View full logs]  [Release SDK Changes]
      info	[Changelog]
    • Azure.ResourceManager.Resources [View full logsBreaking Change Detected
      error	Fatal error: cannot force update branch 'sdkAuto/Azure.ResourceManager.Resources' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		Azure.ResourceManager.Resources
      error		Azure.ResourceManager.Resources
      error		Azure.ResourceManager
    • Azure.ResourceManagerBreaking Change Detected
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4940129. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.7.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-resource [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Parameter mode of model DenySettings is now required
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4940129. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/resources/armresources [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 12 items here, please refer to log for details.
      info	[Changelog] - Type of `DeploymentWhatIfProperties.Parameters` has been changed from `any` to `map[string]*DeploymentParameter`
      info	[Changelog] - Operation `*TagsClient.CreateOrUpdateAtScope` has been changed to LRO, use `*TagsClient.BeginCreateOrUpdateAtScope` instead.
      info	[Changelog] - Operation `*TagsClient.DeleteAtScope` has been changed to LRO, use `*TagsClient.BeginDeleteAtScope` instead.
      info	[Changelog] - Operation `*TagsClient.UpdateAtScope` has been changed to LRO, use `*TagsClient.BeginUpdateAtScope` instead.
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New struct `DeploymentParameter`
      info	[Changelog] - New struct `KeyVaultParameterReference`
      info	[Changelog] - New struct `KeyVaultReference`
      info	[Changelog]
      info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armdeploymentscripts [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armfeatures [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armlinks [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armlocks [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armmanagedapplications [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armpolicy [View full logs]  [Release SDK Changes]
      Only show 12 items here, please refer to log for details.
      info	[Changelog] - New struct `VariableColumn`
      info	[Changelog] - New struct `VariableListResult`
      info	[Changelog] - New struct `VariableProperties`
      info	[Changelog] - New struct `VariableValue`
      info	[Changelog] - New struct `VariableValueColumnValue`
      info	[Changelog] - New struct `VariableValueListResult`
      info	[Changelog] - New struct `VariableValueProperties`
      info	[Changelog] - New field `Overrides`, `ResourceSelectors` in struct `AssignmentProperties`
      info	[Changelog] - New field `Properties` in struct `AssignmentUpdate`
      info	[Changelog] - New field `AssignmentScopeValidation`, `ResourceSelectors` in struct `ExemptionProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 62 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armsubscriptions [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armtemplatespecs [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/resources/armchanges [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4940129. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
    • ️✔️@azure/arm-changes [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface ChangesListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface ChangesListNextOptionalParams no longer has parameter top
    • ️✔️@azure/arm-features [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Class FeatureClient has a new signature
    • ️✔️@azure/arm-links [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Class ManagementLinkClient has a new signature
      info	[Changelog]   - Interface ResourceLinksListAtSubscriptionNextOptionalParams no longer has parameter filter
    • ️✔️@azure/arm-locks [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Class ManagementLockClient has a new signature
      info	[Changelog]   - Interface ManagementLocksListAtResourceGroupLevelNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface ManagementLocksListAtResourceLevelNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface ManagementLocksListAtSubscriptionLevelNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface ManagementLocksListByScopeNextOptionalParams no longer has parameter filter
    • ️✔️@azure/arm-managedapplications [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Class ApplicationClient has a new signature
    • ️✔️@azure/arm-policy [View full logs]  [Release SDK Changes]
      Only show 14 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias VariableValuesGetResponse
      info	[Changelog]   - Added Type Alias VariableValuesListForManagementGroupNextResponse
      info	[Changelog]   - Added Type Alias VariableValuesListForManagementGroupResponse
      info	[Changelog]   - Added Type Alias VariableValuesListNextResponse
      info	[Changelog]   - Added Type Alias VariableValuesListResponse
      info	[Changelog]   - Interface PolicyAssignment has a new optional parameter overrides
      info	[Changelog]   - Interface PolicyAssignment has a new optional parameter resourceSelectors
      info	[Changelog]   - Interface PolicyAssignmentUpdate has a new optional parameter overrides
      info	[Changelog]   - Interface PolicyAssignmentUpdate has a new optional parameter resourceSelectors
      info	[Changelog]   - Interface PolicyExemption has a new optional parameter assignmentScopeValidation
      info	[Changelog]   - Interface PolicyExemption has a new optional parameter resourceSelectors
      info	[Changelog]   - Added Enum KnownAssignmentScopeValidation
      info	[Changelog]   - Added Enum KnownOverrideKind
      info	[Changelog]   - Added Enum KnownSelectorKind
    • ️✔️@azure/arm-resources-subscriptions [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    • ️✔️@azure/arm-resources [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 14 items here, please refer to log for details.
      info	[Changelog]   - Interface TagsDeleteAtScopeOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface TagsDeleteAtScopeOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface TagsUpdateAtScopeOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface TagsUpdateAtScopeOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation TagsOperations.createOrUpdateAtScope
      info	[Changelog]   - Removed operation TagsOperations.deleteAtScope
      info	[Changelog]   - Removed operation TagsOperations.updateAtScope
      info	[Changelog]   - Class ResourceManagementClient has a new signature
      info	[Changelog]   - Type of parameter parameters of interface DeploymentProperties is changed from Record<string, unknown> to {
      info	[Changelog]         [propertyName: string]: DeploymentParameter;
      info	[Changelog]     }
    • ️✔️@azure/arm-templatespecs [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 14 items here, please refer to log for details.
      info	[Changelog]   - Added Interface TemplateSpecVersionsListBuiltInsNextOptionalParams
      info	[Changelog]   - Added Interface TemplateSpecVersionsListBuiltInsOptionalParams
      info	[Changelog]   - Added Type Alias TemplateSpecsGetBuiltInResponse
      info	[Changelog]   - Added Type Alias TemplateSpecsListBuiltInsNextResponse
      info	[Changelog]   - Added Type Alias TemplateSpecsListBuiltInsResponse
      info	[Changelog]   - Added Type Alias TemplateSpecVersionsGetBuiltInResponse
      info	[Changelog]   - Added Type Alias TemplateSpecVersionsListBuiltInsNextResponse
      info	[Changelog]   - Added Type Alias TemplateSpecVersionsListBuiltInsResponse
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Class TemplateSpecsClient has a new signature
      info	[Changelog]   - Interface TemplateSpecsListByResourceGroupNextOptionalParams no longer has parameter expand
      info	[Changelog]   - Interface TemplateSpecsListBySubscriptionNextOptionalParams no longer has parameter expand
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 4940129. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
    • resources/resource-manager [View full logs]  [Release Schema Changes]
    • ️✔️resources [View full logs]  [Release Schema Changes]
    • ️✔️resources [View full logs
      error	Fatal error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		resources/resource-manager
      error		resources
      error		resources
      error		resources
    • ️✔️resources
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 4940129. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.resources.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.resources.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 12, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/resources/armchanges There is no API change compared with the previous version
    Go sdk/resourcemanager/resources/armdeploymentscripts https://apiview.dev/Assemblies/Review/b97bbe92bf9b4c2480168924c671cdfe
    Go sdk/resourcemanager/resources/armfeatures There is no API change compared with the previous version
    Go sdk/resourcemanager/resources/armlinks There is no API change compared with the previous version
    Go sdk/resourcemanager/resources/armmanagedapplications https://apiview.dev/Assemblies/Review/21e37e037f04455fa383d84b69734b42
    Go sdk/resourcemanager/resources/armpolicy https://apiview.dev/Assemblies/Review/850af648ab4a440db0493f9785c5748a
    Go sdk/resourcemanager/resources/armresources https://apiview.dev/Assemblies/Review/0ad0d16ffc4c4ec797f7bc0f1b13265c
    Go sdk/resourcemanager/resources/armtemplatespecs There is no API change compared with the previous version
    .Net Azure.ResourceManager.Resources https://apiview.dev/Assemblies/Review/894dcbd8b58147f689c46fdb4b2327be
    JavaScript @azure/arm-changes https://apiview.dev/Assemblies/Review/afca46552c9241dc8960e057ed7457d6
    JavaScript @azure/arm-features https://apiview.dev/Assemblies/Review/238fdf5232064173adee32a5eb68882f
    JavaScript @azure/arm-links https://apiview.dev/Assemblies/Review/611d13982f9e45a6a3677b120d2327fa
    JavaScript @azure/arm-locks https://apiview.dev/Assemblies/Review/036dce661c004b079b6617da747a447d
    JavaScript @azure/arm-managedapplications https://apiview.dev/Assemblies/Review/ddcafcbe85904a5abca5aecd92d11e41
    JavaScript @azure/arm-policy https://apiview.dev/Assemblies/Review/47594813ca6549e8b8626c0f1eeccc74
    JavaScript @azure/arm-resources-subscriptions https://apiview.dev/Assemblies/Review/8ca52cb103264b8b888aa97746e02fa8
    JavaScript @azure/arm-resources https://apiview.dev/Assemblies/Review/49914340f1234fffa77d00cad4184b8e
    JavaScript @azure/arm-templatespecs https://apiview.dev/Assemblies/Review/c5d3878c200d44e3ae2a52af3064c308

    This was referenced May 12, 2023
    @kazrael2119
    Copy link
    Contributor

    @abatishchev ,please let me know when you want to merge this pr,thanks

    Copy link
    Member

    @anthony-c-martin anthony-c-martin left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @abatishchev
    Copy link
    Contributor Author

    @kazrael2119 yes, please merge.

    @tadelesh tadelesh merged commit 4940129 into main Jun 15, 2023
    @tadelesh tadelesh deleted the alexbat/deployment-params-1 branch June 15, 2023 01:50
    This was referenced Jun 15, 2023
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    * 2021-04-01
    
    * 2022-09-01
    
    * sync
    
    * merge
    
    * "type": "object"
    
    * no empty "required"
    
    * no "type": "object",
    
    * Revert "no "type": "object","
    
    This reverts commit 3d22f0a.
    
    * "type": "object" on DeploymentParameter
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    10 participants