Revert "[Hub Generated] Review request for Microsoft.Synapse to add version stable/2023-05-01" #23668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion stable/2023-05-01 (Azure#23376)" This reverts commit 5b79bd5.
|
Hi, @vishnumathi Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| types.json | 4.0(47ba62a) | 4.0(main) |
| azureADOnlyAuthentication.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| bigDataPool.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| checkNameAvailability.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| firewallRule.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| integrationRuntime.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| keys.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| library.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| listUsage.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| operations.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| privateEndpointConnections.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| privateLinkResources.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| privatelinkhub.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| sqlPool.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| sqlServer.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
| workspace.json | 2023-05-01(47ba62a) | 2023-05-01(main) |
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/azureADOnlyAuthentications/{azureADOnlyAuthenticationName}' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/azureADOnlyAuthentication.json#L24:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/azureADOnlyAuthentications' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/azureADOnlyAuthentication.json#L148:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/bigDataPools/{bigDataPoolName}' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/bigDataPool.json#L24:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/bigDataPools' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/bigDataPool.json#L291:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Synapse/checkNameAvailability' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/checkNameAvailability.json#L24:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/firewallRules' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/firewallRule.json#L24:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/firewallRules/{ruleName}' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/firewallRule.json#L74:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/replaceAllIpFirewallRules' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/firewallRule.json#L253:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L24:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/nodes/{nodeName}/ipAddress' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L273:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/upgrade' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L333:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/getObjectMetadata' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L383:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/nodes/{nodeName}' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L445:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/syncCredentials' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L626:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L676:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/getConnectionInfo' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L727:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/start' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L780:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/regenerateAuthKey' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L840:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/listAuthKeys' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L902:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/monitoringData' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L955:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/stop' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L1008:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/refreshObjectMetadata' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L1062:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/getStatus' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L1122:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/outboundNetworkDependenciesEndpoints' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L1175:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/enableInteractiveQuery' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L1227:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/disableInteractiveQuery' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/integrationRuntime.json#L1280:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/keys' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/keys.json#L24:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/keys/{keyName}' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/keys.json#L74:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/libraries/{libraryName}' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/library.json#L24:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/libraries' removed or restructured? Old: Microsoft.Synapse/stable/2023-05-01/library.json#L75:5 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| default | default(47ba62a) | default(main) |
️❌Avocado: 19 Errors, 1 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/checkNameAvailability.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/firewallRule.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/keys.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/operations.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/privateEndpointConnections.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/privatelinkhub.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/privateLinkResources.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/workspace.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/azureADOnlyAuthentication.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Synapse/workspaces/{}/recoverableSqlpools is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2019-06-01-preview/sqlServer.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Synapse/workspaces/{}/sqlDatabases/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Synapse/workspaces/{}/sqlDatabases is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2020-04-01-preview/sqlDatabase.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Synapse/workspaces/{}/sqlPools/{}/dataWarehouseQueries is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Synapse/workspaces/{}/sqlPools/{}/dataWarehouseQueries/{}/steps is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Synapse/workspaces/{}/trustedServiceByPassConfiguration/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/workspace.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Synapse/workspaces/{}/checkDefaultStorageAccountStatus is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/workspace.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Synapse/workspaces/{}/scopePools is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/preview/2021-06-01-preview/workspace.json |
| The default tag contains multiple API versions swaggers. readme: specification/synapse/resource-manager/readme.md tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️❌SwaggerAPIView: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"How to fix":"Check the readme file and make sure the readme file format is valid and the tag is defined. Use the provided readme template" |
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
customer-reported
|
Thank you for your contribution vishnumathi! We will review the pull request and get back to you soon. |
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @vishnumathi, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @vishnumathi, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Apr 21, 2023
This was referenced Apr 21, 2023
msyyc
approved these changes
Apr 21, 2023
|
|
This was referenced Apr 21, 2023
Closed
Closed
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-rest-api-specs
that referenced
this pull request
Apr 25, 2023
…ersion stable/2023-05-01 (Azure#23376)" (Azure#23668) This reverts commit 5b79bd5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #23376
Code deployment is in progress, pls revert this pr. We would like to merge it oncecode deployment is completed in all regions