Review request for Microsoft.SecurityInsights to add version preview/2023-05-01-preview #23610

nazang · 2023-04-18T19:29:33Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…w/2023-04-01-preview to version 2023-05-01-preview

openapi-workflow-bot · 2023-04-18T19:29:37Z

Hi, @nazang Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-04-18T19:29:37Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 3 Errors, 12 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
AlertRules.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
AlertRules.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
AutomationRules.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
AutomationRules.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
Bookmarks.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
Bookmarks.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
ContentPackages.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
ContentProductPackages.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
ContentProductTemplates.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
ContentTemplates.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
Enrichment.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
Entities.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
EntityQueries.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
EntityQueryTemplates.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
FileImports.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
Hunts.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
Incidents.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
Incidents.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
Metadata.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
Metadata.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
OfficeConsents.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
OnboardingStates.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
OnboardingStates.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
Recommendations.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
SecurityMLAnalyticsSettings.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
SecurityMLAnalyticsSettings.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
Settings.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
SourceControls.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
ThreatIntelligence.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
ThreatIntelligence.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
TriggeredAnalyticsRuleRuns.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
Watchlists.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
Watchlists.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
WorkspaceManagerAssignments.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
WorkspaceManagerConfigurations.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
WorkspaceManagerGroups.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
WorkspaceManagerMembers.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
AlertTypes.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
AlertTypes.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
ContentCommonTypes.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
EntityTypes.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
EntityTypes.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
IncidentTypes.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
IncidentTypes.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
RelationTypes.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
ThreatIntelligenceTypes.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
dataConnectors.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)
operations.json	2023-05-01-preview(92d40e1)	2023-02-01(main)
operations.json	2023-05-01-preview(92d40e1)	2023-04-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.SecurityInsights/preview/2023-05-01-preview/AlertRules.json#L1576:7 Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1072:7
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.SecurityInsights/preview/2023-05-01-preview/Watchlists.json#L481:7 Old: Microsoft.SecurityInsights/stable/2023-02-01/Watchlists.json#L469:7
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/Watchlists.json#L494:9 Old: Microsoft.SecurityInsights/stable/2023-02-01/Watchlists.json#L482:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/Incidents.json#L1315:9 Old: Microsoft.SecurityInsights/stable/2023-02-01/Incidents.json#L1102:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/Incidents.json#L1319:9 Old: Microsoft.SecurityInsights/stable/2023-02-01/Incidents.json#L1138:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/Incidents.json#L1312:9 Old: Microsoft.SecurityInsights/stable/2023-02-01/Incidents.json#L1245:9
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/AlertRules.json#L2372:11 Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L533:11
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/AlertRules.json#L326:13 Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L317:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/AlertRules.json#L375:13 Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L366:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/AlertRules.json#L381:13 Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L372:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/AlertRules.json#L2331:5 Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L579:5
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/AlertRules.json#L1552:9 Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1053:9
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/AlertRules.json#L1569:5 Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1070:5
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/Metadata.json#L250:9 Old: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L250:9
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SecurityInsights/preview/2023-05-01-preview/Metadata.json#L325:5 Old: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L325:5

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.1)	new version	base version
package-preview-2023-05	package-preview-2023-05(92d40e1)	default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` DeleteResponseBodyEmpty	The delete response body must be empty. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/AutomationRules.json#L148
`❌` DeleteResponseBodyEmpty	The delete response body must be empty. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/AutomationRules.json#L154
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'BookmarkRelations_List' does not match the response definition in the individual GET operation 'BookmarkRelations_Get' . Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Bookmarks.json#L222
`❌` ResourceNameRestriction	The resource name parameter 'relationName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Bookmarks.json#L331
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Bookmarks.json#L566
`❌` ArrayMustHaveType	'items.type' property must be truthy Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/dataConnectors.json#L2393
`❌` ArrayMustHaveType	'items.type' property must be truthy Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/dataConnectors.json#L2405
`❌` ArrayMustHaveType	'items.type' property must be truthy Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/dataConnectors.json#L2417
`❌` ArrayMustHaveType	'items.type' property must be truthy Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/dataConnectors.json#L2429
`❌` ArrayMustHaveType	'items.type' property must be truthy Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/dataConnectors.json#L2449
`❌` ArrayMustHaveType	'items.type' property must be truthy Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/dataConnectors.json#L2825
`❌` ArrayMustHaveType	'items.type' property must be truthy Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/dataConnectors.json#L2837
`❌` ArrayMustHaveType	'items.type' property must be truthy Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/dataConnectors.json#L2933
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'EntitiesRelations_List' does not match the response definition in the individual GET operation 'EntityRelations_GetRelation' . Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Entities.json#L376
`❌` ResourceNameRestriction	The resource name parameter 'relationName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Entities.json#L437
`❌` DefinitionsPropertiesNamesCamelCase	Property name should be camel case. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Entities.json#L1204
`❌` XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/EntityQueries.json#L484
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/EntityQueryTemplates.json#L234
`❌` XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/EntityQueryTemplates.json#L292
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/FileImports.json#L213
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'IncidentRelations_List' does not match the response definition in the individual GET operation 'IncidentRelations_Get' . Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Incidents.json#L634
`❌` ResourceNameRestriction	The resource name parameter 'relationName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Incidents.json#L698
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Incidents.json#L1245
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Incidents.json#L1332
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Metadata.json#L266
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Metadata.json#L266
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Metadata.json#L505
`❌` ResourceNameRestriction	The resource name parameter 'sentinelOnboardingStateName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/OnboardingStates.json#L37
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/operations.json#L83
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.SecurityInsights/preview/2023-05-01-preview/Recommendations.json#L156

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-18T19:29:37Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-js - @azure/arm-securityinsight - Approved - 1.0.0-beta.7

-	Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum19
+	Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum20

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1f449b5. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.SecurityInsights [View full logs] [Release SDK Changes]
- Azure.ResourceManager.SecurityInsights.1.1.0-alpha.20230511.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 1f449b5. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.6` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-securityinsight [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation EntitiesOperations.run_playbook
info	[Changelog]   - Added operation group AlertRuleOperations
info	[Changelog]   - Added operation group BillingStatisticsOperations
info	[Changelog]   - Added operation group ContentPackageOperations
info	[Changelog]   - Added operation group ContentPackagesOperations
info	[Changelog]   - Added operation group ContentTemplateOperations
info	[Changelog]   - Added operation group ContentTemplatesOperations
info	[Changelog]   - Added operation group GetTriggeredAnalyticsRuleRunsOperations
info	[Changelog]   - Added operation group HuntCommentsOperations
info	[Changelog]   - Added operation group HuntRelationsOperations
info	[Changelog]   - Added operation group HuntsOperations
info	[Changelog]   - Added operation group ProductPackageOperations
info	[Changelog]   - Added operation group ProductPackagesOperations
info	[Changelog]   - Added operation group ProductTemplateOperations
info	[Changelog]   - Added operation group ProductTemplatesOperations
info	[Changelog]   - Added operation group TriggeredAnalyticsRuleRunOperations
info	[Changelog]   - Added operation group WorkspaceManagerAssignmentJobsOperations
info	[Changelog]   - Added operation group WorkspaceManagerAssignmentsOperations
info	[Changelog]   - Added operation group WorkspaceManagerConfigurationsOperations
info	[Changelog]   - Added operation group WorkspaceManagerGroupsOperations
info	[Changelog]   - Added operation group WorkspaceManagerMembersOperations
info	[Changelog]   - Model MTPDataConnector has a new parameter filtered_providers
info	[Changelog]   - Model MTPDataConnectorDataTypes has a new parameter alerts
info	[Changelog]   - Model MTPDataConnectorProperties has a new parameter filtered_providers
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
info	[Changelog]   - Parameter logic_app_resource_id of model PlaybookActionProperties is now required

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1f449b5. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-securityinsight [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-securityinsight-1.0.0-beta.7.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]     }
info	[Changelog]   - Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
info	[Changelog]   - Type of parameter additionalData of interface EntityCommonProperties is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface EntityEdges is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum20
info	[Changelog]   - Type of parameter entityKind of interface ExpansionResultAggregation is changed from EntityKind to EntityKindEnum
info	[Changelog]   - Type of parameter additionalData of interface FileEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface FileHashEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface HostEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface HuntingBookmark is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
info	[Changelog]   - Type of parameter additionalData of interface IoTDeviceEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface IpEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface MailboxEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface MailClusterEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface MailMessageEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface MalwareEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter dependencies of interface MetadataModel is changed from MetadataDependencies to MetadataDependenciesAutoGenerated
info	[Changelog]   - Type of parameter kind of interface MetadataModel is changed from Kind to string
info	[Changelog]   - Type of parameter dependencies of interface MetadataPatch is changed from MetadataDependencies to MetadataDependenciesAutoGenerated
info	[Changelog]   - Type of parameter kind of interface MetadataPatch is changed from Kind to string
info	[Changelog]   - Type of parameter additionalData of interface NicEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface ProcessEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface RegistryKeyEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface RegistryValueEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface SecurityAlert is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface SecurityGroupEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface SubmissionMailEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter kind of interface ThreatIntelligenceInformation is changed from ThreatIntelligenceResourceKindEnum to ThreatIntelligenceResourceInnerKind
info	[Changelog]   - Type of parameter sortOrder of interface ThreatIntelligenceSortingCriteria is changed from ThreatIntelligenceSortingCriteriaEnum to ThreatIntelligenceSortingOrder
info	[Changelog]   - Type of parameter additionalData of interface UrlEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Removed Enum KnownEntityKind
info	[Changelog]   - Removed Enum KnownEnum13
info	[Changelog]   - Removed Enum KnownThreatIntelligenceResourceKindEnum
info	[Changelog]   - Removed Enum KnownThreatIntelligenceSortingCriteriaEnum

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 1f449b5. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-securityinsights [View full logs] [Release SDK Changes]

️❌ azure-resource-manager-schemas failed [Detail]

❌Failed [Logs]Release - Generate from 1f449b5. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

❌securityinsights/resource-manager [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 1f449b5. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.securityinsights.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.securityinsights.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-18T19:29:38Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-resourcemanager-securityinsights	https://apiview.dev/Assemblies/Review/e654f603fe674651bd7a86577fd1177d
.Net	Azure.ResourceManager.SecurityInsights	There is no API change compared with the previous version
JavaScript	@azure/arm-securityinsight	https://apiview.dev/Assemblies/Review/7e0b2dde30314d5eb02dca9254b8c785

openapi-workflow-bot · 2023-04-18T19:41:23Z

Hi @nazang, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

* BillingStatistics * Update BillingStatistics path in readme

openapi-workflow-bot · 2023-04-20T03:41:46Z

Hi, @nazang, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

* add gcp kind * fix prettier

nazang · 2023-04-27T23:48:21Z

@tadelesh, this is our teams 05-01-preview change.

Two new API's, both commits are already reviewed by ARM team. Link to the PR with approval
BillingStatistics 2023-05-01-preview #23631
add gcp kind #23691
Cross-version has been approved: https://msazure.visualstudio.com/One/_workitems/edit/17908651

Let me know if anything you need from us.

Thank you!

tadelesh · 2023-04-28T01:29:03Z

@tadelesh, this is our teams 05-01-preview change.

Two new API's, both commits are already reviewed by ARM team.

Cross-version has been approved: https://msazure.visualstudio.com/One/_workitems/edit/17908651

Let me know if anything you need from us.

Thank you!

Could you provide the PR reviewed by ARM?

nazang · 2023-04-28T16:11:48Z

@tadelesh, this is our teams 05-01-preview change.

Two new API's, both commits are already reviewed by ARM team.

Cross-version has been approved: https://msazure.visualstudio.com/One/_workitems/edit/17908651

Let me know if anything you need from us.
Thank you!

Could you provide the PR reviewed by ARM?

@tadelesh, these are the two PR's, can be found in the commit history. Luckily, they are both approved by you :)

#23631
#23691

tadelesh · 2023-05-04T03:03:10Z

@tadelesh, this is our teams 05-01-preview change.

Two new API's, both commits are already reviewed by ARM team.

Cross-version has been approved: https://msazure.visualstudio.com/One/_workitems/edit/17908651

Let me know if anything you need from us.
Thank you!

Could you provide the PR reviewed by ARM?

@tadelesh, these are the two PR's, can be found in the commit history. Luckily, they are both approved by you :)

#23631 #23691

Thanks for the info. It seems the second PR has not reviewed by ARM. I've added WaitForARMFeedback label to wait for ARM to sign off.

sjanamma · 2023-05-04T19:31:55Z

@nazang - PR has breaking changes that have not been approved yet.
There are a bunch of breaking changes reported on this PR. Please get a breaking changes approval from Azure Breaking Changes Reviewers azbreakchangereview@microsoft.com and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers.

openapi-workflow-bot · 2023-05-04T19:32:09Z

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

nazang · 2023-05-04T21:16:10Z

2. Cross-version has been approved: https://msazure.visualstudio.com/One/_workitems/edit/17908651

@nazang - PR has breaking changes that have not been approved yet. There are a bunch of breaking changes reported on this PR. Please get a breaking changes approval from Azure Breaking Changes Reviewers azbreakchangereview@microsoft.com and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers.

@sjanamma, this is the evidence of the approved change. Three breaking changes have been approved for this item and it is done in April. I already added as a reply to tadelesh Cross-version has been approved: https://msazure.visualstudio.com/One/_workitems/edit/17908651

nazang · 2023-05-05T19:48:53Z

@sjanamma, @tadelesh , Got the Approved-BreakingChanges tag. Please check if anything else is missing. Thanks!

nazang · 2023-05-05T19:54:00Z

/azp run

azure-pipelines · 2023-05-05T19:54:09Z

Azure Pipelines successfully started running 1 pipeline(s).

tadelesh · 2023-05-06T01:59:04Z

@qiaozha @MaryGao could you help to review the js breaking change? it seems there is some auto-naming issue.

nazang · 2023-05-10T17:27:04Z

@tadelesh, could you check if something still missing? Could you merge the PR please?

nazang added 3 commits April 18, 2023 12:26

Adds base for updating Microsoft.SecurityInsights from version previe…

14d1e2f

…w/2023-04-01-preview to version 2023-05-01-preview

Updates readme

3e107a5

Updates API version in new specs and examples

c070ac2

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version resource-manager labels Apr 18, 2023

nazang changed the title ~~[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2023-05-01-preview~~ Review request for Microsoft.SecurityInsights to add version preview/2023-05-01-preview Apr 19, 2023

BillingStatistics 2023-05-01-preview (#23631)

0318bfd

* BillingStatistics * Update BillingStatistics path in readme

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Apr 20, 2023

AzureRestAPISpecReview added the CI-MissingBaseCommit label Apr 20, 2023

add gcp kind (#23691)

92d40e1

* add gcp kind * fix prettier

nazang marked this pull request as ready for review April 27, 2023 23:42

openapi-assignment-bot bot assigned tadelesh Apr 27, 2023

tadelesh added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 4, 2023

sjanamma added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 4, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 4, 2023

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 5, 2023

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label May 5, 2023

tadelesh removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 6, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 6, 2023

sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 6, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 6, 2023

qiaozha added the Approved-SdkBreakingChange-JavaScript label May 11, 2023

tadelesh approved these changes May 11, 2023

View reviewed changes

tadelesh merged commit 1f449b5 into main May 11, 2023

tadelesh deleted the release-securityinsights-Microsoft.SecurityInsights-2023-05-01-preview branch May 11, 2023 02:56

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label May 11, 2023

azure-sdk mentioned this pull request May 11, 2023

[ReleasePR Azure.ResourceManager.SecurityInsights] Release release sentinel securityinsights microsoft.security insights 2023 10 01 preview Azure/azure-sdk-for-net#32154

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Review request for Microsoft.SecurityInsights to add version preview/2023-05-01-preview #23610

Review request for Microsoft.SecurityInsights to add version preview/2023-05-01-preview #23610

nazang commented Apr 18, 2023 •

edited by tadelesh

Loading

openapi-workflow-bot bot commented Apr 18, 2023

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading

openapi-workflow-bot bot commented Apr 18, 2023

openapi-workflow-bot bot commented Apr 20, 2023

nazang commented Apr 27, 2023 •

edited

Loading

tadelesh commented Apr 28, 2023

nazang commented Apr 28, 2023

tadelesh commented May 4, 2023

sjanamma commented May 4, 2023

openapi-workflow-bot bot commented May 4, 2023

nazang commented May 4, 2023

nazang commented May 5, 2023

nazang commented May 5, 2023

azure-pipelines bot commented May 5, 2023

tadelesh commented May 6, 2023

nazang commented May 10, 2023

Review request for Microsoft.SecurityInsights to add version preview/2023-05-01-preview #23610

Review request for Microsoft.SecurityInsights to add version preview/2023-05-01-preview #23610

Conversation

nazang commented Apr 18, 2023 • edited by tadelesh Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 18, 2023

openapi-pipeline-app bot commented Apr 18, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 18, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 18, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Apr 18, 2023

openapi-workflow-bot bot commented Apr 20, 2023

nazang commented Apr 27, 2023 • edited Loading

tadelesh commented Apr 28, 2023

nazang commented Apr 28, 2023

tadelesh commented May 4, 2023

sjanamma commented May 4, 2023

openapi-workflow-bot bot commented May 4, 2023

nazang commented May 4, 2023

nazang commented May 5, 2023

nazang commented May 5, 2023

azure-pipelines bot commented May 5, 2023

tadelesh commented May 6, 2023

nazang commented May 10, 2023

nazang commented Apr 18, 2023 •

edited by tadelesh

Loading

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading

nazang commented Apr 27, 2023 •

edited

Loading