Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specversion casing in examples #22268

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Conversation

JoshLove-msft
Copy link
Member

As per the CloudEvent spec, the correct casing is "specversion".

@openapi-pipeline-app
Copy link

Swagger pipeline can not start as the pull request has merge conflicts.

@openapi-workflow-bot
Copy link

Hi, @JoshLove-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @ghost ghost added the Event Grid label Jan 20, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 20, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️❌PrettierCheck: 85 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/keyvalue_deleted.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/keyvalue_modified.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/export_rdb_completed.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/import_rdb_completed.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/patching_completed.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/scaling_completed.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_message_deleted.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_message_deleted_in_thread.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_message_edited.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_message_edited_in_thread.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_message_received.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_message_received_in_thread.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_participant_added_to_thread_with_user.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_participant_removed_from_thread_with_user.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_thread_created.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_thread_created_withUser.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_thread_deleted.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_thread_participant_added.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_thread_participant_removed.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_thread_properties_updated.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_thread_properties_updated_per_user.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chat_thread_with_user_deleted.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/recording_file_status_updated.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/sms_delivery_report_received.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/sms_received.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/user_disconnected.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chart_deleted.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/chart_pushed.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/image_deleted.json
    HowToFix Code style issues found
    path: 2018-01-01/examples/cloud-events-schema/image_pushed.json
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 20, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1a1463a. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.Messaging.EventGrid [View full logs]  [Release SDK Changes]
      info	[Changelog]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 20, 2023

    Generated ApiView

    Language Package Name ApiView Link
    .Net Azure.Messaging.EventGrid There is no API change compared with the previous version

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants