Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTP data connector- filter alerts by provider #22245

Conversation

sivanguetta
Copy link
Contributor

@sivanguetta sivanguetta commented Jan 19, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @sivanguetta Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 19, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    dataConnectors.json 2023-02-01-preview(e375edf) 2022-12-01-preview(main)
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-02 package-preview-2023-02(e375edf) package-preview-2023-02(release-Sentinel-2023-02-01-preview)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2280
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2292
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2304
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2316
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2336
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2712
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2724
    ArrayMustHaveType 'items.type' property must be truthy
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2820
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DataConnectorsCheckRequirementsModel'. Consider using the plural form of 'DataConnectorsCheckRequirements' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L473
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'dataconnectorscheckrequirements' in:'DataConnectorsCheckRequirements_Post'. Consider updating the operationId
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L473
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2460
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2510
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2677
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2861
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2865
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2869
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2873
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.SecurityInsights/preview/2023-02-01-preview/dataConnectors.json#L2900
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌~[Staging] SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 19, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking


    ⚠️azure-sdk-for-js - @azure/arm-securityinsight - Approved - 1.0.0-beta.6
    +	Interface BookmarkRelationsListNextOptionalParams no longer has parameter filter
    +	Interface BookmarkRelationsListNextOptionalParams no longer has parameter orderby
    +	Interface BookmarkRelationsListNextOptionalParams no longer has parameter skipToken
    +	Interface BookmarkRelationsListNextOptionalParams no longer has parameter top
    +	Interface EntitiesRelationsListNextOptionalParams no longer has parameter filter
    +	Interface EntitiesRelationsListNextOptionalParams no longer has parameter orderby
    +	Interface EntitiesRelationsListNextOptionalParams no longer has parameter skipToken
    +	Interface EntitiesRelationsListNextOptionalParams no longer has parameter top
    +	Interface EntityQueriesListNextOptionalParams no longer has parameter kind
    +	Interface FileImportsListNextOptionalParams no longer has parameter filter
    +	Interface FileImportsListNextOptionalParams no longer has parameter orderby
    +	Interface FileImportsListNextOptionalParams no longer has parameter skipToken
    +	Interface FileImportsListNextOptionalParams no longer has parameter top
    +	Interface IncidentCommentsListNextOptionalParams no longer has parameter filter
    +	Interface IncidentCommentsListNextOptionalParams no longer has parameter orderby
    +	Interface IncidentCommentsListNextOptionalParams no longer has parameter skipToken
    +	Interface IncidentCommentsListNextOptionalParams no longer has parameter top
    +	Interface IncidentRelationsListNextOptionalParams no longer has parameter filter
    +	Interface IncidentRelationsListNextOptionalParams no longer has parameter orderby
    +	Interface IncidentRelationsListNextOptionalParams no longer has parameter skipToken
    +	Interface IncidentRelationsListNextOptionalParams no longer has parameter top
    +	Interface IncidentsListNextOptionalParams no longer has parameter filter
    +	Interface IncidentsListNextOptionalParams no longer has parameter orderby
    +	Interface IncidentsListNextOptionalParams no longer has parameter skipToken
    +	Interface IncidentsListNextOptionalParams no longer has parameter top
    +	Interface MetadataListNextOptionalParams no longer has parameter filter
    +	Interface MetadataListNextOptionalParams no longer has parameter orderby
    +	Interface MetadataListNextOptionalParams no longer has parameter skip
    +	Interface MetadataListNextOptionalParams no longer has parameter top
    +	Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter filter
    +	Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter orderby
    +	Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter skipToken
    +	Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter top
    +	Interface WatchlistItemsListNextOptionalParams no longer has parameter skipToken
    +	Interface WatchlistsListNextOptionalParams no longer has parameter skipToken
    +	Operation Incidents.createTeam has a new signature
    +	Type of parameter actionType of interface AutomationRuleAction is changed from "ModifyProperties" | "RunPlaybook" to "AddIncidentTask" | "ModifyProperties" | "RunPlaybook"
    +	Type of parameter additionalData of interface AccountEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface AzureResourceEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface CloudApplicationEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface DnsEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface EntityCommonProperties is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface EntityEdges is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface FileEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface FileHashEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface HostEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface HuntingBookmark is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface IoTDeviceEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface IpEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface MailClusterEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface MailMessageEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface MailboxEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface MalwareEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface NicEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface ProcessEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface RegistryKeyEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface RegistryValueEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface SecurityAlert is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface SecurityGroupEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface SubmissionMailEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter additionalData of interface UrlEntity is changed from {
            [propertyName: string]: Record;
        } to {
            [propertyName: string]: any;
        }
    +	Type of parameter kind of interface DataConnectorsCheckRequirements is changed from "AzureActiveDirectory" | "AzureAdvancedThreatProtection" | "AzureSecurityCenter" | "AmazonWebServicesCloudTrail" | "AmazonWebServicesS3" | "Dynamics365" | "MicrosoftCloudAppSecurity" | "MicrosoftDefenderAdvancedThreatProtection" | "MicrosoftThreatIntelligence" | "MicrosoftThreatProtection" | "OfficeATP" | "OfficeIRM" | "Office365Project" | "OfficePowerBI" | "ThreatIntelligence" | "ThreatIntelligenceTaxii" | "IOT" to "AzureActiveDirectory" | "AzureAdvancedThreatProtection" | "AzureSecurityCenter" | "AmazonWebServicesCloudTrail" | "AmazonWebServicesS3" | "Dynamics365" | "MicrosoftCloudAppSecurity" | "MicrosoftDefenderAdvancedThreatProtection" | "MicrosoftThreatIntelligence" | "MicrosoftThreatProtection" | "OfficeATP" | "OfficeIRM" | "MicrosoftPurviewInformationProtection" | "Office365Project" | "OfficePowerBI" | "ThreatIntelligence" | "ThreatIntelligenceTaxii" | "IOT"
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 73878381b8d61d0864ecb00c0d67739d6afc8ac7. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.SecurityInsights [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 73878381b8d61d0864ecb00c0d67739d6afc8ac7. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.3.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.3.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.3.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model MTPDataConnector has a new parameter filtered_providers
      info	[Changelog]   - Model MTPDataConnectorDataTypes has a new parameter alerts
      info	[Changelog]   - Model MTPDataConnectorProperties has a new parameter filtered_providers
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 73878381b8d61d0864ecb00c0d67739d6afc8ac7. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface CloudApplicationEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter kind of interface DataConnectorsCheckRequirements is changed from "AzureActiveDirectory" | "AzureAdvancedThreatProtection" | "AzureSecurityCenter" | "AmazonWebServicesCloudTrail" | "AmazonWebServicesS3" | "Dynamics365" | "MicrosoftCloudAppSecurity" | "MicrosoftDefenderAdvancedThreatProtection" | "MicrosoftThreatIntelligence" | "MicrosoftThreatProtection" | "OfficeATP" | "OfficeIRM" | "Office365Project" | "OfficePowerBI" | "ThreatIntelligence" | "ThreatIntelligenceTaxii" | "IOT" to "AzureActiveDirectory" | "AzureAdvancedThreatProtection" | "AzureSecurityCenter" | "AmazonWebServicesCloudTrail" | "AmazonWebServicesS3" | "Dynamics365" | "MicrosoftCloudAppSecurity" | "MicrosoftDefenderAdvancedThreatProtection" | "MicrosoftThreatIntelligence" | "MicrosoftThreatProtection" | "OfficeATP" | "OfficeIRM" | "MicrosoftPurviewInformationProtection" | "Office365Project" | "OfficePowerBI" | "ThreatIntelligence" | "ThreatIntelligenceTaxii" | "IOT"
      info	[Changelog]   - Type of parameter additionalData of interface DnsEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface EntityCommonProperties is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface EntityEdges is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface FileEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface FileHashEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface HostEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface HuntingBookmark is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface IoTDeviceEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface IpEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MailboxEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MailClusterEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MailMessageEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MalwareEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface NicEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface ProcessEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface RegistryKeyEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface RegistryValueEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface SecurityAlert is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface SecurityGroupEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface SubmissionMailEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface UrlEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 73878381b8d61d0864ecb00c0d67739d6afc8ac7. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-securityinsights [View full logs]  [Preview SDK Changes]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs] Generate from 73878381b8d61d0864ecb00c0d67739d6afc8ac7. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • securityinsights/resource-manager [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from 73878381b8d61d0864ecb00c0d67739d6afc8ac7. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.securityinsights [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 19, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Java azure-resourcemanager-securityinsights https://apiview.dev/Assemblies/Review/15e27a44d0cc418f9eb995a3d040d5fe
    .Net Azure.ResourceManager.SecurityInsights There is no API change compared with the previous version
    JavaScript @azure/arm-securityinsight https://apiview.dev/Assemblies/Review/20784583a8f64b0ea4f4b605938a4b7d

    @openapi-workflow-bot
    Copy link

    Hi @sivanguetta, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @sivanguetta
    Copy link
    Contributor Author

    Hi,
    Will these failures block the PR?
    I don't understand why it failed.

    @dw511214992 dw511214992 merged commit 77ecbab into Azure:release-Sentinel-2023-02-01-preview Jan 30, 2023
    dw511214992 pushed a commit that referenced this pull request Feb 6, 2023
    * Adds base for updating Microsoft.SecurityInsights from version preview/2022-12-01-preview to version 2023-02-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add microsoft purview information protection connector kind (#22150)
    
    * Add triggeredAnalyticsRuleRuns API (#21977)
    
    * Add triggeredAnalyticsRuleRuns API
    
    * fix examples path
    
    * run prettier
    
    * fix lint
    
    * fix prettier
    
    * Update readme.md
    
    * draft
    
    * draft
    
    * fixing comments
    
    * fixing nit and param name
    
    * adding requires
    
    * fixing idention
    
    * Update TriggeredAnalyticsRuleRuns.json
    
    adding location header
    
    * Update TriggeredAnalyticsRuleRuns.json
    
    closing headers
    
    * Update TriggeredAnalyticsRuleRuns.json
    
    fixing warnings
    
    * Update TriggeredAnalyticsRuleRuns.json
    
    fixing lint warnings pt 2
    
    * Update TriggeredAnalyticsRuleRuns.json
    
    fixing flatten position
    
    ---------
    
    Co-authored-by: Rotemdvir1 <rotemdvir@microsoft.com>
    Co-authored-by: Rotemdvir1 <95570648+Rotemdvir1@users.noreply.github.com>
    
    * MTP data connector- filter alerts by provider (#22245)
    
    * MTP data connector- filter alerts by provider
    
    * validations
    
    ---------
    
    Co-authored-by: Alexander Feldsher <66358192+alfeldsh@users.noreply.github.com>
    Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com>
    Co-authored-by: Rotemdvir1 <rotemdvir@microsoft.com>
    Co-authored-by: Rotemdvir1 <95570648+Rotemdvir1@users.noreply.github.com>
    Co-authored-by: sivanguetta <46525261+sivanguetta@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants