Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AzureAPIM} fixes Azure/azure-rest-api-specs#21849 'in body' parameter specification missing #21875

Merged
merged 2 commits into from
Jan 5, 2023

Commits on Dec 13, 2022

  1. {AzureAPIM} fixes #21849 'in body' parameter specification missing

    fixes #21849  'in body' parameter specification missing
    
    The CreateOrUpdate operations on both of the following resource types are missing the in body parameter in the OpenAPI specification (OAS):
    
    Microsoft.ApiManagement/service/contentTypes
    Microsoft.ApiManagement/service/contentTypes/contentItems
    This causes the documentation TryIt and autogenerated libraries (e.g. nodejs @azure/arm-apimanagement) to break, as they don't support passing in the properties in the body, making these resource types unable to be updated or created.
    
    For example, if you run the "Try It" for this API, it doesn't give you a body field in the auto-generated REST HTTP request form. The body field is needed, but it doesn't give you that field as it's not populated in the OAS for this resource type.
    
    See this: https://github.com/Azure/azure-rest-api-specs/blob/7245d0f5cc01bf95df9d7ae893f252d4001b4ad7/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2021-08-01/apimcontenttypes.json#L132-L162
    navba-MSFT committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    67828b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0d89fc View commit details
    Browse the repository at this point in the history