[Hub Generated] Review request for Microsoft.ResourceHealth to add version preview/2022-05-01 #21286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…020-05-01 to version 2022-05-01
… the private repo
|
Hi, @abhayohri Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.2)] | new version | base version |
|---|---|---|
| ResourceHealth.json | 2022-05-01-preview(1c63627) | 2020-05-01(main) |
| ResourceHealth.json | 2022-05-01-preview(1c63627) | 2020-05-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.ResourceHealth/preview/2022-05-01-preview/ResourceHealth.json#L967:5 Old: Microsoft.ResourceHealth/stable/2020-05-01/ResourceHealth.json#L259:5 |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 9 Errors, 6 Warnings failed [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-preview-2022-05-01 | package-preview-2022-05-01(1c63627) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
The following errors/warnings exist before current PR submission:
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Oct 27, 2022
|
/azp run unifiedPipeline |
|
Pull request contains merge conflicts. |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @abhayohri your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
Please Note that these changes were approved in https://github.com/Azure/azure-rest-api-specs-pr/pull/9037 |
… defaults were ga versions. thus will be updated when this goes to GA
This was referenced Nov 11, 2022
live1206
approved these changes
Nov 14, 2022
live1206
added
Approved-LintDiff
and removed
WaitForARMFeedback
This was referenced Nov 14, 2022
abhayohri
deleted the
dev-resourcehealth-Microsoft.ResourceHealth-2022-05-01
branch
This was referenced Dec 2, 2022
11 tasks
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
…rsion preview/2022-05-01 (Azure#21286) * Adds base for updating Microsoft.ResourceHealth from version stable/2020-05-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * made the changes for tenant level and impacted resources similarly to the private repo * changed api version to 2022-05-01-preview * changed api version to 2022-05-01-preview * updated readme to reflect new filename * updated example to use targetRegion instead of region in filter condition * changed the default version back to 2020 as i found that all previous defaults were ga versions. thus will be updated when this goes to GA
11 tasks
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 21, 2022
…rsion preview/2022-05-01 (Azure#21286) * Adds base for updating Microsoft.ResourceHealth from version stable/2020-05-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * made the changes for tenant level and impacted resources similarly to the private repo * changed api version to 2022-05-01-preview * changed api version to 2022-05-01-preview * updated readme to reflect new filename * updated example to use targetRegion instead of region in filter condition * changed the default version back to 2020 as i found that all previous defaults were ga versions. thus will be updated when this goes to GA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.