Added new receivers to action group document. #2077
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,10 @@ | |
| "200": { | ||
| "headers": {}, | ||
| "body": null | ||
| }, | ||
| "409": { | ||
| "headers": {}, | ||
| "body": null | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "187f412d-1758-44d9-b052-169e2564721d", | ||
| "resourceGroupName": "Default-NotificationRules", | ||
| "actionGroupName": "SampleActionGroup", | ||
| "api-version": "2017-04-01", | ||
| "actionGroupPatch": { | ||
| "tags": { "key1": "value1", "key2": "value2" }, | ||
| "properties": { | ||
| "enabled": false | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": { }, | ||
| "body": { | ||
| "id": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/Default-NotificationRules/providers/microsoft.insights/actionGroups/SampleActionGroup", | ||
| "type": "Microsoft.Insights/ActionGroups", | ||
| "name": "SampleActionGroup", | ||
| "location": "Global", | ||
| "tags": { "key1": "value1", "key2": "value2" }, | ||
| "properties": { | ||
| "groupShortName": "sample", | ||
| "enabled": true, | ||
| "emailReceivers": [ | ||
| { | ||
| "name": "John Doe's email", | ||
| "emailAddress": "johndoe@email.com", | ||
| "status": "Enabled" | ||
| }, | ||
| { | ||
| "name": "Jane Smith's email", | ||
| "emailAddress": "janesmith@email.com", | ||
| "status": "Enabled" | ||
| } | ||
| ], | ||
| "smsReceivers":[ | ||
| { | ||
| "name": "John Doe's mobile", | ||
| "countryCode": "1", | ||
| "phoneNumber": "1234567890", | ||
| "status": "Enabled" | ||
| }, | ||
| { | ||
| "name": "Jane Smith's mobile", | ||
| "countryCode": "1", | ||
| "phoneNumber": "0987654321", | ||
| "status": "Enabled" | ||
| } | ||
| ], | ||
| "webhookReceivers":[ | ||
| { | ||
| "name": "Sample webhook", | ||
| "serviceUri": "http://www.example.com/webhook" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because these are not required properties, I don't believe this is a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding new properties - required or optional is considered a breaking change. This could result in clients unitentionally overriding the properties on the server. Imagine a resource got created with this new property. Then the GET on the resource happened from a client which did not understand this property and so ignored it. Now if the PUT happens from the same client using the resource that was obtained via GET, the value of this property on the server will be overridden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it is advisable to increment the api-version for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already released for this API version and is almost like a baseline now. In future we are planning to support patch operation for individual receiver types. We will change the version then.