Add Api Management Basic Sku

[solankisamir]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[KedarJoshi]

#sign-off

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[fearthecowboy]

Have SDKs for this been published already?

The enum is marked with modelAsString : false which means that this will be a breaking change to the SDK generation (for C# at the very least), -- we should probably move to modelAsString : true to avoid this in the future,.

[solankisamir]

not yet.

[fearthecowboy]

oh, good. (dammit! the editor keeps submitting before i'm done typeing)

You probably should review the x-ms-enums for ones that can be extensible in the future, and use modelAsString: true on ones that may have things added to avoid future breaking changes.

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[solankisamir]

@fearthecowboy ping

[fearthecowboy]

@solankisamir Sorry; I restarted the validation and then forgot to come back.

The validator is complaining about a couple properties that aren't camel-cased.
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/311558732#L702

Can we clean those up while we're here?

(the breaking-change detection is complaining that there are changes without an API change, but you've assured me this hasn't had an SDK published yet)

[solankisamir]

@fearthecowboy
Issue with Value contract will be addressed in next version 2018-01-01
#1987

Issue with certificate_password will be addressed in next version 2018-01-01
#1881

We have active issues tracking that.

[AutorestCI]

No modification for AutorestCI/azure-sdk-for-python

[AutorestCI]

No modification for AutorestCI/azure-sdk-for-ruby