Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Managedapplication]Update readme.python.md #20127

Merged
merged 2 commits into from
Aug 5, 2022
Merged

[Managedapplication]Update readme.python.md #20127

merged 2 commits into from
Aug 5, 2022

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Aug 5, 2022 •
edited
Loading

Fix #19826

@openapi-workflow-bot
Copy link

Hi, @msyyc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 5, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️🔄CredScan inProgress [Detail]
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    compared tags (via openapi-validator v1.13.0) new version base version
    default default(90942d2) default(main)
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️🔄PoliCheck inProgress [Detail]
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️❌Lint(RPaaS): 3 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ R4023 - Rpaas_CreateOperationAsyncResponseValidation [RPaaS] An async PUT operation must set ''x-ms-long-running-operation' : true''.
    Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L368
    ❌ R4023 - Rpaas_CreateOperationAsyncResponseValidation [RPaaS] An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L368
    ❌ R4031 - Rpaas_ResourceProvisioningState [RPaaS] The resource ApplicationDefinition is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it.
    Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1614
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 5, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - armmanagedapplications - 2.0.0
    -	Field `Parameters` of struct `ApplicationsClientUpdateByIDOptions` has been removed
-	Field `Parameters` of struct `ApplicationsClientUpdateOptions` has been removed
-	Function `*ApplicationsClient.UpdateByID` parameter(s) have been changed from `(context.Context, string, *ApplicationsClientUpdateByIDOptions)` to `(context.Context, string, Application, *ApplicationsClientUpdateByIDOptions)`
-	Function `*ApplicationsClient.Update` parameter(s) have been changed from `(context.Context, string, string, *ApplicationsClientUpdateOptions)` to `(context.Context, string, string, ApplicationPatchable, *ApplicationsClientUpdateOptions)`
+	Field `Application` of struct `ApplicationsClientUpdateResponse` has been removed
+	Field `ProvisioningState` of struct `ApplicationDefinitionProperties` has been removed
+	Function `*ApplicationDefinitionsClient.BeginCreateOrUpdate` has been removed
+	Function `*ApplicationDefinitionsClient.BeginDelete` has been removed
+	Function `*ApplicationsClient.Update` has been removed
+	Struct `ApplicationDefinitionsClientBeginCreateOrUpdateOptions` has been removed
+	Struct `ApplicationDefinitionsClientBeginDeleteOptions` has been removed
+	Struct `ApplicationPropertiesPatchable` has been removed
+	Struct `ApplicationsClientUpdateOptions` has been removed
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-managedapplication - first release
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2feaf7f. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-managedapplication [View full logs]  [Release SDK Changes] 
      info	[Changelog]   - Initial Release
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2feaf7f. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armmanagedapplications [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*ApplicationDefinitionsClient.BeginDelete` has been removed
info	[Changelog] - Function `*ApplicationsClient.Update` has been removed
info	[Changelog] - Function `*ApplicationDefinitionsClient.BeginCreateOrUpdate` has been removed
info	[Changelog] - Struct `ApplicationDefinitionsClientBeginCreateOrUpdateOptions` has been removed
info	[Changelog] - Struct `ApplicationDefinitionsClientBeginDeleteOptions` has been removed
info	[Changelog] - Struct `ApplicationPropertiesPatchable` has been removed
info	[Changelog] - Struct `ApplicationsClientUpdateOptions` has been removed
info	[Changelog] - Field `Application` of struct `ApplicationsClientUpdateResponse` has been removed
info	[Changelog] - Field `ProvisioningState` of struct `ApplicationDefinitionProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `SubstatusApproved`
info	[Changelog] - New const `StatusNotSpecified`
info	[Changelog] - New const `SubstatusTimeout`
info	[Changelog] - New const `SubstatusFailed`
info	[Changelog] - New const `SubstatusNotSpecified`
info	[Changelog] - New const `StatusElevate`
info	[Changelog] - New const `SubstatusExpired`
info	[Changelog] - New const `SubstatusDenied`
info	[Changelog] - New const `StatusRemove`
info	[Changelog] - New function `*ApplicationsClient.ListTokens(context.Context, string, string, ListTokenRequest, *ApplicationsClientListTokensOptions) (ApplicationsClientListTokensResponse, error)`
info	[Changelog] - New function `*ApplicationsClient.BeginCreateOrUpdateByID(context.Context, string, Application, *ApplicationsClientBeginCreateOrUpdateByIDOptions) (*runtime.Poller[ApplicationsClientCreateOrUpdateByIDResponse], error)`
info	[Changelog] - New function `*ApplicationDefinitionsClient.GetByID(context.Context, string, string, *ApplicationDefinitionsClientGetByIDOptions) (ApplicationDefinitionsClientGetByIDResponse, error)`
info	[Changelog] - New function `*ApplicationsClient.BeginUpdateByID(context.Context, string, ApplicationPatchable, *ApplicationsClientBeginUpdateByIDOptions) (*runtime.Poller[ApplicationsClientUpdateByIDResponse], error)`
info	[Changelog] - New function `PossibleStatusValues() []Status`
info	[Changelog] - New function `*ApplicationsClient.GetByID(context.Context, string, *ApplicationsClientGetByIDOptions) (ApplicationsClientGetByIDResponse, error)`
info	[Changelog] - New function `*ApplicationsClient.BeginUpdate(context.Context, string, string, ApplicationPatchable, *ApplicationsClientBeginUpdateOptions) (*runtime.Poller[ApplicationsClientUpdateResponse], error)`
info	[Changelog] - New function `*ApplicationDefinitionsClient.CreateOrUpdateByID(context.Context, string, string, ApplicationDefinition, *ApplicationDefinitionsClientCreateOrUpdateByIDOptions) (ApplicationDefinitionsClientCreateOrUpdateByIDResponse, error)`
info	[Changelog] - New function `*ApplicationDefinitionsClient.UpdateByID(context.Context, string, string, ApplicationDefinitionPatchable, *ApplicationDefinitionsClientUpdateByIDOptions) (ApplicationDefinitionsClientUpdateByIDResponse, error)`
info	[Changelog] - New function `*ApplicationDefinitionsClient.CreateOrUpdate(context.Context, string, string, ApplicationDefinition, *ApplicationDefinitionsClientCreateOrUpdateOptions) (ApplicationDefinitionsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `PossibleSubstatusValues() []Substatus`
info	[Changelog] - New function `*ApplicationsClient.BeginUpdateAccess(context.Context, string, string, UpdateAccessDefinition, *ApplicationsClientBeginUpdateAccessOptions) (*runtime.Poller[ApplicationsClientUpdateAccessResponse], error)`
info	[Changelog] - New function `*ApplicationsClient.BeginDeleteByID(context.Context, string, *ApplicationsClientBeginDeleteByIDOptions) (*runtime.Poller[ApplicationsClientDeleteByIDResponse], error)`
info	[Changelog] - New function `*ApplicationDefinitionsClient.DeleteByID(context.Context, string, string, *ApplicationDefinitionsClientDeleteByIDOptions) (ApplicationDefinitionsClientDeleteByIDResponse, error)`
info	[Changelog] - New function `*ApplicationDefinitionsClient.Delete(context.Context, string, string, *ApplicationDefinitionsClientDeleteOptions) (ApplicationDefinitionsClientDeleteResponse, error)`
info	[Changelog] - New struct `AllowedUpgradePlansResult`
info	[Changelog] - New struct `ApplicationDefinitionsClientCreateOrUpdateByIDOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientCreateOrUpdateByIDResponse`
info	[Changelog] - New struct `ApplicationDefinitionsClientCreateOrUpdateOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientDeleteByIDOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientDeleteByIDResponse`
info	[Changelog] - New struct `ApplicationDefinitionsClientDeleteOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientGetByIDOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientGetByIDResponse`
info	[Changelog] - New struct `ApplicationDefinitionsClientUpdateByIDOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientUpdateByIDResponse`
info	[Changelog] - New struct `ApplicationsClientBeginCreateOrUpdateByIDOptions`
info	[Changelog] - New struct `ApplicationsClientBeginDeleteByIDOptions`
info	[Changelog] - New struct `ApplicationsClientBeginUpdateAccessOptions`
info	[Changelog] - New struct `ApplicationsClientBeginUpdateByIDOptions`
info	[Changelog] - New struct `ApplicationsClientBeginUpdateOptions`
info	[Changelog] - New struct `ApplicationsClientCreateOrUpdateByIDResponse`
info	[Changelog] - New struct `ApplicationsClientDeleteByIDResponse`
info	[Changelog] - New struct `ApplicationsClientGetByIDOptions`
info	[Changelog] - New struct `ApplicationsClientGetByIDResponse`
info	[Changelog] - New struct `ApplicationsClientListTokensOptions`
info	[Changelog] - New struct `ApplicationsClientListTokensResponse`
info	[Changelog] - New struct `ApplicationsClientUpdateAccessResponse`
info	[Changelog] - New struct `ApplicationsClientUpdateByIDResponse`
info	[Changelog] - New struct `JitRequestMetadata`
info	[Changelog] - New struct `ListTokenRequest`
info	[Changelog] - New struct `ManagedIdentityToken`
info	[Changelog] - New struct `ManagedIdentityTokenResult`
info	[Changelog] - New struct `UpdateAccessDefinition`
info	[Changelog] - New anonymous field `AllowedUpgradePlansResult` in struct `ApplicationsClientListAllowedUpgradePlansResponse`
info	[Changelog] - New anonymous field `ApplicationPatchable` in struct `ApplicationsClientUpdateResponse`
info	[Changelog]
info	[Changelog] Total 13 breaking change(s), 84 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2feaf7f. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from 2feaf7f. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.solutions [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 5, 2022 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-managedapplication Create ApiView timeout. Package is too large and we cannot create ApiView for it.
    Java azure-resourcemanager-solutions https://apiview.dev/Assemblies/Review/47c642ca47a747ffabcfa3d9a045e78c

    @msyyc msyyc marked this pull request as ready for review August 5, 2022 08:49
    @msyyc msyyc requested a review from BigCat20196 as a code owner August 5, 2022 08:49
    @msyyc msyyc assigned msyyc and unassigned changlong-liu Aug 5, 2022
    @openapi-workflow-bot
    Copy link

    Hi @msyyc, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @azure-sdk azure-sdk mentioned this pull request Aug 5, 2022
    Closed
    This was referenced Aug 5, 2022
    Closed
    Closed
    @msyyc msyyc changed the title Update readme.python.md [Managedapplication]Update readme.python.md Aug 5, 2022
    @azure-sdk azure-sdk mentioned this pull request Aug 5, 2022
    Closed
    @msyyc msyyc merged commit 2feaf7f into main Aug 5, 2022
    @msyyc msyyc deleted the managedapplication-fix-python-config branch August 5, 2022 09:10
    This was referenced Aug 5, 2022
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @BigCat20196 BigCat20196 BigCat20196 approved these changes

    Assignees

    @msyyc msyyc

    Labels
    CI-BreakingChange-Go CI-FixRequiredOnFailure resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @msyyc @BigCat20196 @changlong-liu