Flexible MySQL: add APIs for AAD administrator #19949

Suna-MS · 2022-07-26T08:52:49Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-07-26T08:52:51Z

Hi, @Suna-MS Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-07-26T08:52:53Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.9.6)]	new version	base version
2021-12-01-preview	2021-12-01-preview(d74b141)	2021-12-01-preview(main)

Rule	Message
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforMySQL/preview/2021-12-01-preview/AzureADAdministrator.json#L37:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforMySQL/preview/2021-12-01-preview/AzureADAdministrator.json#L194:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 1 Warnings warning [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-flexibleserver-2021-12-01-preview	package-flexibleserver-2021-12-01-preview(d74b141)	package-flexibleserver-2021-12-01-preview(main)

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'administrators' with immediate parent 'Server', must have a list by immediate parent operation. Location: Microsoft.DBforMySQL/preview/2021-12-01-preview/AzureADAdministrator.json#L274

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/mysql/resource-manager/readme.md tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]

The following tags are being changed in this PR

"https://github.com/Azure/azure-rest-api-specs/blob/d74b1415c853a5973b8a2cf5b639e1b9eca4dc39/specification/mysql/resource-manager/readme.md#tag-package-flexibleserver-2021-12-01-preview">mysql/resource-manager/readme.md#package-flexibleserver-2021-12-01-preview

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ UnkownSecurityScheme	"readme":"mysql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-12-01-preview", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-07-26T08:52:54Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go - armmysql - 1.0.1
️✔️azure-sdk-for-go - armmysqlflexibleservers - 1.1.0-beta.1
❌azure-sdk-for-python-track2 - track2_azure-mgmt-rdbms - 10.2.0b1

-	Model Server no longer has parameter tags_properties_tags
-	Removed operation BackupsOperations.put

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 705bc5c. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 705bc5c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.15.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.15.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.15.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-rdbms [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group AzureADAdministratorsOperations
info	[Changelog]   - Added operation group CheckNameAvailabilityWithoutLocationOperations

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 705bc5c. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-mysqlflexibleserver [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 705bc5c. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armmysql [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️armmysqlflexibleservers [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `ResetAllToDefaultTrue`
info	[Changelog] - New const `AdministratorTypeActiveDirectory`
info	[Changelog] - New const `AdministratorNameActiveDirectory`
info	[Changelog] - New const `ResetAllToDefaultFalse`
info	[Changelog] - New function `*AzureADAdministratorsClient.BeginCreateOrUpdate(context.Context, string, string, AdministratorName, AzureADAdministrator, *AzureADAdministratorsClientBeginCreateOrUpdateOptions) (*runtime.Poller[AzureADAdministratorsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `NewLogFilesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*LogFilesClient, error)`
info	[Changelog] - New function `NewAzureADAdministratorsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AzureADAdministratorsClient, error)`
info	[Changelog] - New function `*LogFilesClient.NewListByServerPager(string, string, *LogFilesClientListByServerOptions) *runtime.Pager[LogFilesClientListByServerResponse]`
info	[Changelog] - New function `PossibleAdministratorNameValues() []AdministratorName`
info	[Changelog] - New function `*BackupsClient.Put(context.Context, string, string, string, *BackupsClientPutOptions) (BackupsClientPutResponse, error)`
info	[Changelog] - New function `PossibleAdministratorTypeValues() []AdministratorType`
info	[Changelog] - New function `NewCheckNameAvailabilityWithoutLocationClient(string, azcore.TokenCredential, *arm.ClientOptions) (*CheckNameAvailabilityWithoutLocationClient, error)`
info	[Changelog] - New function `*AzureADAdministratorsClient.NewListByServerPager(string, string, *AzureADAdministratorsClientListByServerOptions) *runtime.Pager[AzureADAdministratorsClientListByServerResponse]`
info	[Changelog] - New function `PossibleResetAllToDefaultValues() []ResetAllToDefault`
info	[Changelog] - New function `*CheckNameAvailabilityWithoutLocationClient.Execute(context.Context, NameAvailabilityRequest, *CheckNameAvailabilityWithoutLocationClientExecuteOptions) (CheckNameAvailabilityWithoutLocationClientExecuteResponse, error)`
info	[Changelog] - New function `*AzureADAdministratorsClient.Get(context.Context, string, string, AdministratorName, *AzureADAdministratorsClientGetOptions) (AzureADAdministratorsClientGetResponse, error)`
info	[Changelog] - New function `*AzureADAdministratorsClient.BeginDelete(context.Context, string, string, AdministratorName, *AzureADAdministratorsClientBeginDeleteOptions) (*runtime.Poller[AzureADAdministratorsClientDeleteResponse], error)`
info	[Changelog] - New struct `AdministratorListResult`
info	[Changelog] - New struct `AdministratorProperties`
info	[Changelog] - New struct `AzureADAdministrator`
info	[Changelog] - New struct `AzureADAdministratorsClient`
info	[Changelog] - New struct `AzureADAdministratorsClientBeginCreateOrUpdateOptions`
info	[Changelog] - New struct `AzureADAdministratorsClientBeginDeleteOptions`
info	[Changelog] - New struct `AzureADAdministratorsClientCreateOrUpdateResponse`
info	[Changelog] - New struct `AzureADAdministratorsClientDeleteResponse`
info	[Changelog] - New struct `AzureADAdministratorsClientGetOptions`
info	[Changelog] - New struct `AzureADAdministratorsClientGetResponse`
info	[Changelog] - New struct `AzureADAdministratorsClientListByServerOptions`
info	[Changelog] - New struct `AzureADAdministratorsClientListByServerResponse`
info	[Changelog] - New struct `BackupsClientPutOptions`
info	[Changelog] - New struct `BackupsClientPutResponse`
info	[Changelog] - New struct `CheckNameAvailabilityWithoutLocationClient`
info	[Changelog] - New struct `CheckNameAvailabilityWithoutLocationClientExecuteOptions`
info	[Changelog] - New struct `CheckNameAvailabilityWithoutLocationClientExecuteResponse`
info	[Changelog] - New struct `LogFile`
info	[Changelog] - New struct `LogFileListResult`
info	[Changelog] - New struct `LogFileProperties`
info	[Changelog] - New struct `LogFilesClient`
info	[Changelog] - New struct `LogFilesClientListByServerOptions`
info	[Changelog] - New struct `LogFilesClientListByServerResponse`
info	[Changelog] - New field `Version` in struct `ServerPropertiesForUpdate`
info	[Changelog] - New field `ResetAllToDefault` in struct `ConfigurationListForBatchUpdate`
info	[Changelog] - New field `PageSize` in struct `ConfigurationsClientListByServerOptions`
info	[Changelog] - New field `Tags` in struct `ConfigurationsClientListByServerOptions`
info	[Changelog] - New field `Keyword` in struct `ConfigurationsClientListByServerOptions`
info	[Changelog] - New field `Page` in struct `ConfigurationsClientListByServerOptions`
info	[Changelog] - New field `Location` in struct `VirtualNetworkSubnetUsageResult`
info	[Changelog] - New field `SubscriptionID` in struct `VirtualNetworkSubnetUsageResult`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 67 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 705bc5c. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 705bc5c. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️mysql [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 705bc5c. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.mysql [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-07-26T08:54:11Z

Hi, @Suna-MS your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

openapi-workflow-bot · 2022-07-26T08:55:58Z

Hi @Suna-MS, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2022-07-26T08:55:59Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

zizw123 · 2022-07-26T20:26:08Z

Please look at the errors and remove the "ARMChangesRequested" tag once it's ready for ARM review.

openapi-workflow-bot · 2022-07-26T20:26:17Z

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

Suna-MS · 2022-07-27T03:39:22Z

SDK azure-powersehll: an old issue, not caused by this change
SDK azure-sdk-for-net: Permission denied, an old issue
BreakingChange: And new APIs to a recent preview version, should not be a breaking change, already ask breaking reviewers help to review.
Swagger LintDiff: PathResourceProviderNamePascalCase, already suppressed this error in readme.md, why still has such error? The resource provider must be "Microsoft.DBforMySQL", same as that in other files.

@zizw123 Please help remove the "ARMChangesRequested" tag (I have no permission). It's ready for ARM review

openapi-workflow-bot · 2022-07-27T03:49:15Z

Hi @Suna-MS, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

zizw123 · 2022-07-28T18:41:31Z

...l/resource-manager/Microsoft.DBforMySQL/preview/2021-12-01-preview/AzureADAdministrator.json

+          },
+          "202": {
+            "description": "Accepted"
+          },


202 is an old model for async PUT, please see https://github.com/Azure/azure-resource-manager-rpc/blob/a7dd5c0021d0a84bcad6d4736e3fcc3b319b20af/v1.0/async-api-reference.md#creatingupdating-using-put

Thanks @zizw123 for this information. But to change the old async PUT model to new, we need a very big change to refactor the controller of our Resource Provide, because all our APIs are using the same pattern now. Since this is a part of existing api-version, we have to use the existing model.
And we will evaluate the effort in the team and put the new model change to our backlog items.

zizw123 · 2022-07-28T18:42:16Z

...l/resource-manager/Microsoft.DBforMySQL/preview/2021-12-01-preview/AzureADAdministrator.json

+        "description": "Creates or updates an existing Azure Active Directory administrator.",
+        "parameters": [
+          {
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ApiVersionParameter"


v1

Consider use v3 when possible

Since all this api-version "2021-12-01-preview" are using the same v1 version, I'd like to keep them consistence this time. Will try to change all of them to V3 in our next api-version or the stable version.

raosuhas

Create to sync Azure/azure-rest-api-specs#19949 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/mysql?expand=1)

Flexible MySQL server: add APIs for AAD administrator

378b70c

openapi-assignment-bot bot assigned akning-ms Jul 26, 2022

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 26, 2022

openapi-pipeline-app bot added CI-FixRequiredOnFailure NewApiVersionRequired labels Jul 26, 2022

Suna-MS added 2 commits July 26, 2022 18:29

Fix LintDiff error

245b53e

Fix LintDiff check

d74b141

zizw123 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 26, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 26, 2022

akning-ms added the BreakingChangeReviewRequired label Jul 27, 2022

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 27, 2022

akning-ms removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 28, 2022

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 28, 2022

zizw123 reviewed Jul 28, 2022

View reviewed changes

zizw123 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 28, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 28, 2022

akning-ms removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 29, 2022

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 29, 2022

raosuhas approved these changes Aug 1, 2022

View reviewed changes

raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 1, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 1, 2022

akning-ms merged commit 705bc5c into Azure:main Aug 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flexible MySQL: add APIs for AAD administrator #19949

Flexible MySQL: add APIs for AAD administrator #19949

Suna-MS commented Jul 26, 2022 •

edited

Loading

openapi-workflow-bot bot commented Jul 26, 2022

openapi-pipeline-app bot commented Jul 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 26, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jul 26, 2022

openapi-workflow-bot bot commented Jul 26, 2022

openapi-workflow-bot bot commented Jul 26, 2022

zizw123 commented Jul 26, 2022

openapi-workflow-bot bot commented Jul 26, 2022

Suna-MS commented Jul 27, 2022

openapi-workflow-bot bot commented Jul 27, 2022

zizw123 Jul 28, 2022

Suna-MS Jul 29, 2022

zizw123 Jul 28, 2022

Suna-MS Jul 29, 2022

raosuhas left a comment

Flexible MySQL: add APIs for AAD administrator #19949

Flexible MySQL: add APIs for AAD administrator #19949

Conversation

Suna-MS commented Jul 26, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jul 26, 2022

openapi-pipeline-app bot commented Jul 26, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jul 26, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jul 26, 2022

openapi-workflow-bot bot commented Jul 26, 2022

openapi-workflow-bot bot commented Jul 26, 2022

zizw123 commented Jul 26, 2022

openapi-workflow-bot bot commented Jul 26, 2022

Suna-MS commented Jul 27, 2022

openapi-workflow-bot bot commented Jul 27, 2022

zizw123 Jul 28, 2022

Choose a reason for hiding this comment

Suna-MS Jul 29, 2022

Choose a reason for hiding this comment

zizw123 Jul 28, 2022

Choose a reason for hiding this comment

Suna-MS Jul 29, 2022

Choose a reason for hiding this comment

raosuhas left a comment

Choose a reason for hiding this comment

Suna-MS commented Jul 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 26, 2022 •

edited

Loading