Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview #19767

Merged
merged 4 commits into from
Jul 25, 2022
Merged

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview #19767

merged 4 commits into from
Jul 25, 2022

Conversation

neeerajaakula
Copy link
Contributor

@neeerajaakula neeerajaakula commented Jul 13, 2022 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @neeerajaakula Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 13, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    compared swaggers (via Oad v0.9.6)] new version base version
    managedHsm.json 2021-04-01(59771d3) 2021-04-01(main)
    managedHsm.json 2021-06-01(59771d3) 2021-06-01(main)
    managedHsm.json 2021-11-01(59771d3) 2021-11-01(main)
    managedHsm.json 2021-10-01(59771d3) 2021-10-01(main)
    managedHsm.json 2022-07-01(59771d3) 2022-07-01(main)
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-07 package-2022-07(59771d3) package-2022-07(main)
    package-preview-2021-11 package-preview-2021-11(59771d3) package-preview-2021-11(main)
    package-2021-10 package-2021-10(59771d3) package-2021-10(main)
    package-preview-2021-06 package-preview-2021-06(59771d3) package-preview-2021-06(main)
    package-preview-2021-04-full package-preview-2021-04-full(59771d3) package-preview-2021-04-full(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsmSku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L788
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsmProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L821
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsm' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L969
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsmResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L983
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsmListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1026
    ❌ R4037 - MissingTypeObject The schema 'MHSMPrivateEndpointConnectionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1042
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsmError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1058
    ❌ R4037 - MissingTypeObject The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1068
    ❌ R4037 - MissingTypeObject The schema 'DeletedManagedHsm' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1089
    ❌ R4037 - MissingTypeObject The schema 'DeletedManagedHsmProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1112
    ❌ R4037 - MissingTypeObject The schema 'DeletedManagedHsmListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1152
    ❌ R4037 - MissingTypeObject The schema 'MHSMNetworkRuleSet' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1168
    ❌ R4037 - MissingTypeObject The schema 'MHSMIPRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1211
    ❌ R4037 - MissingTypeObject The schema 'MHSMVirtualNetworkRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1223
    ❌ R4037 - MissingTypeObject The schema 'MHSMPrivateEndpointConnectionItem' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1235
    ❌ R4037 - MissingTypeObject The schema 'MHSMPrivateEndpointConnection' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1253
    ❌ R4037 - MissingTypeObject The schema 'MHSMPrivateEndpointConnectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1273
    ❌ R4037 - MissingTypeObject The schema 'MHSMPrivateEndpoint' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1290
    ❌ R4037 - MissingTypeObject The schema 'MHSMPrivateLinkServiceConnectionState' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1300
    ❌ R4037 - MissingTypeObject The schema 'MHSMPrivateLinkResourceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1355
    ❌ R4037 - MissingTypeObject The schema 'MHSMPrivateLinkResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1367
    ❌ R4037 - MissingTypeObject The schema 'MHSMPrivateLinkResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L1382
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsmSku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json#L788
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsmProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json#L821
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsm' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json#L969
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsmResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json#L983
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsmListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json#L1026
    ❌ R4037 - MissingTypeObject The schema 'MHSMPrivateEndpointConnectionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json#L1042
    ❌ R4037 - MissingTypeObject The schema 'ManagedHsmError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json#L1058
    ❌ R4037 - MissingTypeObject The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json#L1068
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/59771d3124ba508e680667ac179274ebe89adcd0/specification/keyvault/resource-manager/readme.md#tag-package-2022-07">keyvault/resource-manager/readme.md#package-2022-07
      • "https://github.com/Azure/azure-rest-api-specs/blob/59771d3124ba508e680667ac179274ebe89adcd0/specification/keyvault/resource-manager/readme.md#tag-package-preview-2021-11">keyvault/resource-manager/readme.md#package-preview-2021-11
      • "https://github.com/Azure/azure-rest-api-specs/blob/59771d3124ba508e680667ac179274ebe89adcd0/specification/keyvault/resource-manager/readme.md#tag-package-2021-10">keyvault/resource-manager/readme.md#package-2021-10
      • "https://github.com/Azure/azure-rest-api-specs/blob/59771d3124ba508e680667ac179274ebe89adcd0/specification/keyvault/resource-manager/readme.md#tag-package-preview-2021-06">keyvault/resource-manager/readme.md#package-preview-2021-06
      • "https://github.com/Azure/azure-rest-api-specs/blob/59771d3124ba508e680667ac179274ebe89adcd0/specification/keyvault/resource-manager/readme.md#tag-package-preview-2021-04">keyvault/resource-manager/readme.md#package-preview-2021-04
      • "https://github.com/Azure/azure-rest-api-specs/blob/59771d3124ba508e680667ac179274ebe89adcd0/specification/keyvault/resource-manager/readme.md#tag-package-preview-2021-04-full">keyvault/resource-manager/readme.md#package-preview-2021-04-full
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"keyvault/resource-manager/readme.md",
    "tag":"package-2022-07",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"keyvault/resource-manager/readme.md",
    "tag":"package-preview-2021-11",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"keyvault/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"keyvault/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"keyvault/resource-manager/readme.md",
    "tag":"package-preview-2021-04",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"keyvault/resource-manager/readme.md",
    "tag":"package-preview-2021-04-full",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 13, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - armkeyvault - 1.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-keyvault - 10.0.0
    ❌azure-sdk-for-js - @azure/arm-keyvault - Approved - 3.0.0
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]  
  
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 5bca310. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  global `--global`, `--local` are deprecated. Use `--location=global` instead.
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.15.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.15.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.15.0` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-keyvault        [View full logs]         [Release SDK Changes]      
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model MHSMPrivateEndpointConnectionItem has a new parameter etag
info	[Changelog]   - Model MHSMPrivateEndpointConnectionItem has a new parameter id
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]  
  
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 5bca310. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armkeyvault        [View full logs]         [Release SDK Changes]      
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `KeyPermissionsSetrotationpolicy`
info	[Changelog] - New const `KeyPermissionsRelease`
info	[Changelog] - New const `ActivationStatusActive`
info	[Changelog] - New const `KeyPermissionsRotate`
info	[Changelog] - New const `ActivationStatusNotActivated`
info	[Changelog] - New const `KeyPermissionsGetrotationpolicy`
info	[Changelog] - New const `ActivationStatusUnknown`
info	[Changelog] - New const `ActivationStatusFailed`
info	[Changelog] - New const `KeyRotationPolicyActionTypeNotify`
info	[Changelog] - New const `KeyRotationPolicyActionTypeRotate`
info	[Changelog] - New const `JSONWebKeyOperationRelease`
info	[Changelog] - New function `PossibleActivationStatusValues() []ActivationStatus`
info	[Changelog] - New function `*ManagedHsmsClient.CheckMhsmNameAvailability(context.Context, CheckMhsmNameAvailabilityParameters, *ManagedHsmsClientCheckMhsmNameAvailabilityOptions) (ManagedHsmsClientCheckMhsmNameAvailabilityResponse, error)`
info	[Changelog] - New function `PossibleKeyRotationPolicyActionTypeValues() []KeyRotationPolicyActionType`
info	[Changelog] - New struct `Action`
info	[Changelog] - New struct `CheckMhsmNameAvailabilityParameters`
info	[Changelog] - New struct `CheckMhsmNameAvailabilityResult`
info	[Changelog] - New struct `KeyReleasePolicy`
info	[Changelog] - New struct `KeyRotationPolicyAttributes`
info	[Changelog] - New struct `LifetimeAction`
info	[Changelog] - New struct `ManagedHSMSecurityDomainProperties`
info	[Changelog] - New struct `ManagedHsmsClientCheckMhsmNameAvailabilityOptions`
info	[Changelog] - New struct `ManagedHsmsClientCheckMhsmNameAvailabilityResponse`
info	[Changelog] - New struct `RotationPolicy`
info	[Changelog] - New struct `Trigger`
info	[Changelog] - New field `ID` in struct `MHSMPrivateEndpointConnectionItem`
info	[Changelog] - New field `Etag` in struct `MHSMPrivateEndpointConnectionItem`
info	[Changelog] - New field `RotationPolicy` in struct `KeyProperties`
info	[Changelog] - New field `ReleasePolicy` in struct `KeyProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 38 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 5bca310. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-keyvault        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation ManagedHsms.checkMhsmNameAvailability
info	[Changelog]   - Added Interface Action
info	[Changelog]   - Added Interface CheckMhsmNameAvailabilityParameters
info	[Changelog]   - Added Interface CheckMhsmNameAvailabilityResult
info	[Changelog]   - Added Interface KeyReleasePolicy
info	[Changelog]   - Added Interface KeyRotationPolicyAttributes
info	[Changelog]   - Added Interface LifetimeAction
info	[Changelog]   - Added Interface ManagedHsmsCheckMhsmNameAvailabilityOptionalParams
info	[Changelog]   - Added Interface ManagedHsmsCreateOrUpdateHeaders
info	[Changelog]   - Added Interface ManagedHsmsDeleteHeaders
info	[Changelog]   - Added Interface ManagedHSMSecurityDomainProperties
info	[Changelog]   - Added Interface ManagedHsmsPurgeDeletedHeaders
info	[Changelog]   - Added Interface ManagedHsmsUpdateHeaders
info	[Changelog]   - Added Interface RotationPolicy
info	[Changelog]   - Added Interface Trigger
info	[Changelog]   - Added Type Alias ActivationStatus
info	[Changelog]   - Added Type Alias KeyRotationPolicyActionType
info	[Changelog]   - Added Type Alias ManagedHsmsCheckMhsmNameAvailabilityResponse
info	[Changelog]   - Added Type Alias ManagedHsmsPurgeDeletedResponse
info	[Changelog]   - Interface KeyProperties has a new optional parameter releasePolicy
info	[Changelog]   - Interface KeyProperties has a new optional parameter rotationPolicy
info	[Changelog]   - Interface MhsmPrivateEndpointConnectionItem has a new optional parameter etag
info	[Changelog]   - Interface MhsmPrivateEndpointConnectionItem has a new optional parameter id
info	[Changelog]   - Type Alias Key has a new parameter rotationPolicy
info	[Changelog]   - Type Alias Key has a new parameter releasePolicy
info	[Changelog]   - Added Enum KnownActivationStatus
info	[Changelog]   - Enum KnownJsonWebKeyOperation has a new value Release
info	[Changelog]   - Enum KnownKeyPermissions has a new value Getrotationpolicy
info	[Changelog]   - Enum KnownKeyPermissions has a new value Release
info	[Changelog]   - Enum KnownKeyPermissions has a new value Rotate
info	[Changelog]   - Enum KnownKeyPermissions has a new value Setrotationpolicy
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface MhsmPrivateEndpointConnectionsDeleteHeaders no longer has parameter retryAfter
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 5bca310. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️keyvault        [View full logs]       
    ️❌ azure-powershell failed [Detail]   
  
    • ❌Failed [Logs]Release - Generate from 5bca310. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.keyvault        [View full logs]         [Release SDK Changes]      
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


          

        
    

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi @neeerajaakula, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.  
    TaskHow to fixPriority
     
    AvocadoFix-AvocadoHigh
     
    Semantic validationFix-SemanticValidation-ErrorHigh
     
    Model validationFix-ModelValidation-ErrorHigh
     
    LintDiffFix-LintDiffhigh
      If you need further help, please feedback via swagger feedback.
    
          		
    
    
      

    
    


          

        
    

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
          
    
  
    
    
  
    

  
    
      
    
  This was referenced Jul 13, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

  
    
  
  
    
  
          @neeerajaakula
  neeerajaakula


        marked this pull request as ready for review

    
      July 13, 2022 23:59
    
    

    

    
  
    


    


  
    
  
    
    
  
    

  
    
      
    
    @azure-sdk
azure-sdk



    mentioned this pull request
    
      Jul 14, 2022
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    

    





    

      
    
  
      

    

  
    
  @neeerajaakula


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

      

  
    Contributor


      

  Author


  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    S360 flag: https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=8FC38B25-C23B-4663-806E-CF7679E9FD23
    
The private endpoint connection of managed hsm is returning property "id" from control plane however this was not specified in the swagger. Fixed this bug by adding this property and "etag" property to the private endpoint connection item to keep CP and swagger in sync. Updated all versions released starting from the version where this was introduced.
    
          		
    
    
      

    
    


          

        
    

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            


  



    

      
    
  
        
    
  
    
      
    
  
  
    
  
              
    
  
    
    
    
      

    
  
    
      
        @neeerajaakula
  
    

    

      
    
        
          Address LRO_RESPONSE_HEADER violation for managed hsm
        

          
                        
      
    

      
    
        

    
    
    

  

      
    

      
    
        
    
          

    
    
    

  

  
    
    
  
    

    
        
    
      
    

      
    
        
          59771d3
        
      
    
    
    
  
    
    
    
      
    Long running operations that are annotated with x-ms-long-running-operation:true
must return location header or azure-AsyncOperation in response.
Added the missing location header for managed hsm update command as well as to the corresponding
examples.
    
    
    

    


    

      
    

    



    

      
    
  
            





    

      
    
  
      

    

  
    
  @neeerajaakula


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

      

  
    Contributor


      

  Author


  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    @heaths  any guidance on resolving the sdk failures. The breaking change for MhsmPrivateEndpointConnectionsDeleteHeaders was made as part of new api version and I have not made any changes related to that on my end.
    
          		
    
    
      

    
    


          

        
    

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            
    
    
    
      
    
    
    
    

      

          @rkmanda
rkmanda




          added
  the 

  ARMSignedOff

  <valid label in PR review process>add this label when ARM approve updates after review
 label


      Jul 20, 2022

    
    
  
    





    

      
    
  
      

    

  
    
  @qiaozha


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

      

  
  Member


      

  
    

  
    
    
    
      

      
            qiaozha
  

      

      

      commented


        Jul 21, 2022


      
  •

  
    
    
      
    
        
          edited
          
        
        
      
    
        
    
      
        
      Loading

      
    
  
    
    

    
    

  
    

    


      
    

        

    
  
    
    
      
          
    The JS SDK breaking change is because when service team add version 2022-07-01 they removed retry-after in MHSMPrivateEndpointConnections_Delete operation's response. @neeerajaakula Can you confirm within your team ?  If it's expected, I can approve the SDK breaking change.
    
          		
    
    
      

    
    


          

        
    

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @neeerajaakula


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

      

  
    Contributor


      

  Author


  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    I did confirm that the change was made intentionally as part of version 2022-07-01.
    
          		
    
    
      

    
    


          

        
    

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @heaths


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

      

  
  Member


      

  
    

  
    
    
    
      

      
            heaths
  

      

      

      commented


        Jul 22, 2022


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    I don't know about the powershell validation, but for the breaking change check you'll need a sign-off from @JeffreyRichter or @johanste. That said, I normally only review data plane swaggers.
    
          		
    
    
      

    
    


          

        
    

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    




        
    
  
            





    

        
    
  
        



    

        
    
  
          
    
  
    
    
  
    
  
    


        @honghr
  honghr



        merged commit 5bca310
      into

      
  
    Azure:main
  


    Jul 25, 2022

  
    

    


    

  
    
  
    
    
  
    

  
    
      
    
  This was referenced Jul 25, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

  

    
  
    
  
  
    
    
  akning-ms 

      pushed a commit
      that referenced
      this pull request

    
      Aug 1, 2022
    
    
    
      

    
  
    
    
    
      

    
  
    
      
        @grizzlytheodore
      
        @deyaaeldeen
        
    
      
        @FumingZhang
      
        @bingosummer
      
        @mattstam
      
        @zjpjack
      
        @orparnes
      
        @abatishchev
      
        @PatrickTseng
      
        @gigigoo0
      
        @Wzb123456789
      
        @AbhishekKrishna123
      
        @ArcturusZhang
      
        @divyansh3131
      
        @t-bzhan
      
        @cohen-uriel-ms
      
        @susolank
      
        @bexxx
      
        @arpit-gagneja
      
        @argagnej
      
        @yanjungao718
      
        @mikekistler
      
        @heaths
      
        @weidongxu-microsoft
      
        @Alancere
      
        @j-zhong-ms
      
        @tfitzmac
      
        @neeerajaakula
      
        @darkoa-msft
      
        @roy-work
      
        @amitelran
      
        @kazrael2119
      
        @gubalasu
  
    

    


      
    
        
          Compute update folder structure (#19723)
        

          
            
          

      
    

      
    
          

    
    
    

  

    


      
    

      
    
      
    

      
      
    
        
          2dcad6d
        
      
    
    
    
  
    
    
    
      
    * update folder structure

* small errors and CI check

* [Language Text] Update swagger titles (#19835)

* [Language Text] Update swagger titles

* edits

* address feedback

* Review request for Microsoft.ContainerService to add version 2022-06-01 (#19848)

* Adds base for updating Microsoft.ContainerService from version stable/2022-04-01 to version 2022-06-01

* Updates readme

* Updates API version in new specs and examples

* update readmes (#19421)

* Add key management service profile of a managed cluster for version 2022-06-01 (#19529)

* Add NetworkPlugin none option to 2022-06-01 (#19510)

* Add NetworkPlugin none option to 2022-06-01

* improve description for none value

* Fix violated rule R4041 for 2022-06-01 managedCluster swagger (#19581)

* remove useless directive

* fix R4041

* GA AKS support for Dedicated Host Group (#19547)

* GA AKS support for Dedicated Host Group

* fit some format minor issue

* add newline in end of files

* Defender updates (#19665)

* Defender updates

* sample

* remove old description

Co-authored-by: Bin Xia <binxi@microsoft.com>
Co-authored-by: Matt Stam <mattstam@live.com>
Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com>
Co-authored-by: Or Parnes <orparnes@microsoft.com>

* Update resources.json (#19861)

* Pattts/predictive autoscale 20221001 (#19765)

* Rev Autoscale API from 2021-05-01-preview to 2022-10-01.

* Fix minor swagger issue. Default should be 'false'

* Fix swagger validation error

* Defining a new package 2022-10

* AutoscaleSettingResource now reference allOf 'resource' which is the actual autoscaleSetting resource definition

* Fix require property issue

* Run prettier against autoscale_API.json

* [Maps - Render & Spatial Services] add v2022-08-01 (#19520)

* copy old swagger to new folders

* set api version to 2022-08-01

* apply api changes

Co-authored-by: Gigi Grajo <gigigrajo@microsoft.com>

* update appconfiguration (#19330)

* update appconfiguration

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* [Hub Generated] Publish private branch 'main' (#19852)

* Add StorageMover specification for PubliC Preview

* SpellCheck fix

* Update custom-words

* Update specification/storagemover/resource-manager/readme.md

Co-authored-by: Abhishek Krishna <abkrish@microsoft.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>

* Merging Dynatrace swagger in stable folder (#19862)

* Committing base swagger version

* Removing preview tag from stable folder api version

* Changing version name in all the files

* Updating readme.go and readme.md files

* [CDN] Fix customDomains property type in Endpoint (#19788)

* [CDN] Fix customDomains property type in Endpoint

* Fix linter error

Co-authored-by: Bo Zhang <bzhan@microsoft.com>

* Adding Microsoft.Sql AdvancedThreatProtectionSettings APIs for MI on v5 tag for 2022-02-01-preview (#19866)

* update folders

* [Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 (#19844)

* Update description of exportable attribute and release_policy.data

* Remove submodule azure-reset-api-specs

* Fix description for exportable

Co-authored-by: Sunny Solanki <Sunny.Solanki@microsoft.com>

* Add latest StorageMover updates (#19876)

* Add StorageMover specification for PubliC Preview

* SpellCheck fix

* Update custom-words

* Update specification/storagemover/resource-manager/readme.md

* Add latest StorageMover updates

Co-authored-by: Abhishek Krishna <abkrish@microsoft.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>

* Update readme.python.md (#19899)

* Update readme.python.md

* Update readme.md

* Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review (#19878)

* Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review

* Add known words

* Removed static IP allocation only from examples (#19858)

* Removed static IP allocation

* Removed static only from examples

Co-authored-by: Arpit Gagneja <argagnej@microsoft.com>

* Update securityinsights readme.python (#19903)

* update securityinsights readme.python

* Update readme.python.md

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>

* fix lint errors in Synapse trigger.json (#19660)

* put json files into RP folders

* update readme

* Add CONTRIBUTING.md (#19257)

* Add CONTRIBUTING.md

* Apply suggestions from PR review

Co-authored-by: Heath Stewart <heaths@outlook.com>

* Apply suggestions from PR review

Co-authored-by: Weidong Xu <weidxu@microsoft.com>

* Regen toc for CONTRIBUTING.md

* Address PR review comments

* Address PR review comments

Co-authored-by: Heath Stewart <heaths@outlook.com>
Co-authored-by: Weidong Xu <weidxu@microsoft.com>

* fix devcenter readme.go.md config (#19906)

* fix readme.go.md config

* rename to SkuInfo

* add annotation for labservices (#19884)

* add to description of OS state (#19764)

* [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#19767)

* Updated the managed hsm resource manager spec to include two additional properties for private endpoint connection item

* Update managed hsm private endpoint connection item in mhsm spec for latest api version

* Address LRO_RESPONSE_HEADER violation for managed hsm

Long running operations that are annotated with x-ms-long-running-operation:true
must return location header or azure-AsyncOperation in response.
Added the missing location header for managed hsm update command as well as to the corresponding
examples.

* [Microsoft.DeviceUpdate] Adding first stable API version (#19846)

* Copied the most recent preview version into the first stable version

* Updated api version in new stable version, added the tag to readme.md

* Fixed typo

* Fixed the wrong path in readme.md

* Reverted VS Code automatic breaking change

* Fix broken link (#19688)

* add aadObjectId property to kustoPool (#19856)

Co-authored-by: Amit Elran <amelran@microsoft.com>

* Updata securityinsights readme.python (#19917)

* update securityinsights readme.python

* update readme.python

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>

* modify readme.typescripy.md for compute package (#19607)

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <v-ziweichen@microsoft.com>

* Dev gubalasu frontdoor microsoft.network 2021 06 01 (#19578)

* Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2021-06-01

* Updates readme

* Updates API version in new specs and examples

* update waf configs and examples from 2020-11-01

* Update api version in new specs and examples

* Migration api update

* Update readme

* Fix readme

* update readme

* Fix readme again

* Fix readme

* Fix readme

* update waf policy provisioning state

* Update securityinsights readme.python (#19923)

* update securityinsights readme.python

* update readme.python

* last modify

* Update readme.python.md

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>

* sync with changes made to master

* update folder structure

* small errors and CI check

* update folders

* put json files into RP folders

* update readme

* resolve capitalization and number misplacement accident

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Co-authored-by: Bin Xia <binxi@microsoft.com>
Co-authored-by: Matt Stam <mattstam@live.com>
Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com>
Co-authored-by: Or Parnes <orparnes@microsoft.com>
Co-authored-by: Alexander Batishchev <abatishchev@gmail.com>
Co-authored-by: PatrickTseng <pattts@microsoft.com>
Co-authored-by: gigi <52640944+gigigoo0@users.noreply.github.com>
Co-authored-by: Gigi Grajo <gigigrajo@microsoft.com>
Co-authored-by: zhenbiao wei <424401670@qq.com>
Co-authored-by: Abhishek Krishna <AbhishekKrishna123@users.noreply.github.com>
Co-authored-by: Abhishek Krishna <abkrish@microsoft.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>
Co-authored-by: Divyansh Agarwal <83802474+divyansh3131@users.noreply.github.com>
Co-authored-by: t-bzhan <61817681+t-bzhan@users.noreply.github.com>
Co-authored-by: Bo Zhang <bzhan@microsoft.com>
Co-authored-by: Uriel Cohen <urielc@microsoft.com>
Co-authored-by: susolank <73919400+susolank@users.noreply.github.com>
Co-authored-by: Sunny Solanki <Sunny.Solanki@microsoft.com>
Co-authored-by: Ralf Beckers <bexxx@users.noreply.github.com>
Co-authored-by: arpit-gagneja <gagneja.arpit@gmail.com>
Co-authored-by: Arpit Gagneja <argagnej@microsoft.com>
Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>
Co-authored-by: YanjunGao <85206987+yanjungao718@users.noreply.github.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Heath Stewart <heaths@outlook.com>
Co-authored-by: Weidong Xu <weidxu@microsoft.com>
Co-authored-by: Jiahui Peng <46921893+Alancere@users.noreply.github.com>
Co-authored-by: j-zhong-ms <107880703+j-zhong-ms@users.noreply.github.com>
Co-authored-by: Tom FitzMacken <tomfitz@microsoft.com>
Co-authored-by: neeerajaakula <81248992+neeerajaakula@users.noreply.github.com>
Co-authored-by: darkoa-msft <61987922+darkoa-msft@users.noreply.github.com>
Co-authored-by: Roy Wellington <53838718+roy-work@users.noreply.github.com>
Co-authored-by: Amit Elran <amitelran2110@gmail.com>
Co-authored-by: Amit Elran <amelran@microsoft.com>
Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <v-ziweichen@microsoft.com>
Co-authored-by: gubalasu <59630928+gubalasu@users.noreply.github.com>
    
    
    

    

    
    
  
    

    

  
  
  
  



    



  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
    @honghr
  
    honghr



          
            
              
            
          
          honghr approved these changes

        
    
      
    
          

  
    @heaths
  
    heaths


                Awaiting requested review from heaths

                    heaths is a code owner
      
    
      
    
          

  
    @jlichwa
  
    jlichwa


                Awaiting requested review from jlichwa

                    jlichwa is a code owner
      
    
      
    
          

  
    @riteshchitlangia1
  
    riteshchitlangia1


                Awaiting requested review from riteshchitlangia1

      
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
    @honghr
  
    honghr
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    Approved-SdkBreakingChange-JavaScript

  

    ARMReview

  

    ARMSignedOff

  <valid label in PR review process>add this label when ARM approve updates after review
  

    CI-BreakingChange-JavaScript

  

    FixS360



    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

        
          

    

  
      
    
  
    
    
    
      5 participants
    
    
    
    
        
          @neeerajaakula 
        
          @qiaozha 
        
          @heaths 
        
          @honghr 
        
          @rkmanda